<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>176157</bug_id>
          
          <creation_ts>2017-08-31 05:12:19 -0700</creation_ts>
          <short_desc>WebRTC Ice gathering never completes</short_desc>
          <delta_ts>2017-09-25 08:46:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebRTC</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Clement Wehrung">cwehrung</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>sebastian.schenk</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1343898</commentid>
    <comment_count>0</comment_count>
    <who name="Clement Wehrung">cwehrung</who>
    <bug_when>2017-08-31 05:12:19 -0700</bug_when>
    <thetext>Steps to reproduce: 
- In Chrome, the following test succeeds and returns results: https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/
- In Safari, it never completes (no error, no success) 

The following article specifically mentions this: https://webrtchacks.com/safari-webrtc/
&quot;The ICE implementation appears to work the same as Chrome with Trickle. TURN/TLS seems unsupported. In addition the candidate gathering demo does not work as createOffer({offerToReceiveAudio})  has a bug and creates and offer without any m-lines.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1343930</commentid>
    <comment_count>1</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-08-31 08:17:45 -0700</bug_when>
    <thetext>This test page is using a legacy option (offerToReceiveAudio: 1) that is not supported by Safari.
As you saw, the SDP is almost empty and no ICE candidate gathering will start.

The test would succeed gathering candidates if using:
- pc.addTransceiver(&apos;video&apos;);
- or pc.createDataChannel(&apos;test&apos;);

In both cases, you would expect to only see STUN/TURN candidates, not host ones.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1343932</commentid>
    <comment_count>2</comment_count>
    <who name="Clement Wehrung">cwehrung</who>
    <bug_when>2017-08-31 08:42:00 -0700</bug_when>
    <thetext>Thank you for your quick reply. It&apos;s good to know that this should not ever be expected to work in Safari. Would you believe it should be shimmed by webrtc-adapter? I feel like many apps will break with this currently.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1343933</commentid>
    <comment_count>3</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-08-31 08:48:38 -0700</bug_when>
    <thetext>A shim in adapter.js for both offerToReceiveAudio and offerToReceiveVideo is a great idea!

I hope current WebRTC WebKit support would be sufficient for that but I haven&apos;t made the exercise.
Working on this shim would be very valuable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352187</commentid>
    <comment_count>4</comment_count>
    <who name="">sebastian.schenk</who>
    <bug_when>2017-09-25 07:21:52 -0700</bug_when>
    <thetext>@youenn fablet 

Why would I expect to only see STUN/TURN candidates?
Is it possible to also get the Host candidates?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352206</commentid>
    <comment_count>5</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-09-25 08:46:21 -0700</bug_when>
    <thetext>(In reply to sebastian.schenk from comment #4)
&gt; @youenn fablet 
&gt; 
&gt; Why would I expect to only see STUN/TURN candidates?


Currently, WebKit only exposes Host addresses if camera and/or microphone access has been granted.
This prevents a privacy issue (IP address gathering).

&gt; Is it possible to also get the Host candidates?

You can call getUserMedia.
In Safari, there is also a way in the developer/WebRTC menu to disable candidate filtering.

If you have a particular use case where host candidates are important and you do not want to request camera/microphone access, please describe it in bug 174500.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>