176140 2017-08-30 18:10:05 -0700 REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed 2017-08-31 13:09:58 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply buildbot cgarcia cturner danw gustavo mcatanzaro oldest_to_newest 1343822 0 mcatanzaro 2017-08-30 18:10:05 -0700 Charlie noticed this error in the buildbot logs: libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed I bet it's a regression from r221226. 1343823 1 319429 mcatanzaro 2017-08-30 18:11:55 -0700 Created attachment 319429 Patch 1343824 2 mcatanzaro 2017-08-30 18:13:05 -0700 This is a speculative fix, but I'm fairly confident.... 1343881 3 319429 cgarcia 2017-08-30 23:15:42 -0700 Comment on attachment 319429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319429&action=review > Source/WebCore/platform/network/soup/CookieJarSoup.cpp:92 > - bool didAccessSecureCookies = false; > + if (!cookies) > + return { { }, false }; > > + bool didAccessSecureCookies = false; I think it would be better to do this check after the loop. If all cookies are secure and includeSecureCookies == IncludeSecureCookies::No, the list can be empty (nullptr) after the loop. 1343900 4 cturner 2017-08-31 05:22:58 -0700 Michael, your speculative fix has worked for me, thanks! 1344023 5 mcatanzaro 2017-08-31 11:27:45 -0700 (In reply to Carlos Garcia Campos from comment #3) > I think it would be better to do this check after the loop. If all cookies > are secure and includeSecureCookies == IncludeSecureCookies::No, the list > can be empty (nullptr) after the loop. Good catch. 1344095 6 mcatanzaro 2017-08-31 13:09:58 -0700 Committed r221438: <http://trac.webkit.org/changeset/221438> 319429 2017-08-30 18:11:55 -0700 2017-08-30 23:15:42 -0700 Patch bug-176140-20170830201155.patch text/plain 1743 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzU0NmZlZTc2MTcxMWNh MGRkM2FjOTVhMDhjYzQwMmY3N2FmMTlmMi4uNmNkODJmZDM4NGQ2ZjdlYzQ5NTkzNTFjMzRkZTNl NjA1ZWEwMTUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTMwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIyMjEyMjYpOiBbU09VUF0gbGlic291cC1DUklUSUNBTCAqKjogc291cF9jb29raWVzX3Rv X2Nvb2tpZV9oZWFkZXI6IGFzc2VydGlvbiAnY29va2llcyAhPSBOVUxMJyBmYWlsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjE0MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgc2hvdWxkIGZp eCB1bmV4cGVjdGVkIHN0ZGVyciBvdXRwdXQgaW4gc2V2ZXJhbCB0ZXN0cy4KKworICAgICAgICAq IHBsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmNvb2tpZXNGb3JTZXNzaW9uKToKKwogMjAxNy0wOC0yOCAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIyMDI3OCk6IFdlYiBJ bnNwZWN0b3I6IENvbnRleHRNZW51IGl0ZW1zIGFyZSBub3QgZ2V0dGluZyB0cmlnZ2VyZWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJT b3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJT b3VwLmNwcAppbmRleCAxMDdiODcxZmNmOGQ2OTQzMTk4ZDk3MzI0Yzk0YjBhN2I1ZjVmZGI2Li5i NGQzNzQ1OTBhZTExN2Y3NjdlYWY5YjNmYThjNzljM2Q1NjNiMjVhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwCkBA IC04Niw4ICs4NiwxMCBAQCBzdGF0aWMgc3RkOjpwYWlyPFN0cmluZywgYm9vbD4gY29va2llc0Zv clNlc3Npb24oY29uc3QgTmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBzZQogewogICAgIEdVbmlxdWVQ dHI8U291cFVSST4gdXJpID0gdXJsLmNyZWF0ZVNvdXBVUkkoKTsKICAgICBHU0xpc3QqIGNvb2tp ZXMgPSBzb3VwX2Nvb2tpZV9qYXJfZ2V0X2Nvb2tpZV9saXN0KHNlc3Npb24uY29va2llU3RvcmFn ZSgpLCB1cmkuZ2V0KCksIGZvckhUVFBIZWFkZXIpOwotICAgIGJvb2wgZGlkQWNjZXNzU2VjdXJl Q29va2llcyA9IGZhbHNlOworICAgIGlmICghY29va2llcykKKyAgICAgICAgcmV0dXJuIHsgeyB9 LCBmYWxzZSB9OwogCisgICAgYm9vbCBkaWRBY2Nlc3NTZWN1cmVDb29raWVzID0gZmFsc2U7CiAg ICAgLy8gbGlic291cCBzaG91bGQgb21pdCBzZWN1cmUgY29va2llcyBpdHNlbGYgaWYgdGhlIHBy b3RvY29sIGlzIG5vdCBodHRwcy4KICAgICBpZiAodXJsLnByb3RvY29sSXMoImh0dHBzIikpIHsK ICAgICAgICAgR1NMaXN0KiBpdGVtID0gY29va2llczsK