176099 2017-08-30 06:01:47 -0700 [WPE] Enable MEMORY_SAMPLER 2022-02-28 03:47:07 -0800 1 1 1 Unclassified WebKit WPE WebKit Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164517 P2 Normal --- 1 clopez clopez aperez bugs-noreply calvaris clopez kling koivisto mcatanzaro webkit-bug-importer zan oldest_to_newest 1343512 0 clopez 2017-08-30 06:01:47 -0700 The GTK+ port enables (build-time) the MEMORY_SAMPLE feature by default. Let's do this also for WPE. With this feature enabled, you can then set the environment variable WEBKIT_SAMPLE_MEMORY=1 and each second you will get detailed memory stats of the WebKit internals printed on a file with the name of the process in /tmp If the environment variable is not set, then this does nothing. 1343529 1 319361 clopez 2017-08-30 06:57:52 -0700 Created attachment 319361 Patch 1343531 2 319361 mcatanzaro 2017-08-30 07:36:15 -0700 Comment on attachment 319361 Patch I think you want it to be PRIVATE as nobody would ever want to do a release build with it enabled. 1343532 3 clopez 2017-08-30 07:47:18 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 319361 [details] > Patch > > I think you want it to be PRIVATE as nobody would ever want to do a release > build with it enabled. do you mean "that nobody will want to disable this" ? On the GTK+ port is also set like this (PUBLIC) and this is getting enabled on all the GTK+ release builds by default. I want this enabled at build time on all release builds. Its just disabled by default at runtime. Its really useful when you need to answer questions like "why WebKit is using more memory than expected on this webpage? is because some JS leak or something else?." The file it generates is easily parsed with a script to produce nice charts. 1343535 4 mcatanzaro 2017-08-30 07:51:03 -0700 OK let me flip the question around: why would you want to *dis*able it, then? I think it should be PRIVATE for GTK+ too. 1343537 5 clopez 2017-08-30 07:58:35 -0700 (In reply to Michael Catanzaro from comment #4) > OK let me flip the question around: why would you want to *dis*able it, > then? I think it should be PRIVATE for GTK+ too. OK.. I will switch it to private (and set the GTK+ one to private also) 1343539 6 clopez 2017-08-30 08:06:52 -0700 Committed r221372: <http://trac.webkit.org/changeset/221372> 319361 2017-08-30 06:57:52 -0700 2022-02-28 03:47:07 -0800 Patch bug-176099-20170830155751.patch text/plain 2915 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNiOTIwMGI4MjM0OTNmYTA5 YmFjMDhkMzIxMmY1ZWM5NTM5MjczNDkuLjhmNTM1ZjRiOWYyYzBhNGIxMjBlNjQ3ZTcxMjlmNjc4 MTg2OTQxN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDgtMzAgIENhcmxvcyBB bGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0g RW5hYmxlIE1FTU9SWV9TQU1QTEVSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzYwOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFbmFibGUgaXQgYXQgcnVudGltZSBpZiB0aGUgZW52aXJvbm1lbnQgdmFy aWFibGUgV0VCS0lUX1NBTVBMRV9NRU1PUlkgaXMgc2V0LgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS93cGUvV1BFVmlldy5jcHA6CisgICAgICAgIChXS1dQRTo6bV9jb21wb3NpdGluZ01hbmFn ZXJQcm94eSk6CisKIDIwMTctMDgtMzAgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgog CiAgICAgICAgIFtNYWNdIFVwc3RyZWFtIENhcmJvbi1yZWxhdGVkIFdlYktpdFN5c3RlbUludGVy ZmFjZSBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93 cGUvV1BFVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZpZXcu Y3BwCmluZGV4IDU1NjU2NDUwNmU0ZDJjYzEyMjk4NDk5MzE4YWY1N2U0YWJjOThkMTMuLjQ4MDcx ODM4MzA4ZGMzMzYyNjllMjMzZGNiYWRmYTQ0NjdmNzFjNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL3dwZS9XUEVWaWV3LmNwcApAQCAtNjYsNiArNjYsMTEgQEAgVmlldzo6Vmll dyhzdHJ1Y3Qgd3BlX3ZpZXdfYmFja2VuZCogYmFja2VuZCwgY29uc3QgQVBJOjpQYWdlQ29uZmln dXJhdGlvbiYgYmFzZUMKICAgICBhdXRvKiBwb29sID0gY29uZmlndXJhdGlvbi0+cHJvY2Vzc1Bv b2woKTsKICAgICBtX3BhZ2VQcm94eSA9IHBvb2wtPmNyZWF0ZVdlYlBhZ2UoKm1fcGFnZUNsaWVu dCwgV1RGTW92ZShjb25maWd1cmF0aW9uKSk7CiAKKyNpZiBFTkFCTEUoTUVNT1JZX1NBTVBMRVIp CisgICAgaWYgKGdldGVudigiV0VCS0lUX1NBTVBMRV9NRU1PUlkiKSkKKyAgICAgICAgcG9vbC0+ c3RhcnRNZW1vcnlTYW1wbGVyKDApOworI2VuZGlmCisKICAgICBtX2JhY2tlbmQgPSBiYWNrZW5k OwogICAgIGlmICghbV9iYWNrZW5kKQogICAgICAgICBtX2JhY2tlbmQgPSB3cGVfdmlld19iYWNr ZW5kX2NyZWF0ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2Ug Yi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQppbmRleCA3YTU1ZjE3ZWNjMzkwZjc4NTI2 MjRhMDJlZGFkNzAxNDU2OWNlZWVmLi40MDhlOWE5YWYwYzlkMDU4ZTM1NDBjZWZkMjI0MTQ1YTc0 ZDcxYTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysgYi9T b3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQpAQCAtMzYsOCArMzYsMTAgQEAgV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9BTklNQVRJT05TIFBSSVZBVEUgT04p CiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCR0wgUFVCTElDIE9O KQogCiBpZiAoQ01BS0VfU1lTVEVNX05BTUUgTUFUQ0hFUyAiTGludXgiKQorICAgIFdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRU1PUllfU0FNUExFUiBQVUJMSUMgT04p CiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFU09VUkNFX1VT QUdFIFBSSVZBVEUgT04pCiBlbHNlICgpCisgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX01FTU9SWV9TQU1QTEVSIFBVQkxJQyBPRkYpCiAgICAgV0VCS0lUX09QVElP Tl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFU09VUkNFX1VTQUdFIFBSSVZBVEUgT0ZGKQog ZW5kaWYgKCkKIApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDcwNDMw NWIwMDFlNDA5YjIzYWRiY2EzMjQ1NmU2MGZkNDk4NDI3MTMuLjg1ODc5YjBhOTk2MzBjNTBjNzYx NmRmYzliMDI0NDk0ZWNlMTY5MTMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOC0zMCAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVy ZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBFbmFibGUgTUVNT1JZX1NB TVBMRVIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjA5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu YWJsZSB0aGUgb3Rpb24gYXQgYnVpbGQgdGltZSBieSBkZWZhdWx0IG9uIExpbnV4IChjdXJyZW50 bHkKKyAgICAgICAgdGhlcmUgYXJlIG9ubHkgTGludXggYW5kIE1hYyBpbXBsZW1lbnRhdGlvbnMg b2YgdGhpcyBmZWF0dXJlKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNt YWtlOgorCiAyMDE3LTA4LTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggdmVyc2lvbnMgbnVtYmVycyBhZnRlciBy MjIxMTM2Lgo=