176064 2017-08-29 13:47:53 -0700 [Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests. 2017-08-29 16:36:59 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen benjamin bfulgham buildbot cdumez cmarcelo commit-queue dbates saam webkit-bug-importer oldest_to_newest 1343203 0 pvollan 2017-08-29 13:47:53 -0700 FAULTING_IP: WTF!WTF::WorkQueue::performWorkOnRegisteredWorkThread+70 [c:\cygwin\home\buildbot\slave\win-release\build\source\wtf\wtf\win\workqueuewin.cpp @ 60] 71d0b1a0 8b0e mov ecx,dword ptr [esi] EXCEPTION_RECORD: ffffffffffffffff -- (.exr 0xffffffffffffffff) .exr 0xffffffffffffffff ExceptionAddress: 0000000071d0b1a0 (WTF!std::unique_ptr<WTF::Function<void __cdecl(void)>::CallableWrapperBase,std::default_delete<WTF::Function<void __cdecl(void)>::CallableWrapperBase> >::get) ExceptionCode: c0000005 (Access violation) ExceptionFlags: 00000000 NumberParameters: 2 Parameter[0]: 0000000000000000 Parameter[1]: 0000000000000000 Attempt to read from address 0000000000000000 CONTEXT: 0000000000000000 -- (.cxr 0x0;r) .cxr 0x0;r eax=090dd7d8 ebx=24375f60 ecx=08ef1484 edx=00289208 esi=00000000 edi=08ef147c eip=71d0b1a0 esp=0928f798 ebp=0928f7b4 iopl=0 nv up ei pl nz na po nc cs=0023 ss=002b ds=002b es=002b fs=0053 gs=002b efl=00010202 WTF!std::unique_ptr<WTF::Function<void __cdecl(void)>::CallableWrapperBase,std::default_delete<WTF::Function<void __cdecl(void)>::CallableWrapperBase> >::get [inlined in WTF!WTF::WorkQueue::performWorkOnRegisteredWorkThread+0x70]: 71d0b1a0 8b0e mov ecx,dword ptr [esi] ds:002b:00000000=???????? .cxr STACK_TEXT: 0928f7b4 71d0b0f0 08ef1578 0928f834 77da7edf WTF!WTF::WorkQueue::performWorkOnRegisteredWorkThread+0x70 0928f7c0 77da7edf 08ef1478 353b3e3a 08ef1578 WTF!WTF::WorkQueue::workThreadCallback+0x20 WARNING: Stack unwind information not available. Following frames may be wrong. 0928f834 77d90951 08ef1478 08ef1578 353b3f8a ntdll_77d40000!RtlClearAllBits+0x110 0928f984 7699336a 00705980 0928f9d0 77d79902 ntdll_77d40000!TpCallbackIndependent+0x710 0928f990 77d79902 00705980 353b3fde 00000000 KERNEL32!BaseThreadInitThunk+0x12 0928f9d0 77d798d5 77d9046c 00705980 00000000 ntdll_77d40000!RtlInitializeExceptionChain+0x63 0928f9e8 00000000 77d9046c 00705980 00000000 ntdll_77d40000!RtlInitializeExceptionChain+0x36 1343208 1 319280 pvollan 2017-08-29 13:55:06 -0700 Created attachment 319280 Patch 1343212 2 319280 bfulgham 2017-08-29 14:07:14 -0700 Comment on attachment 319280 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319280&action=review > Source/WTF/wtf/win/WorkQueueWin.cpp:62 > + function(); I think we should understand how a nullptr function is getting into this Vector. Maybe we could just protect against nullptr functions being placed in the queue? We don't seem to do this kind of null-check elsewhere in the code, so it seems like an anti-pattern. 1343223 3 319283 pvollan 2017-08-29 14:30:16 -0700 Created attachment 319283 Patch 1343224 4 pvollan 2017-08-29 14:31:27 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 319280 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319280&action=review > > > Source/WTF/wtf/win/WorkQueueWin.cpp:62 > > + function(); > > I think we should understand how a nullptr function is getting into this > Vector. Maybe we could just protect against nullptr functions being placed > in the queue? We don't seem to do this kind of null-check elsewhere in the > code, so it seems like an anti-pattern. Thanks! That's a good point, I have updated the patch. 1343237 5 319283 saam 2017-08-29 14:52:46 -0700 Comment on attachment 319283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319283&action=review > Source/WTF/wtf/win/WorkQueueWin.cpp:105 > + ASSERT(function); > + if (!function) > + return; Maybe this should be accompanied with a FIXME and a bug to fix the underlying issue? 1343252 6 319291 pvollan 2017-08-29 15:17:10 -0700 Created attachment 319291 Patch 1343255 7 pvollan 2017-08-29 15:19:38 -0700 (In reply to Saam Barati from comment #5) > Comment on attachment 319283 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319283&action=review > > > Source/WTF/wtf/win/WorkQueueWin.cpp:105 > > + ASSERT(function); > > + if (!function) > > + return; > > Maybe this should be accompanied with a FIXME and a bug to fix the > underlying issue? Yes, thank you! I have updated the patch. 1343302 8 319291 commit-queue 2017-08-29 16:35:37 -0700 Comment on attachment 319291 Patch Clearing flags on attachment: 319291 Committed r221323: <http://trac.webkit.org/changeset/221323> 1343303 9 commit-queue 2017-08-29 16:35:39 -0700 All reviewed patches have been landed. Closing bug. 1343305 10 webkit-bug-importer 2017-08-29 16:36:59 -0700 <rdar://problem/34146574> 319280 2017-08-29 13:55:06 -0700 2017-08-29 14:30:15 -0700 Patch bug-176064-20170829225507.patch text/plain 1364 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjEzMDgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmFzaCB1bmRlciBXb3JrUXVldWU6 OnBlcmZvcm1Xb3JrT25SZWdpc3RlcmVkV29ya1RocmVhZCBpbiBsYXlvdXQgdGVzdHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYwNjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3Jhc2ggbG9n IGluZGljYXRlcyB0aGF0IHRoZSBmdW5jdGlvbiBwb2ludGVyIGlzIG51bGwgaW4gdGhpcyBjYXNl LiAKKyAKKyAgICAgICAgKiB3dGYvd2luL1dvcmtRdWV1ZVdpbi5jcHA6CisgICAgICAgIChXVEY6 OldvcmtRdWV1ZTo6cGVyZm9ybVdvcmtPblJlZ2lzdGVyZWRXb3JrVGhyZWFkKToKKwogMjAxNy0w OC0yOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBV cHN0cmVhbSBXS0dldFdlYkRlZmF1bHRDRlN0cmluZ0VuY29kaW5nKCkKSW5kZXg6IFNvdXJjZS9X VEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3Rm L3dpbi9Xb3JrUXVldWVXaW4uY3BwCShyZXZpc2lvbiAyMjEyOTkpCisrKyBTb3VyY2UvV1RGL3d0 Zi93aW4vV29ya1F1ZXVlV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTcsNyArNTcsOSBAQCB2 b2lkIFdvcmtRdWV1ZTo6cGVyZm9ybVdvcmtPblJlZ2lzdGVyZWRXCiAgICAgICAgIC8vIEFsbG93 IG1vcmUgd29yayB0byBiZSBzY2hlZHVsZWQgd2hpbGUgd2UncmUgbm90IHVzaW5nIHRoZSBxdWV1 ZSBkaXJlY3RseS4KICAgICAgICAgbV9mdW5jdGlvblF1ZXVlTG9jay51bmxvY2soKTsKICAgICAg ICAgZm9yIChhdXRvJiBmdW5jdGlvbiA6IGZ1bmN0aW9uUXVldWUpIHsKLSAgICAgICAgICAgIGZ1 bmN0aW9uKCk7CisgICAgICAgICAgICBBU1NFUlQoZnVuY3Rpb24pOworICAgICAgICAgICAgaWYg KGZ1bmN0aW9uKQorICAgICAgICAgICAgICAgIGZ1bmN0aW9uKCk7CiAgICAgICAgICAgICBkZXJl ZigpOwogICAgICAgICB9CiAgICAgICAgIG1fZnVuY3Rpb25RdWV1ZUxvY2subG9jaygpOwo= 319283 2017-08-29 14:30:16 -0700 2017-08-29 15:17:09 -0700 Patch bug-176064-20170829233017.patch text/plain 1209 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjEzMTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmFzaCB1bmRlciBXb3JrUXVldWU6 OnBlcmZvcm1Xb3JrT25SZWdpc3RlcmVkV29ya1RocmVhZCBpbiBsYXlvdXQgdGVzdHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYwNjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3Jhc2ggbG9n IGluZGljYXRlcyB0aGF0IHRoZSBmdW5jdGlvbiBwb2ludGVyIGlzIG51bGwgaW4gdGhpcyBjYXNl LgorCisgICAgICAgICogd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3BwOgorICAgICAgICAoV1RGOjpX b3JrUXVldWU6OmRpc3BhdGNoKToKKwogMjAxNy0wOC0yOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0Bh cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBVcHN0cmVhbSBXS0dldFdlYkRlZmF1bHRDRlN0 cmluZ0VuY29kaW5nKCkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3BwCShyZXZp c2lvbiAyMjEyOTkpCisrKyBTb3VyY2UvV1RGL3d0Zi93aW4vV29ya1F1ZXVlV2luLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTAwLDYgKzEwMCwxMCBAQCB2b2lkIFdvcmtRdWV1ZTo6cGxhdGZvcm1J bnZhbGlkYXRlKCkKIAogdm9pZCBXb3JrUXVldWU6OmRpc3BhdGNoKEZ1bmN0aW9uPHZvaWQoKT4m JiBmdW5jdGlvbikKIHsKKyAgICBBU1NFUlQoZnVuY3Rpb24pOworICAgIGlmICghZnVuY3Rpb24p CisgICAgICAgIHJldHVybjsKKwogICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2Z1bmN0aW9uUXVl dWVMb2NrKTsKICAgICByZWYoKTsKICAgICBtX2Z1bmN0aW9uUXVldWUuYXBwZW5kKFdURk1vdmUo ZnVuY3Rpb24pKTsK 319291 2017-08-29 15:17:10 -0700 2017-08-29 16:35:37 -0700 Patch bug-176064-20170830001711.patch text/plain 1369 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjEzMTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmFzaCB1bmRlciBXb3JrUXVldWU6 OnBlcmZvcm1Xb3JrT25SZWdpc3RlcmVkV29ya1RocmVhZCBpbiBsYXlvdXQgdGVzdHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYwNjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3Jhc2ggbG9n IGluZGljYXRlcyB0aGF0IHRoZSBmdW5jdGlvbiBwb2ludGVyIGlzIG51bGwgaW4gdGhpcyBjYXNl LgorCisgICAgICAgICogd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3BwOgorICAgICAgICAoV1RGOjpX b3JrUXVldWU6OmRpc3BhdGNoKToKKwogMjAxNy0wOC0yOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0Bh cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBVcHN0cmVhbSBXS0dldFdlYkRlZmF1bHRDRlN0 cmluZ0VuY29kaW5nKCkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3BwCShyZXZp c2lvbiAyMjEyOTkpCisrKyBTb3VyY2UvV1RGL3d0Zi93aW4vV29ya1F1ZXVlV2luLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTAwLDYgKzEwMCwxMiBAQCB2b2lkIFdvcmtRdWV1ZTo6cGxhdGZvcm1J bnZhbGlkYXRlKCkKIAogdm9pZCBXb3JrUXVldWU6OmRpc3BhdGNoKEZ1bmN0aW9uPHZvaWQoKT4m JiBmdW5jdGlvbikKIHsKKyAgICAvLyBGSVhNRTogRHVyaW5nIGxheW91dCB0ZXN0cywgdGhpcyBt ZXRob2QgaXMgc29tZXRpbWVzIGNhbGxlZCB3aXRoIGEgbnVsbHB0ciBmdW5jdGlvbiBwYXJhbWV0 ZXIuCisgICAgLy8gVGhpcyBpcyB0cmFja2VkIGluIDxodHRwOi8vd2Via2l0Lm9yZy9iLzE3NjA3 Mj4uCisgICAgQVNTRVJUKGZ1bmN0aW9uKTsKKyAgICBpZiAoIWZ1bmN0aW9uKQorICAgICAgICBy ZXR1cm47CisKICAgICBNdXRleExvY2tlciBsb2NrZXIobV9mdW5jdGlvblF1ZXVlTG9jayk7CiAg ICAgcmVmKCk7CiAgICAgbV9mdW5jdGlvblF1ZXVlLmFwcGVuZChXVEZNb3ZlKGZ1bmN0aW9uKSk7 Cg==