176063 2017-08-29 13:36:17 -0700 REGRESSION(r220235): Web Inspector: Global search should not happen incrementally 2017-08-29 18:30:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1343197 0 joepeck 2017-08-29 13:36:17 -0700 REGRESSION(r220235): Web Inspector: Global search should not happen incrementally Incremental search is bad at the global search level because a slowly typed search string could result in full text search of strings like "a" which result in many, many results and unfortunately slow performance during that process. Steps to reproduce: 1. Inspect this page 2. Type "a" in the search field => Search happens even though I didn't consider my search term complete yet Regression: (bug 175108) > - this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), null, true); > + this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), true); Notes: - It does seem we can remove the unused delegate of WI.SearchBar. 1343202 1 319279 joepeck 2017-08-29 13:47:29 -0700 Created attachment 319279 [PATCH] Proposed Fix 1343330 2 319279 hi 2017-08-29 17:08:37 -0700 Comment on attachment 319279 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=319279&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:401 > + const incremental = false; > + this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), incremental); NIT: since this is false, I don't think you need to include it at all. 1343363 3 319279 joepeck 2017-08-29 18:18:42 -0700 Comment on attachment 319279 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=319279&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:401 >> + this._searchToolbarItem = new WI.SearchBar("inspector-search", WI.UIString("Search"), incremental); > > NIT: since this is false, I don't think you need to include it at all. Correct. That said, I like being explicit here, so I'll leave it as is. If we ever add new options we could make this an options dictionary {optional: true}, etc. 1343370 4 319279 commit-queue 2017-08-29 18:29:29 -0700 Comment on attachment 319279 [PATCH] Proposed Fix Clearing flags on attachment: 319279 Committed r221332: <http://trac.webkit.org/changeset/221332> 1343371 5 commit-queue 2017-08-29 18:29:30 -0700 All reviewed patches have been landed. Closing bug. 1343372 6 webkit-bug-importer 2017-08-29 18:30:37 -0700 <rdar://problem/34149530> 319279 2017-08-29 13:47:29 -0700 2017-08-29 18:29:29 -0700 [PATCH] Proposed Fix global-search-1.patch text/plain 4144 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyMzg4YTBmNGEyLi5lYmY1MzFhZDZjMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDgtMjkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy MjAyMzUpOiBXZWIgSW5zcGVjdG9yOiBHbG9iYWwgc2VhcmNoIHNob3VsZCBub3QgaGFwcGVuIGlu Y3JlbWVudGFsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NjA2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXSS5jb250ZW50TG9h ZGVkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaEJhci5qczoKKyAgICAg ICAgKFdJLlNlYXJjaEJhcik6CisgICAgICAgIChXSS5TZWFyY2hCYXIucHJvdG90eXBlLl9oYW5k bGVLZXlkb3duRXZlbnQpOgorICAgICAgICBSZW1vdmUgZGVsZWdhdGUgYW5kIHNpbXBsaWZ5IHNl dHRpbmcgaW5jcmVtZW50YWwuCisKIDIwMTctMDgtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgc29tZSB1bnVz ZWQgRGF0YUdyaWQgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzCmluZGV4IDIyMGU0MzhhNGQ4Li45MjNjYjUzODFlNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMzk3 LDcgKzM5Nyw4IEBAIFdJLmNvbnRlbnRMb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5fZGFz aGJvYXJkQ29udGFpbmVyID0gbmV3IFdJLkRhc2hib2FyZENvbnRhaW5lclZpZXc7CiAgICAgdGhp cy5fZGFzaGJvYXJkQ29udGFpbmVyLnNob3dEYXNoYm9hcmRWaWV3Rm9yUmVwcmVzZW50ZWRPYmpl Y3QodGhpcy5kYXNoYm9hcmRNYW5hZ2VyLmRhc2hib2FyZHMuZGVmYXVsdCk7CiAKLSAgICB0aGlz Ll9zZWFyY2hUb29sYmFySXRlbSA9IG5ldyBXSS5TZWFyY2hCYXIoImluc3BlY3Rvci1zZWFyY2gi LCBXSS5VSVN0cmluZygiU2VhcmNoIiksIHRydWUpOworICAgIGNvbnN0IGluY3JlbWVudGFsID0g ZmFsc2U7CisgICAgdGhpcy5fc2VhcmNoVG9vbGJhckl0ZW0gPSBuZXcgV0kuU2VhcmNoQmFyKCJp bnNwZWN0b3Itc2VhcmNoIiwgV0kuVUlTdHJpbmcoIlNlYXJjaCIpLCBpbmNyZW1lbnRhbCk7CiAg ICAgdGhpcy5fc2VhcmNoVG9vbGJhckl0ZW0uYWRkRXZlbnRMaXN0ZW5lcihXSS5TZWFyY2hCYXIu RXZlbnQuVGV4dENoYW5nZWQsIHRoaXMuX3NlYXJjaFRleHREaWRDaGFuZ2UsIHRoaXMpOwogCiAg ICAgdGhpcy50b29sYmFyLmFkZFRvb2xiYXJJdGVtKHRoaXMuX2Nsb3NlVG9vbGJhckJ1dHRvbiwg V0kuVG9vbGJhci5TZWN0aW9uLkNvbnRyb2wpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmpzCmluZGV4IDRhZTcxMjAxNTZm Li5iNDhiOTY2NTU5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU2VhcmNoQmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NlYXJjaEJhci5qcwpAQCAtMjUsMTIgKzI1LDEwIEBACiAKIFdJLlNl YXJjaEJhciA9IGNsYXNzIFNlYXJjaEJhciBleHRlbmRzIFdJLk5hdmlnYXRpb25JdGVtCiB7Ci0g ICAgY29uc3RydWN0b3IoaWRlbnRpZmllciwgcGxhY2Vob2xkZXIsIGRlbGVnYXRlLCBzdXBwcmVz c0luY3JlbWVudGFsKQorICAgIGNvbnN0cnVjdG9yKGlkZW50aWZpZXIsIHBsYWNlaG9sZGVyLCBp bmNyZW1lbnRhbCkKICAgICB7CiAgICAgICAgIHN1cGVyKGlkZW50aWZpZXIpOwogCi0gICAgICAg IHRoaXMuZGVsZWdhdGUgPSBkZWxlZ2F0ZTsKLQogICAgICAgICB0aGlzLl9lbGVtZW50LmNsYXNz TGlzdC5hZGQoInNlYXJjaC1iYXIiKTsKIAogICAgICAgICB0aGlzLl9rZXlib2FyZFNob3J0Y3V0 RXNjID0gbmV3IFdJLktleWJvYXJkU2hvcnRjdXQobnVsbCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5L ZXkuRXNjYXBlKTsKQEAgLTM5LDEyICszNywxMSBAQCBXSS5TZWFyY2hCYXIgPSBjbGFzcyBTZWFy Y2hCYXIgZXh0ZW5kcyBXSS5OYXZpZ2F0aW9uSXRlbQogICAgICAgICB0aGlzLl9zZWFyY2hJbnB1 dCA9IHRoaXMuX2VsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaW5w dXQiKSk7CiAgICAgICAgIHRoaXMuX3NlYXJjaElucHV0LnR5cGUgPSAic2VhcmNoIjsKICAgICAg ICAgdGhpcy5fc2VhcmNoSW5wdXQuc3BlbGxjaGVjayA9IGZhbHNlOwotICAgICAgICB0aGlzLl9z ZWFyY2hJbnB1dC5pbmNyZW1lbnRhbCA9ICFzdXBwcmVzc0luY3JlbWVudGFsOworICAgICAgICB0 aGlzLl9zZWFyY2hJbnB1dC5pbmNyZW1lbnRhbCA9IGluY3JlbWVudGFsOwogICAgICAgICB0aGlz Ll9zZWFyY2hJbnB1dC5zZXRBdHRyaWJ1dGUoInJlc3VsdHMiLCA1KTsKICAgICAgICAgdGhpcy5f c2VhcmNoSW5wdXQuc2V0QXR0cmlidXRlKCJhdXRvc2F2ZSIsIGlkZW50aWZpZXIgKyAiLWF1dG9z YXZlIik7CiAgICAgICAgIHRoaXMuX3NlYXJjaElucHV0LnNldEF0dHJpYnV0ZSgicGxhY2Vob2xk ZXIiLCBwbGFjZWhvbGRlcik7CiAgICAgICAgIHRoaXMuX3NlYXJjaElucHV0LmFkZEV2ZW50TGlz dGVuZXIoInNlYXJjaCIsIHRoaXMuX2hhbmRsZVNlYXJjaEV2ZW50LmJpbmQodGhpcykpOwotICAg ICAgICB0aGlzLl9zZWFyY2hJbnB1dC5hZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgdGhpcy5f aGFuZGxlS2V5ZG93bkV2ZW50LmJpbmQodGhpcykpOwogICAgIH0KIAogICAgIC8vIFB1YmxpYwpA QCAtNzQsMjMgKzcxLDYgQEAgV0kuU2VhcmNoQmFyID0gY2xhc3MgU2VhcmNoQmFyIGV4dGVuZHMg V0kuTmF2aWdhdGlvbkl0ZW0KICAgICB7CiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlz dGVuZXJzKFdJLlNlYXJjaEJhci5FdmVudC5UZXh0Q2hhbmdlZCk7CiAgICAgfQotCi0gICAgX2hh bmRsZUtleWRvd25FdmVudChldmVudCkKLSAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9rZXlib2Fy ZFNob3J0Y3V0RXNjLm1hdGNoZXNFdmVudChldmVudCkpIHsKLSAgICAgICAgICAgIGlmICh0aGlz LmRlbGVnYXRlICYmIHR5cGVvZiB0aGlzLmRlbGVnYXRlLnNlYXJjaEJhcldhbnRzVG9Mb3NlRm9j dXMgPT09ICJmdW5jdGlvbiIpIHsKLSAgICAgICAgICAgICAgICB0aGlzLmRlbGVnYXRlLnNlYXJj aEJhcldhbnRzVG9Mb3NlRm9jdXModGhpcyk7Ci0gICAgICAgICAgICAgICAgZXZlbnQuc3RvcFBy b3BhZ2F0aW9uKCk7Ci0gICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKLSAg ICAgICAgICAgIH0KLSAgICAgICAgfSBlbHNlIGlmICh0aGlzLl9rZXlib2FyZFNob3J0Y3V0RW50 ZXIubWF0Y2hlc0V2ZW50KGV2ZW50KSkgewotICAgICAgICAgICAgaWYgKHRoaXMuZGVsZWdhdGUg JiYgdHlwZW9mIHRoaXMuZGVsZWdhdGUuc2VhcmNoQmFyRGlkQWN0aXZhdGUgPT09ICJmdW5jdGlv biIpIHsKLSAgICAgICAgICAgICAgICB0aGlzLmRlbGVnYXRlLnNlYXJjaEJhckRpZEFjdGl2YXRl KHRoaXMpOwotICAgICAgICAgICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOwotICAgICAg ICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Ci0gICAgICAgICAgICB9Ci0gICAgICAg IH0KLSAgICB9CiB9OwogCiBXSS5TZWFyY2hCYXIuRXZlbnQgPSB7Cg==