176056 2017-08-29 09:49:01 -0700 [Win] A WTF test is timing out in run-api-tests. 2023-04-26 23:53:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195161 InRadar P2 Normal --- 1 pvollan pvollan bfulgham lforschler sabouhallawa webkit-bug-importer oldest_to_newest 1343121 0 pvollan 2017-08-29 09:49:01 -0700 Tests that timed out: WTF_SynchronizedFixedQueue.ProduceOnly 1343133 1 319257 pvollan 2017-08-29 10:03:20 -0700 Created attachment 319257 Patch 1343146 2 319257 bfulgham 2017-08-29 10:49:38 -0700 Comment on attachment 319257 Patch I think we should use a conditional here so we don't allow millisecond-accurate platforms to regress. #if PLATFORM(WIN) auto sleepAmount = std::chrono::milliseconds(20); #else auto sleepAmount = std::chrono::milliseconds(10); #endif 1343152 3 pvollan 2017-08-29 10:58:52 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 319257 [details] > Patch > > I think we should use a conditional here so we don't allow > millisecond-accurate platforms to regress. > > #if PLATFORM(WIN) > auto sleepAmount = std::chrono::milliseconds(20); > #else > auto sleepAmount = std::chrono::milliseconds(10); > #endif Thanks for reviewing! I will update the patch before landing. 1343153 4 319262 pvollan 2017-08-29 11:05:10 -0700 Created attachment 319262 Patch 1343166 5 pvollan 2017-08-29 11:36:31 -0700 Committed r221307: <https://trac.webkit.org/changeset/221307/webkit> 1343167 6 webkit-bug-importer 2017-08-29 11:37:22 -0700 <rdar://problem/34137707> 319257 2017-08-29 10:03:20 -0700 2017-08-29 10:49:38 -0700 Patch bug-176056-20170829190321.patch text/plain 1758 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTMwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTA4LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBBIFdURiB0ZXN0IGlzIHRpbWluZyBvdXQgaW4gcnVuLWFwaS10 ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjA1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSB0ZXN0IFN5bmNocm9uaXplZEZpeGVkUXVldWUuUHJvZHVjZU9ubHkgcmVsaWVzIG9uIHRoYXQg cHV0dGluZyBhIHRocmVhZCB0byBzbGVlcCBmb3IKKyAgICAgICAgMW1zIHdpbGwgd2FrZSBpdCB1 cCBiZWZvcmUgYW5vdGhlciB0aHJlYWQgd2hpY2ggaXMgcHV0IHRvIHNsZWVwIGZvciAxMG1zLiBJ IGJlbGlldmUgdGhpcworICAgICAgICBpcyBub3QgbmVjY2Vzc2FyaWx5IHRydWUgb24gV2luZG93 cyB3aGVyZSB0aGUgdGhyZWFkIHNjaGVkdWxpbmcgZG9lcyBub3QgaGF2ZSBtaWxsaXNlY29uZAor ICAgICAgICBhY2N1cmFjeS4gRml4IHRoZSB0ZXN0IHRpbWVvdXQgYnkgYWRqdXN0aW5nIHRoZSBz bGVlcCB0aW1lIHNsaWdodGx5LgorIAorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1N5bmNocm9uaXplZEZpeGVkUXVldWUuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VG9V cHBlckNvbnZlcnRlcjo6c3RhcnRQcm9kdWNpbmcpOgorCiAyMDE3LTA4LTI5ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBS RUdSRVNTSU9OKHIyMjEyMTkpOiBGaXggdW5pdCB0ZXN0cyB1c2luZyByZXNvdXJjZXMgZnJvbSBX ZWJLaXQgZGlyZWN0b3J5LgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3lu Y2hyb25pemVkRml4ZWRRdWV1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvU3luY2hyb25pemVkRml4ZWRRdWV1ZS5jcHAJKHJldmlzaW9uIDIyMTI5OSkK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N5bmNocm9uaXplZEZpeGVkUXVldWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04Myw3ICs4Myw3IEBAIHB1YmxpYzoKICAgICAgICAgICAg IHdoaWxlIChtX2xvd2VyUXVldWUuZGVxdWV1ZShsb3dlcikpIHsKICAgICAgICAgICAgICAgICBt X3VwcGVyUXVldWUuZW5xdWV1ZSh0b1VwcGVyKGxvd2VyKSk7CiAgICAgICAgICAgICAgICAgRVhQ RUNUX1RSVUUobG93ZXIgPT0gdGV4dEl0ZW0obV9wcm9kdWNlQ291bnQrKykpOwotICAgICAgICAg ICAgICAgIHN0ZDo6dGhpc190aHJlYWQ6OnNsZWVwX2ZvcihzdGQ6OmNocm9ubzo6bWlsbGlzZWNv bmRzKDEwKSk7CisgICAgICAgICAgICAgICAgc3RkOjp0aGlzX3RocmVhZDo6c2xlZXBfZm9yKHN0 ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMoMjApKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IG1fcHJvZHVjZUNsb3NlU2VtYXBob3JlLnNpZ25hbCgpOwogICAgICAgICB9KTsK 319262 2017-08-29 11:05:10 -0700 2017-08-29 11:05:10 -0700 Patch bug-176056-20170829200510.patch text/plain 1909 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTMwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTA4LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBBIFdURiB0ZXN0IGlzIHRpbWluZyBvdXQgaW4gcnVuLWFwaS10 ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjA1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSB0ZXN0IFN5bmNocm9uaXplZEZpeGVkUXVldWUuUHJvZHVjZU9ubHkgcmVsaWVzIG9uIHRoYXQg cHV0dGluZyBhIHRocmVhZCB0byBzbGVlcCBmb3IKKyAgICAgICAgMW1zIHdpbGwgd2FrZSBpdCB1 cCBiZWZvcmUgYW5vdGhlciB0aHJlYWQgd2hpY2ggaXMgcHV0IHRvIHNsZWVwIGZvciAxMG1zLiBJ IGJlbGlldmUgdGhpcworICAgICAgICBpcyBub3QgbmVjY2Vzc2FyaWx5IHRydWUgb24gV2luZG93 cyB3aGVyZSB0aGUgdGhyZWFkIHNjaGVkdWxpbmcgZG9lcyBub3QgaGF2ZSBtaWxsaXNlY29uZAor ICAgICAgICBhY2N1cmFjeS4gRml4IHRoZSB0ZXN0IHRpbWVvdXQgYnkgYWRqdXN0aW5nIHRoZSBz bGVlcCB0aW1lIHNsaWdodGx5LgorIAorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1N5bmNocm9uaXplZEZpeGVkUXVldWUuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VG9V cHBlckNvbnZlcnRlcjo6c3RhcnRQcm9kdWNpbmcpOgorCiAyMDE3LTA4LTI5ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBS RUdSRVNTSU9OKHIyMjEyMTkpOiBGaXggdW5pdCB0ZXN0cyB1c2luZyByZXNvdXJjZXMgZnJvbSBX ZWJLaXQgZGlyZWN0b3J5LgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3lu Y2hyb25pemVkRml4ZWRRdWV1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvU3luY2hyb25pemVkRml4ZWRRdWV1ZS5jcHAJKHJldmlzaW9uIDIyMTI5OSkK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N5bmNocm9uaXplZEZpeGVkUXVldWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04Myw3ICs4MywxMiBAQCBwdWJsaWM6CiAgICAgICAgICAg ICB3aGlsZSAobV9sb3dlclF1ZXVlLmRlcXVldWUobG93ZXIpKSB7CiAgICAgICAgICAgICAgICAg bV91cHBlclF1ZXVlLmVucXVldWUodG9VcHBlcihsb3dlcikpOwogICAgICAgICAgICAgICAgIEVY UEVDVF9UUlVFKGxvd2VyID09IHRleHRJdGVtKG1fcHJvZHVjZUNvdW50KyspKTsKLSAgICAgICAg ICAgICAgICBzdGQ6OnRoaXNfdGhyZWFkOjpzbGVlcF9mb3Ioc3RkOjpjaHJvbm86Om1pbGxpc2Vj b25kcygxMCkpOworI2lmIFBMQVRGT1JNKFdJTikKKyAgICAgICAgICAgICAgICBhdXRvIHNsZWVw QW1vdW50ID0gc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcygyMCk7CisjZWxzZQorICAgICAgICAg ICAgICAgIGF1dG8gc2xlZXBBbW91bnQgPSBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzKDEwKTsK KyNlbmRpZgorICAgICAgICAgICAgICAgIHN0ZDo6dGhpc190aHJlYWQ6OnNsZWVwX2ZvcihzbGVl cEFtb3VudCk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBtX3Byb2R1Y2VDbG9zZVNlbWFw aG9yZS5zaWduYWwoKTsKICAgICAgICAgfSk7Cg==