176052 2017-08-29 06:43:05 -0700 REGRESSION(r221064): [GTK] Editor not correctly working after r221064 2017-08-30 00:00:08 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=175370 Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro rniwa wenson_hsieh oldest_to_newest 1343096 0 cgarcia 2017-08-29 06:43:05 -0700 Since r221064 we are not always notified about typing attributes when editor state changes. didChangeSelection no longer includes the typing attributes in EditorStateChange message, it's scheduled to be sent after the compositing layer have been flushed, but that part is not implemented for GTK+ port. This is causing test /webkit2/WebKitWebView/editor-state/typing-attributes to time out. 1343097 1 319252 cgarcia 2017-08-29 06:48:37 -0700 Created attachment 319252 Patch 1343473 2 cgarcia 2017-08-30 00:00:08 -0700 Committed r221344: <http://trac.webkit.org/changeset/221344> 319252 2017-08-29 06:48:37 -0700 2017-08-29 07:30:03 -0700 Patch wk2-editor-state.diff text/plain 6001 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMWY0YjkxYjk3MjcuLjAwZmJjZTQyZWJkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI4IEBACisyMDE3LTA4LTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjEwNjQpOiBbR1RLXSBFZGl0b3Igbm90IGNv cnJlY3RseSB3b3JraW5nIGFmdGVyIHIyMjEwNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjA1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHIyMjEwNjQgd2UgYXJlIG5vdCBhbHdheXMgbm90 aWZpZWQgYWJvdXQgdHlwaW5nIGF0dHJpYnV0ZXMgd2hlbiBlZGl0b3Igc3RhdGUgY2hhbmdlcy4g ZGlkQ2hhbmdlU2VsZWN0aW9uCisgICAgICAgIG5vIGxvbmdlciBpbmNsdWRlcyB0aGUgdHlwaW5n IGF0dHJpYnV0ZXMgaW4gRWRpdG9yU3RhdGVDaGFuZ2UgbWVzc2FnZSwgaXQncyBzY2hlZHVsZWQg dG8gYmUgc2VudCBhZnRlciB0aGUKKyAgICAgICAgY29tcG9zaXRpbmcgbGF5ZXIgaGF2ZSBiZWVu IGZsdXNoZWQsIGJ1dCB0aGF0IHBhcnQgaXMgbm90IGltcGxlbWVudGVkIGZvciBHVEsrIHBvcnQu CisKKyAgICAgICAgRml4ZXMgdGVzdCAvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L2VkaXRvci1zdGF0 ZS90eXBpbmctYXR0cmlidXRlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9BY2Nl bGVyYXRlZERyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QWNjZWxlcmF0ZWREcmF3 aW5nQXJlYTo6dXBkYXRlQmFja2luZ1N0b3JlU3RhdGUpOiBDYWxsIFdlYlBhZ2U6OmZsdXNoUGVu ZGluZ0VkaXRvclN0YXRlVXBkYXRlKCkgYWZ0ZXIKKyAgICAgICAgdGhlIGxheW91dC4KKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExh eWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZExheWVyVHJlZUhv c3Q6OmxheWVyRmx1c2hUaW1lckZpcmVkKTogQ2FsbCBXZWJQYWdlOjpmbHVzaFBlbmRpbmdFZGl0 b3JTdGF0ZVVwZGF0ZSgpIGFmdGVyCisgICAgICAgIHRoZSBkaXNwbGF5IHN5bmMuCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJL aXQ6OkRyYXdpbmdBcmVhSW1wbDo6ZGlzcGxheSk6IENhbGwgV2ViUGFnZTo6Zmx1c2hQZW5kaW5n RWRpdG9yU3RhdGVVcGRhdGUoKSBhZnRlciB0aGUgbGF5b3V0LgorICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6 OnBsYXRmb3JtRWRpdG9yU3RhdGUgY29uc3QpOiBBbHNvIHJldHVybiBlYXJseSwgc2V0dGluZyBp c01pc3NpbmdQb3N0TGF5b3V0RGF0YSB0byB0cnVlLCB3aGVuCisgICAgICAgIHRoZXJlJ3Mgbm8g ZnJhbWUgdmlldywgdGhlIHZpZXcgbmVlZHMgYSBsYXlvdXQgb3IgdGhlIHJlc3VsdCBpcyBub3Qg Zm9yIGVkaXRhYmxlIGNvbnRlbnQuCisKIDIwMTctMDgtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gd2Via2l0X2Nvb2tp ZV9tYW5hZ2VyX2RlbGV0ZV9hbGxfY29va2llcyBkb2Vzbid0IGRlbGV0ZSB0aGUgY29va2llcyBp ZiBjYWxsZWQgYmVmb3JlIGEgd2ViIHByb2Nlc3MgaXMgcnVubmluZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9BY2NlbGVyYXRlZERyYXdpbmdBcmVh LmNwcAppbmRleCA5NmMzN2NmNWVlMi4uYWM1MzViMGY3MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0FjY2VsZXJhdGVkRHJhd2luZ0FyZWEu Y3BwCkBAIC0yNDYsNiArMjQ2LDcgQEAgdm9pZCBBY2NlbGVyYXRlZERyYXdpbmdBcmVhOjp1cGRh dGVCYWNraW5nU3RvcmVTdGF0ZSh1aW50NjRfdCBzdGF0ZUlELCBib29sIHJlc3AKICAgICAgICAg bV93ZWJQYWdlLnNldERldmljZVNjYWxlRmFjdG9yKGRldmljZVNjYWxlRmFjdG9yKTsKICAgICAg ICAgbV93ZWJQYWdlLnNldFNpemUoc2l6ZSk7CiAgICAgICAgIG1fd2ViUGFnZS5sYXlvdXRJZk5l ZWRlZCgpOworICAgICAgICBtX3dlYlBhZ2UuZmx1c2hQZW5kaW5nRWRpdG9yU3RhdGVVcGRhdGUo KTsKICAgICAgICAgbV93ZWJQYWdlLnNjcm9sbE1haW5GcmFtZUlmTm90QXRNYXhTY3JvbGxQb3Np dGlvbihzY3JvbGxPZmZzZXQpOwogCiAgICAgICAgIGlmIChtX2xheWVyVHJlZUhvc3QpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBo aWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5j cHAKaW5kZXggMTE5YmEzMzkzMzEuLjViOTk5MmRhNDY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5 ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC0xOTIsNiAr MTkyLDcgQEAgdm9pZCBDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OmxheWVyRmx1c2hUaW1lckZp cmVkKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9jb29yZGluYXRvci5zeW5jRGlzcGxheVN0 YXRlKCk7CisgICAgbV93ZWJQYWdlLmZsdXNoUGVuZGluZ0VkaXRvclN0YXRlVXBkYXRlKCk7CiAK ICAgICBpZiAoIW1faXNWYWxpZCB8fCAhbV9jb29yZGluYXRvci5yb290Q29tcG9zaXRpbmdMYXll cigpKQogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAppbmRleCA3MGRiZjU1NzRjNS4uMzlmMGFmYjM3 OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB cmVhSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2lu Z0FyZWFJbXBsLmNwcApAQCAtNDAwLDYgKzQwMCw3IEBAIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpk aXNwbGF5KFVwZGF0ZUluZm8mIHVwZGF0ZUluZm8pCiAgICAgQVNTRVJUKCFtX3dlYlBhZ2Uuc2l6 ZSgpLmlzRW1wdHkoKSk7CiAKICAgICBtX3dlYlBhZ2UubGF5b3V0SWZOZWVkZWQoKTsKKyAgICBt X3dlYlBhZ2UuZmx1c2hQZW5kaW5nRWRpdG9yU3RhdGVVcGRhdGUoKTsKIAogICAgIC8vIFRoZSBs YXlvdXQgbWF5IGhhdmUgcHV0IHRoZSBwYWdlIGludG8gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcg bW9kZS4gSWYgdGhlIExheWVyVHJlZUhvc3QgaXMKICAgICAvLyBpbiBjaGFyZ2Ugb2YgZGlzcGxh eWluZywgd2UgaGF2ZSBub3RoaW5nIG1vcmUgdG8gZG8uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAKaW5kZXggMDgzNGFlOThlMDUu LjRmZGY3MjZhMjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9ndGsvV2ViUGFnZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvZ3RrL1dlYlBhZ2VHdGsuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgV2ViUGFnZTo6cGxh dGZvcm1EZXRhY2goKQogCiB2b2lkIFdlYlBhZ2U6OnBsYXRmb3JtRWRpdG9yU3RhdGUoRnJhbWUm IGZyYW1lLCBFZGl0b3JTdGF0ZSYgcmVzdWx0LCBJbmNsdWRlUG9zdExheW91dERhdGFIaW50IHNo b3VsZEluY2x1ZGVQb3N0TGF5b3V0RGF0YSkgY29uc3QKIHsKLSAgICBpZiAoc2hvdWxkSW5jbHVk ZVBvc3RMYXlvdXREYXRhID09IEluY2x1ZGVQb3N0TGF5b3V0RGF0YUhpbnQ6Ok5vKSB7CisgICAg aWYgKHNob3VsZEluY2x1ZGVQb3N0TGF5b3V0RGF0YSA9PSBJbmNsdWRlUG9zdExheW91dERhdGFI aW50OjpObyB8fCAhZnJhbWUudmlldygpIHx8IGZyYW1lLnZpZXcoKS0+bmVlZHNMYXlvdXQoKSB8 fCAhcmVzdWx0LmlzQ29udGVudEVkaXRhYmxlKSB7CiAgICAgICAgIHJlc3VsdC5pc01pc3NpbmdQ b3N0TGF5b3V0RGF0YSA9IHRydWU7CiAgICAgICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjllMTcyZmI4YWEuLjA0 N2ZkYjRiMjcxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDgtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyMTA2NCk6IFtHVEtd IEVkaXRvciBub3QgY29ycmVjdGx5IHdvcmtpbmcgYWZ0ZXIgcjIyMTA2NAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MDUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUnVuIHRoZSB0ZXN0IGluc2lkZSBh IHdpbmRvdyB0byBlbnN1cmUgZGlzcGxheSB1cGRhdGVzIGhhcHBlbi4KKworICAgICAgICAqIFRl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RXZWJWaWV3RWRpdG9yLmNwcDoKKyAgICAg ICAgKHRlc3RXZWJWaWV3RWRpdG9yRWRpdG9yU3RhdGVUeXBpbmdBdHRyaWJ1dGVzKToKKwogMjAx Ny0wOC0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS11bV1BFXSB3ZWJraXRfY29va2llX21hbmFnZXJfZGVsZXRlX2FsbF9jb29raWVz IGRvZXNuJ3QgZGVsZXRlIHRoZSBjb29raWVzIGlmIGNhbGxlZCBiZWZvcmUgYSB3ZWIgcHJvY2Vz cyBpcyBydW5uaW5nCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dEd0ay9UZXN0V2ViVmlld0VkaXRvci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdEd0ay9UZXN0V2ViVmlld0VkaXRvci5jcHAKaW5kZXggMDBjMDJhZWQyMDYuLjc2ZmI2Y2Vh MGUyIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEd0ay9UZXN0 V2ViVmlld0VkaXRvci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRH dGsvVGVzdFdlYlZpZXdFZGl0b3IuY3BwCkBAIC0yOTMsNiArMjkzLDcgQEAgc3RhdGljIHZvaWQg dGVzdFdlYlZpZXdFZGl0b3JFZGl0b3JTdGF0ZVR5cGluZ0F0dHJpYnV0ZXMoRWRpdG9yVGVzdCog dGVzdCwgZ2NvbnMKICAgICAgICAgIjxiPjxpPmJvbGRhbmRpdGFsaWMgPC9pPjwvYj4iCiAgICAg ICAgICI8L2JvZHk+PC9odG1sPiI7CiAKKyAgICB0ZXN0LT5zaG93SW5XaW5kb3dBbmRXYWl0VW50 aWxNYXBwZWQoKTsKICAgICB0ZXN0LT5sb2FkSHRtbCh0eXBpbmdBdHRyaWJ1dGVzSFRNTCwgbnVs bHB0cik7CiAgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CiAgICAgdGVzdC0+c2V0 RWRpdGFibGUodHJ1ZSk7Cg==