176029 2017-08-28 11:19:00 -0700 Web Inspector: Remove some unused DataGrid code 2017-08-28 12:58:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1342866 0 joepeck 2017-08-28 11:19:00 -0700 Remove some unused DataGrid code: - ResizeMethod stuff - ColumnWidthsMap stuff 1342869 1 319186 joepeck 2017-08-28 11:21:34 -0700 Created attachment 319186 [PATCH] Proposed Fix 1342873 2 319186 mattbaker 2017-08-28 11:36:54 -0700 Comment on attachment 319186 [PATCH] Proposed Fix Nice cleanup, r=me 1342898 3 319186 commit-queue 2017-08-28 12:57:02 -0700 Comment on attachment 319186 [PATCH] Proposed Fix Clearing flags on attachment: 319186 Committed r221266: <http://trac.webkit.org/changeset/221266> 1342899 4 commit-queue 2017-08-28 12:57:03 -0700 All reviewed patches have been landed. Closing bug. 1342900 5 webkit-bug-importer 2017-08-28 12:58:04 -0700 <rdar://problem/34116670> 319186 2017-08-28 11:21:34 -0700 2017-08-28 12:57:02 -0700 [PATCH] Proposed Fix unused-1.patch text/plain 5430 joepeck Y29tbWl0IDg0ZDIzNDM0ZDkxOWFhYzU4MzgyMjM3YjIwMmMzOWJhYWE1OGFhMzUKQXV0aG9yOiBK b3NlcGggUGVjb3Jhcm8gPHBlY29yYXJvQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gQXVnIDI4IDEx OjIxOjEyIDIwMTcgLTA3MDAKCiAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgc29tZSB1bnVzZWQg RGF0YUdyaWQgY29kZQogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NjAyOQogICAgCiAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzOgogICAgKFdJLkRhdGFHcmlkLnByb3RvdHlw ZS5nZXQgY29weVRleHREZWxpbWl0ZXIpOgogICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5zZXQg Y29weVRleHREZWxpbWl0ZXIpOgogICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5yZXNpemVyRHJh Z2dpbmcpOgogICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5jb2x1bW5XaWR0aHNNYXApOiBEZWxl dGVkLgogICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5hcHBseUNvbHVtbldpZHRoc01hcCk6IERl bGV0ZWQuCiAgICAoV0kuRGF0YUdyaWQucHJvdG90eXBlLmdldCByZXNpemVNZXRob2QpOiBEZWxl dGVkLgogICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5zZXQgcmVzaXplTWV0aG9kKTogRGVsZXRl ZC4KCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2NjMwNDIyZDJmNC4uZjIzODhhMGY0YTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA4LTI4ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogUmVtb3ZlIHNvbWUgdW51c2VkIERhdGFHcmlkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjAyOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EYXRh R3JpZC5qczoKKyAgICAgICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5nZXQgY29weVRleHREZWxp bWl0ZXIpOgorICAgICAgICAoV0kuRGF0YUdyaWQucHJvdG90eXBlLnNldCBjb3B5VGV4dERlbGlt aXRlcik6CisgICAgICAgIChXSS5EYXRhR3JpZC5wcm90b3R5cGUucmVzaXplckRyYWdnaW5nKToK KyAgICAgICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5jb2x1bW5XaWR0aHNNYXApOiBEZWxldGVk LgorICAgICAgICAoV0kuRGF0YUdyaWQucHJvdG90eXBlLmFwcGx5Q29sdW1uV2lkdGhzTWFwKTog RGVsZXRlZC4KKyAgICAgICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5nZXQgcmVzaXplTWV0aG9k KTogRGVsZXRlZC4KKyAgICAgICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5zZXQgcmVzaXplTWV0 aG9kKTogRGVsZXRlZC4KKwogMjAxNy0wOC0yNyAgRGV2aW4gUm91c3NvICA8d2Via2l0QGRldmlu cm91c3NvLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWNvcmQgYWN0aW9ucyBwZXJm b3JtZWQgb24gV2ViR0xSZW5kZXJpbmdDb250ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCmluZGV4IDJiNDFiY2U4ZDEz Li42ZWI2YzcyY2Q1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKQEAgLTIzMCw2ICsyMzAsOSBAQCBXSS5EYXRhR3Jp ZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0kuVmlldwogICAgIGdldCBjb2x1bW5DaG9vc2Vy RW5hYmxlZCgpIHsgcmV0dXJuIHRoaXMuX2NvbHVtbkNob29zZXJFbmFibGVkOyB9CiAgICAgc2V0 IGNvbHVtbkNob29zZXJFbmFibGVkKHgpIHsgdGhpcy5fY29sdW1uQ2hvb3NlckVuYWJsZWQgPSB4 OyB9CiAKKyAgICBnZXQgY29weVRleHREZWxpbWl0ZXIoKSB7IHJldHVybiB0aGlzLl9jb3B5VGV4 dERlbGltaXRlcjsgfQorICAgIHNldCBjb3B5VGV4dERlbGltaXRlcih4KSB7IHRoaXMuX2NvcHlU ZXh0RGVsaW1pdGVyID0geDsgfQorCiAgICAgZ2V0IHJlZnJlc2hDYWxsYmFjaygpCiAgICAgewog ICAgICAgICByZXR1cm4gdGhpcy5fcmVmcmVzaENhbGxiYWNrOwpAQCAtODkxLDI4ICs4OTQsNiBA QCBXSS5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB0 aGlzLl9jYWNoZWRTY3JvbGxhYmxlT2Zmc2V0SGVpZ2h0ID0gTmFOOwogICAgIH0KIAotICAgIGNv bHVtbldpZHRoc01hcCgpCi0gICAgewotICAgICAgICB2YXIgcmVzdWx0ID0ge307Ci0gICAgICAg IGZvciAodmFyIFtpZGVudGlmaWVyLCBjb2x1bW5dIG9mIHRoaXMuY29sdW1ucykgewotICAgICAg ICAgICAgdmFyIHdpZHRoID0gdGhpcy5faGVhZGVyVGFibGVDb2x1bW5Hcm91cEVsZW1lbnQuY2hp bGRyZW5bY29sdW1uWyJvcmRpbmFsIl1dLnN0eWxlLndpZHRoOwotICAgICAgICAgICAgcmVzdWx0 W2lkZW50aWZpZXJdID0gcGFyc2VGbG9hdCh3aWR0aCk7Ci0gICAgICAgIH0KLSAgICAgICAgcmV0 dXJuIHJlc3VsdDsKLSAgICB9Ci0KLSAgICBhcHBseUNvbHVtbldpZHRoc01hcChjb2x1bW5XaWR0 aHNNYXApCi0gICAgewotICAgICAgICBmb3IgKHZhciBbaWRlbnRpZmllciwgY29sdW1uXSBvZiB0 aGlzLmNvbHVtbnMpIHsKLSAgICAgICAgICAgIHZhciB3aWR0aCA9IChjb2x1bW5XaWR0aHNNYXBb aWRlbnRpZmllcl0gfHwgMCkgKyAiJSI7Ci0gICAgICAgICAgICB2YXIgb3JkaW5hbCA9IGNvbHVt blsib3JkaW5hbCJdOwotICAgICAgICAgICAgdGhpcy5faGVhZGVyVGFibGVDb2x1bW5Hcm91cEVs ZW1lbnQuY2hpbGRyZW5bb3JkaW5hbF0uc3R5bGUud2lkdGggPSB3aWR0aDsKLSAgICAgICAgICAg IHRoaXMuX2RhdGFUYWJsZUNvbHVtbkdyb3VwRWxlbWVudC5jaGlsZHJlbltvcmRpbmFsXS5zdHls ZS53aWR0aCA9IHdpZHRoOwotICAgICAgICB9Ci0KLSAgICAgICAgdGhpcy5uZWVkc0xheW91dCgp OwotICAgIH0KLQogICAgIF9pc0NvbHVtblZpc2libGUoY29sdW1uSWRlbnRpZmllcikKICAgICB7 CiAgICAgICAgIHJldHVybiAhdGhpcy5jb2x1bW5zLmdldChjb2x1bW5JZGVudGlmaWVyKVsiaGlk ZGVuIl07CkBAIC0xNzE4LDggKzE2OTksNiBAQCBXSS5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlk IGV4dGVuZHMgV0kuVmlldwogICAgICAgICByZXR1cm4gKGRhdGEgaW5zdGFuY2VvZiBOb2RlID8g ZGF0YS50ZXh0Q29udGVudCA6IGRhdGEpIHx8ICIiOwogICAgIH0KIAotICAgIHNldCBjb3B5VGV4 dERlbGltaXRlcih2YWx1ZSkgeyB0aGlzLl9jb3B5VGV4dERlbGltaXRlciA9IHZhbHVlOyB9Ci0K ICAgICBfY29weVRleHRGb3JEYXRhR3JpZE5vZGUobm9kZSkKICAgICB7CiAgICAgICAgIGxldCBm aWVsZHMgPSBub2RlLmRhdGFHcmlkLm9yZGVyZWRDb2x1bW5zLm1hcCgoaWRlbnRpZmllcikgPT4g dGhpcy50ZXh0Rm9yRGF0YUdyaWROb2RlQ29sdW1uKG5vZGUsIGlkZW50aWZpZXIpKTsKQEAgLTE3 NzgsMTggKzE3NTcsNiBAQCBXSS5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0ku VmlldwogICAgICAgICByZXR1cm4gZ3JpZE5vZGUgJiYgZ3JpZE5vZGUuc2VsZWN0YWJsZSAmJiBn cmlkTm9kZS5jb3B5YWJsZTsKICAgICB9CiAKLSAgICBnZXQgcmVzaXplTWV0aG9kKCkKLSAgICB7 Ci0gICAgICAgIGlmICghdGhpcy5fcmVzaXplTWV0aG9kKQotICAgICAgICAgICAgcmV0dXJuIFdJ LkRhdGFHcmlkLlJlc2l6ZU1ldGhvZC5OZWFyZXN0OwotICAgICAgICByZXR1cm4gdGhpcy5fcmVz aXplTWV0aG9kOwotICAgIH0KLQotICAgIHNldCByZXNpemVNZXRob2QobWV0aG9kKQotICAgIHsK LSAgICAgICAgdGhpcy5fcmVzaXplTWV0aG9kID0gbWV0aG9kOwotICAgIH0KLQogICAgIHJlc2l6 ZXJEcmFnU3RhcnRlZChyZXNpemVyKQogICAgIHsKICAgICAgICAgaWYgKCFyZXNpemVyW1dJLkRh dGFHcmlkLk5leHRDb2x1bW5PcmRpbmFsU3ltYm9sXSkKQEAgLTE4MjQsMTQgKzE3OTEsNiBAQCBX SS5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0kuVmlldwogICAgICAgICBmb3Ig KGxldCBpID0gMDsgaSA8IGxlZnRDb2x1bW5JbmRleDsgKytpKQogICAgICAgICAgICAgbGVhZGlu Z0VkZ2VPZlByZXZpb3VzQ29sdW1uICs9IGZpcnN0Um93Q2VsbHNbaV0ub2Zmc2V0V2lkdGg7CiAK LSAgICAgICAgLy8gRGlmZmVyZW5jZXMgZm9yIG90aGVyIHJlc2l6ZSBtZXRob2RzCi0gICAgICAg IGlmICh0aGlzLnJlc2l6ZU1ldGhvZCA9PT0gV0kuRGF0YUdyaWQuUmVzaXplTWV0aG9kLkxhc3Qp IHsKLSAgICAgICAgICAgIHJpZ2h0Q29sdW1uSW5kZXggPSB0aGlzLnJlc2l6ZXJzLmxlbmd0aDsK LSAgICAgICAgfSBlbHNlIGlmICh0aGlzLnJlc2l6ZU1ldGhvZCA9PT0gV0kuRGF0YUdyaWQuUmVz aXplTWV0aG9kLkZpcnN0KSB7Ci0gICAgICAgICAgICBsZWFkaW5nRWRnZU9mUHJldmlvdXNDb2x1 bW4gKz0gZmlyc3RSb3dDZWxsc1tsZWZ0Q29sdW1uSW5kZXhdLm9mZnNldFdpZHRoIC0gZmlyc3RS b3dDZWxsc1swXS5vZmZzZXRXaWR0aDsKLSAgICAgICAgICAgIGxlZnRDb2x1bW5JbmRleCA9IDA7 Ci0gICAgICAgIH0KLQogICAgICAgICBsZXQgdHJhaWxpbmdFZGdlT2ZOZXh0Q29sdW1uID0gbGVh ZGluZ0VkZ2VPZlByZXZpb3VzQ29sdW1uICsgZmlyc3RSb3dDZWxsc1tsZWZ0Q29sdW1uSW5kZXhd Lm9mZnNldFdpZHRoICsgZmlyc3RSb3dDZWxsc1tyaWdodENvbHVtbkluZGV4XS5vZmZzZXRXaWR0 aDsKIAogICAgICAgICAvLyBHaXZlIGVhY2ggY29sdW1uIHNvbWUgcGFkZGluZyBzbyB0aGF0IHRo ZXkgZG9uJ3QgZGlzYXBwZWFyLgpAQCAtMTk0OCwxMiArMTkwNyw2IEBAIFdJLkRhdGFHcmlkLkV2 ZW50ID0gewogICAgIE5vZGVXYXNGaWx0ZXJlZDogImRhdGFncmlkLW5vZGUtd2FzLWZpbHRlcmVk IgogfTsKIAotV0kuRGF0YUdyaWQuUmVzaXplTWV0aG9kID0gewotICAgIE5lYXJlc3Q6ICJuZWFy ZXN0IiwKLSAgICBGaXJzdDogImZpcnN0IiwKLSAgICBMYXN0OiAibGFzdCIKLX07Ci0KIFdJLkRh dGFHcmlkLlNvcnRPcmRlciA9IHsKICAgICBJbmRldGVybWluYXRlOiAiZGF0YS1ncmlkLXNvcnQt b3JkZXItaW5kZXRlcm1pbmF0ZSIsCiAgICAgQXNjZW5kaW5nOiAiZGF0YS1ncmlkLXNvcnQtb3Jk ZXItYXNjZW5kaW5nIiwK