176024 2017-08-28 08:17:51 -0700 [GTK] Layout test fast/forms/file/webkitdirectory-open-panel.html is failing 2018-03-21 03:32:31 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro Ms2ger bugs-noreply cdumez commit-queue mcatanzaro Ms2ger oldest_to_newest 1342834 0 mcatanzaro 2017-08-28 08:17:51 -0700 Layout test fast/forms/file/webkitdirectory-open-panel.html is failing since it was added in r221177. I'm not sure if this is an actual problem, or if it's OK that the results are unordered. I'll mark it as expected fail for now and if Chris thinks it's OK, we can add a platform expectation instead. --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/forms/file/webkitdirectory-open-panel-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/forms/file/webkitdirectory-open-panel-actual.txt @@ -7,17 +7,18 @@ PASS inputElement.webkitdirectory is true PASS fileList.length is 5 -PASS fileList[0].name is "file1.txt" -PASS fileList[0].webkitRelativePath is "testFiles/file1.txt" -PASS fileList[1].name is "file2.txt" -PASS fileList[1].webkitRelativePath is "testFiles/file2.txt" -PASS fileList[2].name is "file3.txt" -PASS fileList[2].webkitRelativePath is "testFiles/subfolder1/file3.txt" -PASS fileList[3].name is "file4.txt" -PASS fileList[3].webkitRelativePath is "testFiles/subfolder2/file4.txt" -PASS fileList[4].name is "file5.txt" -PASS fileList[4].webkitRelativePath is "testFiles/subfolder2/subfolder2a/file5.txt" +FAIL fileList[0].name should be file1.txt. Was file2.txt. +FAIL fileList[0].webkitRelativePath should be testFiles/file1.txt. Was testFiles/file2.txt. +FAIL fileList[1].name should be file2.txt. Was file1.txt. +FAIL fileList[1].webkitRelativePath should be testFiles/file2.txt. Was testFiles/file1.txt. +FAIL fileList[2].name should be file3.txt. Was file4.txt. +FAIL fileList[2].webkitRelativePath should be testFiles/subfolder1/file3.txt. Was testFiles/subfolder2/file4.txt. +FAIL fileList[3].name should be file4.txt. Was file5.txt. +FAIL fileList[3].webkitRelativePath should be testFiles/subfolder2/file4.txt. Was testFiles/subfolder2/subfolder2a/file5.txt. +FAIL fileList[4].name should be file5.txt. Was file3.txt. +FAIL fileList[4].webkitRelativePath should be testFiles/subfolder2/subfolder2a/file5.txt. Was testFiles/subfolder1/file3.txt. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1342840 1 cdumez 2017-08-28 09:05:03 -0700 If it is WebKit1, you probably need to enable the feature in your DRT. 1342842 2 cdumez 2017-08-28 09:07:14 -0700 My comment was about the failures. The fact that the lines are in a different order may mean that listDirectory() works differently on Mac and Linux and returns non-sorted results. We may want to make the test deal with non-sorted results. 1342843 3 mcatanzaro 2017-08-28 09:19:32 -0700 (In reply to Chris Dumez from comment #1) > If it is WebKit1, you probably need to enable the feature in your DRT. WebKit1 is long gone! I think the lines being unsorted is the only failure. 1407960 4 336184 Ms2ger 2018-03-21 02:49:39 -0700 Created attachment 336184 Patch 1407964 5 336184 commit-queue 2018-03-21 03:32:29 -0700 Comment on attachment 336184 Patch Clearing flags on attachment: 336184 Committed r229802: <https://trac.webkit.org/changeset/229802> 1407965 6 commit-queue 2018-03-21 03:32:31 -0700 All reviewed patches have been landed. Closing bug. 336184 2018-03-21 02:49:39 -0700 2018-03-21 03:32:29 -0700 Patch bug-176024-20180321104937.patch text/plain 1520 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5ODAwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjgyOWFmYzUyZjE2MDQ5NmU5YjYx ZTRjMGRjZTQ5ODBmZDllMzIzYi4uYjYyYmFlOTQ2NjM1YWQzNWZiMTBiZTc5MzNjZDBmNGU4MDVk MzRkNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTIxICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNYXJrIGZhc3QvZm9ybXMvZmlsZS9lbnRyaWVz LWFwaS93ZWJraXRkaXJlY3Rvcnktb3Blbi1wYW5lbC5odG1sIGFzIHBhc3NpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYwMjQKKworICAgICAg ICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgIEl0IGhhcyBiZWVuIHBhc3Np bmcgc2luY2UgdGhlIHRlc3Qgd2FzIGNoYW5nZWQgbm90IHRvIHJlbHkgb24gdGhlIG9yZGVyCisg ICAgICAgIG9mIGZpbGVzIGluIHRoZSBsaXN0IGluIHIyMjk2NDIuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxOC0wMy0yMCAgWmFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmRlclRyZWVOZWVkc0xheW91dENoZWNrZXIg ZmFpbHMgd2l0aCBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgc3ZnIGFuZCA8dXNlPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5NzczM2VkOWU4ZTE4NGUyMzBj MzExNzllZDI1YzVkN2ZmYTczNjFiLi4yZTQwODQyNWE3MGJiYjVmZWIwZDc3MGRjODU2NGU2ODNh YWM5NWM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAt MzIzMSw4ICszMjMxLDYgQEAgd2Via2l0Lm9yZy9iLzE3NTkzMSBmYXN0L2NhbnZhcy93ZWJnbC9u by1pbmZvLWxvZy1mb3Itc2ltcGxlLXNoYWRlcnMuaHRtbCBbIEZhaWwKIAogd2Via2l0Lm9yZy9i LzE3NjAyMSBmYXN0L2V2ZW50cy9vdmVyZmxvdy12aWV3cG9ydC1yZW5kZXJlci1kZWxldGVkLmh0 bWwgWyBNaXNzaW5nIF0KIAotd2Via2l0Lm9yZy9iLzE3NjAyNCBmYXN0L2Zvcm1zL2ZpbGUvZW50 cmllcy1hcGkvd2Via2l0ZGlyZWN0b3J5LW9wZW4tcGFuZWwuaHRtbCBbIEZhaWx1cmUgXQotCiB3 ZWJraXQub3JnL2IvMTc2MDI1IGluc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLXdlYmdsLXNuYXBz aG90cy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTc2MDI1IGluc3BlY3Rvci9jYW52 YXMvcmVjb3JkaW5nLXdlYmdsLmh0bWwgWyBGYWlsdXJlIF0KIAo=