176006 2017-08-26 04:40:00 -0700 Promise.prototype.finally should perform PromiseResolve 2020-09-10 16:03:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar, WebExposed P2 Trivial --- 1 gskachkov ashvayka ashvayka ews-watchlist joepeck keith_miller ljharb mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1342645 0 gskachkov 2017-08-26 04:40:00 -0700 Reflect change in PromiseResolve https://github.com/tc39/proposal-promise-finally/issues/37#event-1222201172 1342664 1 ljharb 2017-08-26 13:44:53 -0700 Thanks for filing this. Hopefully this is a minor change, and allows for a slight perf boost. 1685388 2 407905 ashvayka 2020-09-03 12:08:41 -0700 Created attachment 407905 Patch 1685389 3 ashvayka 2020-09-03 12:10:36 -0700 Test262 coverage is coming in https://github.com/tc39/test262/pull/2752. 1685390 4 407905 ysuzuki 2020-09-03 12:13:23 -0700 Comment on attachment 407905 Patch r=me 1687578 5 ashvayka 2020-09-10 16:03:02 -0700 Committed r266896: <https://trac.webkit.org/changeset/266896> 1687579 6 webkit-bug-importer 2020-09-10 16:03:18 -0700 <rdar://problem/68670458> 407905 2020-09-03 12:08:41 -0700 2020-09-03 12:13:23 -0700 Patch bug-176006-20200903220840.patch text/plain 4021 ashvayka SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY2NTM1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDIwLTA5LTAzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKwor ICAgICAgICBQcm9taXNlLnByb3RvdHlwZS5maW5hbGx5IHNob3VsZCBwZXJmb3JtIFByb21pc2VS ZXNvbHZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzYwMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGV4dHJhY3RzIEBwcm9taXNlUmVzb2x2ZSBnbG9iYWwgcHJpdmF0ZSBtZXRob2Qg YW5kIHV0aWxpemVzIGl0IGluCisgICAgICAgIFByb21pc2UucHJvdG90eXBlLmZpbmFsbHkgdGhl bi9jYXRjaCBmdW5jdGlvbnMgWzFdIHRvIGF2b2lkIGNyZWF0aW5nIGFuIGV4dHJhCisgICAgICAg IFByb21pc2UgQ2FwYWJpbGl0eS4gQWxpZ25zIEpTQyB3aXRoIFY4IGFuZCBTcGlkZXJNb25rZXku CisKKyAgICAgICAgWzFdOiBodHRwczovL3RjMzkuZXMvZWNtYTI2Mi8jc2VjLXRoZW5maW5hbGx5 ZnVuY3Rpb25zIChzdGVwIDcpCisKKyAgICAgICAgKiBidWlsdGlucy9Qcm9taXNlQ29uc3RydWN0 b3IuanM6CisgICAgICAgIChyZXNvbHZlKToKKyAgICAgICAgKiBidWlsdGlucy9Qcm9taXNlT3Bl cmF0aW9ucy5qczoKKyAgICAgICAgKGdsb2JhbFByaXZhdGUucHJvbWlzZVJlc29sdmUpOgorICAg ICAgICAqIGJ1aWx0aW5zL1Byb21pc2VQcm90b3R5cGUuanM6CisgICAgICAgIChnbG9iYWxQcml2 YXRlLmdldFRoZW5GaW5hbGx5KToKKyAgICAgICAgKGdsb2JhbFByaXZhdGUuZ2V0Q2F0Y2hGaW5h bGx5KToKKwogMjAyMC0wOS0wMyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogYWxsb3cgc3BlY2lhbCBKYXZhU2NyaXB0IGJyZWFrcG9p bnRzIHRvIGJlIGNvbmZpZ3VyZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlu cy9Qcm9taXNlQ29uc3RydWN0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2J1aWx0aW5zL1Byb21pc2VDb25zdHJ1Y3Rvci5qcwkocmV2aXNpb24gMjY2NTA3KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1Byb21pc2VDb25zdHJ1Y3Rvci5qcwkod29y a2luZyBjb3B5KQpAQCAtMjYzLDE5ICsyNjMsNyBAQCBmdW5jdGlvbiByZXNvbHZlKHZhbHVlKQog ICAgIGlmICghQGlzT2JqZWN0KHRoaXMpKQogICAgICAgICBAdGhyb3dUeXBlRXJyb3IoInx0aGlz fCBpcyBub3QgYW4gb2JqZWN0Iik7CiAKLSAgICBpZiAoQGlzUHJvbWlzZSh2YWx1ZSkpIHsKLSAg ICAgICAgdmFyIHZhbHVlQ29uc3RydWN0b3IgPSB2YWx1ZS5jb25zdHJ1Y3RvcjsKLSAgICAgICAg aWYgKHZhbHVlQ29uc3RydWN0b3IgPT09IHRoaXMpCi0gICAgICAgICAgICByZXR1cm4gdmFsdWU7 Ci0gICAgfQotCi0gICAgaWYgKHRoaXMgPT09IEBQcm9taXNlKSB7Ci0gICAgICAgIHZhciBwcm9t aXNlID0gQG5ld1Byb21pc2UoKTsKLSAgICAgICAgQHJlc29sdmVQcm9taXNlV2l0aEZpcnN0UmVz b2x2aW5nRnVuY3Rpb25DYWxsQ2hlY2socHJvbWlzZSwgdmFsdWUpOwotICAgICAgICByZXR1cm4g cHJvbWlzZTsKLSAgICB9Ci0KLSAgICByZXR1cm4gQHByb21pc2VSZXNvbHZlU2xvdyh0aGlzLCB2 YWx1ZSk7CisgICAgcmV0dXJuIEBwcm9taXNlUmVzb2x2ZSh0aGlzLCB2YWx1ZSk7CiB9CiAKIEBu YWtlZENvbnN0cnVjdG9yCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUHJv bWlzZU9wZXJhdGlvbnMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J1 aWx0aW5zL1Byb21pc2VPcGVyYXRpb25zLmpzCShyZXZpc2lvbiAyNjY1MDcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUHJvbWlzZU9wZXJhdGlvbnMuanMJKHdvcmtpbmcgY29w eSkKQEAgLTkwLDYgKzkwLDIxIEBAIGZ1bmN0aW9uIG5ld1Byb21pc2VDYXBhYmlsaXR5KGNvbnN0 cnVjdG8KIH0KIAogQGdsb2JhbFByaXZhdGUKK2Z1bmN0aW9uIHByb21pc2VSZXNvbHZlKGNvbnN0 cnVjdG9yLCB2YWx1ZSkKK3sKKyAgICBpZiAoQGlzUHJvbWlzZSh2YWx1ZSkgJiYgdmFsdWUuY29u c3RydWN0b3IgPT09IGNvbnN0cnVjdG9yKQorICAgICAgICByZXR1cm4gdmFsdWU7CisKKyAgICBp ZiAoY29uc3RydWN0b3IgPT09IEBQcm9taXNlKSB7CisgICAgICAgIHZhciBwcm9taXNlID0gQG5l d1Byb21pc2UoKTsKKyAgICAgICAgQHJlc29sdmVQcm9taXNlV2l0aEZpcnN0UmVzb2x2aW5nRnVu Y3Rpb25DYWxsQ2hlY2socHJvbWlzZSwgdmFsdWUpOworICAgICAgICByZXR1cm4gcHJvbWlzZTsK KyAgICB9CisKKyAgICByZXR1cm4gQHByb21pc2VSZXNvbHZlU2xvdyhjb25zdHJ1Y3RvciwgdmFs dWUpOworfQorCitAZ2xvYmFsUHJpdmF0ZQogZnVuY3Rpb24gcHJvbWlzZVJlc29sdmVTbG93KGNv bnN0cnVjdG9yLCB2YWx1ZSkKIHsKICAgICBAYXNzZXJ0KGNvbnN0cnVjdG9yICE9PSBAUHJvbWlz ZSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUHJvbWlzZVByb3RvdHlw ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUHJvbWlz ZVByb3RvdHlwZS5qcwkocmV2aXNpb24gMjY2NTA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2J1aWx0aW5zL1Byb21pc2VQcm90b3R5cGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTg5LDExICs4 OSw4IEBAIGZ1bmN0aW9uIGdldFRoZW5GaW5hbGx5KG9uRmluYWxseSwgY29uc3QKICAgICAgICAg dmFyIHJlc3VsdCA9IG9uRmluYWxseSgpOwogCiAgICAgICAgIEBhc3NlcnQoQGlzQ29uc3RydWN0 b3IoY29uc3RydWN0b3IpKTsKLSAgICAgICAgdmFyIHJlc3VsdENhcGFiaWxpdHkgPSBAbmV3UHJv bWlzZUNhcGFiaWxpdHkoY29uc3RydWN0b3IpOworICAgICAgICB2YXIgcHJvbWlzZSA9IEBwcm9t aXNlUmVzb2x2ZShjb25zdHJ1Y3RvciwgcmVzdWx0KTsKIAotICAgICAgICByZXN1bHRDYXBhYmls aXR5LkByZXNvbHZlLkBjYWxsKEB1bmRlZmluZWQsIHJlc3VsdCk7Ci0KLSAgICAgICAgdmFyIHBy b21pc2UgPSByZXN1bHRDYXBhYmlsaXR5LkBwcm9taXNlOwogICAgICAgICByZXR1cm4gcHJvbWlz ZS50aGVuKCgpID0+IHZhbHVlKTsKICAgICB9CiB9CkBAIC0xMDksMTEgKzEwNiw4IEBAIGZ1bmN0 aW9uIGdldENhdGNoRmluYWxseShvbkZpbmFsbHksIGNvbnMKICAgICAgICAgdmFyIHJlc3VsdCA9 IG9uRmluYWxseSgpOwogCiAgICAgICAgIEBhc3NlcnQoQGlzQ29uc3RydWN0b3IoY29uc3RydWN0 b3IpKTsKLSAgICAgICAgdmFyIHJlc3VsdENhcGFiaWxpdHkgPSBAbmV3UHJvbWlzZUNhcGFiaWxp dHkoY29uc3RydWN0b3IpOwotCi0gICAgICAgIHJlc3VsdENhcGFiaWxpdHkuQHJlc29sdmUuQGNh bGwoQHVuZGVmaW5lZCwgcmVzdWx0KTsKKyAgICAgICAgdmFyIHByb21pc2UgPSBAcHJvbWlzZVJl c29sdmUoY29uc3RydWN0b3IsIHJlc3VsdCk7CiAKLSAgICAgICAgdmFyIHByb21pc2UgPSByZXN1 bHRDYXBhYmlsaXR5LkBwcm9taXNlOwogICAgICAgICByZXR1cm4gcHJvbWlzZS50aGVuKCgpID0+ IHsgdGhyb3cgcmVhc29uOyB9KTsKICAgICB9CiB9Cg==