176004 2017-08-25 17:52:31 -0700 Fix incorrect enum in atBoundaryOfGranularity call 2017-08-28 16:57:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin enrica thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1342599 0 megan_gardner 2017-08-25 17:52:31 -0700 Fix incorrect enum in atBoundaryOfGranularity call 1342601 1 319123 megan_gardner 2017-08-25 18:03:34 -0700 Created attachment 319123 Patch 1342633 2 319123 wenson_hsieh 2017-08-26 00:46:42 -0700 Comment on attachment 319123 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319123&action=review Nice find! r=me (though, this might still need a WK2R?) > Source/WebKit/ChangeLog:6 > + Enum that was being used was incorrect, as that case in not covered in called function. The ChangeLog description should go under the "Reviewed by" line. (also, it looks like you meant "is not covered" instead of "in not covered"). > Source/WebKit/ChangeLog:7 > + Resulted in a no-op, expected behavior will happen now. I think a sentence or two describing the "expected behavior" here would be helpful. What change in behavior did you observe after making this tweak? 1342988 3 megan_gardner 2017-08-28 16:56:51 -0700 https://trac.webkit.org/r221281 1342989 4 webkit-bug-importer 2017-08-28 16:57:46 -0700 <rdar://problem/34122131> 319123 2017-08-25 18:03:34 -0700 2017-08-26 00:50:03 -0700 Patch bug-176004-20170825180334.patch text/plain 2073 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjEyMTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA4LTI1ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGluY29ycmVjdCBl bnVtIGluIGF0Qm91bmRhcnlPZkdyYW51bGFyaXR5IGNhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjAwNAorCisgICAgICAgIEVudW0gdGhhdCB3 YXMgYmVpbmcgdXNlZCB3YXMgaW5jb3JyZWN0LCBhcyB0aGF0IGNhc2UgaW4gbm90IGNvdmVyZWQg aW4gY2FsbGVkIGZ1bmN0aW9uLgorICAgICAgICBSZXN1bHRlZCBpbiBhIG5vLW9wLCBleHBlY3Rl ZCBiZWhhdmlvciB3aWxsIGhhcHBlbiBub3cuCisgICAgICAgIAorICAgICAgICBOb3QgcG9zc2li bGUgdG8gYWRkIHRlc3RzIGZvciBzZWxlY3Rpb25zIHdpdGggdmVsb2NpdHkuIFdpbGwgYXR0ZW1w dCB0byBhZGQgdGhpcyBiZWhhdmlvciBsYXRlci4KKyAgICAgICAgCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X ZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpyYW5nZUF0V29yZEJvdW5kYXJ5Rm9yUG9z aXRpb24pOgorCiAyMDE3LTA4LTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFdLVUlEZWxlZ2F0ZVByaXZhdGUgZXF1aXZhbGVudCBv ZiBXS1BhZ2VVSUNsaWVudCdzIHNhdmVEYXRhVG9GaWxlSW5Eb3dubG9hZHNGb2xkZXIKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9T Lm1tCShyZXZpc2lvbiAyMjA4OTQpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTI0NSwxMCArMTI0NSwxMCBA QCBzdGF0aWMgUmVmUHRyPFJhbmdlPiByYW5nZUF0V29yZEJvdW5kYXJ5CiAKICAgICAvLyBJZiB0 aGlzIGlzIHdoZXJlIHRoZSBleHRlbnQgd2FzIGluaXRpYWxseSwgdGhlbiBpdGVyYXRlIGluIHRo ZSBvdGhlciBkaXJlY3Rpb24gaW4gdGhlIGRvY3VtZW50IHVudGlsIHdlIGhpdCB0aGUgbmV4dCB3 b3JkLgogICAgIHdoaWxlIChleHRlbnQuaXNOb3ROdWxsKCkKLSAgICAgICAgICAgJiYgIWF0Qm91 bmRhcnlPZkdyYW51bGFyaXR5KGV4dGVudCwgV29yZEdyYW51bGFyaXR5LCBzYW1lRGlyZWN0aW9u KQotICAgICAgICAgICAmJiBleHRlbnQgIT0gYmFzZQotICAgICAgICAgICAmJiAhYXRCb3VuZGFy eU9mR3JhbnVsYXJpdHkoZXh0ZW50LCBMaW5lQm91bmRhcnksIHNhbWVEaXJlY3Rpb24pCi0gICAg ICAgICAgICYmICFhdEJvdW5kYXJ5T2ZHcmFudWxhcml0eShleHRlbnQsIExpbmVCb3VuZGFyeSwg b3Bwb3NpdGVEaXJlY3Rpb24pKSB7CisgICAgICAgICYmICFhdEJvdW5kYXJ5T2ZHcmFudWxhcml0 eShleHRlbnQsIFdvcmRHcmFudWxhcml0eSwgc2FtZURpcmVjdGlvbikKKyAgICAgICAgJiYgZXh0 ZW50ICE9IGJhc2UKKyAgICAgICAgJiYgIWF0Qm91bmRhcnlPZkdyYW51bGFyaXR5KGV4dGVudCwg TGluZUdyYW51bGFyaXR5LCBzYW1lRGlyZWN0aW9uKQorICAgICAgICAmJiAhYXRCb3VuZGFyeU9m R3JhbnVsYXJpdHkoZXh0ZW50LCBMaW5lR3JhbnVsYXJpdHksIG9wcG9zaXRlRGlyZWN0aW9uKSkg ewogICAgICAgICBleHRlbnQgPSBiYXNlSXNTdGFydCA/IGV4dGVudC5uZXh0KCkgOiBleHRlbnQu cHJldmlvdXMoKTsKICAgICB9CiAK