175994 2017-08-25 13:37:45 -0700 Define *_GIGACAGE_MASK when Gigacage is not supported 2017-08-25 16:12:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead benjamin buildbot cdumez cmarcelo commit-queue dbates fpizlo mark.lam webkit-bug-importer oldest_to_newest 1342498 0 don.olmstead 2017-08-25 13:37:45 -0700 After https://trac.webkit.org/changeset/221148/webkit the WinCairo bots report the following errors error C2065: 'JSVALUE_GIGACAGE_MASK': undeclared identifier error C2065: 'PRIMITIVE_GIGACAGE_MASK': undeclared identifier 1342499 1 319095 don.olmstead 2017-08-25 13:41:28 -0700 Created attachment 319095 Patch Fix suggested by mlam on IRC. Built WinCairo successfully. 1342500 2 319095 fpizlo 2017-08-25 13:42:25 -0700 Comment on attachment 319095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319095&action=review > Source/WTF/wtf/Gigacage.h:33 > +#define PRIMITIVE_GIGACAGE_MASK UINTPTR_MAX > +#define JSVALUE_GIGACAGE_MASK UINTPTR_MAX Why? 1342503 3 319095 mark.lam 2017-08-25 13:44:29 -0700 Comment on attachment 319095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319095&action=review >> Source/WTF/wtf/Gigacage.h:33 >> +#define JSVALUE_GIGACAGE_MASK UINTPTR_MAX > > Why? The wincairo build which does not use bmalloc is failing to build. Is this the wrong fix for when bmalloc is not used? 1342504 4 fpizlo 2017-08-25 13:45:05 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 319095 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319095&action=review > > >> Source/WTF/wtf/Gigacage.h:33 > >> +#define JSVALUE_GIGACAGE_MASK UINTPTR_MAX > > > > Why? > > The wincairo build which does not use bmalloc is failing to build. Is this > the wrong fix for when bmalloc is not used? I see. OK. 1342505 5 319095 fpizlo 2017-08-25 13:45:18 -0700 Comment on attachment 319095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319095&action=review >>>> Source/WTF/wtf/Gigacage.h:33 >>>> +#define JSVALUE_GIGACAGE_MASK UINTPTR_MAX >>> >>> Why? >> >> The wincairo build which does not use bmalloc is failing to build. Is this the wrong fix for when bmalloc is not used? > > I see. OK. Please set these to 0, not UINTPTR_MAX. 1342506 6 319095 mark.lam 2017-08-25 13:49:00 -0700 Comment on attachment 319095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319095&action=review >>>>> Source/WTF/wtf/Gigacage.h:33 >>>>> +#define JSVALUE_GIGACAGE_MASK UINTPTR_MAX >>>> >>>> Why? >>> >>> The wincairo build which does not use bmalloc is failing to build. Is this the wrong fix for when bmalloc is not used? >> >> I see. OK. > > Please set these to 0, not UINTPTR_MAX. At first, I thought that the llint code is unconditionally applying the masm. But I see that the llint code only applies the mask if GIGACAGE_ENABLED. Hence, setting these to 0 makes sense. 1342507 7 319096 don.olmstead 2017-08-25 13:50:24 -0700 Created attachment 319096 Patch Setting masks to 0 1342510 8 319096 mark.lam 2017-08-25 13:56:36 -0700 Comment on attachment 319096 Patch r=me if EWS is green and if this patch makes the code build on wincairo (which was where this issue was detected) and tests passes there as well. 1342558 9 319096 commit-queue 2017-08-25 16:11:28 -0700 Comment on attachment 319096 Patch Clearing flags on attachment: 319096 Committed r221211: <http://trac.webkit.org/changeset/221211> 1342559 10 commit-queue 2017-08-25 16:11:30 -0700 All reviewed patches have been landed. Closing bug. 1342560 11 webkit-bug-importer 2017-08-25 16:12:36 -0700 <rdar://problem/34091627> 319095 2017-08-25 13:41:28 -0700 2017-08-25 13:50:24 -0700 Patch bug-175994.diff text/plain 949 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNDRkYmE0N2EyMzQuLmM3MmMyYjM3OTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3 LTA4LTI1ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg RGVmaW5lICpfR0lHQUNBR0VfTUFTSyB3aGVuIEdpZ2FjYWdlIGlzIG5vdCBzdXBwb3J0ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTk5NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0dpZ2Fj YWdlLmg6CisKIDIwMTctMDgtMjQgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjExMTksIHIyMjExMjQs IGFuZCByMjIxMTQzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvR2lnYWNhZ2UuaCBiL1Nv dXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmgKaW5kZXggNzYyMWJmMGU5OWIuLjQ4OWVmYjFlYWY2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0dpZ2FjYWdlLmgKQEAgLTI5LDYgKzI5LDggQEAKIAogI2lmIGRlZmluZWQoVVNFX1NZU1RFTV9N QUxMT0MpICYmIFVTRV9TWVNURU1fTUFMTE9DCiAjZGVmaW5lIEdJR0FDQUdFX0VOQUJMRUQgMAor I2RlZmluZSBQUklNSVRJVkVfR0lHQUNBR0VfTUFTSyBVSU5UUFRSX01BWAorI2RlZmluZSBKU1ZB TFVFX0dJR0FDQUdFX01BU0sgVUlOVFBUUl9NQVgKIAogZXh0ZXJuICJDIiB7CiBleHRlcm4gV1RG X0VYUE9SVERBVEEgdm9pZCogZ19naWdhY2FnZUJhc2VQdHI7Cg== 319096 2017-08-25 13:50:24 -0700 2017-08-25 16:11:28 -0700 Patch bug-175994.diff text/plain 929 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNDRkYmE0N2EyMzQuLmM3MmMyYjM3OTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3 LTA4LTI1ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg RGVmaW5lICpfR0lHQUNBR0VfTUFTSyB3aGVuIEdpZ2FjYWdlIGlzIG5vdCBzdXBwb3J0ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTk5NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0dpZ2Fj YWdlLmg6CisKIDIwMTctMDgtMjQgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjExMTksIHIyMjExMjQs IGFuZCByMjIxMTQzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvR2lnYWNhZ2UuaCBiL1Nv dXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmgKaW5kZXggNzYyMWJmMGU5OWIuLjQ4OWVmYjFlYWY2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0dpZ2FjYWdlLmgKQEAgLTI5LDYgKzI5LDggQEAKIAogI2lmIGRlZmluZWQoVVNFX1NZU1RFTV9N QUxMT0MpICYmIFVTRV9TWVNURU1fTUFMTE9DCiAjZGVmaW5lIEdJR0FDQUdFX0VOQUJMRUQgMAor I2RlZmluZSBQUklNSVRJVkVfR0lHQUNBR0VfTUFTSyAwCisjZGVmaW5lIEpTVkFMVUVfR0lHQUNB R0VfTUFTSyAwCiAKIGV4dGVybiAiQyIgewogZXh0ZXJuIFdURl9FWFBPUlREQVRBIHZvaWQqIGdf Z2lnYWNhZ2VCYXNlUHRyOwo=