175960 2017-08-24 15:57:34 -0700 Fix build breakage with Public iOS 11 SDK 2017-08-25 11:55:12 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard commit-queue lforschler webkit-bug-importer wenson_hsieh oldest_to_newest 1342211 0 jbedard 2017-08-24 15:57:34 -0700 Currently, there are some build issues when building tip of tree WebKit with the public iOS 11 SDK. 1342212 1 webkit-bug-importer 2017-08-24 15:58:02 -0700 <rdar://problem/34069264> 1342217 2 319032 jbedard 2017-08-24 16:05:49 -0700 Created attachment 319032 Patch 1342219 3 319032 wenson_hsieh 2017-08-24 16:09:32 -0700 Comment on attachment 319032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319032&action=review > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93 > +@interface UIItemProvider : NSItemProvider <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest SDK, and that defines preferredPresentationSize on NSItemProvider (which UIItemProvider subclasses). Can we just import that header instead? 1342224 4 jbedard 2017-08-24 16:15:34 -0700 (In reply to Wenson Hsieh from comment #3) > Comment on attachment 319032 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319032&action=review > > > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93 > > +@interface UIItemProvider : NSItemProvider > > <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest > SDK, and that defines preferredPresentationSize on NSItemProvider (which > UIItemProvider subclasses). Can we just import that header instead? Then we need to change that in UIKitSPI.h as well. 1342245 5 wenson_hsieh 2017-08-24 16:44:58 -0700 (In reply to Jonathan Bedard from comment #4) > (In reply to Wenson Hsieh from comment #3) > > Comment on attachment 319032 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=319032&action=review > > > > > Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:93 > > > +@interface UIItemProvider : NSItemProvider > > > > <UIKit/NSItemProvider+UIKitAdditions.h> appears to be public in the latest > > SDK, and that defines preferredPresentationSize on NSItemProvider (which > > UIItemProvider subclasses). Can we just import that header instead? > > Then we need to change that in UIKitSPI.h as well. Yep, that would be ideal! 1342247 6 319035 jbedard 2017-08-24 16:47:32 -0700 Created attachment 319035 Patch 1342389 7 319035 commit-queue 2017-08-25 08:27:25 -0700 Comment on attachment 319035 Patch Clearing flags on attachment: 319035 Committed r221187: <http://trac.webkit.org/changeset/221187> 1342390 8 commit-queue 2017-08-25 08:27:26 -0700 All reviewed patches have been landed. Closing bug. 1342464 9 jbedard 2017-08-25 11:55:12 -0700 Follow-up fix in <http://trac.webkit.org/changeset/221197> 319032 2017-08-24 16:05:49 -0700 2017-08-24 16:47:31 -0700 Patch bug-175960-20170824160548.patch text/plain 2484 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjExNjApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA4LTI0ICBKb25hdGhhbiBC ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgYnJlYWthZ2Ug d2l0aCBQdWJsaWMgaU9TIDExIFNESworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc1OTYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDA2OTI2ND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRm b3JtL3NwaS9pb3MvVUlLaXRTUEkuaDogQWRkIFVJVVJMRHJhZ1ByZXZpZXdWaWV3IGRlY2xhcmF0 aW9uLgorCiAyMDE3LTA4LTI0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIExheW91dCBzaXplIG92ZXJyaWRlIGNoYW5nZXMgZHVyaW5nIGluLWZsaWdo dCBhbmltYXRlZCByZXNpemUgYXJlIGRyb3BwZWQgb24gdGhlIGZsb29yIGZvcmV2ZXIKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCShyZXZpc2lvbiAyMjEx NjApCisrKyBTb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAkod29ya2lu ZyBjb3B5KQpAQCAtOTE4LDYgKzkxOCwxMCBAQCB0eXBlZGVmIE5TX09QVElPTlMoTlNVSW50ZWdl ciwgVUlEcmFnT3BlCiArIChVSVRleHRFZmZlY3RzV2luZG93ICopc2hhcmVkVGV4dEVmZmVjdHNX aW5kb3c7CiBAZW5kCiAKK0BpbnRlcmZhY2UgVUlVUkxEcmFnUHJldmlld1ZpZXcgOiBVSVZpZXcK KysgKGluc3RhbmNldHlwZSl2aWV3V2l0aFRpdGxlOihOU1N0cmluZyAqKXRpdGxlIFVSTDooTlNV UkwgKil1cmw7CitAZW5kCisKICNlbmRpZgogCiAjZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFM X1NESykKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VM b2cJKHJldmlzaW9uIDIyMTE2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE3LTA4LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFw cGxlLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgYnJlYWthZ2Ugd2l0aCBQdWJsaWMgaU9TIDEx IFNESworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1 OTYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDA2OTI2ND4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvaW9zL0RhdGFJ bnRlcmFjdGlvblNpbXVsYXRvci5oOiBBZGQgVUlJdGVtUHJvdmlkZXIgZGVjbGFyYXRpb24uCisK IDIwMTctMDgtMjQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBBZGQgV0tVSURlbGVnYXRlUHJpdmF0ZSBjYWxsYmFjayBjb3JyZXNwb25kaW5n IHRvIFBhZ2VVSUNsaWVudCdzIGRpZE5vdEhhbmRsZVdoZWVsRXZlbnQKSW5kZXg6IFRvb2xzL1Rl c3RXZWJLaXRBUEkvaW9zL0RhdGFJbnRlcmFjdGlvblNpbXVsYXRvci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL0RhdGFJbnRlcmFjdGlvblNpbXVsYXRvci5oCShyZXZp c2lvbiAyMjExNjApCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL2lvcy9EYXRhSW50ZXJhY3Rpb25T aW11bGF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtOTAsNiArOTAsMTAgQEAgdHlwZWRlZiBOU19F TlVNKE5TSW50ZWdlciwgRGF0YUludGVyYWN0aQogICAgIERhdGFJbnRlcmFjdGlvblBlcmZvcm1p bmcgPSA0CiB9OwogCitAaW50ZXJmYWNlIFVJSXRlbVByb3ZpZGVyIDogTlNJdGVtUHJvdmlkZXIK K0Bwcm9wZXJ0eSAobm9uYXRvbWljKSBDR1NpemUgcHJlZmVycmVkUHJlc2VudGF0aW9uU2l6ZTsK K0BlbmQKKwogQGludGVyZmFjZSBEYXRhSW50ZXJhY3Rpb25TaW11bGF0b3IgOiBOU09iamVjdDxX S1VJRGVsZWdhdGVQcml2YXRlLCBfV0tJbnB1dERlbGVnYXRlPiB7CiBAcHJpdmF0ZQogICAgIFJl dGFpblB0cjxUZXN0V0tXZWJWaWV3PiBfd2ViVmlldzsK 319035 2017-08-24 16:47:32 -0700 2017-08-25 08:27:25 -0700 Patch bug-175960-20170824164731.patch text/plain 4440 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjIxMTYwKQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4 LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBGaXgg YnVpbGQgYnJlYWthZ2Ugd2l0aCBQdWJsaWMgaU9TIDExIFNESworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1OTYwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zNDA2OTI2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisKKyAg ICAgICAgKiBwYWwvc3BpL2lvcy9VSUtpdFNQSS5oOiBVc2UgTlNJdGVtUHJvdmlkZXIgZGVmaW5p dGlvbiBvZiBwcmVmZXJyZWRQcmVzZW50YXRpb25TaXplCisgICAgICAgIGluc3RlYWQgb2YgcmUt ZGVjbGFyaW5nIGl0LgorCiAyMDE3LTA4LTIzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25A YXBwbGUuY29tPgogCiAgICAgICAgIFBsYXRmb3JtIGNvZGUgc2hvdWxkIGJlIGFibGUgdG8gc2Fm ZWx5IGxvZyBpbiByZWxlYXNlIGJ1aWxkcwpJbmRleDogU291cmNlL1dlYkNvcmUvUEFML3BhbC9z cGkvaW9zL1VJS2l0U1BJLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvUEFML3BhbC9z cGkvaW9zL1VJS2l0U1BJLmgJKHJldmlzaW9uIDIyMTE2MCkKKysrIFNvdXJjZS9XZWJDb3JlL1BB TC9wYWwvc3BpL2lvcy9VSUtpdFNQSS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw2ICs0NywxMCBA QAogCiAjaW1wb3J0IDxVSUtpdC9VSUtpdC5oPgogCisjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkK KyNpbXBvcnQgPFVJS2l0L05TSXRlbVByb3ZpZGVyK1VJS2l0QWRkaXRpb25zLmg+CisjZW5kaWYK KwogTlNfQVNTVU1FX05PTk5VTExfQkVHSU4KIAogdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwg VUlBcHBsaWNhdGlvblNjZW5lQ2xhc3NpY01vZGUpIHsKQEAgLTk1LDcgKzk5LDYgQEAgTlNfQVNT VU1FX05PTk5VTExfRU5ECiBOU19BU1NVTUVfTk9OTlVMTF9CRUdJTgogCiBAaW50ZXJmYWNlIFVJ SXRlbVByb3ZpZGVyIDogTlNJdGVtUHJvdmlkZXIKLUBwcm9wZXJ0eSAobm9uYXRvbWljKSBDR1Np emUgcHJlZmVycmVkUHJlc2VudGF0aW9uU2l6ZTsKIEBlbmQKIAogI2RlZmluZSBVSUl0ZW1Qcm92 aWRlclJlcHJlc2VudGF0aW9uT3B0aW9uc1Zpc2liaWxpdHlBbGwgTlNJdGVtUHJvdmlkZXJSZXBy ZXNlbnRhdGlvblZpc2liaWxpdHlBbGwKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjExNjApCisr KyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE3LTA4LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAg ICAgICBGaXggYnVpbGQgYnJlYWthZ2Ugd2l0aCBQdWJsaWMgaU9TIDExIFNESworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1OTYwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDA2OTI2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNp ZWguCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6IEFkZCBVSVVSTERy YWdQcmV2aWV3VmlldyBkZWNsYXJhdGlvbi4KKwogMjAxNy0wOC0yNCAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBMYXlvdXQgc2l6ZSBvdmVycmlkZSBj aGFuZ2VzIGR1cmluZyBpbi1mbGlnaHQgYW5pbWF0ZWQgcmVzaXplIGFyZSBkcm9wcGVkIG9uIHRo ZSBmbG9vciBmb3JldmVyCkluZGV4OiBTb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaAkocmV2aXNpb24gMjIxMTYwKQorKysgU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkv aW9zL1VJS2l0U1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMiw2ICsxMDIsMTAgQEAKIAogI2Vs c2UKIAorI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCisjaW1wb3J0IDxVSUtpdC9OU0l0ZW1Qcm92 aWRlcitVSUtpdEFkZGl0aW9ucy5oPgorI2VuZGlmCisKICNpZiBIQVZFKExJTktfUFJFVklFVykK IHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIFVJUHJldmlld0l0ZW1UeXBlKSB7CiAgICAgVUlQ cmV2aWV3SXRlbVR5cGVOb25lLApAQCAtODc4LDcgKzg4Miw2IEBAIHR5cGVkZWYgZW51bSB7CiAj aWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKIAogQGludGVyZmFjZSBVSUl0ZW1Qcm92aWRlciA6IE5T SXRlbVByb3ZpZGVyCi1AcHJvcGVydHkgKG5vbmF0b21pYykgQ0dTaXplIHByZWZlcnJlZFByZXNl bnRhdGlvblNpemU7CiBAZW5kCiAKIFdURl9FWFRFUk5fQ19CRUdJTgpAQCAtOTE4LDYgKzkyMSwx MCBAQCB0eXBlZGVmIE5TX09QVElPTlMoTlNVSW50ZWdlciwgVUlEcmFnT3BlCiArIChVSVRleHRF ZmZlY3RzV2luZG93ICopc2hhcmVkVGV4dEVmZmVjdHNXaW5kb3c7CiBAZW5kCiAKK0BpbnRlcmZh Y2UgVUlVUkxEcmFnUHJldmlld1ZpZXcgOiBVSVZpZXcKKysgKGluc3RhbmNldHlwZSl2aWV3V2l0 aFRpdGxlOihOU1N0cmluZyAqKXRpdGxlIFVSTDooTlNVUkwgKil1cmw7CitAZW5kCisKICNlbmRp ZgogCiAjZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFMX1NESykKSW5kZXg6IFRvb2xzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMTE2OCkKKysr IFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA4 LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBGaXgg YnVpbGQgYnJlYWthZ2Ugd2l0aCBQdWJsaWMgaU9TIDExIFNESworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1OTYwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zNDA2OTI2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL2lvcy9EYXRhSW50ZXJhY3Rpb25TaW11bGF0b3IuaDogQWRk IFVJSXRlbVByb3ZpZGVyIGRlY2xhcmF0aW9uLgorCiAyMDE3LTA4LTI0ICBKb25hdGhhbiBCZWRh cmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgY29uZmlndXJlLXhjb2Rl LWZvci1pb3MtZGV2ZWxvcG1lbnQgZm9yIGlPUyAxMQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQ SS9pb3MvRGF0YUludGVyYWN0aW9uU2ltdWxhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVz dFdlYktpdEFQSS9pb3MvRGF0YUludGVyYWN0aW9uU2ltdWxhdG9yLmgJKHJldmlzaW9uIDIyMTE2 MCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL0RhdGFJbnRlcmFjdGlvblNpbXVsYXRvci5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBACiAjaWYgRU5BQkxFKERBVEFfSU5URVJB Q1RJT04pCiAKICNpbXBvcnQgIlRlc3RXS1dlYlZpZXcuaCIKKyNpbXBvcnQgPFVJS2l0L05TSXRl bVByb3ZpZGVyK1VJS2l0QWRkaXRpb25zLmg+CiAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RL KQogI2ltcG9ydCA8VUlLaXQvTlNTdHJpbmcrVUlJdGVtUHJvdmlkZXIuaD4KQEAgLTkwLDYgKzkx LDkgQEAgdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgRGF0YUludGVyYWN0aQogICAgIERhdGFJ bnRlcmFjdGlvblBlcmZvcm1pbmcgPSA0CiB9OwogCitAaW50ZXJmYWNlIFVJSXRlbVByb3ZpZGVy IDogTlNJdGVtUHJvdmlkZXIKK0BlbmQKKwogQGludGVyZmFjZSBEYXRhSW50ZXJhY3Rpb25TaW11 bGF0b3IgOiBOU09iamVjdDxXS1VJRGVsZWdhdGVQcml2YXRlLCBfV0tJbnB1dERlbGVnYXRlPiB7 CiBAcHJpdmF0ZQogICAgIFJldGFpblB0cjxUZXN0V0tXZWJWaWV3PiBfd2ViVmlldzsK