175922 2017-08-23 20:11:35 -0700 [iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly 2017-08-24 08:59:29 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 cdumez cdumez achristensen aestes beidson commit-queue ggaren sam thorton webkit-bug-importer yongjun_zhang oldest_to_newest 1341947 0 cdumez 2017-08-23 20:11:35 -0700 ViewServices started by StoreKitUIService may get suspended unexpectedly. 1341948 1 cdumez 2017-08-23 20:11:57 -0700 <rdar://problem/34028921> 1341949 2 318962 cdumez 2017-08-23 20:16:12 -0700 Created attachment 318962 Patch 1341978 3 318962 thorton 2017-08-24 00:14:43 -0700 Comment on attachment 318962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318962&action=review > Source/WebKit/UIProcess/ApplicationStateTracker.mm:153 > + m_isInBackground = false; Can’t they just use the WKWebViewConfiguration SPI to be treated like they’re always in the foreground, like every other instance of this? 1341980 4 318962 thorton 2017-08-24 00:18:22 -0700 Comment on attachment 318962 Patch If not, please kick back for review, but it seems wrong to special case this when we already have a mechanism to handle it. If this were a generic mechanism to handle doubly-service-hosted web views, that would be a different story. 1341982 5 thorton 2017-08-24 00:20:54 -0700 Specifically, I am referring to _setAlwaysRunsAtForegroundPriority: 1342016 6 yongjun_zhang 2017-08-24 06:29:59 -0700 (In reply to Tim Horton from comment #5) > Specifically, I am referring to _setAlwaysRunsAtForegroundPriority: The host app doesn’t have access to WKWebview since it is using Safari view controller. 1342051 7 318962 commit-queue 2017-08-24 08:59:27 -0700 Comment on attachment 318962 Patch Clearing flags on attachment: 318962 Committed r221138: <http://trac.webkit.org/changeset/221138> 1342052 8 commit-queue 2017-08-24 08:59:29 -0700 All reviewed patches have been landed. Closing bug. 318962 2017-08-23 20:16:12 -0700 2017-08-24 08:59:27 -0700 Patch bug-175922-20170823201610.patch text/plain 3219 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIzMzhjNTgxYTI1YTY3N2Mx YWI3ZTNlY2VhZjYwMGNmNjg4YmFiMzEuLjc0YTg0ZmRlYjNmMjAxZmM0ZGE1OGVjZjJhNmUyNTc0 Y2Y2ZjQ2OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTctMDgtMjMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBWaWV3U2VydmljZXMgc3Rh cnRlZCBieSBTdG9yZUtpdFVJU2VydmljZSBtYXkgZ2V0IHN1c3BlbmRlZCB1bmV4cGVjdGVkbHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTkyMgor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQwMjg5MjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVmlld1NlcnZpY2VzIHN0YXJ0ZWQgYnkgU3RvcmVL aXRVSVNlcnZpY2UgbWF5IGdldCBzdXNwZW5kZWQgdW5leHBlY3RlZGx5LiBUaGlzIGlzCisgICAg ICAgIGJlY2F1c2UgU3RvcmVLaXRVSVNlcnZpY2UgaXMgaXRzZWxmIGEgVmlld1NlcnZpY2UgYW5k IGlzIHRoZXJlZm9yZSBpbiB0aGUgYmFja2dyb3VuZC4KKyAgICAgICAgVG8gYWRkcmVzcyB0aGUg aXNzdWUsIHRyZWF0IFN0b3JlS2l0VUlTZXJ2aWNlIGFzIGluaXRpYWxseSBmb3JlZ3JvdW5kIGlu CisgICAgICAgIEFwcGxpY2F0aW9uU3RhdGVUcmFja2VyIHNvIHRoYXQgaXRzIFZpZXdTZXJ2aWNl cyBkbyBub3QgZ2V0IHN1c3BlbmRlZC4gV2UgZG9uJ3QKKyAgICAgICAgaGF2ZSBnb29kIHdheSB0 byBkZWFsIHdpdGggVmlld1NlcnZpY2VzIHN0YXJ0ZWQgYnkgb3RoZXIgVmlld1NlcnZpY2VzIHVu Zm9ydHVuYXRlbHkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6Cisg ICAgICAgICogVUlQcm9jZXNzL0FwcGxpY2F0aW9uU3RhdGVUcmFja2VyLm1tOgorICAgICAgICAo V2ViS2l0OjpBcHBsaWNhdGlvblN0YXRlVHJhY2tlcjo6QXBwbGljYXRpb25TdGF0ZVRyYWNrZXIp OgorCiAyMDE3LTA4LTIwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgog CiAgICAgICAgIFtpT1MgV0syXSBXS1dlYlZpZXcgc2NoZWR1bGVzIG5vbnN0b3AgbGF5b3V0IGFm dGVyIHByZXNzaW5nIGNtYitiLGksdSBpbnNpZGUgYSBjb250ZW50ZWRpdGFibGUgZGl2CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDkyMTIxN2JjNjFkMzRj NjRmY2Y4YzI2NjQwOGNiOTZjOThmN2ZhNTAuLjI0ZGZjZTIzMTJiNjFiMTBlZDhmZmVmMjI4ODhj OTc1MTQxMzI2ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9V SUtpdFNQSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5o CkBAIC0zOTcsNiArMzk3LDcgQEAgdHlwZWRlZiBlbnVtIHsKIAogQGludGVyZmFjZSBVSVZpZXdD b250cm9sbGVyIChWaWV3U2VydmljZSkKIC0gKHBpZF90KV9ob3N0UHJvY2Vzc0lkZW50aWZpZXI7 CitAcHJvcGVydHkgKHJlYWRvbmx5KSBOU1N0cmluZyAqX2hvc3RBcHBsaWNhdGlvbkJ1bmRsZUlk ZW50aWZpZXI7CiBAZW5kCiAKIEBwcm90b2NvbCBVSVZpZXdDb250cm9sbGVyQ29udGV4dFRyYW5z aXRpb25pbmdFeCA8VUlWaWV3Q29udHJvbGxlckNvbnRleHRUcmFuc2l0aW9uaW5nPgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXBwbGljYXRpb25TdGF0ZVRyYWNrZXIubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BcHBsaWNhdGlvblN0YXRlVHJhY2tlci5tbQppbmRl eCAyODY2OTdkNzViNTk2ODFmNmM5ZGExMjQ2MWY4YjUxYmE2NDczYmY5Li42YjI5MzlhZDNjMGUw NmI1ZGQ1MjFjZTdhODg2MmQyYmRiN2U4NTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BcHBsaWNhdGlvblN0YXRlVHJhY2tlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BcHBsaWNhdGlvblN0YXRlVHJhY2tlci5tbQpAQCAtMTQ2LDYgKzE0NiwxMiBAQCBB cHBsaWNhdGlvblN0YXRlVHJhY2tlcjo6QXBwbGljYXRpb25TdGF0ZVRyYWNrZXIoVUlWaWV3ICp2 aWV3LCBTRUwgZGlkRW50ZXJCYWNrZwogICAgICAgICBtX2lzSW5CYWNrZ3JvdW5kID0gaXNCYWNr Z3JvdW5kU3RhdGUoW2FwcGxpY2F0aW9uU3RhdGVNb25pdG9yIG1vc3RFbGV2YXRlZEFwcGxpY2F0 aW9uU3RhdGVGb3JQSUQ6YXBwbGljYXRpb25QSURdKTsKICAgICAgICAgW2FwcGxpY2F0aW9uU3Rh dGVNb25pdG9yIGludmFsaWRhdGVdOwogCisgICAgICAgIC8vIFdvcmthcm91bmQgZm9yIDxyZGFy Oi8vcHJvYmxlbS8zNDAyODkyMT4uIElmIHRoZSBob3N0IGFwcGxpY2F0aW9uIGlzIFN0b3JlS2l0 VUlTZXJ2aWNlIHRoZW4gaXQgaXMgYWxzbyBhIFZpZXdTZXJ2aWNlCisgICAgICAgIC8vIGFuZCBp cyBhbHdheXMgaW4gdGhlIGJhY2tncm91bmQuIFdlIG5lZWQgdG8gdHJlYXQgU3RvcmVLaXRVSVNl cnZpY2UgYXMgZm9yZWdyb3VuZCBmb3IgdGhlIHB1cnBvc2Ugb2YgcHJvY2VzcyBzdXNwZW5zaW9u CisgICAgICAgIC8vIG9yIGl0cyBWaWV3U2VydmljZXMgd2lsbCBnZXQgc3VzcGVuZGVkLgorICAg ICAgICBpZiAoW3NlcnZpY2VWaWV3Q29udHJvbGxlci5faG9zdEFwcGxpY2F0aW9uQnVuZGxlSWRl bnRpZmllciBpc0VxdWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuaW9zLlN0b3JlS2l0VUlTZXJ2aWNl Il0pCisgICAgICAgICAgICBtX2lzSW5CYWNrZ3JvdW5kID0gZmFsc2U7CisKICAgICAgICAgbV9k aWRFbnRlckJhY2tncm91bmRPYnNlcnZlciA9IFtub3RpZmljYXRpb25DZW50ZXIgYWRkT2JzZXJ2 ZXJGb3JOYW1lOkAiX1VJVmlld1NlcnZpY2VIb3N0RGlkRW50ZXJCYWNrZ3JvdW5kTm90aWZpY2F0 aW9uIiBvYmplY3Q6c2VydmljZVZpZXdDb250cm9sbGVyIHF1ZXVlOm5pbCB1c2luZ0Jsb2NrOlt0 aGlzXShOU05vdGlmaWNhdGlvbiAqKSB7CiAgICAgICAgICAgICBhcHBsaWNhdGlvbkRpZEVudGVy QmFja2dyb3VuZCgpOwogICAgICAgICB9XTsK