175899 2017-08-23 12:35:08 -0700 ASSERTION FAILED: !m_valueOrException under FontFaceSet::completedLoading loading a Serious Eats page 2017-09-27 12:47:47 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton mmaxfield commit-queue mmaxfield webkit-bug-importer oldest_to_newest 1341711 0 thorton 2017-08-23 12:35:08 -0700 Steps to Reproduce: 1. Load http://www.seriouseats.com/recipes/2017/08/roasted-carrots-black-sesame-dressing-recipe.html in a ToT debug build. Expected: Carrots. Actual: Crash. For me, every time. I have r221082. ASSERTION FAILED: !m_valueOrException /Users/thorton/src/WebKit/OpenSource/Source/WebCore/bindings/js/DOMPromiseProxy.h(291) : void WebCore::DOMPromiseProxyWithResolveCallback<WebCore::IDLInterface<WebCore::FontFaceSet> >::resolve(typename IDLType::ParameterType) [IDLType = WebCore::IDLInterface<WebCore::FontFaceSet>] 1 0x195c0a9ad WTFCrash 2 0x188aab579 WebCore::DOMPromiseProxyWithResolveCallback<WebCore::IDLInterface<WebCore::FontFaceSet> >::resolve(WebCore::FontFaceSet&) 3 0x188aac779 WebCore::FontFaceSet::completedLoading() 4 0x18856f1b0 WebCore::CSSFontFaceSet::decrementActiveCount() 5 0x188574363 WebCore::CSSFontFaceSet::fontStateChanged(WebCore::CSSFontFace&, WebCore::CSSFontFace::Status, WebCore::CSSFontFace::Status) 6 0x18856d5c7 WebCore::CSSFontFace::setStatus(WebCore::CSSFontFace::Status)::$_14::operator()(WebCore::CSSFontFace::Client&) const 1348045 1 mmaxfield 2017-09-12 14:50:15 -0700 *** This bug has been marked as a duplicate of bug 176525 *** 1348077 2 mmaxfield 2017-09-12 16:11:59 -0700 Turns out this isn't a duplicate. 1348092 3 mmaxfield 2017-09-12 16:32:19 -0700 Upon closer investigation, 176525 fixed it but I'd still like to add a test and update the patch with a slight style change. 1348093 4 320581 mmaxfield 2017-09-12 16:37:12 -0700 Created attachment 320581 Patch 1348113 5 320581 commit-queue 2017-09-12 17:13:05 -0700 Comment on attachment 320581 Patch Clearing flags on attachment: 320581 Committed r221948: <http://trac.webkit.org/changeset/221948> 1348114 6 commit-queue 2017-09-12 17:13:06 -0700 All reviewed patches have been landed. Closing bug. 1353654 7 webkit-bug-importer 2017-09-27 12:47:47 -0700 <rdar://problem/34694033> 320581 2017-09-12 16:37:12 -0700 2017-09-12 17:13:05 -0700 Patch bug-175899-20170912163711.patch text/plain 5179 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc5YzgxODY3YzgzODgy OTA3NzhhNDc1MmE3Y2U2ZDVlNGVjOTY5NC4uMDJjZGQxYjkxYTY1NmU0NzI4MjQwYjViNmJkMGYw MTNiYzM0MTg5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA5LTEyICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9O IEZBSUxFRDogIW1fdmFsdWVPckV4Y2VwdGlvbiB1bmRlciBGb250RmFjZVNldDo6Y29tcGxldGVk TG9hZGluZyBsb2FkaW5nIGEgU2VyaW91cyBFYXRzIHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTg5OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNsaWdodCBzdHlsZSB1cGRhdGUgdG8gcjIyMTgz NS4gQWxzbyBhZGRzIGEgdGVzdC4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvZG9jdW1lbnQt Zm9udHMtd2hpbGUtbG9hZGluZy1jcmFzaC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTRm9udEZh Y2VTZXQuaDoKKyAgICAgICAgKiBjc3MvRm9udEZhY2VTZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Rm9udEZhY2VTZXQ6OkZvbnRGYWNlU2V0KToKKwogMjAxNy0wOS0xMSAgUGVyIEFybmUgVm9s bGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gQWRkIE1vZHVsZXMvY2Fj aGUgdG8gbGlzdCBvZiBmb3J3YXJkaW5nIGhlYWRlcnMgZm9sZGVycy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVNldC5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U0ZvbnRGYWNlU2V0LmgKaW5kZXggYTZkNjA4ZTMyYjZmNzEwMWI4YmM4YTg0NGY0N2Q2YjA4ZmQ4 MDFmNC4uYjYzYmE2YmZlZTU0MmY5MzZjNTU2ZjZhMGRhN2Q5ZmJlOWY0NzEyYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlU2V0LmgKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU0ZvbnRGYWNlU2V0LmgKQEAgLTczLDYgKzczLDggQEAgcHVibGljOgogICAgIGVu dW0gY2xhc3MgU3RhdHVzIHsgTG9hZGluZywgTG9hZGVkIH07CiAgICAgU3RhdHVzIHN0YXR1cygp IGNvbnN0IHsgcmV0dXJuIG1fc3RhdHVzOyB9CiAKKyAgICBib29sIGhhc0FjdGl2ZUZvbnRGYWNl cygpIHsgcmV0dXJuIHN0YXR1cygpID09IFN0YXR1czo6TG9hZGluZzsgfQorCiAgICAgRXhjZXB0 aW9uT3I8VmVjdG9yPHN0ZDo6cmVmZXJlbmNlX3dyYXBwZXI8Q1NTRm9udEZhY2U+Pj4gbWF0Y2hp bmdGYWNlcyhjb25zdCBTdHJpbmcmIGZvbnQsIGNvbnN0IFN0cmluZyYgdGV4dCk7CiAKICAgICAv LyBDU1NGb250RmFjZTo6Q2xpZW50IG5lZWRzIHRvIGJlIGFibGUgdG8gYmUgaGVsZCBpbiBhIFJl ZlB0ci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZVNldC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvRm9udEZhY2VTZXQuY3BwCmluZGV4IDU4MmEwM2VkMzk2ZDc4YTdi Mjg1MGRkMGJkOTMwMDY1ZmYwYTIwNjcuLmUyMTllMmI3YWZiN2FjM2QyZjU4ZjcyNTA5OWEyZTA0 N2QzNzFhYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZVNldC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlU2V0LmNwcApAQCAtNjMsOSArNjMsOSBA QCBGb250RmFjZVNldDo6Rm9udEZhY2VTZXQoRG9jdW1lbnQmIGRvY3VtZW50LCBDU1NGb250RmFj ZVNldCYgYmFja2luZykKICAgICAsIG1fYmFja2luZyhiYWNraW5nKQogICAgICwgbV9yZWFkeVBy b21pc2UoKnRoaXMsICZGb250RmFjZVNldDo6cmVhZHlQcm9taXNlUmVzb2x2ZSkKIHsKLSAgICBt X2JhY2tpbmctPmFkZENsaWVudCgqdGhpcyk7Ci0gICAgaWYgKG1fYmFja2luZy0+c3RhdHVzKCkg PT0gQ1NTRm9udEZhY2VTZXQ6OlN0YXR1czo6TG9hZGVkKQorICAgIGlmICghYmFja2luZy5oYXNB Y3RpdmVGb250RmFjZXMoKSkKICAgICAgICAgbV9yZWFkeVByb21pc2UucmVzb2x2ZSgqdGhpcyk7 CisgICAgbV9iYWNraW5nLT5hZGRDbGllbnQoKnRoaXMpOwogfQogCiBGb250RmFjZVNldDo6fkZv bnRGYWNlU2V0KCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA0MjI5NGZkOTU4OGE3MzVmZjQ0Yjc2ZmY2OGRiMTc5MzUwOGM0 NmVjLi40NGFlYjNiZDgxNGVjZWJmNjk0MDg5NTg4YTYxMzNiMWFhNGU3YzJhIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTctMDktMTIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFw cGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAhbV92YWx1ZU9yRXhjZXB0aW9u IHVuZGVyIEZvbnRGYWNlU2V0Ojpjb21wbGV0ZWRMb2FkaW5nIGxvYWRpbmcgYSBTZXJpb3VzIEVh dHMgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc1ODk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L3RleHQvZG9jdW1lbnQtZm9udHMtd2hpbGUtbG9hZGluZy1jcmFzaC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9kb2N1bWVudC1mb250cy13aGlsZS1sb2Fk aW5nLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE3LTA5LTExICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYW51cCBhbmQg dGVzdCBNSU1FVHlwZVV0aWxpdGllcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L2RvY3VtZW50LWZvbnRzLXdoaWxlLWxvYWRpbmctY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC90ZXh0L2RvY3VtZW50LWZvbnRzLXdoaWxlLWxvYWRpbmctY3Jhc2gtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmUyMmJkOWM4NzIxM2I1OWQzODc5OThjNDk3ZWU0MjdhNGFkNmM0 YWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvZG9jdW1lbnQtZm9u dHMtd2hpbGUtbG9hZGluZy1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitUaGlz IHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIEFTU0VSVCBpbiBkZWJ1ZyBtb2RlLiBUaGlzIGhh cHBlbnMgd2hlbjoKK05vIG9uZSB1c2VzIHRoZSBDU1MgRm9udCBMb2FkaW5nIEFQSQorQSBmb250 IHN0YXJ0cyBsb2FkaW5nCitTb21lb25lIHVzZXMgdGhlIENTUyBGb250IExvYWRpbmcgQVBJLCBj YXVzaW5nIHVzIHRvIGNyZWF0ZSBKYXZhc2NyaXB0IHdyYXBwZXJzIGZvciBvdXIgaW50ZXJuYWwg b2JqZWN0cworVGhlIGZvbnQgZmluaXNoZXMgbG9hZGluZworVGhlIGJ1ZyBvY2N1cnMgd2hlbiB0 aGUgd3JhcHBlcnMgZG8gbm90IGNvcnJlY3RseSB1bmRlcnN0YW5kIHRoYXQgdGhlcmUgYXJlIGlu LWZsaWdodCBsb2FkcyBhbHJlYWR5IGhhcHBlbmluZy4KK0hlbGxvCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L3RleHQvZG9jdW1lbnQtZm9udHMtd2hpbGUtbG9hZGluZy1jcmFzaC5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2RvY3VtZW50LWZvbnRzLXdoaWxlLWxvYWRpbmctY3Jh c2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4xNjk1ZWVkMGQ0ZWM5MDAxNWY4MWQ0YjgwZTdlMjg0MWYzZjY4 NDJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2RvY3VtZW50LWZv bnRzLXdoaWxlLWxvYWRpbmctY3Jhc2guaHRtbApAQCAtMCwwICsxLDM5IEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5pbnRlcm5hbHMpIHsK KyAgICBpbnRlcm5hbHMuaW52YWxpZGF0ZUZvbnRDYWNoZSgpOworICAgIGludGVybmFscy5jbGVh ck1lbW9yeUNhY2hlKCk7Cit9CitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICB0ZXN0UnVu bmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKK30KKzwv c2NyaXB0PgorPHN0eWxlPgorQGZvbnQtZmFjZSB7CisgICAgZm9udC1mYW1pbHk6ICJXZWJGb250 IjsKKyAgICBzcmM6IHVybCgiLi4vLi4vcmVzb3VyY2VzL0FoZW0ub3RmIikgZm9ybWF0KCJvcGVu dHlwZSIpOworfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorVGhpcyB0ZXN0IHBhc3NlcyBp ZiB0aGVyZSBpcyBubyBBU1NFUlQgaW4gZGVidWcgbW9kZS4gVGhpcyBoYXBwZW5zIHdoZW46Cis8 b2w+Cis8bGk+Tm8gb25lIHVzZXMgdGhlIENTUyBGb250IExvYWRpbmcgQVBJPC9saT4KKzxsaT5B IGZvbnQgc3RhcnRzIGxvYWRpbmc8L2xpPgorPGxpPlNvbWVvbmUgdXNlcyB0aGUgQ1NTIEZvbnQg TG9hZGluZyBBUEksIGNhdXNpbmcgdXMgdG8gY3JlYXRlIEphdmFzY3JpcHQgd3JhcHBlcnMgZm9y IG91ciBpbnRlcm5hbCBvYmplY3RzPC9saT4KKzxsaT5UaGUgZm9udCBmaW5pc2hlcyBsb2FkaW5n PC9saT4KKzwvb2w+CitUaGUgYnVnIG9jY3VycyB3aGVuIHRoZSB3cmFwcGVycyBkbyBub3QgY29y cmVjdGx5IHVuZGVyc3RhbmQgdGhhdCB0aGVyZSBhcmUgaW4tZmxpZ2h0IGxvYWRzIGFscmVhZHkg aGFwcGVuaW5nLgorPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6ICdXZWJGb250JzsiPkhlbGxvPC9k aXY+Cis8c2NyaXB0PgorZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7IC8vIEZvcmNlIGxheW91dCwg d2hpY2ggc3RhcnRzIGZvbnRzIGxvYWRpbmcKK2RvY3VtZW50LmZvbnRzLnJlYWR5LnRoZW4oZnVu Y3Rpb24oKSB7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVy Lm5vdGlmeURvbmUoKTsKK30pOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==