175893 2017-08-23 11:14:07 -0700 DFG::JITCode::osrEntry should get sorted since we perform a binary search on it 2017-08-25 12:12:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 175973 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1341661 0 saam 2017-08-23 11:14:07 -0700 I think right now we're probably just lucky that it often ends up in a sorted manner because of sensible program order. But I don't see any way we ensure this, so we should explicitly sort it. 1341971 1 saam 2017-08-23 22:54:28 -0700 Hmm, it seems like zero jsc tests end up with an unsorted vector. Maybe I'm missing something. 1341973 2 saam 2017-08-23 23:23:19 -0700 Ok, there is definitely no reason we should be seeing them already sorted. We're just getting lucky. Ima add code that sorts them. 1341974 3 318970 saam 2017-08-23 23:39:23 -0700 Created attachment 318970 patch 1342060 4 318970 mark.lam 2017-08-24 09:28:47 -0700 Comment on attachment 318970 patch r=me 1342074 5 318970 commit-queue 2017-08-24 09:59:03 -0700 Comment on attachment 318970 patch Clearing flags on attachment: 318970 Committed r221143: <http://trac.webkit.org/changeset/221143> 1342075 6 commit-queue 2017-08-24 09:59:04 -0700 All reviewed patches have been landed. Closing bug. 1342076 7 webkit-bug-importer 2017-08-24 09:59:42 -0700 <rdar://problem/34060471> 1342291 8 commit-queue 2017-08-24 18:53:16 -0700 Re-opened since this is blocked by bug 175973 1342452 9 319089 saam 2017-08-25 11:29:20 -0700 Created attachment 319089 re-landing patch 1342475 10 319089 commit-queue 2017-08-25 12:12:41 -0700 Comment on attachment 319089 re-landing patch Clearing flags on attachment: 319089 Committed r221200: <http://trac.webkit.org/changeset/221200> 1342476 11 commit-queue 2017-08-25 12:12:43 -0700 All reviewed patches have been landed. Closing bug. 318970 2017-08-23 23:39:23 -0700 2017-08-25 11:29:20 -0700 patch c-backup.diff text/plain 3397 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxMTMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE3LTA4LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERGRzo6SklUQ29kZTo6b3NyRW50cnkgc2hvdWxkIGdldCBzb3J0ZWQgc2luY2Ugd2UgcGVyZm9y bSBhIGJpbmFyeSBzZWFyY2ggb24gaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NTg5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZGZnL0RGR0pJVENvZGUuY3BwOgorICAgICAgICAoSlNDOjpERkc6 OkpJVENvZGU6OmZpbmFsaXplT1NSRW50cnlwb2ludHMpOgorICAgICAgICAqIGRmZy9ERkdKSVRD b2RlLmg6CisgICAgICAgIChKU0M6OkRGRzo6SklUQ29kZTo6ZmluYWxpemVDYXRjaE9TUkVudHJ5 cG9pbnRzKTogRGVsZXRlZC4KKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgor ICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpsaW5rT1NSRW50cmllcyk6CisKIDIw MTctMDgtMjMgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAg ICAgRml4IFRpdHplciBiZW5jaCBvbiBpT1MuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0pJVENvZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHSklUQ29kZS5jcHAJKHJldmlzaW9uIDIyMTEzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHSklUQ29kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzOCw2ICsyMzgsMjQg QEAgc3RkOjpvcHRpb25hbDxDb2RlT3JpZ2luPiBKSVRDb2RlOjpmaW5kUAogICAgIHJldHVybiBz dGQ6Om51bGxvcHQ7CiB9CiAKK3ZvaWQgSklUQ29kZTo6ZmluYWxpemVPU1JFbnRyeXBvaW50cygp Cit7CisgICAgYXV0byBjb21wYXJhdG9yID0gW10gKGNvbnN0IGF1dG8mIGEsIGNvbnN0IGF1dG8m IGIpIHsKKyAgICAgICAgcmV0dXJuIGEubV9ieXRlY29kZUluZGV4IDwgYi5tX2J5dGVjb2RlSW5k ZXg7CisgICAgfTsKKyAgICBzdGQ6OnNvcnQoY2F0Y2hFbnRyeXBvaW50cy5iZWdpbigpLCBjYXRj aEVudHJ5cG9pbnRzLmVuZCgpLCBjb21wYXJhdG9yKTsKKyAgICBzdGQ6OnNvcnQob3NyRW50cnku YmVnaW4oKSwgb3NyRW50cnkuZW5kKCksIGNvbXBhcmF0b3IpOworCisjaWYgIUFTU0VSVF9ESVNB QkxFRAorICAgIGF1dG8gdmVyaWZ5SXNTb3J0ZWQgPSBbJl0gKGF1dG8mIG9zclZlY3Rvcikgewor ICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpICsgMSA8IG9zclZlY3Rvci5zaXplKCk7ICsr aSkKKyAgICAgICAgICAgIEFTU0VSVChvc3JWZWN0b3JbaV0ubV9ieXRlY29kZUluZGV4IDw9IG9z clZlY3RvcltpICsgMV0ubV9ieXRlY29kZUluZGV4KTsKKyAgICB9OworICAgIHZlcmlmeUlzU29y dGVkKGNhdGNoRW50cnlwb2ludHMpOworICAgIHZlcmlmeUlzU29ydGVkKG9zckVudHJ5KTsKKyNl bmRpZgorfQorCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6REZHCiAKICNlbmRpZiAvLyBFTkFCTEUo REZHX0pJVCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5oCShyZXZp c2lvbiAyMjExMzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGUuaAko d29ya2luZyBjb3B5KQpAQCAtNzcsMTkgKzc3LDcgQEAgcHVibGljOgogICAgICAgICAgICAgW10g KGNvbnN0IENhdGNoRW50cnlwb2ludERhdGEqIGl0ZW0pIHsgcmV0dXJuIGl0ZW0tPm1fYnl0ZWNv ZGVJbmRleDsgfSk7CiAgICAgfQogCi0gICAgdm9pZCBmaW5hbGl6ZUNhdGNoT1NSRW50cnlwb2lu dHMoKQotICAgIHsKLSAgICAgICAgc3RkOjpzb3J0KGNhdGNoRW50cnlwb2ludHMuYmVnaW4oKSwg Y2F0Y2hFbnRyeXBvaW50cy5lbmQoKSwgW10gKGNvbnN0IENhdGNoRW50cnlwb2ludERhdGEmIGEs IGNvbnN0IENhdGNoRW50cnlwb2ludERhdGEmIGIpIHsKLSAgICAgICAgICAgIHJldHVybiBhLm1f Ynl0ZWNvZGVJbmRleCA8IGIubV9ieXRlY29kZUluZGV4OwotICAgICAgICB9KTsKLSNpZiAhQVNT RVJUX0RJU0FCTEVECi0gICAgICAgIHVuc2lnbmVkIHByZXZpb3VzSW5kZXggPSAwOwotICAgICAg ICBmb3IgKGNvbnN0IENhdGNoRW50cnlwb2ludERhdGEmIGVudHJ5cG9pbnQgOiBjYXRjaEVudHJ5 cG9pbnRzKSB7Ci0gICAgICAgICAgICBBU1NFUlQocHJldmlvdXNJbmRleCA8IGVudHJ5cG9pbnQu bV9ieXRlY29kZUluZGV4KTsKLSAgICAgICAgICAgIHByZXZpb3VzSW5kZXggPSBlbnRyeXBvaW50 Lm1fYnl0ZWNvZGVJbmRleDsKLSAgICAgICAgfQotI2VuZGlmCi0gICAgfQorICAgIHZvaWQgZmlu YWxpemVPU1JFbnRyeXBvaW50cygpOwogCiAgICAgdm9pZCBhcHBlbmRDYXRjaEVudHJ5cG9pbnQo dW5zaWduZWQgYnl0ZWNvZGVJbmRleCwgdW5zaWduZWQgbWFjaGluZUNvZGVPZmZzZXQsIFZlY3Rv cjxGbHVzaEZvcm1hdD4mJiBhcmd1bWVudEZvcm1hdHMpCiAgICAgewpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDIy MTEzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xOTMwLDcgKzE5MzAsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklU OjpsaW5rT1NSRW50cmllcyhMaW5rCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBtX2ppdC5qaXRD b2RlKCktPmZpbmFsaXplQ2F0Y2hPU1JFbnRyeXBvaW50cygpOworICAgIG1faml0LmppdENvZGUo KS0+ZmluYWxpemVPU1JFbnRyeXBvaW50cygpOwogCiAgICAgQVNTRVJUKG9zckVudHJ5SW5kZXgg PT0gbV9vc3JFbnRyeUhlYWRzLnNpemUoKSk7CiAgICAgCg== 319089 2017-08-25 11:29:20 -0700 2017-08-25 12:12:41 -0700 re-landing patch patch.diff text/plain 3391 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxMTMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE3LTA4LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERGRzo6SklUQ29kZTo6b3NyRW50cnkgc2hvdWxkIGdldCBzb3J0ZWQgc2luY2Ugd2UgcGVyZm9y bSBhIGJpbmFyeSBzZWFyY2ggb24gaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NTg5MworCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgTGFtLgor CisgICAgICAgICogZGZnL0RGR0pJVENvZGUuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkpJVENv ZGU6OmZpbmFsaXplT1NSRW50cnlwb2ludHMpOgorICAgICAgICAqIGRmZy9ERkdKSVRDb2RlLmg6 CisgICAgICAgIChKU0M6OkRGRzo6SklUQ29kZTo6ZmluYWxpemVDYXRjaE9TUkVudHJ5cG9pbnRz KTogRGVsZXRlZC4KKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAg ICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpsaW5rT1NSRW50cmllcyk6CisKIDIwMTctMDgt MjMgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IFRpdHplciBiZW5jaCBvbiBpT1MuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0pJVENvZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH SklUQ29kZS5jcHAJKHJldmlzaW9uIDIyMTEzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHSklUQ29kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzOCw2ICsyMzgsMjQgQEAgc3Rk OjpvcHRpb25hbDxDb2RlT3JpZ2luPiBKSVRDb2RlOjpmaW5kUAogICAgIHJldHVybiBzdGQ6Om51 bGxvcHQ7CiB9CiAKK3ZvaWQgSklUQ29kZTo6ZmluYWxpemVPU1JFbnRyeXBvaW50cygpCit7Cisg ICAgYXV0byBjb21wYXJhdG9yID0gW10gKGNvbnN0IGF1dG8mIGEsIGNvbnN0IGF1dG8mIGIpIHsK KyAgICAgICAgcmV0dXJuIGEubV9ieXRlY29kZUluZGV4IDwgYi5tX2J5dGVjb2RlSW5kZXg7Cisg ICAgfTsKKyAgICBzdGQ6OnNvcnQoY2F0Y2hFbnRyeXBvaW50cy5iZWdpbigpLCBjYXRjaEVudHJ5 cG9pbnRzLmVuZCgpLCBjb21wYXJhdG9yKTsKKyAgICBzdGQ6OnNvcnQob3NyRW50cnkuYmVnaW4o KSwgb3NyRW50cnkuZW5kKCksIGNvbXBhcmF0b3IpOworCisjaWYgIUFTU0VSVF9ESVNBQkxFRAor ICAgIGF1dG8gdmVyaWZ5SXNTb3J0ZWQgPSBbJl0gKGF1dG8mIG9zclZlY3RvcikgeworICAgICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpICsgMSA8IG9zclZlY3Rvci5zaXplKCk7ICsraSkKKyAg ICAgICAgICAgIEFTU0VSVChvc3JWZWN0b3JbaV0ubV9ieXRlY29kZUluZGV4IDw9IG9zclZlY3Rv cltpICsgMV0ubV9ieXRlY29kZUluZGV4KTsKKyAgICB9OworICAgIHZlcmlmeUlzU29ydGVkKGNh dGNoRW50cnlwb2ludHMpOworICAgIHZlcmlmeUlzU29ydGVkKG9zckVudHJ5KTsKKyNlbmRpZgor fQorCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6REZHCiAKICNlbmRpZiAvLyBFTkFCTEUoREZHX0pJ VCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5oCShyZXZpc2lvbiAy MjExMzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtNzcsMTkgKzc3LDcgQEAgcHVibGljOgogICAgICAgICAgICAgW10gKGNvbnN0 IENhdGNoRW50cnlwb2ludERhdGEqIGl0ZW0pIHsgcmV0dXJuIGl0ZW0tPm1fYnl0ZWNvZGVJbmRl eDsgfSk7CiAgICAgfQogCi0gICAgdm9pZCBmaW5hbGl6ZUNhdGNoT1NSRW50cnlwb2ludHMoKQot ICAgIHsKLSAgICAgICAgc3RkOjpzb3J0KGNhdGNoRW50cnlwb2ludHMuYmVnaW4oKSwgY2F0Y2hF bnRyeXBvaW50cy5lbmQoKSwgW10gKGNvbnN0IENhdGNoRW50cnlwb2ludERhdGEmIGEsIGNvbnN0 IENhdGNoRW50cnlwb2ludERhdGEmIGIpIHsKLSAgICAgICAgICAgIHJldHVybiBhLm1fYnl0ZWNv ZGVJbmRleCA8IGIubV9ieXRlY29kZUluZGV4OwotICAgICAgICB9KTsKLSNpZiAhQVNTRVJUX0RJ U0FCTEVECi0gICAgICAgIHVuc2lnbmVkIHByZXZpb3VzSW5kZXggPSAwOwotICAgICAgICBmb3Ig KGNvbnN0IENhdGNoRW50cnlwb2ludERhdGEmIGVudHJ5cG9pbnQgOiBjYXRjaEVudHJ5cG9pbnRz KSB7Ci0gICAgICAgICAgICBBU1NFUlQocHJldmlvdXNJbmRleCA8IGVudHJ5cG9pbnQubV9ieXRl Y29kZUluZGV4KTsKLSAgICAgICAgICAgIHByZXZpb3VzSW5kZXggPSBlbnRyeXBvaW50Lm1fYnl0 ZWNvZGVJbmRleDsKLSAgICAgICAgfQotI2VuZGlmCi0gICAgfQorICAgIHZvaWQgZmluYWxpemVP U1JFbnRyeXBvaW50cygpOwogCiAgICAgdm9pZCBhcHBlbmRDYXRjaEVudHJ5cG9pbnQodW5zaWdu ZWQgYnl0ZWNvZGVJbmRleCwgdW5zaWduZWQgbWFjaGluZUNvZGVPZmZzZXQsIFZlY3RvcjxGbHVz aEZvcm1hdD4mJiBhcmd1bWVudEZvcm1hdHMpCiAgICAgewpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDIyMTEzMCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xOTMwLDcgKzE5MzAsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpsaW5r T1NSRW50cmllcyhMaW5rCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBtX2ppdC5qaXRDb2RlKCkt PmZpbmFsaXplQ2F0Y2hPU1JFbnRyeXBvaW50cygpOworICAgIG1faml0LmppdENvZGUoKS0+Zmlu YWxpemVPU1JFbnRyeXBvaW50cygpOwogCiAgICAgQVNTRVJUKG9zckVudHJ5SW5kZXggPT0gbV9v c3JFbnRyeUhlYWRzLnNpemUoKSk7CiAgICAgCg==