175882 2017-08-23 08:07:14 -0700 CacheStorageEngine readCachesFromDisk callback should return the read Caches 2017-08-25 14:25:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen buildbot cdumez cgarcia commit-queue saam webkit-bug-importer oldest_to_newest 1341531 0 youennf 2017-08-23 08:07:14 -0700 This is more consistent with the other callbacks 1341532 1 318868 youennf 2017-08-23 08:08:49 -0700 Created attachment 318868 Patch 1341636 2 318868 commit-queue 2017-08-23 10:52:59 -0700 Comment on attachment 318868 Patch Clearing flags on attachment: 318868 Committed r221085: <http://trac.webkit.org/changeset/221085> 1341637 3 commit-queue 2017-08-23 10:53:01 -0700 All reviewed patches have been landed. Closing bug. 1341639 4 webkit-bug-importer 2017-08-23 10:53:34 -0700 <rdar://problem/34038604> 1342483 5 318868 saam 2017-08-25 12:21:17 -0700 Comment on attachment 318868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318868&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:130 > + cachesInfo.uncheckedAppend(WebCore::CacheStorageConnection::CacheInfo { cache.identifier, cache.name}); Ned space between "e" and "}" 1342527 6 youennf 2017-08-25 14:25:10 -0700 (In reply to Saam Barati from comment #5) > Comment on attachment 318868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318868&action=review > > > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:130 > > + cachesInfo.uncheckedAppend(WebCore::CacheStorageConnection::CacheInfo { cache.identifier, cache.name}); > > Ned space between "e" and "}" Thanks, will fix it as part of bug 175995 318868 2017-08-23 08:08:49 -0700 2017-08-23 10:52:59 -0700 Patch bug-175882-20170823080849.patch text/plain 6386 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI2YjMxOWMyNDIwNDU5ZWMy NDk0NWE1ODAxMjJiNGY0MTM0MzYwMTEuLjY3OGM1MjZhNWNiMGRhMmVlMGM1NTcwYmY2NDc5NjJi YzljOTc3MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDgtMjMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENhY2hlU3RvcmFnZUVuZ2luZSBy ZWFkQ2FjaGVzRnJvbURpc2sgY2FsbGJhY2sgc2hvdWxkIHJldHVybiB0aGUgcmVhZCBDYWNoZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTg4Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxiYWNr IG9mIHJlYWRDYWNoZXNGcm9tRGlzayB0YWtlcyBub3cgYSBDYWNoZXMgb3IgZXJyb3IgcGFyYW1l dGVyLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5l LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2FjaGVTdG9yYWdlRW5naW5lOjpvcGVuKToKKyAgICAg ICAgKFdlYktpdDo6Q2FjaGVTdG9yYWdlRW5naW5lOjpyZXRyaWV2ZUNhY2hlcyk6CisgICAgICAg IChXZWJLaXQ6OkNhY2hlU3RvcmFnZUVuZ2luZTo6cmVhZENhY2hlc0Zyb21EaXNrKToKKyAgICAg ICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmUuaDoKKwogMjAxNy0w OC0yMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NhY2hl IEFQSV0gQWRkIHN1cHBvcnQgZm9yIG92ZXJ3cml0aW5nIHJlc3BvbnNlcyB3aXRoIHB1dCBvbiBh biBleGlzdGluZyByZWNvcmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lLmNwcAppbmRleCA1ZDU3ODdiZjdjOTgyODFk MDUxNGI0MjgzMDcwMjIwYTAyYjlkNDQyLi41ZTg5MmJlZDZmOTcxNDU2ZTViYTg1NjI1OWMyOTVk ZjFhNjQzMmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hl L0NhY2hlU3RvcmFnZUVuZ2luZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmUuY3BwCkBAIC02NCwxNSArNjQsMTMgQEAgQ2FjaGVT dG9yYWdlRW5naW5lJiBDYWNoZVN0b3JhZ2VFbmdpbmU6OmRlZmF1bHRFbmdpbmUoKQogCiB2b2lk IENhY2hlU3RvcmFnZUVuZ2luZTo6b3Blbihjb25zdCBTdHJpbmcmIG9yaWdpbiwgY29uc3QgU3Ry aW5nJiBjYWNoZU5hbWUsIENhY2hlSWRlbnRpZmllckNhbGxiYWNrJiYgY2FsbGJhY2spCiB7Ci0g ICAgcmVhZENhY2hlc0Zyb21EaXNrKFt0aGlzLCBvcmlnaW4sIGNhY2hlTmFtZSwgY2FsbGJhY2sg PSBXVEZNb3ZlKGNhbGxiYWNrKV0oc3RkOjpvcHRpb25hbDxFcnJvcj4mJiBlcnJvcikgbXV0YWJs ZSB7Ci0gICAgICAgIGlmIChlcnJvcikgewotICAgICAgICAgICAgY2FsbGJhY2sobWFrZVVuZXhw ZWN0ZWQoZXJyb3IudmFsdWUoKSkpOworICAgIHJlYWRDYWNoZXNGcm9tRGlzayhvcmlnaW4sIFt0 aGlzLCBjYWNoZU5hbWUsIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKENhY2hlc09yRXJy b3ImJiBjYWNoZXNPckVycm9yKSBtdXRhYmxlIHsKKyAgICAgICAgaWYgKCFjYWNoZXNPckVycm9y Lmhhc1ZhbHVlKCkpIHsKKyAgICAgICAgICAgIGNhbGxiYWNrKG1ha2VVbmV4cGVjdGVkKGNhY2hl c09yRXJyb3IuZXJyb3IoKSkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAg ICAgICAgYXV0byYgY2FjaGVzID0gbV9jYWNoZXMuZW5zdXJlKG9yaWdpbiwgW10gewotICAgICAg ICAgICAgcmV0dXJuIFZlY3RvcjxDYWNoZT4oKTsKLSAgICAgICAgfSkuaXRlcmF0b3ItPnZhbHVl OworICAgICAgICBhdXRvJiBjYWNoZXMgPSBjYWNoZXNPckVycm9yLnZhbHVlKCkuZ2V0KCk7CiAK ICAgICAgICAgYXV0byBwb3NpdGlvbiA9IGNhY2hlcy5maW5kTWF0Y2hpbmcoWyZdKGNvbnN0IGF1 dG8mIGl0ZW0pIHsgcmV0dXJuIGl0ZW0ubmFtZSA9PSBjYWNoZU5hbWU7IH0pOwogICAgICAgICBp ZiAocG9zaXRpb24gPT0gbm90Rm91bmQpIHsKQEAgLTExOCwxMiArMTE2LDIwIEBAIHZvaWQgQ2Fj aGVTdG9yYWdlRW5naW5lOjpyZW1vdmUodWludDY0X3QgY2FjaGVJZGVudGlmaWVyLCBDYWNoZUlk ZW50aWZpZXJDYWxsYmFjCiAKIHZvaWQgQ2FjaGVTdG9yYWdlRW5naW5lOjpyZXRyaWV2ZUNhY2hl cyhjb25zdCBTdHJpbmcmIG9yaWdpbiwgQ2FjaGVJbmZvc0NhbGxiYWNrJiYgY2FsbGJhY2spCiB7 Ci0gICAgcmVhZENhY2hlc0Zyb21EaXNrKFt0aGlzLCBvcmlnaW4sIGNhbGxiYWNrID0gV1RGTW92 ZShjYWxsYmFjayldKHN0ZDo6b3B0aW9uYWw8RXJyb3I+JiYgZXJyb3IpIG11dGFibGUgewotICAg ICAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAgICAgIGNhbGxiYWNrKG1ha2VVbmV4cGVjdGVkKGVy cm9yLnZhbHVlKCkpKTsKKyAgICByZWFkQ2FjaGVzRnJvbURpc2sob3JpZ2luLCBbdGhpcywgY2Fs bGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0oQ2FjaGVzT3JFcnJvciYmIGNhY2hlc09yRXJyb3Ip IG11dGFibGUgeworICAgICAgICBpZiAoIWNhY2hlc09yRXJyb3IuaGFzVmFsdWUoKSkgeworICAg ICAgICAgICAgY2FsbGJhY2sobWFrZVVuZXhwZWN0ZWQoY2FjaGVzT3JFcnJvci5lcnJvcigpKSk7 CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KLSAgICAgICAgY2FsbGJhY2soY2FjaGVz KG9yaWdpbikpOworCisgICAgICAgIGF1dG8mIGNhY2hlcyA9IGNhY2hlc09yRXJyb3IudmFsdWUo KS5nZXQoKTsKKworICAgICAgICBWZWN0b3I8V2ViQ29yZTo6Q2FjaGVTdG9yYWdlQ29ubmVjdGlv bjo6Q2FjaGVJbmZvPiBjYWNoZXNJbmZvOworICAgICAgICBjYWNoZXNJbmZvLnJlc2VydmVJbml0 aWFsQ2FwYWNpdHkoY2FjaGVzLnNpemUoKSk7CisgICAgICAgIGZvciAoYXV0byYgY2FjaGUgOiBj YWNoZXMpCisgICAgICAgICAgICBjYWNoZXNJbmZvLnVuY2hlY2tlZEFwcGVuZChXZWJDb3JlOjpD YWNoZVN0b3JhZ2VDb25uZWN0aW9uOjpDYWNoZUluZm8geyBjYWNoZS5pZGVudGlmaWVyLCBjYWNo ZS5uYW1lfSk7CisKKyAgICAgICAgY2FsbGJhY2soV1RGTW92ZShjYWNoZXNJbmZvKSk7CiAgICAg fSk7CiB9CiAKQEAgLTIzMCwxMCArMjM2LDE1IEBAIHZvaWQgQ2FjaGVTdG9yYWdlRW5naW5lOjp3 cml0ZUNhY2hlc1RvRGlzayhGdW5jdGlvbjx2b2lkKHN0ZDo6b3B0aW9uYWw8RXJyb3I+JiYpCiAg ICAgY2FsbGJhY2soc3RkOjpudWxsb3B0KTsKIH0KIAotdm9pZCBDYWNoZVN0b3JhZ2VFbmdpbmU6 OnJlYWRDYWNoZXNGcm9tRGlzayhDb21wbGV0aW9uQ2FsbGJhY2smJiBjYWxsYmFjaykKK3ZvaWQg Q2FjaGVTdG9yYWdlRW5naW5lOjpyZWFkQ2FjaGVzRnJvbURpc2soY29uc3QgU3RyaW5nJiBvcmln aW4sIENhY2hlc0NhbGxiYWNrJiYgY2FsbGJhY2spCiB7CiAgICAgLy8gRklYTUU6IEltcGxlbWVu dCByZWFkaW5nLgotICAgIGNhbGxiYWNrKHN0ZDo6bnVsbG9wdCk7CisKKyAgICBhdXRvJiBjYWNo ZXMgPSBtX2NhY2hlcy5lbnN1cmUob3JpZ2luLCBbXSB7CisgICAgICAgIHJldHVybiBWZWN0b3I8 Q2FjaGU+KCk7CisgICAgfSkuaXRlcmF0b3ItPnZhbHVlOworCisgICAgY2FsbGJhY2soc3RkOjpy ZWZlcmVuY2Vfd3JhcHBlcjxWZWN0b3I8Q2FjaGU+PiB7IGNhY2hlcyB9KTsKIH0KIAogdm9pZCBD YWNoZVN0b3JhZ2VFbmdpbmU6OnJlYWRDYWNoZSh1aW50NjRfdCBjYWNoZUlkZW50aWZpZXIsIENh Y2hlQ2FsbGJhY2smJiBjYWxsYmFjaykKQEAgLTI3NywyMCArMjg4LDYgQEAgQ2FjaGVTdG9yYWdl RW5naW5lOjpDYWNoZSogQ2FjaGVTdG9yYWdlRW5naW5lOjpjYWNoZSh1aW50NjRfdCBjYWNoZUlk ZW50aWZpZXIpCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotVmVjdG9yPFdlYkNvcmU6OkNhY2hl U3RvcmFnZUNvbm5lY3Rpb246OkNhY2hlSW5mbz4gQ2FjaGVTdG9yYWdlRW5naW5lOjpjYWNoZXMo Y29uc3QgU3RyaW5nJiBvcmlnaW4pIGNvbnN0Ci17Ci0gICAgYXV0byBpdGVyYXRvciA9IG1fY2Fj aGVzLmZpbmQob3JpZ2luKTsKLSAgICBpZiAoaXRlcmF0b3IgPT0gbV9jYWNoZXMuZW5kKCkpCi0g ICAgICAgIHJldHVybiB7IH07Ci0KLSAgICBWZWN0b3I8V2ViQ29yZTo6Q2FjaGVTdG9yYWdlQ29u bmVjdGlvbjo6Q2FjaGVJbmZvPiBjYWNoZXNJbmZvOwotICAgIGNhY2hlc0luZm8ucmVzZXJ2ZUlu aXRpYWxDYXBhY2l0eShpdGVyYXRvci0+dmFsdWUuc2l6ZSgpKTsKLSAgICBmb3IgKGF1dG8mIGNh Y2hlIDogaXRlcmF0b3ItPnZhbHVlKQotICAgICAgICBjYWNoZXNJbmZvLnVuY2hlY2tlZEFwcGVu ZChXZWJDb3JlOjpDYWNoZVN0b3JhZ2VDb25uZWN0aW9uOjpDYWNoZUluZm8geyBjYWNoZS5pZGVu dGlmaWVyLCBjYWNoZS5uYW1lfSk7Ci0KLSAgICByZXR1cm4gY2FjaGVzSW5mbzsKLX0KLQogVmVj dG9yPHVpbnQ2NF90PiBDYWNoZVN0b3JhZ2VFbmdpbmU6OnF1ZXJ5Q2FjaGUoY29uc3QgVmVjdG9y PFJlY29yZD4mIHJlY29yZHMsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVxdWVz dCwgY29uc3QgV2ViQ29yZTo6Q2FjaGVRdWVyeU9wdGlvbnMmIG9wdGlvbnMpCiB7CiAgICAgaWYg KCFvcHRpb25zLmlnbm9yZU1ldGhvZCAmJiByZXF1ZXN0Lmh0dHBNZXRob2QoKSAhPSAiR0VUIikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9y YWdlRW5naW5lLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3Rv cmFnZUVuZ2luZS5oCmluZGV4IDdjMjIzNGEwZWRkY2Q1Mjc4MzMzOTY2ZGEwMmY4ZGU4MjZmMDJm ZGIuLmJlOWI5OTRhNjgyNWIzY2I1ZTIyMmQ5NDM4MmVkNWRmOWUxZWI0NWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lLmgK KysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdp bmUuaApAQCAtNzksOSArNzksNiBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIHN0YXRpYyBDYWNo ZVN0b3JhZ2VFbmdpbmUmIGRlZmF1bHRFbmdpbmUoKTsKIAotICAgIHZvaWQgd3JpdGVDYWNoZXNU b0Rpc2soQ29tcGxldGlvbkNhbGxiYWNrJiYpOwotICAgIHZvaWQgcmVhZENhY2hlc0Zyb21EaXNr KENvbXBsZXRpb25DYWxsYmFjayYmKTsKLQogICAgIHN0cnVjdCBDYWNoZSB7CiAgICAgICAgIHVp bnQ2NF90IGlkZW50aWZpZXI7CiAgICAgICAgIFN0cmluZyBuYW1lOwpAQCAtODksMTEgKzg2LDE1 IEBAIHByaXZhdGU6CiAgICAgICAgIHVpbnQ2NF90IG5leHRSZWNvcmRJZGVudGlmaWVyIHsgMCB9 OwogICAgIH07CiAKKyAgICB2b2lkIHdyaXRlQ2FjaGVzVG9EaXNrKENvbXBsZXRpb25DYWxsYmFj ayYmKTsKKworICAgIHVzaW5nIENhY2hlc09yRXJyb3IgPSBFeHBlY3RlZDxzdGQ6OnJlZmVyZW5j ZV93cmFwcGVyPFZlY3RvcjxDYWNoZT4+LCBFcnJvcj47CisgICAgdXNpbmcgQ2FjaGVzQ2FsbGJh Y2sgPSBGdW5jdGlvbjx2b2lkKENhY2hlc09yRXJyb3ImJik+OworICAgIHZvaWQgcmVhZENhY2hl c0Zyb21EaXNrKGNvbnN0IFN0cmluZyYgb3JpZ2luLCBGdW5jdGlvbjx2b2lkKENhY2hlc09yRXJy b3ImJik+JiYpOworCiAgICAgdXNpbmcgQ2FjaGVPckVycm9yID0gRXhwZWN0ZWQ8c3RkOjpyZWZl cmVuY2Vfd3JhcHBlcjxDYWNoZT4sIEVycm9yPjsKICAgICB1c2luZyBDYWNoZUNhbGxiYWNrID0g RnVuY3Rpb248dm9pZChDYWNoZU9yRXJyb3ImJik+OwogCi0gICAgVmVjdG9yPFdlYkNvcmU6OkNh Y2hlU3RvcmFnZUNvbm5lY3Rpb246OkNhY2hlSW5mbz4gY2FjaGVzKGNvbnN0IFN0cmluZyYgb3Jp Z2luKSBjb25zdDsKLQogICAgIHZvaWQgcmVhZENhY2hlKHVpbnQ2NF90IGNhY2hlSWRlbnRpZmll ciwgQ2FjaGVDYWxsYmFjayYmKTsKICAgICB2b2lkIHdyaXRlQ2FjaGVSZWNvcmRzKHVpbnQ2NF90 IGNhY2hlSWRlbnRpZmllciwgVmVjdG9yPHVpbnQ2NF90PiYmLCBSZWNvcmRJZGVudGlmaWVyc0Nh bGxiYWNrJiYpOwogICAgIHZvaWQgcmVtb3ZlQ2FjaGVSZWNvcmRzKHVpbnQ2NF90IGNhY2hlSWRl bnRpZmllciwgVmVjdG9yPHVpbnQ2NF90PiYmLCBSZWNvcmRJZGVudGlmaWVyc0NhbGxiYWNrJiYp Owo=