175880 2017-08-23 02:42:41 -0700 REGRESSION(r218437): [GTK][WPE] Test /webkit2/WebKitWebExtension/isolated-world is failing since r218437 2017-08-28 04:46:19 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 Ms2ger Ms2ger andersca bugs-noreply cgarcia clopez commit-queue oldest_to_newest 1341490 0 Ms2ger 2017-08-23 02:42:41 -0700 . 1341491 1 318860 Ms2ger 2017-08-23 02:44:58 -0700 Created attachment 318860 Patch 1341496 2 318860 clopez 2017-08-23 03:39:48 -0700 Comment on attachment 318860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318860&action=review > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:151 > - "document.open(1, 2, 3);"; > + "window.open(1, 2, 3);"; What mean the parameters 1, 2, 3 here? 1341498 3 Ms2ger 2017-08-23 03:54:22 -0700 (In reply to Carlos Alberto Lopez Perez from comment #2) > Comment on attachment 318860 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318860&action=review > > > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:151 > > - "document.open(1, 2, 3);"; > > + "window.open(1, 2, 3);"; > > What mean the parameters 1, 2, 3 here? The forwarding to window.open() only happens with at least three arguments. No idea why this used such a roundabout approach; CC'ing some people from bug 103377. 1341500 4 clopez 2017-08-23 03:59:00 -0700 (In reply to Ms2ger from comment #3) > (In reply to Carlos Alberto Lopez Perez from comment #2) > > Comment on attachment 318860 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=318860&action=review > > > > > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:151 > > > - "document.open(1, 2, 3);"; > > > + "window.open(1, 2, 3);"; > > > > What mean the parameters 1, 2, 3 here? > > The forwarding to window.open() only happens with at least three arguments. > No idea why this used such a roundabout approach; CC'ing some people from > bug 103377. Just doing window.open() seems to work here to make the test pass 1341501 5 clopez 2017-08-23 04:05:52 -0700 (In reply to Carlos Alberto Lopez Perez from comment #4) > (In reply to Ms2ger from comment #3) > > (In reply to Carlos Alberto Lopez Perez from comment #2) > > > Comment on attachment 318860 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=318860&action=review > > > > > > > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:151 > > > > - "document.open(1, 2, 3);"; > > > > + "window.open(1, 2, 3);"; > > > > > > What mean the parameters 1, 2, 3 here? > > > > The forwarding to window.open() only happens with at least three arguments. > > No idea why this used such a roundabout approach; CC'ing some people from > > bug 103377. > Ah! I see what you mean.. previously (before r218437) 3 parameter where needed to pass the call from document.open to window.open() > Just doing window.open() seems to work here to make the test pass Now simply calling window.open without any parameter seems enough 1341518 6 318865 Ms2ger 2017-08-23 06:41:51 -0700 Created attachment 318865 Patch 1341519 7 Ms2ger 2017-08-23 06:49:39 -0700 Since I don't know what purpose the function call served, I just removed it entirely. 1341523 8 318865 clopez 2017-08-23 07:10:22 -0700 Comment on attachment 318865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318865&action=review > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:150 > - "window.open = function () { alert('Main World'); }\n" > - "document.open(1, 2, 3);"; > + "alert('Main World');"; Looks fine to me, but I prefer to wait for cgarcia r+ here (as I'm a bit confused about the previous window.open usage here and maybe there is something i'm overlooking) 1342763 9 cgarcia 2017-08-28 00:43:12 -0700 I find the bug title a bit confusing, it's not that the test has a way of running pop ups, that was the way to test isolated worlds, it was actually a "port" of the layout test http/tests/security/isolatedWorld/document-open.html. 1342764 10 318865 cgarcia 2017-08-28 00:46:35 -0700 Comment on attachment 318865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318865&action=review Thanks for looking at this failure, it has been in my TODO since it started to fail. > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:161 > - "window.open = function () { alert('Isolated World'); }\n" > - "document.open(1, 2, 3);"; > + "alert('Isolated World');"; I'm not sure this is testing what we want, running this alert in the main world would still show an alert with the text 'Isolated World'. Here we were testing that property open of window can be set in an isolated world and it can be used, without affecting the normal world. Maybe we can simply keep the window.open line but use window open directly instead of document.open? 1342782 11 318865 cgarcia 2017-08-28 02:38:19 -0700 Comment on attachment 318865 Patch Sorry, I used the wrong r flag. r- because I don't think the test is correct. 1342790 12 319173 Ms2ger 2017-08-28 03:54:21 -0700 Created attachment 319173 Patch 1342794 13 319173 cgarcia 2017-08-28 04:17:00 -0700 Comment on attachment 319173 Patch Thanks! 1342803 14 319173 commit-queue 2017-08-28 04:46:18 -0700 Comment on attachment 319173 Patch Clearing flags on attachment: 319173 Committed r221240: <http://trac.webkit.org/changeset/221240> 1342804 15 commit-queue 2017-08-28 04:46:19 -0700 All reviewed patches have been landed. Closing bug. 318860 2017-08-23 02:44:58 -0700 2017-08-23 06:41:47 -0700 Patch bug-175880-20170823114457.patch text/plain 2640 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2FmNTgxZDdkNDc3MTJiNzk4MDZlNTk3NjYxMDYxZTFh Y2UyYzE1ZC4uNTE2ZmFkZTBlYTMxNzhiZmEwMmQxNDBhNGIwMzllMDVkOTYyYzE4NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE3LTA4LTIzICBNczJnZXIgIDxNczJnZXJAZ21haWwuY29tPgorCisgICAgICAgIFVz ZSBhIHNsaWdodGx5IGJldHRlciB3YXkgdG8gcG9wIHVwIGEgZGlhbG9nIGluIFRlc3RXZWJFeHRl bnNpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc1ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIHRlc3QgcmVsaWVkIG9uIGEgYnVnIGluIHRoZSBIVE1MRG9jdW1lbnQgSmF2YVNjcmlwdCBi aW5kaW5nczogd2hlbiBjYWxsaW5nCisgICAgICAgIGRvY3VtZW50Lm9wZW4oKSB3aXRoIHRocmVl IGFyZ3VtZW50cywgaXQgd291bGQgY2FsbCBhbnkgZnVuY3Rpb24gc2V0IGFzIHRoZQorICAgICAg ICAib3BlbiIgcHJvcGVydHkgb24gdGhlIHdpbmRvdyBvYmplY3QsIHJhdGhlciB0aGFuIGp1c3Qg dGhlIHJlYWwgV2luZG93OjpvcGVuKCkKKyAgICAgICAgbWV0aG9kLiBUaGlzIGJ1ZyB3YXMgZml4 ZWQgYnkgdGhlIHJlbW92YWwgb2YgY3VzdG9tIGJpbmRpbmdzIGZvciBIVE1MRG9jdW1lbnQKKyAg ICAgICAgaW4gcjIxODQzNy4gQXMgYSByZXN1bHQsIHRoZSB0ZXN0IG5vIGxvbmdlciBjYWxsZWQg YWxlcnQoKSwgd2hpY2ggY2F1c2VkIGl0IHRvCisgICAgICAgIGZhaWwuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwOgorICAg ICAgICAodGVzdFdlYkV4dGVuc2lvbklzb2xhdGVkV29ybGQpOgorCiAyMDE3LTA4LTIxICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgRGF0YUludGVy YWN0aW9uVGVzdHMuRXh0ZXJuYWxTb3VyY2VBdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRpdGFi bGUgaGl0cyBhIGRlYnVnIGFzc2VydGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcCBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHAKaW5kZXggY2NiMTFk YWMxN2M1YWFmOTVhYzVkM2VjMmNiNDVlOGY4OGJiMDNjNS4uZjEwODhmMjkzNmNjZjhhYzMxNmFm ZmFmZDU3MDY0OGVkNzJjNWQ3NiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRHTGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwCkBAIC0xNDgsNyArMTQ4 LDcgQEAgc3RhdGljIHZvaWQgdGVzdFdlYkV4dGVuc2lvbklzb2xhdGVkV29ybGQoV2ViVmlld1Rl c3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgICAgICJ0b3AuZm9vID0gJ0Zvbyc7XG4iCiAg ICAgICAgICJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9IHRv cC5mb287XG4iCiAgICAgICAgICJ3aW5kb3cub3BlbiA9IGZ1bmN0aW9uICgpIHsgYWxlcnQoJ01h aW4gV29ybGQnKTsgfVxuIgotICAgICAgICAiZG9jdW1lbnQub3BlbigxLCAyLCAzKTsiOworICAg ICAgICAid2luZG93Lm9wZW4oMSwgMiwgMyk7IjsKICAgICB0ZXN0LT5ydW5KYXZhU2NyaXB0QW5k V2FpdFVudGlsRmluaXNoZWQobWFpbldvcmxkU2NyaXB0LCAwKTsKICAgICBnX2Fzc2VydF9jbXBz dHIoc2NyaXB0RGlhbG9nUmVzdWx0LmdldCgpLCA9PSwgIk1haW4gV29ybGQiKTsKIApAQCAtMTYw LDcgKzE2MCw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJFeHRlbnNpb25Jc29sYXRlZFdvcmxkKFdl YlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBp c29sYXRlZFdvcmxkU2NyaXB0ID0KICAgICAgICAgImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdj b25zb2xlJykuaW5uZXJIVE1MID0gdG9wLmZvbztcbiIKICAgICAgICAgIndpbmRvdy5vcGVuID0g ZnVuY3Rpb24gKCkgeyBhbGVydCgnSXNvbGF0ZWQgV29ybGQnKTsgfVxuIgotICAgICAgICAiZG9j dW1lbnQub3BlbigxLCAyLCAzKTsiOworICAgICAgICAid2luZG93Lm9wZW4oMSwgMiwgMyk7IjsK ICAgICBHVW5pcXVlUHRyPGNoYXI+IGV4dGVuc2lvbkJ1c05hbWUoZ19zdHJkdXBfcHJpbnRmKCJv cmcud2Via2l0Lmd0ay5XZWJFeHRlbnNpb25UZXN0JXUiLCBUZXN0OjpzX3dlYkV4dGVuc2lvbklE KSk7CiAgICAgR1JlZlB0cjxHREJ1c1Byb3h5PiBwcm94eSA9IGFkb3B0R1JlZihidXMtPmNyZWF0 ZVByb3h5KGV4dGVuc2lvbkJ1c05hbWUuZ2V0KCksCiAgICAgICAgICIvb3JnL3dlYmtpdC9ndGsv V2ViRXh0ZW5zaW9uVGVzdCIgLCAib3JnLndlYmtpdC5ndGsuV2ViRXh0ZW5zaW9uVGVzdCIsIHRl c3QtPm1fbWFpbkxvb3ApKTsK 318865 2017-08-23 06:41:51 -0700 2017-08-28 03:54:17 -0700 Patch bug-175880-20170823154150.patch text/plain 2734 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2FmNTgxZDdkNDc3MTJiNzk4MDZlNTk3NjYxMDYxZTFh Y2UyYzE1ZC4uZDNiNjQyNzYwOTRkMzEwNmYwODBmNjI2NGViYTM4MTI2ODQ1NGQ4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE3LTA4LTIzICBNczJnZXIgIDxNczJnZXJAZ21haWwuY29tPgorCisgICAgICAgIFVz ZSBhIHNsaWdodGx5IGJldHRlciB3YXkgdG8gcG9wIHVwIGEgZGlhbG9nIGluIFRlc3RXZWJFeHRl bnNpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc1ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIHRlc3QgcmVsaWVkIG9uIGEgYnVnIGluIHRoZSBIVE1MRG9jdW1lbnQgSmF2YVNjcmlwdCBi aW5kaW5nczogd2hlbiBjYWxsaW5nCisgICAgICAgIGRvY3VtZW50Lm9wZW4oKSB3aXRoIHRocmVl IGFyZ3VtZW50cywgaXQgd291bGQgY2FsbCBhbnkgZnVuY3Rpb24gc2V0IGFzIHRoZQorICAgICAg ICAib3BlbiIgcHJvcGVydHkgb24gdGhlIHdpbmRvdyBvYmplY3QsIHJhdGhlciB0aGFuIGp1c3Qg dGhlIHJlYWwgV2luZG93OjpvcGVuKCkKKyAgICAgICAgbWV0aG9kLiBUaGlzIGJ1ZyB3YXMgZml4 ZWQgYnkgdGhlIHJlbW92YWwgb2YgY3VzdG9tIGJpbmRpbmdzIGZvciBIVE1MRG9jdW1lbnQKKyAg ICAgICAgaW4gcjIxODQzNy4gQXMgYSByZXN1bHQsIHRoZSB0ZXN0IG5vIGxvbmdlciBjYWxsZWQg YWxlcnQoKSwgd2hpY2ggY2F1c2VkIGl0IHRvCisgICAgICAgIGZhaWwuCisKKyAgICAgICAgSW5z dGVhZCwganVzdCBjYWxsIGFsZXJ0KCkgZGlyZWN0bHkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwOgorICAgICAgICAodGVz dFdlYkV4dGVuc2lvbklzb2xhdGVkV29ybGQpOgorCiAyMDE3LTA4LTIxICBNeWxlcyBDLiBNYXhm aWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgRGF0YUludGVyYWN0aW9uVGVz dHMuRXh0ZXJuYWxTb3VyY2VBdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRpdGFibGUgaGl0cyBh IGRlYnVnIGFzc2VydGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRHTGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0R0xpYi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHAKaW5kZXggY2NiMTFkYWMxN2M1YWFm OTVhYzVkM2VjMmNiNDVlOGY4OGJiMDNjNS4uYjQ1M2I5NjIzOWViZmE3MjA3ZDBmMTM2YzE2Yjcx YmJkYjAyMDY5NiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRH TGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdEdMaWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwCkBAIC0xNDcsOCArMTQ3LDcgQEAgc3Rh dGljIHZvaWQgdGVzdFdlYkV4dGVuc2lvbklzb2xhdGVkV29ybGQoV2ViVmlld1Rlc3QqIHRlc3Qs IGdjb25zdHBvaW50ZXIpCiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIG1haW5Xb3JsZFNjcmlwdCA9 CiAgICAgICAgICJ0b3AuZm9vID0gJ0Zvbyc7XG4iCiAgICAgICAgICJkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9IHRvcC5mb287XG4iCi0gICAgICAgICJ3aW5k b3cub3BlbiA9IGZ1bmN0aW9uICgpIHsgYWxlcnQoJ01haW4gV29ybGQnKTsgfVxuIgotICAgICAg ICAiZG9jdW1lbnQub3BlbigxLCAyLCAzKTsiOworICAgICAgICAiYWxlcnQoJ01haW4gV29ybGQn KTsiOwogICAgIHRlc3QtPnJ1bkphdmFTY3JpcHRBbmRXYWl0VW50aWxGaW5pc2hlZChtYWluV29y bGRTY3JpcHQsIDApOwogICAgIGdfYXNzZXJ0X2NtcHN0cihzY3JpcHREaWFsb2dSZXN1bHQuZ2V0 KCksID09LCAiTWFpbiBXb3JsZCIpOwogCkBAIC0xNTksOCArMTU4LDcgQEAgc3RhdGljIHZvaWQg dGVzdFdlYkV4dGVuc2lvbklzb2xhdGVkV29ybGQoV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCiAKICAgICBzdGF0aWMgY29uc3QgY2hhciogaXNvbGF0ZWRXb3JsZFNjcmlwdCA9CiAg ICAgICAgICJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9IHRv cC5mb287XG4iCi0gICAgICAgICJ3aW5kb3cub3BlbiA9IGZ1bmN0aW9uICgpIHsgYWxlcnQoJ0lz b2xhdGVkIFdvcmxkJyk7IH1cbiIKLSAgICAgICAgImRvY3VtZW50Lm9wZW4oMSwgMiwgMyk7IjsK KyAgICAgICAgImFsZXJ0KCdJc29sYXRlZCBXb3JsZCcpOyI7CiAgICAgR1VuaXF1ZVB0cjxjaGFy PiBleHRlbnNpb25CdXNOYW1lKGdfc3RyZHVwX3ByaW50Zigib3JnLndlYmtpdC5ndGsuV2ViRXh0 ZW5zaW9uVGVzdCV1IiwgVGVzdDo6c193ZWJFeHRlbnNpb25JRCkpOwogICAgIEdSZWZQdHI8R0RC dXNQcm94eT4gcHJveHkgPSBhZG9wdEdSZWYoYnVzLT5jcmVhdGVQcm94eShleHRlbnNpb25CdXNO YW1lLmdldCgpLAogICAgICAgICAiL29yZy93ZWJraXQvZ3RrL1dlYkV4dGVuc2lvblRlc3QiICwg Im9yZy53ZWJraXQuZ3RrLldlYkV4dGVuc2lvblRlc3QiLCB0ZXN0LT5tX21haW5Mb29wKSk7Cg== 319173 2017-08-28 03:54:21 -0700 2017-08-28 04:46:18 -0700 Patch bug-175880-20170828125420.patch text/plain 2684 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMjM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM1YjNjZDEzZTVhZjNhYmY0Y2NmODhhNzE5MjJjMTg1 YTE0MTY3MS4uYzY3ZmU5YWJmNDcyNWVkNzExMDMzYjQxNTI3Yzk5YTQ5YjljMzNlOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE3LTA4LTI4ICBNczJnZXIgIDxNczJnZXJAZ21haWwuY29tPgorCisgICAgICAgIEVu c3VyZSB0aGF0IHRoZSBhbGVydCBmdW5jdGlvbiBpcyBjYWxsZWQgaW4gVGVzdFdlYkV4dGVuc2lv bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU4 ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg dGVzdCByZWxpZWQgb24gYSBidWcgaW4gdGhlIEhUTUxEb2N1bWVudCBKYXZhU2NyaXB0IGJpbmRp bmdzOiB3aGVuIGNhbGxpbmcKKyAgICAgICAgZG9jdW1lbnQub3BlbigpIHdpdGggdGhyZWUgYXJn dW1lbnRzLCBpdCB3b3VsZCBjYWxsIGFueSBmdW5jdGlvbiBzZXQgYXMgdGhlCisgICAgICAgICJv cGVuIiBwcm9wZXJ0eSBvbiB0aGUgd2luZG93IG9iamVjdCwgcmF0aGVyIHRoYW4ganVzdCB0aGUg cmVhbCBXaW5kb3c6Om9wZW4oKQorICAgICAgICBtZXRob2QuIFRoaXMgYnVnIHdhcyBmaXhlZCBi eSB0aGUgcmVtb3ZhbCBvZiBjdXN0b20gYmluZGluZ3MgZm9yIEhUTUxEb2N1bWVudAorICAgICAg ICBpbiByMjE4NDM3LiBBcyBhIHJlc3VsdCwgdGhlIHRlc3Qgbm8gbG9uZ2VyIGNhbGxlZCBhbGVy dCgpLCB3aGljaCBjYXVzZWQgaXQgdG8KKyAgICAgICAgZmFpbC4KKworICAgICAgICBJbnN0ZWFk LCBjYWxsIHRoZSB3aW5kb3cub3BlbigpIGZ1bmN0aW9uIGRpcmVjdGx5LgorCisgICAgICAgICog VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcDoKKyAg ICAgICAgKHRlc3RXZWJFeHRlbnNpb25Jc29sYXRlZFdvcmxkKToKKwogMjAxNy0wOC0yNyAgV2Vu c29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBQaWNraW5nIGFu IGVtb2ppIHZpYSB0aGUgZW1vamkgZGlhbG9nIChDdHJsK0NtZCtTcGFjZSkgZmlyZXMgaW5jb25z aXN0ZW50IGJlZm9yZWlucHV0IGV2ZW50cy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHAgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYkV4dGVuc2lvbnMuY3BwCmluZGV4IGNjYjEx ZGFjMTdjNWFhZjk1YWM1ZDNlYzJjYjQ1ZThmODhiYjAzYzUuLmZmOTMwNTNhMDRjZGZkNzk5YWE4 OTM1OGJiYThjZjc3OGU4NDE5YWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0R0xpYi9UZXN0V2ViRXh0ZW5zaW9ucy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RXZWJFeHRlbnNpb25zLmNwcApAQCAtMTQ4LDcgKzE0 OCw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJFeHRlbnNpb25Jc29sYXRlZFdvcmxkKFdlYlZpZXdU ZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAgICAgICAidG9wLmZvbyA9ICdGb28nO1xuIgog ICAgICAgICAiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5pbm5lckhUTUwgPSB0 b3AuZm9vO1xuIgogICAgICAgICAid2luZG93Lm9wZW4gPSBmdW5jdGlvbiAoKSB7IGFsZXJ0KCdN YWluIFdvcmxkJyk7IH1cbiIKLSAgICAgICAgImRvY3VtZW50Lm9wZW4oMSwgMiwgMyk7IjsKKyAg ICAgICAgIndpbmRvdy5vcGVuKCk7IjsKICAgICB0ZXN0LT5ydW5KYXZhU2NyaXB0QW5kV2FpdFVu dGlsRmluaXNoZWQobWFpbldvcmxkU2NyaXB0LCAwKTsKICAgICBnX2Fzc2VydF9jbXBzdHIoc2Ny aXB0RGlhbG9nUmVzdWx0LmdldCgpLCA9PSwgIk1haW4gV29ybGQiKTsKIApAQCAtMTYwLDcgKzE2 MCw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJFeHRlbnNpb25Jc29sYXRlZFdvcmxkKFdlYlZpZXdU ZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBpc29sYXRl ZFdvcmxkU2NyaXB0ID0KICAgICAgICAgImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xl JykuaW5uZXJIVE1MID0gdG9wLmZvbztcbiIKICAgICAgICAgIndpbmRvdy5vcGVuID0gZnVuY3Rp b24gKCkgeyBhbGVydCgnSXNvbGF0ZWQgV29ybGQnKTsgfVxuIgotICAgICAgICAiZG9jdW1lbnQu b3BlbigxLCAyLCAzKTsiOworICAgICAgICAid2luZG93Lm9wZW4oKTsiOwogICAgIEdVbmlxdWVQ dHI8Y2hhcj4gZXh0ZW5zaW9uQnVzTmFtZShnX3N0cmR1cF9wcmludGYoIm9yZy53ZWJraXQuZ3Rr LldlYkV4dGVuc2lvblRlc3QldSIsIFRlc3Q6OnNfd2ViRXh0ZW5zaW9uSUQpKTsKICAgICBHUmVm UHRyPEdEQnVzUHJveHk+IHByb3h5ID0gYWRvcHRHUmVmKGJ1cy0+Y3JlYXRlUHJveHkoZXh0ZW5z aW9uQnVzTmFtZS5nZXQoKSwKICAgICAgICAgIi9vcmcvd2Via2l0L2d0ay9XZWJFeHRlbnNpb25U ZXN0IiAsICJvcmcud2Via2l0Lmd0ay5XZWJFeHRlbnNpb25UZXN0IiwgdGVzdC0+bV9tYWluTG9v cCkpOwo=