175827 2017-08-22 10:24:43 -0700 Add sanity check for source origin in WebLoaderStrategy::startPingLoad() 2017-08-22 13:54:00 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ggaren ryanhaddad webkit-bug-importer youennf oldest_to_newest 1341087 0 cdumez 2017-08-22 10:24:43 -0700 Add sanity check for source origin in WebLoaderStrategy::startPingLoad(). 1341089 1 318762 cdumez 2017-08-22 10:26:10 -0700 Created attachment 318762 Patch 1341091 2 318762 ggaren 2017-08-22 10:29:56 -0700 Comment on attachment 318762 Patch r=me 1341092 3 youennf 2017-08-22 10:31:25 -0700 Origin header might not always be there for same-origin requests. 1341093 4 318763 cdumez 2017-08-22 10:34:28 -0700 Created attachment 318763 Patch 1341151 5 318763 commit-queue 2017-08-22 11:16:43 -0700 Comment on attachment 318763 Patch Clearing flags on attachment: 318763 Committed r221027: <http://trac.webkit.org/changeset/221027> 1341152 6 commit-queue 2017-08-22 11:16:45 -0700 All reviewed patches have been landed. Closing bug. 1341155 7 webkit-bug-importer 2017-08-22 11:17:31 -0700 <rdar://problem/34016866> 1341244 8 ryanhaddad 2017-08-22 13:53:24 -0700 Reverted r221027 for reason: This change caused LayoutTests to exit early with assertion failures. Committed r221043: <http://trac.webkit.org/changeset/221043> 1341246 9 ryanhaddad 2017-08-22 13:54:00 -0700 (In reply to Ryan Haddad from comment #8) > Reverted r221027 for reason: > > This change caused LayoutTests to exit early with assertion failures. > > Committed r221043: <http://trac.webkit.org/changeset/221043> Relevant link: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221029%20(2653)/results.html 318762 2017-08-22 10:26:10 -0700 2017-08-22 10:34:27 -0700 Patch bug-175827-20170822102609.patch text/plain 2343 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg2MGViMzljNDgzZjI1ZTdm ZDY0NGE5YzlkYWQzYTYwNGY1MTc5NmEuLmM1M2E5MzM0YjMzZTI1MTdhNzY0ZDk4MjlmNmYzZDll NDE5OWRlYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDgtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc2FuaXR5IGNoZWNrIGZvciBz b3VyY2Ugb3JpZ2luIGluIFdlYkxvYWRlclN0cmF0ZWd5OjpzdGFydFBpbmdMb2FkKCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTgyNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVy U3RyYXRlZ3k6OnN0YXJ0UGluZ0xvYWQpOgorCiAyMDE3LTA4LTIyICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPiBhbmQgUHJhbmphbCBKdW1kZSAgPHBqdW1kZUBhcHBsZS5jb20+ CiAKICAgICAgICAgRGlzYWJsZSBhY2Nlc3MgdG8gc2VjdXJlIGNvb2tpZXMgaWYgYW4gSFRUUFMg c2l0ZSBsb2FkcyBtaXhlZCBjb250ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKaW5kZXggMWYwYTIxM2MyYzAwYzI3 YzkwMGVhYWMyOGZjYzg5ZGYwN2QzZGQ4MS4uN2U5MGJhMzk5NWFmNGMzNzI4NDhkOTVkMzU2YTYx ZjE1MDc3MTRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsv V2ViTG9hZGVyU3RyYXRlZ3kuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcApAQCAtNDI1LDEzICs0MjUsMTQgQEAgdm9pZCBXZWJM b2FkZXJTdHJhdGVneTo6c3RhcnRQaW5nTG9hZChGcmFtZSYgZnJhbWUsIFJlc291cmNlUmVxdWVz dCYgcmVxdWVzdCwgY28KICAgICBsb2FkUGFyYW1ldGVycy5pZGVudGlmaWVyID0gZ2VuZXJhdGVQ aW5nTG9hZElkZW50aWZpZXIoKTsKICAgICBsb2FkUGFyYW1ldGVycy5yZXF1ZXN0ID0gcmVxdWVz dDsKICAgICBsb2FkUGFyYW1ldGVycy5zb3VyY2VPcmlnaW4gPSAmZG9jdW1lbnQtPnNlY3VyaXR5 T3JpZ2luKCk7CisgICAgQVNTRVJUKGxvYWRQYXJhbWV0ZXJzLnJlcXVlc3QuaHR0cEhlYWRlckZp ZWxkKEhUVFBIZWFkZXJOYW1lOjpPcmlnaW4pID09IGxvYWRQYXJhbWV0ZXJzLnNvdXJjZU9yaWdp bi0+dG9TdHJpbmcoKSk7CiAgICAgbG9hZFBhcmFtZXRlcnMuc2Vzc2lvbklEID0gd2ViUGFnZSA/ IHdlYlBhZ2UtPnNlc3Npb25JRCgpIDogUEFMOjpTZXNzaW9uSUQ6OmRlZmF1bHRTZXNzaW9uSUQo KTsKICAgICBsb2FkUGFyYW1ldGVycy5hbGxvd1N0b3JlZENyZWRlbnRpYWxzID0gb3B0aW9ucy5j cmVkZW50aWFscyA9PSBGZXRjaE9wdGlvbnM6OkNyZWRlbnRpYWxzOjpPbWl0ID8gRG9Ob3RBbGxv d1N0b3JlZENyZWRlbnRpYWxzIDogQWxsb3dTdG9yZWRDcmVkZW50aWFsczsKICAgICBsb2FkUGFy YW1ldGVycy5tb2RlID0gb3B0aW9ucy5tb2RlOwogICAgIGxvYWRQYXJhbWV0ZXJzLnNob3VsZEZv bGxvd1JlZGlyZWN0cyA9IG9wdGlvbnMucmVkaXJlY3QgPT0gRmV0Y2hPcHRpb25zOjpSZWRpcmVj dDo6Rm9sbG93OwogICAgIGxvYWRQYXJhbWV0ZXJzLnNob3VsZENsZWFyUmVmZXJyZXJPbkhUVFBT VG9IVFRQUmVkaXJlY3QgPSBuZXR3b3JraW5nQ29udGV4dC0+c2hvdWxkQ2xlYXJSZWZlcnJlck9u SFRUUFNUb0hUVFBSZWRpcmVjdCgpOwogICAgIGlmICghZG9jdW1lbnQtPnNob3VsZEJ5cGFzc01h aW5Xb3JsZENvbnRlbnRTZWN1cml0eVBvbGljeSgpKSB7Ci0gICAgICAgIGlmIChhdXRvICogY29u dGVudFNlY3VyaXR5UG9saWN5ID0gZG9jdW1lbnQtPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpKQor ICAgICAgICBpZiAoYXV0byogY29udGVudFNlY3VyaXR5UG9saWN5ID0gZG9jdW1lbnQtPmNvbnRl bnRTZWN1cml0eVBvbGljeSgpKQogICAgICAgICAgICAgbG9hZFBhcmFtZXRlcnMuY3NwUmVzcG9u c2VIZWFkZXJzID0gY29udGVudFNlY3VyaXR5UG9saWN5LT5yZXNwb25zZUhlYWRlcnMoKTsKICAg ICB9CiAK 318763 2017-08-22 10:34:28 -0700 2017-08-22 11:16:43 -0700 Patch bug-175827-20170822103427.patch text/plain 2418 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg2MGViMzljNDgzZjI1ZTdm ZDY0NGE5YzlkYWQzYTYwNGY1MTc5NmEuLjc1OGFlMDA0MjIwZTg3ZGZlYTRjZGRjNjc3YWUzNWZk M2E2ZGNmYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDgtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc2FuaXR5IGNoZWNrIGZvciBz b3VyY2Ugb3JpZ2luIGluIFdlYkxvYWRlclN0cmF0ZWd5OjpzdGFydFBpbmdMb2FkKCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTgyNworCisgICAg ICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVy U3RyYXRlZ3k6OnN0YXJ0UGluZ0xvYWQpOgorCiAyMDE3LTA4LTIyICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPiBhbmQgUHJhbmphbCBKdW1kZSAgPHBqdW1kZUBhcHBsZS5jb20+ CiAKICAgICAgICAgRGlzYWJsZSBhY2Nlc3MgdG8gc2VjdXJlIGNvb2tpZXMgaWYgYW4gSFRUUFMg c2l0ZSBsb2FkcyBtaXhlZCBjb250ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKaW5kZXggMWYwYTIxM2MyYzAwYzI3 YzkwMGVhYWMyOGZjYzg5ZGYwN2QzZGQ4MS4uNWIwY2MxODdlNTE4YmJmYmE3NjQyMWU4MjM2MTY4 NjI3NjlkMDYzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsv V2ViTG9hZGVyU3RyYXRlZ3kuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcApAQCAtNDI1LDEzICs0MjUsMTQgQEAgdm9pZCBXZWJM b2FkZXJTdHJhdGVneTo6c3RhcnRQaW5nTG9hZChGcmFtZSYgZnJhbWUsIFJlc291cmNlUmVxdWVz dCYgcmVxdWVzdCwgY28KICAgICBsb2FkUGFyYW1ldGVycy5pZGVudGlmaWVyID0gZ2VuZXJhdGVQ aW5nTG9hZElkZW50aWZpZXIoKTsKICAgICBsb2FkUGFyYW1ldGVycy5yZXF1ZXN0ID0gcmVxdWVz dDsKICAgICBsb2FkUGFyYW1ldGVycy5zb3VyY2VPcmlnaW4gPSAmZG9jdW1lbnQtPnNlY3VyaXR5 T3JpZ2luKCk7CisgICAgQVNTRVJUKGxvYWRQYXJhbWV0ZXJzLnJlcXVlc3QuaHR0cEhlYWRlckZp ZWxkKEhUVFBIZWFkZXJOYW1lOjpPcmlnaW4pLmlzTnVsbCgpIHx8IGxvYWRQYXJhbWV0ZXJzLnJl cXVlc3QuaHR0cEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpPcmlnaW4pID09IGxvYWRQYXJh bWV0ZXJzLnNvdXJjZU9yaWdpbi0+dG9TdHJpbmcoKSk7CiAgICAgbG9hZFBhcmFtZXRlcnMuc2Vz c2lvbklEID0gd2ViUGFnZSA/IHdlYlBhZ2UtPnNlc3Npb25JRCgpIDogUEFMOjpTZXNzaW9uSUQ6 OmRlZmF1bHRTZXNzaW9uSUQoKTsKICAgICBsb2FkUGFyYW1ldGVycy5hbGxvd1N0b3JlZENyZWRl bnRpYWxzID0gb3B0aW9ucy5jcmVkZW50aWFscyA9PSBGZXRjaE9wdGlvbnM6OkNyZWRlbnRpYWxz OjpPbWl0ID8gRG9Ob3RBbGxvd1N0b3JlZENyZWRlbnRpYWxzIDogQWxsb3dTdG9yZWRDcmVkZW50 aWFsczsKICAgICBsb2FkUGFyYW1ldGVycy5tb2RlID0gb3B0aW9ucy5tb2RlOwogICAgIGxvYWRQ YXJhbWV0ZXJzLnNob3VsZEZvbGxvd1JlZGlyZWN0cyA9IG9wdGlvbnMucmVkaXJlY3QgPT0gRmV0 Y2hPcHRpb25zOjpSZWRpcmVjdDo6Rm9sbG93OwogICAgIGxvYWRQYXJhbWV0ZXJzLnNob3VsZENs ZWFyUmVmZXJyZXJPbkhUVFBTVG9IVFRQUmVkaXJlY3QgPSBuZXR3b3JraW5nQ29udGV4dC0+c2hv dWxkQ2xlYXJSZWZlcnJlck9uSFRUUFNUb0hUVFBSZWRpcmVjdCgpOwogICAgIGlmICghZG9jdW1l bnQtPnNob3VsZEJ5cGFzc01haW5Xb3JsZENvbnRlbnRTZWN1cml0eVBvbGljeSgpKSB7Ci0gICAg ICAgIGlmIChhdXRvICogY29udGVudFNlY3VyaXR5UG9saWN5ID0gZG9jdW1lbnQtPmNvbnRlbnRT ZWN1cml0eVBvbGljeSgpKQorICAgICAgICBpZiAoYXV0byogY29udGVudFNlY3VyaXR5UG9saWN5 ID0gZG9jdW1lbnQtPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpKQogICAgICAgICAgICAgbG9hZFBh cmFtZXRlcnMuY3NwUmVzcG9uc2VIZWFkZXJzID0gY29udGVudFNlY3VyaXR5UG9saWN5LT5yZXNw b25zZUhlYWRlcnMoKTsKICAgICB9CiAK