175814 2017-08-21 23:53:48 -0700 [GTK][WPE] Rename StorageProcessMainGtk.cpp to StorageProcessMainGLib.cpp 2017-08-22 02:15:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan buildbot gyuyoung.kim webkit-bug-importer oldest_to_newest 1340977 0 zan 2017-08-21 23:53:48 -0700 [GTK][WPE] Rename StorageProcessMainGtk.cpp to StorageProcessMainGLib.cpp 1340978 1 318743 zan 2017-08-21 23:55:44 -0700 Created attachment 318743 Patch 1340979 2 buildbot 2017-08-21 23:58:03 -0700 Attachment 318743 did not pass style-queue: ERROR: Source/WebKit/StorageProcess/glib/StorageProcessMainGLib.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/glib/StorageProcessMainGLib.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1340980 3 318743 gyuyoung.kim 2017-08-22 00:02:55 -0700 Comment on attachment 318743 Patch This patch is just for refactoring. r=me. 1341005 4 318743 zan 2017-08-22 02:13:49 -0700 Comment on attachment 318743 Patch Clearing flags on attachment: 318743 Committed r221007: <http://trac.webkit.org/changeset/221007> 1341006 5 zan 2017-08-22 02:13:53 -0700 All reviewed patches have been landed. Closing bug. 1341007 6 webkit-bug-importer 2017-08-22 02:15:00 -0700 <rdar://problem/34009486> 318743 2017-08-21 23:55:44 -0700 2017-08-22 02:13:49 -0700 Patch bug-175814-20170822085543.patch text/plain 6383 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ4YzM3OTU2YmY0NDQzODYz NzQ0NjQwZjI4MDlkYjZmOTFlMzU3YjEuLjk3Y2EyYTU2ODM5NjIyYzg4MDc1NjE0YzU2ZDEyMmRm NjZmMjVkYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDgtMjEgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gUmVuYW1l IFN0b3JhZ2VQcm9jZXNzTWFpbkd0ay5jcHAgdG8gU3RvcmFnZVByb2Nlc3NNYWluR0xpYi5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTgxNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJvdGggR1RL KyBhbmQgV1BFIHBvcnRzIGFscmVhZHkgY29tcGlsZSB0aGUgU3RvcmFnZVByb2Nlc3NNYWluR3Rr LmNwcAorICAgICAgICBmaWxlLCBidXQgaXQgc2hvdWxkIGJlIHJlbmFtZWQgdG8gU3RvcmFnZVBy b2Nlc3NNYWluR0xpYiBhbmQgbW92ZWQgaW50bworICAgICAgICB0aGUgU3RvcmFnZVByb2Nlc3Mv Z2xpYi8gZGlyZWN0b3J5LgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisgICAgICAg ICogUGxhdGZvcm1XUEUuY21ha2U6CisgICAgICAgICogU3RvcmFnZVByb2Nlc3MvZ2xpYi9TdG9y YWdlUHJvY2Vzc01haW5HTGliLmNwcDogUmVuYW1lZCBmcm9tIFNvdXJjZS9XZWJLaXQvU3RvcmFn ZVByb2Nlc3MvZ3RrL1N0b3JhZ2VQcm9jZXNzTWFpbkd0ay5jcHAuCisKIDIwMTctMDgtMjEgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQmVhY29uXSBDb250ZW50 IGV4dGVuc2lvbnMgc2hvdWxkIGJlIGFibGUgdG8gaW50ZXJjZXB0IEJlYWNvbiAvIFBpbmcgcmVk aXJlY3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291 cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAzZjNkZTYwOTJlYTg0YWY0NGY4NTAz OWM0NzVkMDQ4MTIwNmM5MGMyLi5kMzQzZTZmZmM4M2Q0OWJiMzJjMjJkYzc5YzRhOGNjNWMzNGY5 ZjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTk5LDcgKzk5LDcgQEAgbGlzdChBUFBF TkQgV2ViS2l0Ml9TT1VSQ0VTCiAKICAgICBTaGFyZWQvdW5peC9DaGlsZFByb2Nlc3NNYWluLmNw cAogCi0gICAgU3RvcmFnZVByb2Nlc3MvZ3RrL1N0b3JhZ2VQcm9jZXNzTWFpbkd0ay5jcHAKKyAg ICBTdG9yYWdlUHJvY2Vzcy9nbGliL1N0b3JhZ2VQcm9jZXNzTWFpbkdMaWIuY3BwCiAKICAgICBV SVByb2Nlc3MvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYVByb3h5LmNwcAogICAgIFVJUHJvY2Vzcy9C YWNraW5nU3RvcmUuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNt YWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCAxOTlmMGM1NWVmYTc0 MjdlODU0N2M2NmI0ZmI4YzMzOWE2ZDIwODU5Li5hNThjMDVjZTA2ZjY0ODU2ZGNlYjUwN2I2OGVh YTM1NWU2NDA5NDljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtl CisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTEyMCw2ICsxMjAsOCBA QCBsaXN0KEFQUEVORCBXZWJLaXQyX1NPVVJDRVMKICAgICBTaGFyZWQvd3BlL1Byb2Nlc3NFeGVj dXRhYmxlUGF0aFdQRS5jcHAKICAgICBTaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAKIAor ICAgIFN0b3JhZ2VQcm9jZXNzL2dsaWIvU3RvcmFnZVByb2Nlc3NNYWluR0xpYi5jcHAKKwogICAg IFVJUHJvY2Vzcy9BY2NlbGVyYXRlZERyYXdpbmdBcmVhUHJveHkuY3BwCiAgICAgVUlQcm9jZXNz L0JhY2tpbmdTdG9yZS5jcHAKICAgICBVSVByb2Nlc3MvRGVmYXVsdFVuZG9Db250cm9sbGVyLmNw cApAQCAtMjYxLDkgKzI2Myw2IEBAIGxpc3QoQVBQRU5EIFdlYktpdDJfU09VUkNFUwogICAgIFdl YlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAKIAogICAgIFdlYlByb2Nlc3Mvd3BlL1dl YlByb2Nlc3NNYWluV1BFLmNwcAotCi0gICAgIyBGSVhNRS1HV1NIQVJFOgotICAgIFN0b3JhZ2VQ cm9jZXNzL2d0ay9TdG9yYWdlUHJvY2Vzc01haW5HdGsuY3BwCiApCiAKIGxpc3QoQVBQRU5EIFdl YktpdDJfTUVTU0FHRVNfSU5fRklMRVMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU3RvcmFn ZVByb2Nlc3MvZ2xpYi9TdG9yYWdlUHJvY2Vzc01haW5HTGliLmNwcCBiL1NvdXJjZS9XZWJLaXQv U3RvcmFnZVByb2Nlc3MvZ2xpYi9TdG9yYWdlUHJvY2Vzc01haW5HTGliLmNwcApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5iYzE4NDc4N2U5YjlkYjFmZDA5MDNhMTdiMjEyZjhjZmEwMzY1ZmI5Ci0tLSAvZGV2L251bGwK KysrIGIvU291cmNlL1dlYktpdC9TdG9yYWdlUHJvY2Vzcy9nbGliL1N0b3JhZ2VQcm9jZXNzTWFp bkdMaWIuY3BwCkBAIC0wLDAgKzEsMzkgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTUgSWdh bGlhIFMuTC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAq IDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUg Y29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZv cm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQor ICogICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGgg dGhlIGRpc3RyaWJ1dGlvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQ UExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnCisgKiBBTkQgQU5ZIEVYUFJF U1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywK KyAqIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNT IEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5U IFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUworICogQkUgTElBQkxFIEZPUiBB TlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUgor ICogQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywg UFJPQ1VSRU1FTlQgT0YKKyAqIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0Yg VVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUworICogSU5URVJSVVBUSU9OKSBIT1dF VkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4KKyAq IENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5D RSBPUiBPVEhFUldJU0UpCisgKiBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0Yg VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GCisgKiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlN0b3Jh Z2VQcm9jZXNzTWFpblVuaXguaCIKKworI2luY2x1ZGUgIkNoaWxkUHJvY2Vzc01haW4uaCIKKyNp bmNsdWRlICJTdG9yYWdlUHJvY2Vzcy5oIgorCituYW1lc3BhY2UgV2ViS2l0IHsKKworaW50IFN0 b3JhZ2VQcm9jZXNzTWFpblVuaXgoaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQoreworICAgIHJldHVy biBDaGlsZFByb2Nlc3NNYWluPFN0b3JhZ2VQcm9jZXNzLCBDaGlsZFByb2Nlc3NNYWluQmFzZT4o YXJnYywgYXJndik7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9TdG9yYWdlUHJvY2Vzcy9ndGsvU3RvcmFnZVByb2Nlc3NNYWluR3RrLmNwcCBi L1NvdXJjZS9XZWJLaXQvU3RvcmFnZVByb2Nlc3MvZ3RrL1N0b3JhZ2VQcm9jZXNzTWFpbkd0ay5j cHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGJjMTg0Nzg3ZTliOWRiMWZkMDkwM2Ex N2IyMTJmOGNmYTAzNjVmYjkuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAKLS0tIGEvU291cmNlL1dlYktpdC9TdG9yYWdlUHJvY2Vzcy9ndGsvU3RvcmFnZVByb2Nlc3NN YWluR3RrLmNwcAorKysgL2Rldi9udWxsCkBAIC0xLDM5ICswLDAgQEAKLS8qCi0gKiBDb3B5cmln aHQgKEMpIDIwMTUgSWdhbGlhIFMuTC4KLSAqCi0gKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGlu IHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKLSAqIG1vZGlmaWNhdGlv biwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwot ICogYXJlIG1ldDoKLSAqIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAyLiBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAotICog ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyIGluIHRoZQotICogICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxz IHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElT IFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnCi0g KiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBO T1QgTElNSVRFRCBUTywKLSAqIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklM SVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJU0NMQUlN RUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUwotICog QkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwg RVhFTVBMQVJZLCBPUgotICogQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBO T1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YKLSAqIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS VklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUwotICogSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFks IFdIRVRIRVIgSU4KLSAqIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJTkNM VURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpCi0gKiBBUklTSU5HIElOIEFOWSBXQVkgT1VU IE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GCi0gKiBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCi0gKi8KLQotI2luY2x1ZGUgImNvbmZpZy5oIgot I2luY2x1ZGUgIlN0b3JhZ2VQcm9jZXNzTWFpblVuaXguaCIKLQotI2luY2x1ZGUgIkNoaWxkUHJv Y2Vzc01haW4uaCIKLSNpbmNsdWRlICJTdG9yYWdlUHJvY2Vzcy5oIgotCi1uYW1lc3BhY2UgV2Vi S2l0IHsKLQotaW50IFN0b3JhZ2VQcm9jZXNzTWFpblVuaXgoaW50IGFyZ2MsIGNoYXIqKiBhcmd2 KQotewotICAgIHJldHVybiBDaGlsZFByb2Nlc3NNYWluPFN0b3JhZ2VQcm9jZXNzLCBDaGlsZFBy b2Nlc3NNYWluQmFzZT4oYXJnYywgYXJndik7Ci19Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYktpdAo=