175809 2017-08-21 19:57:13 -0700 Make generate_offset_extractor.rb architectures argument more robust 2017-08-21 20:20:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller buildbot joepeck mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1340932 0 keith_miller 2017-08-21 19:57:13 -0700 Make generate_offset_extractor.rb architetures argument more robust 1340933 1 318726 keith_miller 2017-08-21 19:59:23 -0700 Created attachment 318726 Patch 1340934 2 318726 joepeck 2017-08-21 20:04:16 -0700 Comment on attachment 318726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318726&action=review > Source/JavaScriptCore/ChangeLog:3 > + Make generate_offset_extractor.rb architetures argument more robust Typo in bug name: architetures > Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:42 > -validBackends = canonicalizeBackendNames(ARGV.shift.split(",")) > +validBackends = canonicalizeBackendNames(ARGV.shift.split(/,+\s*|\s+/)) How about: /[,\s]+/ This to require any combination of spaces and commas. Your regex supports leading commands and trailing whitespace but not emptiness in-between, which seems weird. 1340935 3 318726 keith_miller 2017-08-21 20:06:57 -0700 Comment on attachment 318726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318726&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + Make generate_offset_extractor.rb architetures argument more robust > > Typo in bug name: architetures Whoops fixed. >> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:42 >> +validBackends = canonicalizeBackendNames(ARGV.shift.split(/,+\s*|\s+/)) > > How about: > > /[,\s]+/ > > This to require any combination of spaces and commas. Your regex supports leading commands and trailing whitespace but not emptiness in-between, which seems weird. Yeah, that's a better Regex! I'll change. 1340936 4 keith_miller 2017-08-21 20:19:55 -0700 Committed r221000: <http://trac.webkit.org/changeset/221000> 1340937 5 webkit-bug-importer 2017-08-21 20:20:57 -0700 <rdar://problem/34006009> 318726 2017-08-21 19:59:23 -0700 2017-08-21 20:04:16 -0700 Patch bug-175809-20170821195923.patch text/plain 1732 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwOTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 ODZjYmVkZWFmY2I0MmIwYWUyNDUxNjI3NDNhMzQ1YjhhZmUzYTMxLi5kNDEzYWNkMjU1ZmI4YmZl MjE5MzU0MmQ5ODAyODNlOTFmZTRiYmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNy0wOC0yMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBNYWtlIGdlbmVyYXRlX29mZnNldF9leHRyYWN0b3IucmIgYXJjaGl0 ZXR1cmVzIGFyZ3VtZW50IG1vcmUgcm9idXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU4MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCBzb21lIG9mIG91ciBidWlsZGVy cyBwYXNzIHRoZWlyIGFyY2hpdGVjdHVyZXMgYXMKKyAgICAgICAgc3BhY2Ugc2VwYXJhdGVkIGxp c3RzLiAgSSBkZWNpZGVkIHRvIGp1c3QgbWFrZSB0aGUgc3BsaXR0aW5nIG9mCisgICAgICAgIG91 ciBsaXN0IHJvYnVzdCB0byBhbnkgcmVhc29uYWJsZSBjb21iaW5hdGlvbiBvZiBzcGFjZXMgYW5k CisgICAgICAgIGNvbW1hcy4KKworICAgICAgICAqIG9mZmxpbmVhc20vZ2VuZXJhdGVfb2Zmc2V0 X2V4dHJhY3Rvci5yYjoKKworMjAxNy0wOC0yMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVy QGFwcGxlLmNvbT4KKwogICAgICAgICBPbmx5IGdlbmVyYXRlIG9mZmxpbmUgYXNtIGZvciB0aGUg QVJDSFMgKHhjb2RlYnVpbGQpIG9yIHRoZSBjdXJyZW50IHN5c3RlbSAoQ01ha2UpCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU2OTAKIApkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2VuZXJhdGVfb2Zmc2V0X2V4 dHJhY3Rvci5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29m ZnNldF9leHRyYWN0b3IucmIKaW5kZXggMWNjNTRjMTg5ZDQ1NjczODdmMzAzNzdhOWE3MTBhNzg4 ZDY3OTY4Ni4uZDhlOGVjMGMxYjY4ZGJkNTFhZmM2MzUxZWU2ZmY3OWViM2Q2ZGZkMSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2VuZXJhdGVfb2Zmc2V0X2V4 dHJhY3Rvci5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9nZW5lcmF0 ZV9vZmZzZXRfZXh0cmFjdG9yLnJiCkBAIC0zOSw3ICszOSw3IEBAIEluY2x1ZGVGaWxlLnByb2Nl c3NJbmNsdWRlT3B0aW9ucygpCiBpbnB1dEZsbm0gPSBBUkdWLnNoaWZ0CiBvdXRwdXRGbG5tID0g QVJHVi5zaGlmdAogCi12YWxpZEJhY2tlbmRzID0gY2Fub25pY2FsaXplQmFja2VuZE5hbWVzKEFS R1Yuc2hpZnQuc3BsaXQoIiwiKSkKK3ZhbGlkQmFja2VuZHMgPSBjYW5vbmljYWxpemVCYWNrZW5k TmFtZXMoQVJHVi5zaGlmdC5zcGxpdCgvLCtccyp8XHMrLykpCiAkc3RkZXJyLnB1dHMgIk9ubHkg ZGVhbGluZyB3aXRoIGJhY2tlbmRzOiAje3ZhbGlkQmFja2VuZHN9IgogaW5jbHVkZU9ubHlCYWNr ZW5kcyh2YWxpZEJhY2tlbmRzKQogCg==