175799 2017-08-21 17:19:59 -0700 [WPE][GTK] Unused variables in UserMediaProcessManager.cpp 2017-08-21 18:15:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen commit-queue darin mcatanzaro webkit-bug-importer oldest_to_newest 1340855 0 aperez 2017-08-21 17:19:59 -0700 Building the GTK+ port (or the WPE one) with Clang results in: ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:33:26: warning: unused variable 'audioExtensionPath' [-Wunused-const-variable] static const char* const audioExtensionPath = "com.apple.webkit.microphone"; ^ ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:34:26: warning: unused variable 'videoExtensionPath' [-Wunused-const-variable] static const char* const videoExtensionPath = "com.apple.webkit.camera"; ^ 2 warnings generated. These variables should be guarded by “#if ENABLE(SANDBOX_EXTENSIONS)”. 1340859 1 318704 aperez 2017-08-21 17:23:56 -0700 Created attachment 318704 Patch 1340896 2 318704 commit-queue 2017-08-21 18:14:18 -0700 Comment on attachment 318704 Patch Clearing flags on attachment: 318704 Committed r220995: <http://trac.webkit.org/changeset/220995> 1340897 3 commit-queue 2017-08-21 18:14:19 -0700 All reviewed patches have been landed. Closing bug. 1340898 4 webkit-bug-importer 2017-08-21 18:15:28 -0700 <rdar://problem/34004298> 318704 2017-08-21 17:23:56 -0700 2017-08-21 18:14:18 -0700 Patch bug-175799-20170822032354.patch text/plain 1468 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU4MzBlYmI5MDVhZDYwOTkx NTI1Nzc2MjllNzJiZjJjYWJmZDUwOTAuLjExZTk1YWI2ZjkzOGU2YzE1Y2UwYTA3ZDA0YzJhNTQ1 MmE4YTQ5OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDgtMjEgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtd IFVudXNlZCB2YXJpYWJsZXMgaW4gVXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU3OTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29kZSB3aGljaCB1 c2VzIHRoZSAiYXVkaW9FeHRlbnNpb25QYXRoIiBhbmQgInZpZGVvRXh0ZW5zaW9uUGF0aCIgdmFy aWFibGVzIGlzIGd1YXJkZWQKKyAgICAgICAgd2l0aCAiI2lmIEVOQUJMRShTQU5EQk9YX0VYVEVO U0lPTlMp4oCdLCBzbyBkbyB0aGUgc2FtZSBmb3IgdGhlIHZhcmlhYmxlcyB0aGVtc2VsdmVzLgor CisgICAgICAgICogVUlQcm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcDogQWRkIG1p c3NpbmcgZ3VhcmRzLgorCiAyMDE3LTA4LTIxICBZb3NoaWFraSBKaXRzdWthd2EgIDxZb3NoaWFr aS5KaXRzdWthd2FAc29ueS5jb20+CiAKICAgICAgICAgW1BBTF0gTW92ZSBzcGkvbWFjIGRpcmVj dG9yeSBpbnRvIFBBTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1l ZGlhUHJvY2Vzc01hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlh UHJvY2Vzc01hbmFnZXIuY3BwCmluZGV4IDk3NzcxY2ZhNGE0NTc1MzE3M2IzMzgwYmJkZTljODUw Yjc1ZTAzZTkuLjg5MjI0YzQyZGYwZjBmMGE0NTNlZDllZDEwNjY4OWNiNjFmY2U5ZGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQcm9jZXNzTWFuYWdlci5j cHAKQEAgLTMwLDggKzMwLDEwIEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCisjaWYgRU5BQkxF KFNBTkRCT1hfRVhURU5TSU9OUykKIHN0YXRpYyBjb25zdCBjaGFyKiBjb25zdCBhdWRpb0V4dGVu c2lvblBhdGggPSAiY29tLmFwcGxlLndlYmtpdC5taWNyb3Bob25lIjsKIHN0YXRpYyBjb25zdCBj aGFyKiBjb25zdCB2aWRlb0V4dGVuc2lvblBhdGggPSAiY29tLmFwcGxlLndlYmtpdC5jYW1lcmEi OworI2VuZGlmCiAKIGNsYXNzIFByb2Nlc3NTdGF0ZSB7CiBwdWJsaWM6Cg==