175780 2017-08-21 12:27:24 -0700 [GTK][WPE][GSTREAMER_GL] Overriden virtual function not marked “override” in MediaPlayerPrivateGStreamerBase.h 2022-02-28 04:10:19 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez annulen calvaris cgarcia thorton webkit-bug-importer zan oldest_to_newest 1340701 0 aperez 2017-08-21 12:27:24 -0700 The following warning is generated when building with Clang: In file included from ../../Source/WebCore/platform/graphics/MediaPlayer.cpp:55: In file included from ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:30: ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:152:45: warning: 'proxy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] RefPtr<TextureMapperPlatformLayerProxy> proxy() const; ^ ../../Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h:36:53: note: overridden virtual function is here virtual RefPtr<TextureMapperPlatformLayerProxy> proxy() const = 0; ^ 1340704 1 318660 aperez 2017-08-21 12:29:05 -0700 Created attachment 318660 Patch 1340706 2 318660 annulen 2017-08-21 12:40:44 -0700 Comment on attachment 318660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318660&action=review > Source/WebCore/ChangeLog:3 > + [GTK][WPE][GSTREAMER_GL] [GTK][WPE] Overriden virtual function not marked “override” in MediaPlayerPrivateGStreamerBase.h ETOOMANYTAGS 1340715 3 aperez 2017-08-21 13:04:29 -0700 (In reply to Konstantin Tokarev from comment #2) > Comment on attachment 318660 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318660&action=review > > > Source/WebCore/ChangeLog:3 > > + [GTK][WPE][GSTREAMER_GL] [GTK][WPE] Overriden virtual function not marked âoverrideâ in MediaPlayerPrivateGStreamerBase.h > > ETOOMANYTAGS Ouch, I'll remove the extra tags before landing. Thanks! 1340719 4 aperez 2017-08-21 13:17:00 -0700 Committed r220978: <http://trac.webkit.org/changeset/220978> 1340720 5 webkit-bug-importer 2017-08-21 13:17:44 -0700 <rdar://problem/33997746> 318660 2017-08-21 12:29:05 -0700 2022-02-28 04:10:19 -0800 Patch bug-175780-20170821222904.patch text/plain 1549 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwOTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzVmNjZlNGVlMDg4Nzdk YTJmYjkyNWU0MDdhYWM5OWI5MWRlMjM5Ny4uYjRhYWViN2JkMWQyNjhiM2E4Mzc0NjJjZDUyYmFk ZDM2NGJhN2I3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA4LTIxICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V1BFXVtHU1RSRUFNRVJfR0xdIFtHVEtdW1dQRV0gT3ZlcnJpZGVuIHZpcnR1YWwgZnVuY3Rpb24g bm90IG1hcmtlZCDigJxvdmVycmlkZeKAnSBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NTc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2UuaDogQWRkIG1pc3NpbmcgIm92ZXJyaWRlIiBxdWFsaWZpZXIuCisKIDIwMTctMDgtMjEgIEFu ZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtQYXltZW50IFJlcXVlc3Rd IEltcGxlbWVudCB0aGUgUGF5bWVudFJlcXVlc3QgY29uc3RydWN0b3IKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCmluZGV4IGI4YzE1Y2VjOTg5 M2Q1ZTgwYjQ1NGE5ZmQwY2Y1ZTgxZTBmMTc1MTYuLmE3ODBkZWU5OTAzODVjMmQ4YWM2YTUyNTZm NzczZWRhY2U1ZjRiN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lckJhc2UuaApAQCAtMTQ5LDcgKzE0OSw3IEBAIHByb3RlY3RlZDoKIAogI2lmIFVT RShURVhUVVJFX01BUFBFUl9HTCkKICAgICB2b2lkIHVwZGF0ZVRleHR1cmUoQml0bWFwVGV4dHVy ZUdMJiwgR3N0VmlkZW9JbmZvJik7Ci0gICAgUmVmUHRyPFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxh eWVyUHJveHk+IHByb3h5KCkgY29uc3Q7CisgICAgUmVmUHRyPFRleHR1cmVNYXBwZXJQbGF0Zm9y bUxheWVyUHJveHk+IHByb3h5KCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdm9pZCBzd2FwQnVmZmVy c0lmTmVlZGVkKCkgb3ZlcnJpZGU7CiAgICAgdm9pZCBwdXNoVGV4dHVyZVRvQ29tcG9zaXRvcigp OwogI2VuZGlmCg==