175768 2017-08-21 07:01:52 -0700 media-captions.html improvements 2017-08-21 08:45:37 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Ms2ger Ms2ger commit-queue eric.carlson jer.noble lforschler webkit-bug-importer oldest_to_newest 1340585 0 Ms2ger 2017-08-21 07:01:52 -0700 . 1340586 1 318630 Ms2ger 2017-08-21 07:04:32 -0700 Created attachment 318630 Patch 1340587 2 Ms2ger 2017-08-21 07:04:46 -0700 For the record, the failure on GTK is --- media-captions-expected.txt +++ media-captions-actual.txt @@ -18,10 +18,10 @@ EVENT(loadstart) EVENT(durationchange) EVENT(canplaythrough) -EXPECTED (mediaElement.webkitHasClosedCaptions == 'true') OK +EXPECTED (mediaElement.webkitHasClosedCaptions == 'true'), OBSERVED 'false' FAIL EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'false') OK *** enabling captions -EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'true') OK +EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'true'), OBSERVED 'false' FAIL END OF TEST 1340598 3 318630 commit-queue 2017-08-21 08:44:31 -0700 Comment on attachment 318630 Patch Clearing flags on attachment: 318630 Committed r220965: <http://trac.webkit.org/changeset/220965> 1340599 4 commit-queue 2017-08-21 08:44:33 -0700 All reviewed patches have been landed. Closing bug. 1340600 5 webkit-bug-importer 2017-08-21 08:45:37 -0700 <rdar://problem/33992226> 318630 2017-08-21 07:04:32 -0700 2017-08-21 08:44:31 -0700 Patch bug-175768-20170821160430.patch text/plain 1872 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwOTY0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmY4MjM5MWRhYTgxNTdjODEzODk5 NTE4NTY0MmU4MDhhMzI0NmNkMC4uMWE1ZmUxNjgzMWRlYjQ2ZmZiZmY3ZjYwZmU3YWQxMjhiMGI3 MWNkZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA4LTIxICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KKworICAgICAgICBtZWRpYS1jYXB0aW9ucy5odG1sIGltcHJvdmVtZW50cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NzY4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRpYS9t ZWRpYS1jYXB0aW9ucy5odG1sOiByZW1vdmUgcmVmZXJlbmNlIHRvIHVudXNlZCBzY3JpcHQgZmls ZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogcmVtb3ZlIFRpbWVv dXQsIENyYXNoIGFubm90YXRpb25zLgorCiAyMDE3LTA4LTIxICBNczJnZXIgIDxNczJnZXJAZ21h aWwuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbW92ZSBzb21lIG9sZCBmbGFreSBjcmFzaCBleHBl Y3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jYXB0aW9ucy5o dG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY2FwdGlvbnMuaHRtbAppbmRleCA4NmFlZWMw M2VkZTU4MmQ5Y2IzNmQ4MDQ5YzNmNjVlYTI4YWU5NTQ2Li5lZWMxZDAzOGRjYWE1NTNhYmVjODBk MjAxNTRiNTIyZjIwN2I0NDU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1j YXB0aW9ucy5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWNhcHRpb25zLmh0bWwK QEAgLTQsNyArNCw2IEBACiAgICAgICAgIDx0aXRsZT5jbG9zZWQgY2FwdGlvbiBBUEkgdGVzdDwv dGl0bGU+CiAKICAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KLSAg ICAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZnVsbHNjcmVlbi5qcz48L3NjcmlwdD4KIAogICAgICAg ICA8c2NyaXB0PgogICAgICAgICAgICAgdmFyIG1vdmllSW5mbyA9IApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlZWMxNDg0NjVmY2E0YjQyOTA0ZDAwODVi OGE3ODZjMjI5YmI5OWU2Li4xMWE3OTNiZTA1NTRkNWUyYWQ0YTZmMTViOGI4MGFjMzEzNjAwNmU0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTU0LDcg KzE1NCw3IEBAIHN2Zy9jdXN0b20vaW1hZ2Utd2l0aC1wcmVmaXgtaW4td2ViYXJjaGl2ZS5zdmcg WyBXb250Rml4IF0KIG1lZGlhL3ZpZGVvLWRvZXMtbm90LWxvb3AuaHRtbCBbIFdvbnRGaXggVGlt ZW91dCBdCiAKICMgUmVxdWlyZXMgbWVkaWEgZW5naW5lIGNsb3NlZCBjYXB0aW9uIHN1cHBvcnQu Ci1tZWRpYS9tZWRpYS1jYXB0aW9ucy5odG1sIFsgV29udEZpeCBUaW1lb3V0IEZhaWx1cmUgQ3Jh c2ggXQorbWVkaWEvbWVkaWEtY2FwdGlvbnMuaHRtbCBbIFdvbnRGaXggRmFpbHVyZSBdCiAKICMg TGVnYWN5IGZ1bGwgc2NyZWVuIEFQSSB0ZXN0cyBhcmUgbm93IG9ic29sZXRlLgogIyBUaGlzIHBh c3NlcyB3aGlsZSBpdCdzIG1hcmtlZCBhcyBhIFdvbnRGaXggLSBjaGVjayBpdC4K