175751 2017-08-18 20:42:20 -0700 Forbid setDragImage after dragstart 2017-08-18 23:41:09 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa buildbot cdumez commit-queue dbates esprehn+autocc kangil.han megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1340371 0 rniwa 2017-08-18 20:42:20 -0700 Right now, WebKit allows setting the drag image after dragstart had happened. However, this doesn't work in WebKit2, and it's pretty much broken in WebKit1, and doesn't match the spec or the behaviors of Chrome and Firefox. Remove this broken feature. 1340380 1 318581 rniwa 2017-08-18 21:35:50 -0700 Created attachment 318581 Removes the code 1340386 2 318581 wenson_hsieh 2017-08-18 22:55:05 -0700 Comment on attachment 318581 Removes the code r=me. A bit sad this was never tested at all :( 1340388 3 318581 commit-queue 2017-08-18 23:40:33 -0700 Comment on attachment 318581 Removes the code Clearing flags on attachment: 318581 Committed r220951: <http://trac.webkit.org/changeset/220951> 1340389 4 commit-queue 2017-08-18 23:40:35 -0700 All reviewed patches have been landed. Closing bug. 1340390 5 webkit-bug-importer 2017-08-18 23:41:09 -0700 <rdar://problem/33977048> 318581 2017-08-18 21:35:50 -0700 2017-08-18 23:40:33 -0700 Removes the code bug-175751-20170818213549.patch text/plain 5025 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDk1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDE3LTA4LTE4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEZvcmJpZCBzZXREcmFnSW1hZ2Ug YWZ0ZXIgZHJhZ3N0YXJ0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzU3NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmVkIHRoZSBjb2RlIHRvIGFsbG93IHNldHRpbmcgdGhlIGRyYWcgbWFnZSBh ZnRlciBkcmFnc3RhcnQgaGFkIGhhcHBlbmVkLgorCisgICAgICAgIFRoZSBmZWF0dXJlIHdhcyBh cHBhcmVudGx5IHVzZWQgaW4gTWFjIFdlYktpdDEgcG9ydCBidXQgdXNpbmcgaXQgdG9kYXkgY2F1 c2VzIHRoZSBkcmFnIGltYWdlCisgICAgICAgIHRvIGRpc2FwZXBhciB3aGlsZSB0aGUgdXNlciBp cyBtb3ZpbmcgdGhlIG1vdXNlIGN1cnNvciBhbmQgYmVpbmcgZHJhd24gb25jZSBpdCdzIHN0b3Bw ZWQKKyAgICAgICAgYW5kIHJlc3VsdHMgaW4gdGhlIGNvbnRpb251cyBmbGlja2VyaW5nIG9mIHRo ZSBkcmFnIGltYWdlLgorCisgICAgICAgIFRoZSBmZWF1cmUgd2FzIG5ldmVyIHN1cHBvcnRlZCBp biBXZWJLaXQyIGFuZCBkb2Vzbid0IG1hdGNoIHRoZSBIVE1MNSBzcGVjaWZpY2F0aW9uOgorICAg ICAgICBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9kbmQuaHRtbCNjb25j ZXB0LWRuZC1ydworICAgICAgICBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFn ZS9kbmQuaHRtbCNkb20tZGF0YXRyYW5zZmVyLXNldGRyYWdpbWFnZQorICAgICAgICBvciB0aGUg YmVoYXZpb3JzIG9mIG90aGVyIGJyb3dzZXJzIHN1Y2ggYXMgQ2hyb21lIGFuZCBGaXJlZm94Lgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBzaW1wbHkgcmVtb3ZlcyBjb2RlLgor CisgICAgICAgICogZG9tL0RhdGFUcmFuc2Zlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRh VHJhbnNmZXI6OnNldERyYWdJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpEYXRhVHJhbnNmZXI6 OmNhblNldERyYWdJbWFnZSBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgICogZG9tL0RhdGFUcmFu c2Zlci5oOgorICAgICAgICAoV2ViQ29yZTo6RGF0YVRyYW5zZmVyOjptYWtlRHJhZ0ltYWdlV3Jp dGFibGUpOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlRHJhZyk6CisKIDIwMTctMDgtMTggIFNh bSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbV2ViQ3J5cHRvXSBHZXQgcmlk IG9mIENyeXB0b0tleURhdGEgY2xhc3MgYW5kIGFsbCBpdHMgc3ViY2xhc3NlcwpJbmRleDogU291 cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5jcHAJKHJldmlzaW9uIDIyMDkzNSkKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9EYXRhVHJhbnNmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYsMTggKzI0 Niw5IEBAIFJlZjxEYXRhVHJhbnNmZXI+IERhdGFUcmFuc2Zlcjo6Y3JlYXRlRm8KICAgICByZXR1 cm4gYWRvcHRSZWYoKm5ldyBEYXRhVHJhbnNmZXIoYWNjZXNzTW9kZSwgUGFzdGVib2FyZDo6Y3Jl YXRlRm9yRHJhZ0FuZERyb3AoZHJhZ0RhdGEpLCB0eXBlKSk7CiB9CiAKLWJvb2wgRGF0YVRyYW5z ZmVyOjpjYW5TZXREcmFnSW1hZ2UoKSBjb25zdAotewotICAgIC8vIE5vdGUgdGhhdCB0aGUgc3Bl YyBkb2Vzbid0IGFjdHVhbGx5IGFsbG93IGRyYWcgaW1hZ2UgbW9kaWZpY2F0aW9uIG91dHNpZGUg dGhlIGRyYWdzdGFydAotICAgIC8vIGV2ZW50LiBUaGlzIGNhcGFiaWxpdHkgaXMgbWFpbnRhaW5l ZCBmb3IgYmFja3dhcmRzIGNvbXBhdGlibGl0eSBmb3IgcG9ydHMgdGhhdCBoYXZlCi0gICAgLy8g c3VwcG9ydGVkIHRoaXMgaW4gdGhlIHBhc3QuIE9uIG1hbnkgcG9ydHMsIGF0dGVtcHRpbmcgdG8g c2V0IGEgZHJhZyBpbWFnZSBvdXRzaWRlIHRoZQotICAgIC8vIGRyYWdzdGFydCBvcGVyYXRpb24g aXMgYSBuby1vcCBhbnl3YXkuCi0gICAgcmV0dXJuIG1fZm9yRHJhZyAmJiAobV9zdG9yZU1vZGUg PT0gU3RvcmVNb2RlOjpEcmFnSW1hZ2VXcml0YWJsZSB8fCBtX3N0b3JlTW9kZSA9PSBTdG9yZU1v ZGU6OlJlYWRXcml0ZSk7Ci19Ci0KIHZvaWQgRGF0YVRyYW5zZmVyOjpzZXREcmFnSW1hZ2UoRWxl bWVudCogZWxlbWVudCwgaW50IHgsIGludCB5KQogewotICAgIGlmICghY2FuU2V0RHJhZ0ltYWdl KCkpCisgICAgaWYgKCFtX2ZvckRyYWcgfHwgIWNhbldyaXRlRGF0YSgpKQogICAgICAgICByZXR1 cm47CiAKICAgICBDYWNoZWRJbWFnZSogaW1hZ2UgPSBudWxscHRyOwpJbmRleDogU291cmNlL1dl YkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Rv bS9EYXRhVHJhbnNmZXIuaAkocmV2aXNpb24gMjIwOTM1KQorKysgU291cmNlL1dlYkNvcmUvZG9t L0RhdGFUcmFuc2Zlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3IEBAIGNsYXNzIFBh c3RlYm9hcmQ7CiBjbGFzcyBEYXRhVHJhbnNmZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxEYXRhVHJh bnNmZXI+IHsKIHB1YmxpYzoKICAgICAvLyBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211 bHRpcGFnZS9kbmQuaHRtbCNkcmFnLWRhdGEtc3RvcmUtbW9kZQotICAgIGVudW0gY2xhc3MgU3Rv cmVNb2RlIHsgSW52YWxpZCwgRHJhZ0ltYWdlV3JpdGFibGUsIFJlYWRXcml0ZSwgUmVhZG9ubHks IFByb3RlY3RlZCB9OworICAgIGVudW0gY2xhc3MgU3RvcmVNb2RlIHsgSW52YWxpZCwgUmVhZFdy aXRlLCBSZWFkb25seSwgUHJvdGVjdGVkIH07CiAKICAgICBzdGF0aWMgUmVmPERhdGFUcmFuc2Zl cj4gY3JlYXRlRm9yQ29weUFuZFBhc3RlKFN0b3JlTW9kZSk7CiAgICAgc3RhdGljIFJlZjxEYXRh VHJhbnNmZXI+IGNyZWF0ZUZvcklucHV0RXZlbnQoY29uc3QgU3RyaW5nJiBwbGFpblRleHQsIGNv bnN0IFN0cmluZyYgaHRtbFRleHQpOwpAQCAtNjgsMTEgKzY4LDYgQEAgcHVibGljOgogICAgIHZv aWQgc2V0RHJhZ0ltYWdlKEVsZW1lbnQqLCBpbnQgeCwgaW50IHkpOwogCiAgICAgdm9pZCBtYWtl SW52YWxpZEZvclNlY3VyaXR5KCkgeyBtX3N0b3JlTW9kZSA9IFN0b3JlTW9kZTo6SW52YWxpZDsg fQotICAgIHZvaWQgbWFrZURyYWdJbWFnZVdyaXRhYmxlKCkKLSAgICB7Ci0gICAgICAgIEFTU0VS VChtX3N0b3JlTW9kZSAhPSBTdG9yZU1vZGU6OkludmFsaWQpOwotICAgICAgICBtX3N0b3JlTW9k ZSA9IFN0b3JlTW9kZTo6RHJhZ0ltYWdlV3JpdGFibGU7Ci0gICAgfQogCiAgICAgYm9vbCBjYW5S ZWFkVHlwZXMoKSBjb25zdDsKICAgICBib29sIGNhblJlYWREYXRhKCkgY29uc3Q7CkBAIC0xMDMs MTAgKzk4LDYgQEAgcHJpdmF0ZToKICAgICBlbnVtIGNsYXNzIFR5cGUgeyBDb3B5QW5kUGFzdGUs IERyYWdBbmREcm9wRGF0YSwgRHJhZ0FuZERyb3BGaWxlcywgSW5wdXRFdmVudCB9OwogICAgIERh dGFUcmFuc2ZlcihTdG9yZU1vZGUsIHN0ZDo6dW5pcXVlX3B0cjxQYXN0ZWJvYXJkPiwgVHlwZSA9 IFR5cGU6OkNvcHlBbmRQYXN0ZSk7CiAKLSNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQotICAgIGJv b2wgY2FuU2V0RHJhZ0ltYWdlKCkgY29uc3Q7Ci0jZW5kaWYKLQogICAgIFN0b3JlTW9kZSBtX3N0 b3JlTW9kZTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UGFzdGVib2FyZD4gbV9wYXN0ZWJvYXJkOwog ICAgIHN0ZDo6dW5pcXVlX3B0cjxEYXRhVHJhbnNmZXJJdGVtTGlzdD4gbV9pdGVtTGlzdDsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDIyMDkzNSkKKysr IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzY4Myw5ICszNjgzLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZURyYWcoY29uc3QgTW91 cwogICAgICAgICBtX21vdXNlRG93bk1heVN0YXJ0RHJhZyA9IGRpc3BhdGNoRHJhZ1NyY0V2ZW50 KGV2ZW50TmFtZXMoKS5kcmFnc3RhcnRFdmVudCwgbV9tb3VzZURvd24pCiAgICAgICAgICAgICAm JiAhbV9mcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKS5pc0luUGFzc3dvcmRGaWVsZCgpOwog Ci0gICAgICAgIC8vIEludmFsaWRhdGUgZGF0YVRyYW5zZmVyIGhlcmUgYWdhaW5zdCBhbnltb3Jl IHBhc3RlYm9hcmQgd3JpdGluZyBmb3Igc2VjdXJpdHkuIFRoZSBkcmFnCi0gICAgICAgIC8vIGlt YWdlIGNhbiBzdGlsbCBiZSBjaGFuZ2VkIGFzIHdlIGRyYWcsIGJ1dCBub3QgdGhlIHBhc3RlYm9h cmQgZGF0YS4KLSAgICAgICAgZHJhZ1N0YXRlKCkuZGF0YVRyYW5zZmVyLT5tYWtlRHJhZ0ltYWdl V3JpdGFibGUoKTsKKyAgICAgICAgZHJhZ1N0YXRlKCkuZGF0YVRyYW5zZmVyLT5tYWtlSW52YWxp ZEZvclNlY3VyaXR5KCk7CiAKICAgICAgICAgaWYgKG1fbW91c2VEb3duTWF5U3RhcnREcmFnKSB7 CiAgICAgICAgICAgICAvLyBHYXRoZXIgdmFsdWVzIGZyb20gREhUTUwgZWxlbWVudCwgaWYgaXQg c2V0IGFueS4K