<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175735</bug_id>
          
          <creation_ts>2017-08-18 13:45:23 -0700</creation_ts>
          <short_desc>Fix leak-checking for iOS Simulators</short_desc>
          <delta_ts>2017-08-22 08:46:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1340216</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-18 13:45:23 -0700</bug_when>
    <thetext>We can&apos;t check leaks for iOS Simulators since we close the process before we check for leaks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340217</commentid>
    <comment_count>1</comment_count>
      <attachid>318537</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-18 13:49:07 -0700</bug_when>
    <thetext>Created attachment 318537
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340302</commentid>
    <comment_count>2</comment_count>
      <attachid>318537</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-18 16:26:43 -0700</bug_when>
    <thetext>Comment on attachment 318537
Patch

Clearing flags on attachment: 318537

Committed r220942: &lt;http://trac.webkit.org/changeset/220942&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340303</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-18 16:26:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340306</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-08-18 16:27:29 -0700</bug_when>
    <thetext>&lt;rdar://problem/33972756&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340848</commentid>
    <comment_count>5</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-21 17:13:04 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340849</commentid>
    <comment_count>6</comment_count>
      <attachid>318700</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-21 17:13:05 -0700</bug_when>
    <thetext>Created attachment 318700
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340872</commentid>
    <comment_count>7</comment_count>
      <attachid>318709</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-21 17:43:55 -0700</bug_when>
    <thetext>Created attachment 318709
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340922</commentid>
    <comment_count>8</comment_count>
      <attachid>318709</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2017-08-21 19:18:29 -0700</bug_when>
    <thetext>Comment on attachment 318709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318709&amp;action=review

r=me

&gt; Tools/Scripts/webkitpy/port/server_process.py:377
&gt;          # read any remaining data on the pipes and return it.
&gt;          if not killed:
&gt; -            if self._use_win32_apis:
&gt; +            if self._use_win32_apis and self._proc:
&gt;                  self._wait_for_data_and_update_buffers_using_win32_apis(now)
&gt; -            else:
&gt; +            elif self._proc:
&gt;                  self._wait_for_data_and_update_buffers_using_select(now, stopping=True)

Can you move the check for self._proc here?

        if not killed and self._proc:</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1341050</commentid>
    <comment_count>9</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-22 08:05:28 -0700</bug_when>
    <thetext>(In reply to David Kilzer (:ddkilzer) from comment #8)
&gt; Comment on attachment 318709 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=318709&amp;action=review
&gt; 
&gt; r=me
&gt; 
&gt; &gt; Tools/Scripts/webkitpy/port/server_process.py:377
&gt; &gt;          # read any remaining data on the pipes and return it.
&gt; &gt;          if not killed:
&gt; &gt; -            if self._use_win32_apis:
&gt; &gt; +            if self._use_win32_apis and self._proc:
&gt; &gt;                  self._wait_for_data_and_update_buffers_using_win32_apis(now)
&gt; &gt; -            else:
&gt; &gt; +            elif self._proc:
&gt; &gt;                  self._wait_for_data_and_update_buffers_using_select(now, stopping=True)
&gt; 
&gt; Can you move the check for self._proc here?
&gt; 
&gt;         if not killed and self._proc:

Good point. Making that change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1341051</commentid>
    <comment_count>10</comment_count>
      <attachid>318757</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-08-22 08:05:42 -0700</bug_when>
    <thetext>Created attachment 318757
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1341059</commentid>
    <comment_count>11</comment_count>
      <attachid>318757</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-22 08:46:33 -0700</bug_when>
    <thetext>Comment on attachment 318757
Patch for landing

Clearing flags on attachment: 318757

Committed r221011: &lt;http://trac.webkit.org/changeset/221011&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1341060</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-22 08:46:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>318537</attachid>
            <date>2017-08-18 13:49:07 -0700</date>
            <delta_ts>2017-08-21 17:13:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175735-20170818134907.patch</filename>
            <type>text/plain</type>
            <size>2865</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIyMDkyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDIxIEBACisyMDE3LTA4LTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBGaXggbGVhay1jaGVja2luZyBmb3IgaU9TIFNpbXVsYXRvcnMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTczNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHRoZSBsZWFrIGNo
ZWNraW5nIGN1cnJlbnRseSBvY2N1cnMgaW4gU2VydmVyUHJvY2Vzcywgd2UgY2Fu4oCZdCBjaGVj
ayBsZWFrcyBvbiBhbiBpT1MKKyAgICAgICAgU2ltdWxhdG9yIChvciBkZXZpY2UpIGJlY2F1c2Ug
dGhlIHByb2Nlc3Mgd2lsbCBoYXZlIGFscmVhZHkgYmVlbiBraWxsZWQgYnkgdGhlIHRpbWUgd2UK
KyAgICAgICAgY2hlY2sgZm9yIGxlYWtzLiBEdXBsaWNhdGUgbGVhay1jaGVja2luZyBjb2RlIGFu
ZCBzaGFyZSBjb2RlIHdhaXRpbmcgb24gYSBwcm9jZXNzIHRvIHN0b3AuCisKKyAgICAgICAgKiBT
Y3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHk6CisgICAgICAgIChTZXJ2ZXJQ
cm9jZXNzLnN0b3ApOiBNb3ZlIGNvZGUgd2FpdGluZyBmb3IgdGhlIHByb2Nlc3MgdG8gY2xvc2Ug
dG8gX3dhaXRfZm9yX3N0b3AoLi4uKS4KKyAgICAgICAgKFNlcnZlclByb2Nlc3MuX3dhaXRfZm9y
X3N0b3ApOiBTaGFyZSBjb2RlIHNodXR0aW5nIGRvd24gYSBwcm9jZXNzIGJldHdlZW4gU2VydmVy
UHJvY2VzcworICAgICAgICBhbmQgU2ltdWxhdG9yUHJvY2Vzcy4KKyAgICAgICAgKiBTY3JpcHRz
L3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHk6CisgICAgICAgIChTaW11bGF0b3JQ
cm9jZXNzLnN0b3ApOiBCZWZvcmUgY2xvc2luZyB0aGUgcHJvY2VzcywgY2hlY2sgZm9yIGxlYWtz
LgorCiAyMDE3LTA4LTE4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAg
ICAgICAgIEFkZCBEZWFuIEpvaG5zb24gdG8gY29udHJpYnV0b3JzLmpzb24gZm9yIEJ1Z3ppbGxh
IGF1dG9jb21wbGV0ZS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJf
cHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2Vy
dmVyX3Byb2Nlc3MucHkJKHJldmlzaW9uIDIyMDkyOCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0
cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtMzQ4LDEwICszNDgs
MTQgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgogICAgICAgICBpZiBzZWxmLnBvbGwo
KSBpcyBOb25lOgogICAgICAgICAgICAgc2VsZi5fcG9ydC5jaGVja19mb3JfbGVha3Moc2VsZi5w
cm9jZXNzX25hbWUoKSwgc2VsZi5waWQoKSkKIAotICAgICAgICBub3cgPSB0aW1lLnRpbWUoKQog
ICAgICAgICBpZiBzZWxmLl9wcm9jLnN0ZGluOgogICAgICAgICAgICAgc2VsZi5fcHJvYy5zdGRp
bi5jbG9zZSgpCiAgICAgICAgICAgICBzZWxmLl9wcm9jLnN0ZGluID0gTm9uZQorCisgICAgICAg
IHJldHVybiBzZWxmLl93YWl0X2Zvcl9zdG9wKHRpbWVvdXRfc2VjcykKKworICAgIGRlZiBfd2Fp
dF9mb3Jfc3RvcChzZWxmLCB0aW1lb3V0X3NlY3M9My4wKToKKyAgICAgICAgbm93ID0gdGltZS50
aW1lKCkKICAgICAgICAga2lsbGVkID0gRmFsc2UKICAgICAgICAgaWYgdGltZW91dF9zZWNzOgog
ICAgICAgICAgICAgZGVhZGxpbmUgPSBub3cgKyB0aW1lb3V0X3NlY3MKSW5kZXg6IFRvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU
b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHJldmlzaW9u
IDIyMDkyOCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vz
cy5weQkod29ya2luZyBjb3B5KQpAQCAtMTE2LDYgKzExNiwxMSBAQCBjbGFzcyBTaW11bGF0b3JQ
cm9jZXNzKFNlcnZlclByb2Nlc3MpOgogICAgICAgICBzZWxmLl9wcm9jID0gU2ltdWxhdG9yUHJv
Y2Vzcy5Qb3BlbihzZWxmLl9waWQsIHN0ZGluLCBzdGRvdXQsIHN0ZGVyciwgc2VsZi5fdGFyZ2V0
X2hvc3QpCiAKICAgICBkZWYgc3RvcChzZWxmLCB0aW1lb3V0X3NlY3M9My4wKToKKyAgICAgICAg
IyBPbmx5IGJvdGhlciB0byBjaGVjayBmb3IgbGVha3Mgb3Igc3RkZXJyIGlmIHRoZSBwcm9jZXNz
IGlzIHN0aWxsIHJ1bm5pbmcuCisgICAgICAgIGlmIHNlbGYucG9sbCgpIGlzIE5vbmU6CisgICAg
ICAgICAgICBzZWxmLl9wb3J0LmNoZWNrX2Zvcl9sZWFrcyhzZWxmLnByb2Nlc3NfbmFtZSgpLCBz
ZWxmLnBpZCgpKQorCiAgICAgICAgIGlmIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3Byb2MucGlkOgog
ICAgICAgICAgICAgc2VsZi5fdGFyZ2V0X2hvc3QuZXhlY3V0aXZlLmtpbGxfcHJvY2VzcyhzZWxm
Ll9wcm9jLnBpZCkKLSAgICAgICAgcmV0dXJuIHN1cGVyKFNpbXVsYXRvclByb2Nlc3MsIHNlbGYp
LnN0b3AodGltZW91dF9zZWNzKQorCisgICAgICAgIHJldHVybiBzZWxmLl93YWl0X2Zvcl9zdG9w
KHRpbWVvdXRfc2VjcykK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>318700</attachid>
            <date>2017-08-21 17:13:05 -0700</date>
            <delta_ts>2017-08-21 17:43:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175735-20170821171304.patch</filename>
            <type>text/plain</type>
            <size>1669</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIyMDk5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE3LTA4LTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBGaXggbGVhay1jaGVja2luZyBmb3IgaU9TIFNpbXVsYXRvcnMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTczNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvdy11cCBmaXgg
dG8gcjIyMDk0Mi4gX3Byb2MgbWF5IGJlIHVuZGVmaW5lZC4KKworICAgICAgICAqIFNjcmlwdHMv
d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3Mu
X3dhaXRfZm9yX3N0b3ApOiBIYW5kbGUgY2FzZSB3aGVyZSBfcHJvYyBpcyB1bmRlZmluZWQuCisK
IDIwMTctMDgtMjEgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog
ICAgICAgICBUeXBvIGluICJ3ZWJraXQtcGF0Y2ggbGFuZCIKSW5kZXg6IFRvb2xzL1NjcmlwdHMv
d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp
cHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkJKHJldmlzaW9uIDIyMDk3NCkKKysr
IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkod29ya2luZyBj
b3B5KQpAQCAtMzU5LDEyICszNTksMTIgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgog
ICAgICAgICBraWxsZWQgPSBGYWxzZQogICAgICAgICBpZiB0aW1lb3V0X3NlY3M6CiAgICAgICAg
ICAgICBkZWFkbGluZSA9IG5vdyArIHRpbWVvdXRfc2VjcwotICAgICAgICAgICAgd2hpbGUgc2Vs
Zi5fcHJvYy5wb2xsKCkgaXMgTm9uZSBhbmQgdGltZS50aW1lKCkgPCBkZWFkbGluZToKKyAgICAg
ICAgICAgIHdoaWxlIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3Byb2MucG9sbCgpIGlzIE5vbmUgYW5k
IHRpbWUudGltZSgpIDwgZGVhZGxpbmU6CiAgICAgICAgICAgICAgICAgdGltZS5zbGVlcCgwLjAx
KQotICAgICAgICAgICAgaWYgc2VsZi5fcHJvYy5wb2xsKCkgaXMgTm9uZToKKyAgICAgICAgICAg
IGlmIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3Byb2MucG9sbCgpIGlzIE5vbmU6CiAgICAgICAgICAg
ICAgICAgX2xvZy53YXJuaW5nKCdzdG9wcGluZyAlcyhwaWQgJWQpIHRpbWVkIG91dCwga2lsbGlu
ZyBpdCcgJSAoc2VsZi5fbmFtZSwgc2VsZi5fcHJvYy5waWQpKQogCi0gICAgICAgIGlmIHNlbGYu
X3Byb2MucG9sbCgpIGlzIE5vbmU6CisgICAgICAgIGlmIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3By
b2MucG9sbCgpIGlzIE5vbmU6CiAgICAgICAgICAgICBzZWxmLl9raWxsKCkKICAgICAgICAgICAg
IGtpbGxlZCA9IFRydWUKICAgICAgICAgICAgIF9sb2cuZGVidWcoJ2tpbGxlZCBwaWQgJWQnICUg
c2VsZi5fcHJvYy5waWQpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>318709</attachid>
            <date>2017-08-21 17:43:55 -0700</date>
            <delta_ts>2017-08-22 08:05:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175735-20170821174354.patch</filename>
            <type>text/plain</type>
            <size>2134</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIyMDk5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE3LTA4LTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBGaXggbGVhay1jaGVja2luZyBmb3IgaU9TIFNpbXVsYXRvcnMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTczNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvdy11cCBmaXgg
dG8gcjIyMDk0Mi4gX3Byb2MgbWF5IGJlIHVuZGVmaW5lZC4KKworICAgICAgICAqIFNjcmlwdHMv
d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3Mu
X3dhaXRfZm9yX3N0b3ApOiBIYW5kbGUgY2FzZSB3aGVyZSBfcHJvYyBpcyB1bmRlZmluZWQuCisK
IDIwMTctMDgtMjEgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog
ICAgICAgICBUeXBvIGluICJ3ZWJraXQtcGF0Y2ggbGFuZCIKSW5kZXg6IFRvb2xzL1NjcmlwdHMv
d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp
cHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkJKHJldmlzaW9uIDIyMDk3NCkKKysr
IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkod29ya2luZyBj
b3B5KQpAQCAtMzU5LDIxICszNTksMjEgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgog
ICAgICAgICBraWxsZWQgPSBGYWxzZQogICAgICAgICBpZiB0aW1lb3V0X3NlY3M6CiAgICAgICAg
ICAgICBkZWFkbGluZSA9IG5vdyArIHRpbWVvdXRfc2VjcwotICAgICAgICAgICAgd2hpbGUgc2Vs
Zi5fcHJvYy5wb2xsKCkgaXMgTm9uZSBhbmQgdGltZS50aW1lKCkgPCBkZWFkbGluZToKKyAgICAg
ICAgICAgIHdoaWxlIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3Byb2MucG9sbCgpIGlzIE5vbmUgYW5k
IHRpbWUudGltZSgpIDwgZGVhZGxpbmU6CiAgICAgICAgICAgICAgICAgdGltZS5zbGVlcCgwLjAx
KQotICAgICAgICAgICAgaWYgc2VsZi5fcHJvYy5wb2xsKCkgaXMgTm9uZToKKyAgICAgICAgICAg
IGlmIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3Byb2MucG9sbCgpIGlzIE5vbmU6CiAgICAgICAgICAg
ICAgICAgX2xvZy53YXJuaW5nKCdzdG9wcGluZyAlcyhwaWQgJWQpIHRpbWVkIG91dCwga2lsbGlu
ZyBpdCcgJSAoc2VsZi5fbmFtZSwgc2VsZi5fcHJvYy5waWQpKQogCi0gICAgICAgIGlmIHNlbGYu
X3Byb2MucG9sbCgpIGlzIE5vbmU6CisgICAgICAgIGlmIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3By
b2MucG9sbCgpIGlzIE5vbmU6CiAgICAgICAgICAgICBzZWxmLl9raWxsKCkKICAgICAgICAgICAg
IGtpbGxlZCA9IFRydWUKICAgICAgICAgICAgIF9sb2cuZGVidWcoJ2tpbGxlZCBwaWQgJWQnICUg
c2VsZi5fcHJvYy5waWQpCiAKICAgICAgICAgIyByZWFkIGFueSByZW1haW5pbmcgZGF0YSBvbiB0
aGUgcGlwZXMgYW5kIHJldHVybiBpdC4KICAgICAgICAgaWYgbm90IGtpbGxlZDoKLSAgICAgICAg
ICAgIGlmIHNlbGYuX3VzZV93aW4zMl9hcGlzOgorICAgICAgICAgICAgaWYgc2VsZi5fdXNlX3dp
bjMyX2FwaXMgYW5kIHNlbGYuX3Byb2M6CiAgICAgICAgICAgICAgICAgc2VsZi5fd2FpdF9mb3Jf
ZGF0YV9hbmRfdXBkYXRlX2J1ZmZlcnNfdXNpbmdfd2luMzJfYXBpcyhub3cpCi0gICAgICAgICAg
ICBlbHNlOgorICAgICAgICAgICAgZWxpZiBzZWxmLl9wcm9jOgogICAgICAgICAgICAgICAgIHNl
bGYuX3dhaXRfZm9yX2RhdGFfYW5kX3VwZGF0ZV9idWZmZXJzX3VzaW5nX3NlbGVjdChub3csIHN0
b3BwaW5nPVRydWUpCiAgICAgICAgIG91dCwgZXJyID0gc2VsZi5fb3V0cHV0LCBzZWxmLl9lcnJv
cgogICAgICAgICBzZWxmLl9yZXNldCgpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>318757</attachid>
            <date>2017-08-22 08:05:42 -0700</date>
            <delta_ts>2017-08-22 08:46:33 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-175735-20170822080541.patch</filename>
            <type>text/plain</type>
            <size>2018</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIyMTAxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE3LTA4LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBGaXggbGVhay1jaGVja2luZyBmb3IgaU9TIFNpbXVsYXRvcnMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTczNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IERhdmlkIEtpbHplci4KKworICAgICAgICBGb2xsb3ctdXAgZml4IHRv
IHIyMjA5NDIuIF9wcm9jIG1heSBiZSB1bmRlZmluZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl
YmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHk6CisgICAgICAgIChTZXJ2ZXJQcm9jZXNzLl93
YWl0X2Zvcl9zdG9wKTogSGFuZGxlIGNhc2Ugd2hlcmUgX3Byb2MgaXMgdW5kZWZpbmVkLgorCiAy
MDE3LTA4LTIyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29t
PgogCiAgICAgICAgIFtHVEtdW1dQRV0gaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2hvdWxkIGluc3Rh
bGwgdGhlIHJlcXVpcmVkIGdzdHJlYW1lciBwYWNrYWdlcyBuZWVkZWQgZm9yIHByb2R1Y3Rpb24g
YnVpbGRzLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNz
LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJv
Y2Vzcy5weQkocmV2aXNpb24gMjIxMDEwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0
L3NlcnZlcl9wcm9jZXNzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNTksMTggKzM1OSwxOCBAQCBj
bGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAgICAgICAgIGtpbGxlZCA9IEZhbHNlCiAgICAg
ICAgIGlmIHRpbWVvdXRfc2VjczoKICAgICAgICAgICAgIGRlYWRsaW5lID0gbm93ICsgdGltZW91
dF9zZWNzCi0gICAgICAgICAgICB3aGlsZSBzZWxmLl9wcm9jLnBvbGwoKSBpcyBOb25lIGFuZCB0
aW1lLnRpbWUoKSA8IGRlYWRsaW5lOgorICAgICAgICAgICAgd2hpbGUgc2VsZi5fcHJvYyBhbmQg
c2VsZi5fcHJvYy5wb2xsKCkgaXMgTm9uZSBhbmQgdGltZS50aW1lKCkgPCBkZWFkbGluZToKICAg
ICAgICAgICAgICAgICB0aW1lLnNsZWVwKDAuMDEpCi0gICAgICAgICAgICBpZiBzZWxmLl9wcm9j
LnBvbGwoKSBpcyBOb25lOgorICAgICAgICAgICAgaWYgc2VsZi5fcHJvYyBhbmQgc2VsZi5fcHJv
Yy5wb2xsKCkgaXMgTm9uZToKICAgICAgICAgICAgICAgICBfbG9nLndhcm5pbmcoJ3N0b3BwaW5n
ICVzKHBpZCAlZCkgdGltZWQgb3V0LCBraWxsaW5nIGl0JyAlIChzZWxmLl9uYW1lLCBzZWxmLl9w
cm9jLnBpZCkpCiAKLSAgICAgICAgaWYgc2VsZi5fcHJvYy5wb2xsKCkgaXMgTm9uZToKKyAgICAg
ICAgaWYgc2VsZi5fcHJvYyBhbmQgc2VsZi5fcHJvYy5wb2xsKCkgaXMgTm9uZToKICAgICAgICAg
ICAgIHNlbGYuX2tpbGwoKQogICAgICAgICAgICAga2lsbGVkID0gVHJ1ZQogICAgICAgICAgICAg
X2xvZy5kZWJ1Zygna2lsbGVkIHBpZCAlZCcgJSBzZWxmLl9wcm9jLnBpZCkKIAogICAgICAgICAj
IHJlYWQgYW55IHJlbWFpbmluZyBkYXRhIG9uIHRoZSBwaXBlcyBhbmQgcmV0dXJuIGl0LgotICAg
ICAgICBpZiBub3Qga2lsbGVkOgorICAgICAgICBpZiBzZWxmLl9wcm9jIGFuZCBub3Qga2lsbGVk
OgogICAgICAgICAgICAgaWYgc2VsZi5fdXNlX3dpbjMyX2FwaXM6CiAgICAgICAgICAgICAgICAg
c2VsZi5fd2FpdF9mb3JfZGF0YV9hbmRfdXBkYXRlX2J1ZmZlcnNfdXNpbmdfd2luMzJfYXBpcyhu
b3cpCiAgICAgICAgICAgICBlbHNlOgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>