175729 2017-08-18 11:28:19 -0700 [Repaint Outside Layout] Add a pref for repainting outside of layout 2017-08-24 10:53:52 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt bfulgham dbates simon.fraser zalan oldest_to_newest 1340156 0 hyatt 2017-08-18 11:28:19 -0700 Add a pref for repainting outside of layout. 1340158 1 318523 hyatt 2017-08-18 11:29:15 -0700 Created attachment 318523 Patch 1340167 2 318523 dbates 2017-08-18 12:00:51 -0700 Comment on attachment 318523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318523&action=review > Source/WebCore/rendering/RenderElement.cpp:2191 > + if (document().view()->needsFullRepaint() || !everHadLayout() || hasSelfPaintingLayer()) > + return false; > + return !settings().repaintOutsideLayoutEnabled(); I take it you feel this reads better. I would have written this using one line without a branch: return !document().view()->needsFullRepaint() && everHadLayout() && !hasSelfPaintingLayer() && !settings().repaintOutsideLayoutEnabled(); 1342090 3 hyatt 2017-08-24 10:53:52 -0700 Landed in r221147. 318523 2017-08-18 11:29:15 -0700 2017-08-18 12:00:51 -0700 Patch patch.txt text/plain 1900 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDkyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTE4ICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtSZXBhaW50IE91dHNpZGUgTGF5b3V0 XSBBZGQgYSBwcmVmIGZvciByZXBhaW50aW5nIG91dHNpZGUgb2YgbGF5b3V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU3MjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuaW46 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyRWxlbWVudDo6Y2hlY2tGb3JSZXBhaW50RHVyaW5nTGF5b3V0KToKKwogMjAxNy0w OC0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtCZWFjb25d IEFkZCBzdXBwb3J0IGZvciBxdW90YSBsaW1pdGF0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w YWdlL1NldHRpbmdzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGlu Z3MuaW4JKHJldmlzaW9uIDIxOTk4NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu aW4JKHdvcmtpbmcgY29weSkKQEAgLTI0OSw2ICsyNDksOCBAQCBuZXdCbG9ja0luc2lkZUlubGlu ZU1vZGVsRW5hYmxlZCBpbml0aWFsCiAKIGRlZmVycmVkQ1NTUGFyc2VyRW5hYmxlZCBpbml0aWFs PWZhbHNlCiAKK3JlcGFpbnRPdXRzaWRlTGF5b3V0RW5hYmxlZCBpbml0aWFsPWZhbHNlCisKIGh0 dHBFcXVpdkVuYWJsZWQgaW5pdGlhbD10cnVlCiAKICMgU29tZSBwb3J0cyAoZS5nLiBpT1MpIG1p Z2h0IGNob29zZSB0byBkaXNwbGF5IGF0dGFjaG1lbnRzIGlubGluZSwgcmVnYXJkbGVzcyBvZiB3 aGV0aGVyIHRoZSByZXNwb25zZSBpbmNsdWRlcyB0aGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAJKHJldmlzaW9uIDIxOTk4NSkKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE4 Niw3ICsyMTg2LDkgQEAgYm9vbCBSZW5kZXJFbGVtZW50OjpoYXNTZWxmUGFpbnRpbmdMYXllcgog CiBib29sIFJlbmRlckVsZW1lbnQ6OmNoZWNrRm9yUmVwYWludER1cmluZ0xheW91dCgpIGNvbnN0 CiB7Ci0gICAgcmV0dXJuICFkb2N1bWVudCgpLnZpZXcoKS0+bmVlZHNGdWxsUmVwYWludCgpICYm IGV2ZXJIYWRMYXlvdXQoKSAmJiAhaGFzU2VsZlBhaW50aW5nTGF5ZXIoKTsKKyAgICBpZiAoZG9j dW1lbnQoKS52aWV3KCktPm5lZWRzRnVsbFJlcGFpbnQoKSB8fCAhZXZlckhhZExheW91dCgpIHx8 IGhhc1NlbGZQYWludGluZ0xheWVyKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1 cm4gIXNldHRpbmdzKCkucmVwYWludE91dHNpZGVMYXlvdXRFbmFibGVkKCk7CiB9CiAKIFJlc3Bl Y3RJbWFnZU9yaWVudGF0aW9uRW51bSBSZW5kZXJFbGVtZW50OjpzaG91bGRSZXNwZWN0SW1hZ2VP cmllbnRhdGlvbigpIGNvbnN0Cg==