175675 2017-08-17 09:23:11 -0700 -Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp 2017-08-17 14:18:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other PC Linux RESOLVED FIXED InRadar P2 Trivial --- 1 mcatanzaro mcatanzaro buildbot commit-queue jiewen_tan mcatanzaro sam webkit-bug-importer oldest_to_newest 1339590 0 mcatanzaro 2017-08-17 09:23:11 -0700 Some new warnings: [2743/5943] Building CXX object Source...les/WebCore.dir/crypto/CryptoKey.cpp.o ../../Source/WebCore/crypto/CryptoKey.cpp: In member function ‘WebCore::CryptoKey::AlgorithmVariant WebCore::CryptoKey::algorithm() const’: ../../Source/WebCore/crypto/CryptoKey.cpp:70:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [2780/5943] Building CXX object Source.../WebCore.dir/crypto/SubtleCrypto.cpp.o ../../Source/WebCore/crypto/SubtleCrypto.cpp: In function ‘WebCore::CryptoKeyUsageBitmap WebCore::toCryptoKeyUsageBitmap(WebCore::CryptoKeyUsage)’: ../../Source/WebCore/crypto/SubtleCrypto.cpp:397:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../../Source/WebCore/crypto/SubtleCrypto.cpp: In function ‘std::optional<WTF::Variant<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16>, WebCore::JsonWebKey> > WebCore::toKeyData(WebCore::SubtleCrypto::KeyFormat, WebCore::SubtleCrypto::KeyDataVariant&&, WTF::Ref<WebCore::DeferredPromise>&)’: ../../Source/WebCore/crypto/SubtleCrypto.cpp:479:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ 1339592 1 318374 mcatanzaro 2017-08-17 09:26:13 -0700 Created attachment 318374 Patch 1339659 2 318374 jiewen_tan 2017-08-17 11:48:42 -0700 Comment on attachment 318374 Patch Looks good to me. r=me. Nice! 1339753 3 318374 commit-queue 2017-08-17 14:17:38 -0700 Comment on attachment 318374 Patch Clearing flags on attachment: 318374 Committed r220876: <http://trac.webkit.org/changeset/220876> 1339754 4 commit-queue 2017-08-17 14:17:40 -0700 All reviewed patches have been landed. Closing bug. 1339755 5 webkit-bug-importer 2017-08-17 14:18:59 -0700 <rdar://problem/33949830> 318374 2017-08-17 09:26:13 -0700 2017-08-17 14:17:38 -0700 Patch bug-175675-20170817112612.patch text/plain 2175 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzkyN2M5OTYwMzAxNzYx MzdlZmY1OGY1NzEzNzA5NDNiYTQ0NjFiZi4uODllOGQxMTc0NmE3OTk5YzQ4YjZlYjY2NTM2MDk3 YjA3MDBmZTQ4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA4LTE3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV3JldHVy bi10eXBlIHdhcm5pbmdzIGluIENyeXB0b0tleS5jcHAgYW5kIFN1YnRsZUNyeXB0by5jcHAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTY3NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3J5cHRvL0Ny eXB0b0tleS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDcnlwdG9LZXk6OmFsZ29yaXRobSBjb25z dCk6CisgICAgICAgICogY3J5cHRvL1N1YnRsZUNyeXB0by5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojp0b0NyeXB0b0tleVVzYWdlQml0bWFwKToKKyAgICAgICAgKFdlYkNvcmU6OnRvS2V5RGF0YSk6 CisKIDIwMTctMDgtMTcgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbmRlckxpc3RJdGVtIC0gQXZvaWQgcmVuZGVyIHRyZWUgbXV0YXRpb24gZHVyaW5nIGxh eW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NyeXB0b0tleS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNwcAppbmRleCA5YTE3ZmE3NTE3MjMxM2Zl M2ExOGU5YzAyYzA0MDEyNzU4OThlM2FkLi45ZWM3NzA2YTczMDJiNjQwNmJiYTc4OTlkMzQwODJl YzNhYmZlZWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vQ3J5cHRvS2V5LmNwcApAQCAtNjcsNiArNjcs OCBAQCBhdXRvIENyeXB0b0tleTo6YWxnb3JpdGhtKCkgY29uc3QgLT4gQWxnb3JpdGhtVmFyaWFu dAogICAgIGNhc2UgS2V5QWxnb3JpdGhtQ2xhc3M6OlJhdzoKICAgICAgICAgcmV0dXJuIGRvd25j YXN0PFJhd0tleUFsZ29yaXRobT4oKmFsZ29yaXRobSkuZGljdGlvbmFyeSgpOwogICAgIH0KKwor ICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKIGF1dG8gQ3J5cHRvS2V5Ojp1 c2FnZXMoKSBjb25zdCAtPiBWZWN0b3I8Q3J5cHRvS2V5VXNhZ2U+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jcnlwdG8vU3VidGxlQ3J5cHRvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2NyeXB0 by9TdWJ0bGVDcnlwdG8uY3BwCmluZGV4IDdmMDk3N2M0MjMzOTE2N2UxZTRmZTZmNjE5MzMyNTVh ZGNlY2Q2ODcuLmRhYWI4YmQzMTY5MTljNmQ5NjFiOWIxZjc3OTkzMWRjZjUwMTk4Y2EgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9TdWJ0bGVDcnlwdG8uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2NyeXB0by9TdWJ0bGVDcnlwdG8uY3BwCkBAIC0zOTQsNiArMzk0LDggQEAgc3Rh dGljIENyeXB0b0tleVVzYWdlQml0bWFwIHRvQ3J5cHRvS2V5VXNhZ2VCaXRtYXAoQ3J5cHRvS2V5 VXNhZ2UgdXNhZ2UpCiAgICAgY2FzZSBDcnlwdG9LZXlVc2FnZTo6VW53cmFwS2V5OgogICAgICAg ICByZXR1cm4gQ3J5cHRvS2V5VXNhZ2VVbndyYXBLZXk7CiAgICAgfQorCisgICAgUkVMRUFTRV9B U1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIAogc3RhdGljIENyeXB0b0tleVVzYWdlQml0bWFwIHRv Q3J5cHRvS2V5VXNhZ2VCaXRtYXAoY29uc3QgVmVjdG9yPENyeXB0b0tleVVzYWdlPiYgdXNhZ2Vz KQpAQCAtNDc2LDYgKzQ3OCw4IEBAIHN0YXRpYyBzdGQ6Om9wdGlvbmFsPEtleURhdGE+IHRvS2V5 RGF0YShTdWJ0bGVDcnlwdG86OktleUZvcm1hdCBmb3JtYXQsIFN1YnRsZUNyCiAgICAgICAgICAg ICB9CiAgICAgICAgICk7CiAgICAgfQorCisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQo KTsKIH0KIAogc3RhdGljIFZlY3Rvcjx1aW50OF90PiBjb3B5VG9WZWN0b3IoQnVmZmVyU291cmNl JiYgZGF0YSkK