175673 2017-08-17 07:57:41 -0700 [GStreamer] GstStructure shouldn't be handled through GRefPtr 2017-08-17 09:56:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan calvaris mcatanzaro webkit-bug-importer oldest_to_newest 1339552 0 zan 2017-08-17 07:57:41 -0700 [GStreamer] GstStructure shouldn't be handled through GRefPtr 1339555 1 318368 zan 2017-08-17 07:59:02 -0700 Created attachment 318368 Patch 1339569 2 318368 calvaris 2017-08-17 08:27:09 -0700 Comment on attachment 318368 Patch O_O 1339570 3 mcatanzaro 2017-08-17 08:29:40 -0700 This is bad. How did it not crash? How did it even compile if it doesn't support g_object_ref/unref and there's no template specialization for GstStructure? 1339596 4 318368 zan 2017-08-17 09:37:31 -0700 Comment on attachment 318368 Patch Clearing flags on attachment: 318368 Committed r220861: <http://trac.webkit.org/changeset/220861> 1339597 5 zan 2017-08-17 09:37:35 -0700 All reviewed patches have been landed. Closing bug. 1339598 6 calvaris 2017-08-17 09:38:01 -0700 (In reply to Michael Catanzaro from comment #3) > This is bad. How did it not crash? How did it even compile if it doesn't > support g_object_ref/unref and there's no template specialization for > GstStructure? I ask myself the same question. 1339599 7 webkit-bug-importer 2017-08-17 09:38:02 -0700 <rdar://problem/33942200> 1339605 8 zan 2017-08-17 09:56:35 -0700 (In reply to Xabier Rodríguez Calvar from comment #6) > (In reply to Michael Catanzaro from comment #3) > > This is bad. How did it not crash? How did it even compile if it doesn't > > support g_object_ref/unref and there's no template specialization for > > GstStructure? > > I ask myself the same question. gst_object_ref() was never called because all values were adopted into the GRefPtr<> object. gst_object_unref() was never called because the managed pointer was leaked from the GRefPtr<> object. 318368 2017-08-17 07:59:02 -0700 2017-08-17 09:37:31 -0700 Patch bug-175673-20170817165901.patch text/plain 3486 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBjNDY1ZDM2ZjZmNWYy YzkwMTVjMGY4NTQxZmNmMWQ4ZjA4Y2ZjYi4uYjgwZDZmMjY4ZDU1NWNkZmIyMjE2ODBkZTI4N2Q2 ZjU5ZWI3ZGVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTE3ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBH c3RTdHJ1Y3R1cmUgc2hvdWxkbid0IGJlIGhhbmRsZWQgdGhyb3VnaCBHUmVmUHRyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU2NzMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0Q29tbW9uRW5jcnlwdGlvbkRlY3J5cHRvckdTdHJlYW1l ci5jcHA6CisgICAgICAgICh3ZWJraXRNZWRpYUNvbW1vbkVuY3J5cHRpb25EZWNyeXB0VHJhbnNm b3JtQ2Fwcyk6IEdzdFN0cnVjdHVyZSBpc24ndAorICAgICAgICByZWYtY291bnRlZCwgc28gaXQg c2hvdWxkIGJlIGhhbmRsZWQgdGhyb3VnaCB0aGUgR1VuaXF1ZVB0cjxHc3RTdHJ1Y3R1cmU+Cisg ICAgICAgIHNtYXJ0IHBvaW50ZXIuCisKIDIwMTctMDgtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gQWRkIE5UTE0gYXV0 aGVudGljYXRpb24gZW5hYmxlZCBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0Q29tbW9uRW5jcnlwdGlvbkRlY3J5cHRv ckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvZW1lL1dlYktpdENvbW1vbkVuY3J5cHRpb25EZWNyeXB0b3JHU3RyZWFtZXIuY3BwCmluZGV4 IGFmMGJmODM4MzcwODgyMWRlYjY1OTIyOTA3OWMzYWQ4NTM5NzM3MzMuLjg3YjFmMGMxN2ExNmMz MDljYjUyOGJkMmNjZTU2ODUyZjNkYzBlYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0Q29tbW9uRW5jcnlwdGlvbkRlY3J5 cHRvckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL2VtZS9XZWJLaXRDb21tb25FbmNyeXB0aW9uRGVjcnlwdG9yR1N0cmVhbWVyLmNw cApAQCAtMjYsNiArMjYsNyBAQAogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUEpICYmIFVTRShH U1RSRUFNRVIpCiAKICNpbmNsdWRlICJHUmVmUHRyR1N0cmVhbWVyLmgiCisjaW5jbHVkZSAiR1Vu aXF1ZVB0ckdTdHJlYW1lci5oIgogI2luY2x1ZGUgPHd0Zi9Db25kaXRpb24uaD4KICNpbmNsdWRl IDx3dGYvUnVuTG9vcC5oPgogCkBAIC0xMTIsMTMgKzExMywxMyBAQCBzdGF0aWMgR3N0Q2Fwcyog d2Via2l0TWVkaWFDb21tb25FbmNyeXB0aW9uRGVjcnlwdFRyYW5zZm9ybUNhcHMoR3N0QmFzZVRy YW5zZm9ybQogICAgIHVuc2lnbmVkIHNpemUgPSBnc3RfY2Fwc19nZXRfc2l6ZShjYXBzKTsKICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2l6ZTsgKytpKSB7CiAgICAgICAgIEdzdFN0cnVj dHVyZSogaW5jb21pbmdTdHJ1Y3R1cmUgPSBnc3RfY2Fwc19nZXRfc3RydWN0dXJlKGNhcHMsIGkp OwotICAgICAgICBHUmVmUHRyPEdzdFN0cnVjdHVyZT4gb3V0Z29pbmdTdHJ1Y3R1cmUgPSBudWxs cHRyOworICAgICAgICBHVW5pcXVlUHRyPEdzdFN0cnVjdHVyZT4gb3V0Z29pbmdTdHJ1Y3R1cmUg PSBudWxscHRyOwogCiAgICAgICAgIGlmIChkaXJlY3Rpb24gPT0gR1NUX1BBRF9TSU5LKSB7CiAg ICAgICAgICAgICBpZiAoIWdzdF9zdHJ1Y3R1cmVfaGFzX2ZpZWxkKGluY29taW5nU3RydWN0dXJl LCAib3JpZ2luYWwtbWVkaWEtdHlwZSIpKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCi0g ICAgICAgICAgICBvdXRnb2luZ1N0cnVjdHVyZSA9IGFkb3B0R1JlZihnc3Rfc3RydWN0dXJlX2Nv cHkoaW5jb21pbmdTdHJ1Y3R1cmUpKTsKKyAgICAgICAgICAgIG91dGdvaW5nU3RydWN0dXJlID0g R1VuaXF1ZVB0cjxHc3RTdHJ1Y3R1cmU+KGdzdF9zdHJ1Y3R1cmVfY29weShpbmNvbWluZ1N0cnVj dHVyZSkpOwogICAgICAgICAgICAgZ3N0X3N0cnVjdHVyZV9zZXRfbmFtZShvdXRnb2luZ1N0cnVj dHVyZS5nZXQoKSwgZ3N0X3N0cnVjdHVyZV9nZXRfc3RyaW5nKG91dGdvaW5nU3RydWN0dXJlLmdl dCgpLCAib3JpZ2luYWwtbWVkaWEtdHlwZSIpKTsKIAogICAgICAgICAgICAgLy8gRmlsdGVyIG91 dCB0aGUgRFJNIHJlbGF0ZWQgZmllbGRzIGZyb20gdGhlIGRvd24tc3RyZWFtIGNhcHMuCkBAIC0x MzAsNyArMTMxLDcgQEAgc3RhdGljIEdzdENhcHMqIHdlYmtpdE1lZGlhQ29tbW9uRW5jcnlwdGlv bkRlY3J5cHRUcmFuc2Zvcm1DYXBzKEdzdEJhc2VUcmFuc2Zvcm0KICAgICAgICAgICAgICAgICAg ICAgZ3N0X3N0cnVjdHVyZV9yZW1vdmVfZmllbGQob3V0Z29pbmdTdHJ1Y3R1cmUuZ2V0KCksIGZp ZWxkTmFtZSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBv dXRnb2luZ1N0cnVjdHVyZSA9IGFkb3B0R1JlZihnc3Rfc3RydWN0dXJlX2NvcHkoaW5jb21pbmdT dHJ1Y3R1cmUpKTsKKyAgICAgICAgICAgIG91dGdvaW5nU3RydWN0dXJlID0gR1VuaXF1ZVB0cjxH c3RTdHJ1Y3R1cmU+KGdzdF9zdHJ1Y3R1cmVfY29weShpbmNvbWluZ1N0cnVjdHVyZSkpOwogICAg ICAgICAgICAgLy8gRmlsdGVyIG91dCB0aGUgdmlkZW8gcmVsYXRlZCBmaWVsZHMgZnJvbSB0aGUg dXAtc3RyZWFtIGNhcHMsCiAgICAgICAgICAgICAvLyBiZWNhdXNlIHRoZXkgYXJlIG5vdCByZWxl dmFudCB0byB0aGUgaW5wdXQgY2FwcyBvZiB0aGlzIGVsZW1lbnQgYW5kCiAgICAgICAgICAgICAv LyBjYW4gY2F1c2UgY2FwcyBuZWdvdGlhdGlvbiBmYWlsdXJlcyB3aXRoIGFkYXB0aXZlIGJpdHJh dGUgc3RyZWFtcy4KQEAgLTE2OCw3ICsxNjksNyBAQCBzdGF0aWMgR3N0Q2Fwcyogd2Via2l0TWVk aWFDb21tb25FbmNyeXB0aW9uRGVjcnlwdFRyYW5zZm9ybUNhcHMoR3N0QmFzZVRyYW5zZm9ybQog ICAgICAgICB9CiAKICAgICAgICAgaWYgKCFkdXBsaWNhdGUpCi0gICAgICAgICAgICBnc3RfY2Fw c19hcHBlbmRfc3RydWN0dXJlKHRyYW5zZm9ybWVkQ2Fwcywgb3V0Z29pbmdTdHJ1Y3R1cmUubGVh a1JlZigpKTsKKyAgICAgICAgICAgIGdzdF9jYXBzX2FwcGVuZF9zdHJ1Y3R1cmUodHJhbnNmb3Jt ZWRDYXBzLCBvdXRnb2luZ1N0cnVjdHVyZS5yZWxlYXNlKCkpOwogICAgIH0KIAogICAgIGlmIChm aWx0ZXIpIHsK