175667 2017-08-17 04:24:10 -0700 [WPE][GTK] Ensure proper casting of data in gvariants 2017-08-18 01:09:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jaragunde webkit-unassigned bburg berto buildbot cgarcia commit-queue gustavo jbicha jidanni keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer zan oldest_to_newest 1339495 0 jaragunde 2017-08-17 04:24:10 -0700 [WPE][GTK] Ensure proper casting of data in gvariants 1339498 1 318350 jaragunde 2017-08-17 04:36:57 -0700 Created attachment 318350 Patch 1339499 2 jaragunde 2017-08-17 04:37:46 -0700 For the record, I searched and reviewed the arguments in calls to g_variant_new all around, but only found missing casts on these. 1339512 3 318350 mcatanzaro 2017-08-17 05:16:29 -0700 Comment on attachment 318350 Patch In this case I'm going to question why the GVariant uses t (guint64) rather than u (guint32) if targetIdentifier is an unsigned int. Probably targetIdentifier should be changed to use either uint32_t or uint64_t directly since it's destined to be passed over IPC. 1339564 4 jaragunde 2017-08-17 08:18:46 -0700 targetIdentifier is defined at JavaScriptCore/inspector/remote/RemoteControllableTarget.h, which is common code, should we still touch that? 1339568 5 cgarcia 2017-08-17 08:22:07 -0700 (In reply to Jacobo Aragunde Pérez from comment #4) > targetIdentifier is defined at > JavaScriptCore/inspector/remote/RemoteControllableTarget.h, which is common > code, should we still touch that? Do not change that, at least not in this patch, let's fix the uses of gvariant, and if we need to change existing types, let's discuss it in a different bug. 1339571 6 318369 jaragunde 2017-08-17 08:30:53 -0700 Created attachment 318369 Patch 1339572 7 jaragunde 2017-08-17 08:31:28 -0700 Additionally reviewed calls to g_variant_get and g_variant_builder_add, correcting one more case of potential corruption. 1339573 8 buildbot 2017-08-17 08:31:46 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1339574 9 318369 mcatanzaro 2017-08-17 08:35:07 -0700 Comment on attachment 318369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318369&action=review Nice, thanks. Real shame we don't have static analysis to catch this sort of problem. > Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp:174 > - g_variant_builder_add(sessionBuilder, "d", frameState.pageScaleFactor); > + g_variant_builder_add(sessionBuilder, "d", static_cast<gdouble>(frameState.pageScaleFactor)); I'm a bit concerned because this affected serialized session state, but not much we can do about that. 1339585 10 318369 commit-queue 2017-08-17 09:17:22 -0700 Comment on attachment 318369 Patch Clearing flags on attachment: 318369 Committed r220860: <http://trac.webkit.org/changeset/220860> 1339586 11 commit-queue 2017-08-17 09:17:24 -0700 All reviewed patches have been landed. Closing bug. 1339587 12 webkit-bug-importer 2017-08-17 09:17:53 -0700 <rdar://problem/33941797> 1339735 13 mcatanzaro 2017-08-17 13:48:52 -0700 *** Bug 175681 has been marked as a duplicate of this bug. *** 1340011 14 cgarcia 2017-08-18 01:09:58 -0700 *** Bug 174026 has been marked as a duplicate of this bug. *** 318350 2017-08-17 04:36:57 -0700 2017-08-17 07:56:04 -0700 Patch bug-175667-20170817133656.patch text/plain 3069 jaragunde SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwODUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE3LTA4LTE3ICBKYWNvYm8gQXJhZ3VuZGUgUMOpcmV6ICA8amFyYWd1bmRlQGlnYWxpYS5j b20+CisKKyAgICAgICAgW1dQRV1bR1RLXSBFbnN1cmUgcHJvcGVyIGNhc3Rpbmcgb2YgZGF0YSBp biBndmFyaWFudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NTY2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGdfdmFyaWFudF9uZXcgcmVxdWlyZXMgZGF0YSBoYXZlIHRoZSBjb3JyZWN0IHdpZHRoIGZv ciB0aGVpciB0eXBlcywgdXNpbmcgY2FzdGluZworICAgICAgICBpZiBuZWNlc3NhcnkuIFNvbWUg ZGF0YSBvZiB0eXBlIGB1bnNpZ25lZGAgd2VyZSBiZWluZyBzYXZlZCB0byBgZ3VpbnQ2NGAgdHlw ZXMKKyAgICAgICAgd2l0aG91dCBleHBsaWNpdCBjYXN0aW5nLCBsZWFkaW5nIHRvIHVuZGVmaW5l ZCBiZWhhdmlvciBpbiBzb21lIHBsYXRmb3Jtcy4KKworICAgICAgICAqIGluc3BlY3Rvci9yZW1v dGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JHbGliLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVt b3RlSW5zcGVjdG9yOjpsaXN0aW5nRm9ySW5zcGVjdGlvblRhcmdldCBjb25zdCk6CisgICAgICAg IChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6bGlzdGluZ0ZvckF1dG9tYXRpb25UYXJnZXQg Y29uc3QpOgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnNlbmRNZXNzYWdl VG9SZW1vdGUpOgorCiAyMDE3LTA4LTE3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtp dC5vcmc+CiAKICAgICAgICAgQVJNIGJ1aWxkIGZpeCBhZnRlciByMjIwODA3IGFuZCByMjIwODM0 LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvZ2xpYi9SZW1v dGVJbnNwZWN0b3JHbGliLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUluc3BlY3RvckdsaWIuY3BwCShyZXZpc2lvbiAy MjA2MzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9nbGliL1Jl bW90ZUluc3BlY3RvckdsaWIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODcsMTQgKzE4NywxNiBA QCBUYXJnZXRMaXN0aW5nIFJlbW90ZUluc3BlY3Rvcjo6bGlzdGluZ0ZvCiAgICAgICAgIHJldHVy biBudWxscHRyOwogCiAgICAgQVNTRVJUKHRhcmdldC50eXBlKCkgPT0gUmVtb3RlSW5zcGVjdGlv blRhcmdldDo6VHlwZTo6V2ViIHx8IHRhcmdldC50eXBlKCkgPT0gUmVtb3RlSW5zcGVjdGlvblRh cmdldDo6VHlwZTo6SmF2YVNjcmlwdCk7Ci0gICAgcmV0dXJuIGdfdmFyaWFudF9uZXcoIih0c3Nz YikiLCB0YXJnZXQudGFyZ2V0SWRlbnRpZmllcigpLCB0YXJnZXQudHlwZSgpID09IFJlbW90ZUlu c3BlY3Rpb25UYXJnZXQ6OlR5cGU6OldlYiA/ICJXZWIiIDogIkphdmFTY3JpcHQiLAorICAgIHJl dHVybiBnX3ZhcmlhbnRfbmV3KCIodHNzc2IpIiwgc3RhdGljX2Nhc3Q8Z3VpbnQ2ND4odGFyZ2V0 LnRhcmdldElkZW50aWZpZXIoKSksCisgICAgICAgIHRhcmdldC50eXBlKCkgPT0gUmVtb3RlSW5z cGVjdGlvblRhcmdldDo6VHlwZTo6V2ViID8gIldlYiIgOiAiSmF2YVNjcmlwdCIsCiAgICAgICAg IHRhcmdldC5uYW1lKCkudXRmOCgpLmRhdGEoKSwgdGFyZ2V0LnR5cGUoKSA9PSBSZW1vdGVJbnNw ZWN0aW9uVGFyZ2V0OjpUeXBlOjpXZWIgPyB0YXJnZXQudXJsKCkudXRmOCgpLmRhdGEoKSA6ICJu dWxsIiwKICAgICAgICAgdGFyZ2V0Lmhhc0xvY2FsRGVidWdnZXIoKSk7CiB9CiAKIFRhcmdldExp c3RpbmcgUmVtb3RlSW5zcGVjdG9yOjpsaXN0aW5nRm9yQXV0b21hdGlvblRhcmdldChjb25zdCBS ZW1vdGVBdXRvbWF0aW9uVGFyZ2V0JiB0YXJnZXQpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGdfdmFy aWFudF9uZXcoIih0c3NzYikiLCB0YXJnZXQudGFyZ2V0SWRlbnRpZmllcigpLCAiQXV0b21hdGlv biIsIHRhcmdldC5uYW1lKCkudXRmOCgpLmRhdGEoKSwgIm51bGwiLCB0YXJnZXQuaXNQYWlyZWQo KSk7CisgICAgcmV0dXJuIGdfdmFyaWFudF9uZXcoIih0c3NzYikiLCBzdGF0aWNfY2FzdDxndWlu dDY0Pih0YXJnZXQudGFyZ2V0SWRlbnRpZmllcigpKSwKKyAgICAgICAgIkF1dG9tYXRpb24iLCB0 YXJnZXQubmFtZSgpLnV0ZjgoKS5kYXRhKCksICJudWxsIiwgdGFyZ2V0LmlzUGFpcmVkKCkpOwog fQogCiB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6cHVzaExpc3RpbmdzTm93KCkKQEAgLTI3NCw3ICsy NzYsNyBAQCB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6c2VuZE1lc3NhZ2VUb1JlbW90CiAKICAgICBn X2RidXNfY29ubmVjdGlvbl9jYWxsKG1fZGJ1c0Nvbm5lY3Rpb24uZ2V0KCksIG51bGxwdHIsCiAg ICAgICAgIElOU1BFQ1RPUl9EQlVTX09CSkVDVF9QQVRILCBJTlNQRUNUT1JfREJVU19JTlRFUkZB Q0UsICJTZW5kTWVzc2FnZVRvRnJvbnRlbmQiLAotICAgICAgICBnX3ZhcmlhbnRfbmV3KCIodHMp IiwgdGFyZ2V0SWRlbnRpZmllciwgbWVzc2FnZS51dGY4KCkuZGF0YSgpKSwKKyAgICAgICAgZ192 YXJpYW50X25ldygiKHRzKSIsIHN0YXRpY19jYXN0PGd1aW50NjQ+KHRhcmdldElkZW50aWZpZXIp LCBtZXNzYWdlLnV0ZjgoKS5kYXRhKCkpLAogICAgICAgICBudWxscHRyLCBHX0RCVVNfQ0FMTF9G TEFHU19OT19BVVRPX1NUQVJULAogICAgICAgICAtMSwgbV9jYW5jZWxsYWJsZS5nZXQoKSwgZGJ1 c0Nvbm5lY3Rpb25DYWxsQXN5bmNSZWFkeUNhbGxiYWNrLCBudWxscHRyKTsKIH0K 318369 2017-08-17 08:30:53 -0700 2017-08-17 09:17:22 -0700 Patch bug-175667-20170817173052.patch text/plain 4927 jaragunde SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwODU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE3LTA4LTE3ICBKYWNvYm8gQXJhZ3VuZGUgUMOpcmV6ICA8amFyYWd1bmRlQGlnYWxpYS5j b20+CisKKyAgICAgICAgW1dQRV1bR1RLXSBFbnN1cmUgcHJvcGVyIGNhc3Rpbmcgb2YgZGF0YSBp biBndmFyaWFudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NTY2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGdfdmFyaWFudF9uZXcgcmVxdWlyZXMgZGF0YSB0byBoYXZlIHRoZSBjb3JyZWN0IHdpZHRo IGZvciB0aGVpciB0eXBlcywgdXNpbmcKKyAgICAgICAgY2FzdGluZyBpZiBuZWNlc3NhcnkuIFNv bWUgZGF0YSBvZiB0eXBlIGB1bnNpZ25lZGAgd2VyZSBiZWluZyBzYXZlZCB0byBgZ3VpbnQ2NGAK KyAgICAgICAgdHlwZXMgd2l0aG91dCBleHBsaWNpdCBjYXN0aW5nLCBsZWFkaW5nIHRvIHVuZGVm aW5lZCBiZWhhdmlvciBpbiBzb21lIHBsYXRmb3Jtcy4KKworICAgICAgICAqIGluc3BlY3Rvci9y ZW1vdGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JHbGliLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6 UmVtb3RlSW5zcGVjdG9yOjpsaXN0aW5nRm9ySW5zcGVjdGlvblRhcmdldCBjb25zdCk6CisgICAg ICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6bGlzdGluZ0ZvckF1dG9tYXRpb25UYXJn ZXQgY29uc3QpOgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnNlbmRNZXNz YWdlVG9SZW1vdGUpOgorCiAyMDE3LTA4LTE3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFA Z21haWwuY29tPgogCiAgICAgICAgIFtKU0NdIEF2b2lkIGNvZGUgYmxvYXRpbmcgZm9yIGl0ZXJh dGlvbiBpZiBibG9jayBkb2VzIG5vdCBoYXZlICJicmVhayIKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2dsaWIvUmVtb3RlSW5zcGVjdG9yR2xpYi5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvZ2xpYi9S ZW1vdGVJbnNwZWN0b3JHbGliLmNwcAkocmV2aXNpb24gMjIwNjMxKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JHbGliLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTg3LDE0ICsxODcsMTYgQEAgVGFyZ2V0TGlzdGluZyBSZW1vdGVJ bnNwZWN0b3I6Omxpc3RpbmdGbwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIEFTU0VS VCh0YXJnZXQudHlwZSgpID09IFJlbW90ZUluc3BlY3Rpb25UYXJnZXQ6OlR5cGU6OldlYiB8fCB0 YXJnZXQudHlwZSgpID09IFJlbW90ZUluc3BlY3Rpb25UYXJnZXQ6OlR5cGU6OkphdmFTY3JpcHQp OwotICAgIHJldHVybiBnX3ZhcmlhbnRfbmV3KCIodHNzc2IpIiwgdGFyZ2V0LnRhcmdldElkZW50 aWZpZXIoKSwgdGFyZ2V0LnR5cGUoKSA9PSBSZW1vdGVJbnNwZWN0aW9uVGFyZ2V0OjpUeXBlOjpX ZWIgPyAiV2ViIiA6ICJKYXZhU2NyaXB0IiwKKyAgICByZXR1cm4gZ192YXJpYW50X25ldygiKHRz c3NiKSIsIHN0YXRpY19jYXN0PGd1aW50NjQ+KHRhcmdldC50YXJnZXRJZGVudGlmaWVyKCkpLAor ICAgICAgICB0YXJnZXQudHlwZSgpID09IFJlbW90ZUluc3BlY3Rpb25UYXJnZXQ6OlR5cGU6Oldl YiA/ICJXZWIiIDogIkphdmFTY3JpcHQiLAogICAgICAgICB0YXJnZXQubmFtZSgpLnV0ZjgoKS5k YXRhKCksIHRhcmdldC50eXBlKCkgPT0gUmVtb3RlSW5zcGVjdGlvblRhcmdldDo6VHlwZTo6V2Vi ID8gdGFyZ2V0LnVybCgpLnV0ZjgoKS5kYXRhKCkgOiAibnVsbCIsCiAgICAgICAgIHRhcmdldC5o YXNMb2NhbERlYnVnZ2VyKCkpOwogfQogCiBUYXJnZXRMaXN0aW5nIFJlbW90ZUluc3BlY3Rvcjo6 bGlzdGluZ0ZvckF1dG9tYXRpb25UYXJnZXQoY29uc3QgUmVtb3RlQXV0b21hdGlvblRhcmdldCYg dGFyZ2V0KSBjb25zdAogewotICAgIHJldHVybiBnX3ZhcmlhbnRfbmV3KCIodHNzc2IpIiwgdGFy Z2V0LnRhcmdldElkZW50aWZpZXIoKSwgIkF1dG9tYXRpb24iLCB0YXJnZXQubmFtZSgpLnV0Zjgo KS5kYXRhKCksICJudWxsIiwgdGFyZ2V0LmlzUGFpcmVkKCkpOworICAgIHJldHVybiBnX3Zhcmlh bnRfbmV3KCIodHNzc2IpIiwgc3RhdGljX2Nhc3Q8Z3VpbnQ2ND4odGFyZ2V0LnRhcmdldElkZW50 aWZpZXIoKSksCisgICAgICAgICJBdXRvbWF0aW9uIiwgdGFyZ2V0Lm5hbWUoKS51dGY4KCkuZGF0 YSgpLCAibnVsbCIsIHRhcmdldC5pc1BhaXJlZCgpKTsKIH0KIAogdm9pZCBSZW1vdGVJbnNwZWN0 b3I6OnB1c2hMaXN0aW5nc05vdygpCkBAIC0yNzQsNyArMjc2LDcgQEAgdm9pZCBSZW1vdGVJbnNw ZWN0b3I6OnNlbmRNZXNzYWdlVG9SZW1vdAogCiAgICAgZ19kYnVzX2Nvbm5lY3Rpb25fY2FsbCht X2RidXNDb25uZWN0aW9uLmdldCgpLCBudWxscHRyLAogICAgICAgICBJTlNQRUNUT1JfREJVU19P QkpFQ1RfUEFUSCwgSU5TUEVDVE9SX0RCVVNfSU5URVJGQUNFLCAiU2VuZE1lc3NhZ2VUb0Zyb250 ZW5kIiwKLSAgICAgICAgZ192YXJpYW50X25ldygiKHRzKSIsIHRhcmdldElkZW50aWZpZXIsIG1l c3NhZ2UudXRmOCgpLmRhdGEoKSksCisgICAgICAgIGdfdmFyaWFudF9uZXcoIih0cykiLCBzdGF0 aWNfY2FzdDxndWludDY0Pih0YXJnZXRJZGVudGlmaWVyKSwgbWVzc2FnZS51dGY4KCkuZGF0YSgp KSwKICAgICAgICAgbnVsbHB0ciwgR19EQlVTX0NBTExfRkxBR1NfTk9fQVVUT19TVEFSVCwKICAg ICAgICAgLTEsIG1fY2FuY2VsbGFibGUuZ2V0KCksIGRidXNDb25uZWN0aW9uQ2FsbEFzeW5jUmVh ZHlDYWxsYmFjaywgbnVsbHB0cik7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjIwNjMxKQor KysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBA QAorMjAxNy0wOC0xNyAgSmFjb2JvIEFyYWd1bmRlIFDDqXJleiAgPGphcmFndW5kZUBpZ2FsaWEu Y29tPgorCisgICAgICAgIFtXUEVdW0dUS10gRW5zdXJlIHByb3BlciBjYXN0aW5nIG9mIGRhdGEg aW4gZ3ZhcmlhbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzU2NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBnX3ZhcmlhbnRfYnVpbGRlcl9hZGQgcmVxdWlyZXMgZGF0YSB0byBoYXZlIHRoZSBjb3Jy ZWN0IHdpZHRoIGZvciB0aGVpciB0eXBlcywgdXNpbmcKKyAgICAgICAgY2FzdGluZyBpZiBuZWNl c3NhcnkuIENvcnJlY3RlZCBhIGNhbGwgd2hlcmUgYSBzaW5nbGUgcHJlY2lzaW9uIGZsb2F0IHdh cyBiZWluZyBwdXQKKyAgICAgICAgaW50byBhIGRvdWJsZSBwcmVjaXNpb24gcGFyYW1ldGVyIHdp dGhvdXQgYSBjYXN0LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZp ZXdTZXNzaW9uU3RhdGUuY3BwOgorICAgICAgICAoZW5jb2RlRnJhbWVTdGF0ZSk6CisKIDIwMTct MDgtMTMgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbV1BFXSBJbXBsZW1lbnQgV2ViQ29yZTo6c3RhbmRhcmRVc2VyQWdlbnQoKQpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlld1Nlc3Npb25TdGF0 ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0V2ViVmlld1Nlc3Npb25TdGF0ZS5jcHAJKHJldmlzaW9uIDIyMDYzMSkKKysrIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXdTZXNzaW9uU3RhdGUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNzEsNyArMTcxLDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGVuY29k ZUZyYW1lU3RhdGUoR1ZhcgogICAgIGdfdmFyaWFudF9idWlsZGVyX2FkZChzZXNzaW9uQnVpbGRl ciwgIngiLCBmcmFtZVN0YXRlLmRvY3VtZW50U2VxdWVuY2VOdW1iZXIpOwogICAgIGdfdmFyaWFu dF9idWlsZGVyX2FkZChzZXNzaW9uQnVpbGRlciwgIngiLCBmcmFtZVN0YXRlLml0ZW1TZXF1ZW5j ZU51bWJlcik7CiAgICAgZ192YXJpYW50X2J1aWxkZXJfYWRkKHNlc3Npb25CdWlsZGVyLCAiKGlp KSIsIGZyYW1lU3RhdGUuc2Nyb2xsUG9zaXRpb24ueCgpLCBmcmFtZVN0YXRlLnNjcm9sbFBvc2l0 aW9uLnkoKSk7Ci0gICAgZ192YXJpYW50X2J1aWxkZXJfYWRkKHNlc3Npb25CdWlsZGVyLCAiZCIs IGZyYW1lU3RhdGUucGFnZVNjYWxlRmFjdG9yKTsKKyAgICBnX3ZhcmlhbnRfYnVpbGRlcl9hZGQo c2Vzc2lvbkJ1aWxkZXIsICJkIiwgc3RhdGljX2Nhc3Q8Z2RvdWJsZT4oZnJhbWVTdGF0ZS5wYWdl U2NhbGVGYWN0b3IpKTsKICAgICBpZiAoIWZyYW1lU3RhdGUuaHR0cEJvZHkpCiAgICAgICAgIGdf dmFyaWFudF9idWlsZGVyX2FkZChzZXNzaW9uQnVpbGRlciwgSFRUUF9CT0RZX1RZUEVfU1RSSU5H X1YxLCBGQUxTRSk7CiAgICAgZWxzZSB7Cg==