175652 2017-08-16 19:09:36 -0700 check-webkit-style shouldn't check spacing in #elif preprocessor lines 2017-08-17 19:38:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned achristensen buildbot commit-queue don.olmstead glenn lforschler webkit-bug-importer oldest_to_newest 1339403 0 yoshiaki.jitsukawa 2017-08-16 19:09:36 -0700 check-webkit-style generates false positive [whitespace/operators] errors around path delimiter '/' for __has_include() predicate. 1339404 1 318317 yoshiaki.jitsukawa 2017-08-16 19:16:28 -0700 Created attachment 318317 Patch 1339407 2 yoshiaki.jitsukawa 2017-08-16 19:28:05 -0700 e.g. ./platform/spi/mac/AVFoundationSPI.h:#if __has_include(<AVFoundation/AVSampleBufferRenderSynchronizer.h>) 1339595 3 achristensen 2017-08-17 09:35:11 -0700 I'm pretty sure check-webkit-style has tests. 1339678 4 yoshiaki.jitsukawa 2017-08-17 12:26:52 -0700 (In reply to Alex Christensen from comment #3) > I'm pretty sure check-webkit-style has tests. Yes https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py#L2035 1339680 5 yoshiaki.jitsukawa 2017-08-17 12:28:40 -0700 (In reply to Yoshiaki Jitsukawa from comment #4) > (In reply to Alex Christensen from comment #3) > > I'm pretty sure check-webkit-style has tests. > > Yes > https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/style/ > checkers/cpp_unittest.py#L2035 Ah, the test passes because of "#if" so I needed to change this "#if" to something else. 1339694 6 318404 yoshiaki.jitsukawa 2017-08-17 12:54:05 -0700 Created attachment 318404 Patch 1339698 7 yoshiaki.jitsukawa 2017-08-17 12:57:56 -0700 Originally I hit this issue with "#elif __has_include.." code so now I think this should be handled by skipping spacing checks for "#elif". 1339703 8 yoshiaki.jitsukawa 2017-08-17 13:00:04 -0700 Related bug: Bug 125534 - check-webkit-style shouldn't check spacing in #if preprocessor lines 1339807 9 yoshiaki.jitsukawa 2017-08-17 15:52:08 -0700 Hi Alex, would you review my patch again if you are available? 1339904 10 318404 commit-queue 2017-08-17 19:17:10 -0700 Comment on attachment 318404 Patch Clearing flags on attachment: 318404 Committed r220896: <http://trac.webkit.org/changeset/220896> 1339905 11 commit-queue 2017-08-17 19:17:11 -0700 All reviewed patches have been landed. Closing bug. 1339910 12 webkit-bug-importer 2017-08-17 19:18:48 -0700 <rdar://problem/33955505> 1339914 13 yoshiaki.jitsukawa 2017-08-17 19:38:09 -0700 Thank you for your reviewing, Alex! 318317 2017-08-16 19:16:28 -0700 2017-08-17 12:44:59 -0700 Patch bug175652.patch text/plain 1891 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MjMw YjJlOGZmNS4uZmViY2E3N2QzMzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNy0wOC0xNiAgWW9zaGlha2kgSml0 c3VrYXdhICA8WW9zaGlha2kuSml0c3VrYXdhQHNvbnkuY29tPgorCisgICAgICAgIGNoZWNrLXdl YmtpdC1zdHlsZTogZmFsc2UgcG9zaXRpdmUgZm9yIFt3aGl0ZXNwYWNlL29wZXJhdG9yc10gZm9y IF9faGFzX2luY2x1ZGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc1NjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRXhjbHVkZSBfX2hhc19pbmNsdWRlKCkgcHJlZGljYXRlIGZyb20gd2hpdGVzcGFj ZSBjaGVjay4KKyAgICAgICAgSXRzIHRlc3QgY2FzZSBpcyBhbHJlYWR5IGluIGNwcF91bml0dGVz dC5weS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 OgorICAgICAgICAoY2hlY2tfc3BhY2luZyk6CisKIDIwMTctMDgtMTYgIFlvc2hpYWtpIEppdHN1 a2F3YSAgPFlvc2hpYWtpLkppdHN1a2F3YUBzb255LmNvbT4KIAogICAgICAgICBbUEFMXSBNb3Zl IHNwaS9pb3MgYW5kIHNwaS93aW4gZGlyZWN0b3JpZXMgaW50byBQQUwKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMmYxYzczYmYwMDUuLjk3MGU2 OGZiNjU2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQpAQCAtMTg2OSwxMCArMTg2OSwxMiBAQCBkZWYgY2hlY2tfc3BhY2luZyhmaWxlX2V4dGVuc2lv biwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CiAKICAgICAj IERvbid0IHRyeSB0byBkbyBzcGFjaW5nIGNoZWNrcyBmb3Igb3BlcmF0b3IgbWV0aG9kcwogICAg IGxpbmUgPSBzdWIocidvcGVyYXRvcig9PXwhPXw8fDw8fDw9fD49fD4+fD58XCs9fC09fFwqPXwv PXwlPXwmPXxcfD18Xj18PDw9fD4+PXwvKVwoJywgJ29wZXJhdG9yXCgnLCBsaW5lKQotICAgICMg RG9uJ3QgdHJ5IHRvIGRvIHNwYWNpbmcgY2hlY2tzIGZvciAjaW5jbHVkZSwgI2ltcG9ydCwgb3Ig I2lmIHN0YXRlbWVudHMgYXQKLSAgICAjIG1pbmltdW0gYmVjYXVzZSBpdCBtZXNzZXMgdXAgY2hl Y2tzIGZvciBzcGFjaW5nIGFyb3VuZCAvCisgICAgIyBEb24ndCB0cnkgdG8gZG8gc3BhY2luZyBj aGVja3MgZm9yICNpbmNsdWRlLCAjaW1wb3J0LCAjaWYgc3RhdGVtZW50cywgb3IgX19oYXNfaW5j bHVkZSBwcmVkaWNhdGUKKyAgICAjIGF0IG1pbmltdW0gYmVjYXVzZSBpdCBtZXNzZXMgdXAgY2hl Y2tzIGZvciBzcGFjaW5nIGFyb3VuZCAvCiAgICAgaWYgbWF0Y2gocidccyojXHMqKD86aW5jbHVk ZXxpbXBvcnR8aWYpJywgbGluZSk6CiAgICAgICAgIHJldHVybgorICAgIGlmIHNlYXJjaChyJ19f aGFzX2luY2x1ZGUnLCBsaW5lKToKKyAgICAgICAgcmV0dXJuCiAgICAgaWYgbm90IGlzX29iamVj dGl2ZV9jX3Byb3BlcnR5IGFuZCBub3QgaXNfb2JqZWN0aXZlX2Nfc3ludGhlc2l6ZSBhbmQgc2Vh cmNoKHInW1x3Ll09W1x3Ll0nLCBsaW5lKToKICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3 aGl0ZXNwYWNlL29wZXJhdG9ycycsIDQsCiAgICAgICAgICAgICAgICdNaXNzaW5nIHNwYWNlcyBh cm91bmQgPScpCg== 318404 2017-08-17 12:54:05 -0700 2017-08-17 19:17:10 -0700 Patch bug175652.patch text/plain 2626 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0OWYy NWEwYzVmMS4uNGZkMDk5Yzk4NTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOC0xNyAgWW9zaGlha2kgSml0 c3VrYXdhICA8WW9zaGlha2kuSml0c3VrYXdhQHNvbnkuY29tPgorCisgICAgICAgIGNoZWNrLXdl YmtpdC1zdHlsZSBzaG91bGRuJ3QgY2hlY2sgc3BhY2luZyBpbiAjZWxpZiBwcmVwcm9jZXNzb3Ig bGluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NTY1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19z cGFjaW5nKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weToKKyAgICAgICAgKENwcFN0eWxlVGVzdC50ZXN0X3NwYWNpbmdfZm9yX2JpbmFy eV9vcHMpOgorCiAyMDE3LTA4LTE3ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K IAogICAgICAgICBEaXNhYmxlIENTUyByZWdpb25zIGF0IGNvbXBpbGUgdGltZQpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCAyZjFjNzNiZjAwNS4u NTZlZDQ2MTcxNDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CkBAIC0xODY5LDkgKzE4NjksOSBAQCBkZWYgY2hlY2tfc3BhY2luZyhmaWxlX2V4dGVu c2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CiAKICAg ICAjIERvbid0IHRyeSB0byBkbyBzcGFjaW5nIGNoZWNrcyBmb3Igb3BlcmF0b3IgbWV0aG9kcwog ICAgIGxpbmUgPSBzdWIocidvcGVyYXRvcig9PXwhPXw8fDw8fDw9fD49fD4+fD58XCs9fC09fFwq PXwvPXwlPXwmPXxcfD18Xj18PDw9fD4+PXwvKVwoJywgJ29wZXJhdG9yXCgnLCBsaW5lKQotICAg ICMgRG9uJ3QgdHJ5IHRvIGRvIHNwYWNpbmcgY2hlY2tzIGZvciAjaW5jbHVkZSwgI2ltcG9ydCwg b3IgI2lmIHN0YXRlbWVudHMgYXQKKyAgICAjIERvbid0IHRyeSB0byBkbyBzcGFjaW5nIGNoZWNr cyBmb3IgI2luY2x1ZGUsICNpbXBvcnQsICNpZiwgb3IgI2VsaWYgc3RhdGVtZW50cyBhdAogICAg ICMgbWluaW11bSBiZWNhdXNlIGl0IG1lc3NlcyB1cCBjaGVja3MgZm9yIHNwYWNpbmcgYXJvdW5k IC8KLSAgICBpZiBtYXRjaChyJ1xzKiNccyooPzppbmNsdWRlfGltcG9ydHxpZiknLCBsaW5lKToK KyAgICBpZiBtYXRjaChyJ1xzKiNccyooPzppbmNsdWRlfGltcG9ydHxpZnxlbGlmKScsIGxpbmUp OgogICAgICAgICByZXR1cm4KICAgICBpZiBub3QgaXNfb2JqZWN0aXZlX2NfcHJvcGVydHkgYW5k IG5vdCBpc19vYmplY3RpdmVfY19zeW50aGVzaXplIGFuZCBzZWFyY2gocidbXHcuXT1bXHcuXScs IGxpbmUpOgogICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2Uvb3BlcmF0b3Jz JywgNCwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHkKaW5kZXggYWE1ZjY5NjNiZjIuLjJhZWU5MzE0MDE5IDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eQpAQCAtMjAzMyw2ICsyMDMzLDggQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJh c2UpOgogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJyNpbmNsdWRlIDxzeXMv aW8uaD5cbicsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJyNpbXBv cnQgPGZvby9iYXIuaD5cbicsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xp bnQoJyNpZiBfX2hhc19pbmNsdWRlKDxBcHBsaWNhdGlvblNlcnZpY2VzL0FwcGxpY2F0aW9uU2Vy dmljZXNQcml2Lmg+KVxuJywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGlu dCgnI2VsaWYgX19oYXNfaW5jbHVkZSg8QXBwbGljYXRpb25TZXJ2aWNlcy9BcHBsaWNhdGlvblNl cnZpY2VzUHJpdi5oPilcbicsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xp bnQoJyNlbmRpZiAvLyBfX2hhc19pbmNsdWRlKDxBcHBsaWNhdGlvblNlcnZpY2VzL0FwcGxpY2F0 aW9uU2VydmljZXNQcml2Lmg+KVxuJywgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ0Zv byYmIGEgPSBiYXIoKTsnLCAnJykKIAogICAgIGRlZiB0ZXN0X29wZXJhdG9yX21ldGhvZHMoc2Vs Zik6Cg==