175635 2017-08-16 13:11:52 -0700 [GTK] Regression in imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html 2017-08-16 17:44:54 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=175628 P2 Normal --- 1 aboya webkit-unassigned cdumez lforschler mcatanzaro youennf oldest_to_newest 1339260 0 aboya 2017-08-16 13:11:52 -0700 The following layout test is failing on GTK. imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html Probable cause: r220779 introduced a workaround for the Fetch & Beacon API: > Use "application/octet-stream" Content-Type for payloads of type > ArrayBuffer / ArrayBufferView in Fetch & Beacon. If we don't set a > Content-Type header, our underlying network stack is going to add a > "application/x-www-form-urlencoded" Content-Type header, which is worse. > > Chrome is already using "application/octet-stream" Content-Type in Beacon, > but use no Content-Type in Fetch. The Fetch/Beacon specification says we > should have no Content-Type header in this case but this is unfortunately not > something we can support at the moment. Using "application/octet-stream" > Content-Type for now seems like the lesser evil. This workaround is unnecessary in WebKitGTK, which does not have the mentioned limitation. The related tests were passing in WebKitGTK, but this workaround has turned them into failures. We should either: a) Introduce the workaround only for platforms where it is needed. b) Update tests expectations in all ports. I think a) is preferrable in this case, as the workaround is for port-specific issues. 1339264 1 318285 aboya 2017-08-16 13:17:57 -0700 Created attachment 318285 Patch 1339267 2 youennf 2017-08-16 13:26:14 -0700 r220779 will probably be rolled out. If not, we should indeed restrict it to platform not being able to comply with the specs. 1339277 3 cdumez 2017-08-16 13:41:45 -0700 Patch is being reworked via https://bugs.webkit.org/show_bug.cgi?id=175628. Will likely land today. 1339383 4 318285 mcatanzaro 2017-08-16 17:44:49 -0700 Comment on attachment 318285 Patch So the patch in bug #175628 has landed. Hopefully that means we can close this bug. 318285 2017-08-16 13:17:57 -0700 2017-08-16 17:44:49 -0700 Patch bug-175635-20170816221756.patch text/plain 2255 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IzNzJmM2ZlZjUxYTk5 YWNhMWExOGQxOTYzNzU3ZmZkNDcxYzM0Yy4uNjJkMDljNjViMDRjM2MyMDVjMjdmNjc3MzYwNDg0 MTVhYWY0NjM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA4LTE2ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBSZWdy ZXNzaW9uIGluIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Jhc2lj L3JlcXVlc3QtaGVhZGVycy5hbnkuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxlIHdvcmthcm91bmQgb2YgcjIyMDc3OSBvbmx5IGZvciBD b2NvYSBwbGF0Zm9ybSwgYXMgaXQncyBub3QKKyAgICAgICAgcmVhbGx5IG5lZWRlZCBpbiBXZWJL aXRHVEssIHdoZXJlIHRoZSByZWxldmFudCB0ZXN0cyB3ZXJlIGFscmVhZHkKKyAgICAgICAgcGFz c2luZyBhbmQgd2VyZSBicm9rZW4gYnkgdGhlIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVsZXMv ZmV0Y2gvRmV0Y2hCb2R5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZldGNoQm9keTo6ZXh0cmFj dCk6CisKIDIwMTctMDgtMTYgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXVtFTUVdIFJld29yayBoYW5kbGluZyBrZXkg c3lzdGVtcyBhbmQgVVVJRHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0 Y2gvRmV0Y2hCb2R5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gvRmV0Y2hCb2R5 LmNwcAppbmRleCAxNjA5YTVmMmFjMjAyZjNlYzcyODExYzkyNzJjNmFjZmQ1OGIzOWEwLi5lMDky ODgyNzcxMWNhNTY4Nzc1YjRkNzZlYzM1NzA5OTU3MjVmZWNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNoQm9keS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9mZXRjaC9GZXRjaEJvZHkuY3BwCkBAIC02NCwxNCArNjQsMTggQEAgRmV0Y2hCb2R5 IEZldGNoQm9keTo6ZXh0cmFjdChTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBJbml0 JiYgdmFsdWUsIFN0cmkKICAgICAgICAgUmVmPGNvbnN0IEFycmF5QnVmZmVyPiBidWZmZXIgPSBX VEY6OmdldDxSZWZQdHI8QXJyYXlCdWZmZXI+Pih2YWx1ZSkucmVsZWFzZU5vbk51bGwoKTsKICAg ICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBub3Qgc2V0IGEgQ29udGVudC1UeXBlIGhlcmUgYnV0 IHdlIG5lZWQgdG8gZG8gdGhpcyB1bnRpbCBhbGwgbmV0d29yayBzdGFja3MKICAgICAgICAgLy8g c3VwcG9ydCBzZW5kaW5nIG5vIENvbnRlbnQtVHlwZSBoZWFkZXIgKDxkYXI6Ly9wcm9ibGVtLzMz OTA2NTY3KS4KKyNpZiBQTEFURk9STShDT0NPQSkKICAgICAgICAgY29udGVudFR5cGUgPSBIVFRQ SGVhZGVyVmFsdWVzOjpvY3RldFN0cmVhbUNvbnRlbnRUeXBlKCk7CisjZW5kaWYKICAgICAgICAg cmV0dXJuIEZldGNoQm9keShXVEZNb3ZlKGJ1ZmZlcikpOwogICAgIH0KICAgICBpZiAoV1RGOjpo b2xkc19hbHRlcm5hdGl2ZTxSZWZQdHI8QXJyYXlCdWZmZXJWaWV3Pj4odmFsdWUpKSB7CiAgICAg ICAgIFJlZjxjb25zdCBBcnJheUJ1ZmZlclZpZXc+IGJ1ZmZlciA9IFdURjo6Z2V0PFJlZlB0cjxB cnJheUJ1ZmZlclZpZXc+Pih2YWx1ZSkucmVsZWFzZU5vbk51bGwoKTsKICAgICAgICAgLy8gRklY TUU6IFdlIHNob3VsZCBub3Qgc2V0IGEgQ29udGVudC1UeXBlIGhlcmUgYnV0IHdlIG5lZWQgdG8g ZG8gdGhpcyB1bnRpbCBhbGwgbmV0d29yayBzdGFja3MKICAgICAgICAgLy8gc3VwcG9ydCBzZW5k aW5nIG5vIENvbnRlbnQtVHlwZSBoZWFkZXIgKDxkYXI6Ly9wcm9ibGVtLzMzOTA2NTY3KS4KKyNp ZiBQTEFURk9STShDT0NPQSkKICAgICAgICAgY29udGVudFR5cGUgPSBIVFRQSGVhZGVyVmFsdWVz OjpvY3RldFN0cmVhbUNvbnRlbnRUeXBlKCk7CisjZW5kaWYKICAgICAgICAgcmV0dXJuIEZldGNo Qm9keShXVEZNb3ZlKGJ1ZmZlcikpOwogICAgIH0KIAo=