175604 2017-08-15 16:03:36 -0700 Make VM::scratchBufferForSize thread safe 2017-08-15 17:04:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174590 1 saam saam benjamin buildbot fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1338928 0 saam 2017-08-15 16:03:36 -0700 We currently call it from many threads, but it's not thread safe ... 1338951 1 318196 saam 2017-08-15 16:29:21 -0700 Created attachment 318196 patch 1338954 2 buildbot 2017-08-15 16:32:08 -0700 Attachment 318196 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/VM.h:574: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1338959 3 318196 ggaren 2017-08-15 16:48:11 -0700 Comment on attachment 318196 patch r=me 1338963 4 318196 mark.lam 2017-08-15 16:50:10 -0700 Comment on attachment 318196 patch View in context: https://bugs.webkit.org/attachment.cgi?id=318196&action=review r=me with issues resolved. > Source/JavaScriptCore/runtime/VM.cpp:1025 > + ScratchBuffer* newBuffer = ScratchBuffer::create(m_sizeOfLastScratchBuffer); Make sure that the newly allocated buffer's activeLength is set to 0. I'm not sure it's an issue, but I'm thinking of GC scanning it incorrectly if the active length is not set. 1338966 5 318196 saam 2017-08-15 17:01:29 -0700 Comment on attachment 318196 patch View in context: https://bugs.webkit.org/attachment.cgi?id=318196&action=review >> Source/JavaScriptCore/runtime/VM.cpp:1025 >> + ScratchBuffer* newBuffer = ScratchBuffer::create(m_sizeOfLastScratchBuffer); > > Make sure that the newly allocated buffer's activeLength is set to 0. I'm not sure it's an issue, but I'm thinking of GC scanning it incorrectly if the active length is not set. ScratchBuffer() already sets it to zero 1338967 6 saam 2017-08-15 17:04:16 -0700 landed in: https://trac.webkit.org/changeset/220777/webkit 1338968 7 webkit-bug-importer 2017-08-15 17:04:48 -0700 <rdar://problem/33907882> 318196 2017-08-15 16:29:21 -0700 2017-08-15 16:48:11 -0700 patch c-backup.diff text/plain 6088 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwNzcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE3LTA4LTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IE1ha2UgVk06OnNjcmF0Y2hCdWZmZXJGb3JTaXplIHRocmVhZCBzYWZlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU2MDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIHdhbnQgdG8gdXNlIHRoZSBWTTo6 c2NyYXRjaEJ1ZmZlckZvclNpemUgaW4gYW5vdGhlciBwYXRjaCBJJ20gd3JpdGluZy4KKyAgICAg ICAgVGhlIHVzZSBjYXNlIGZvciBteSBvdGhlciBwYXRjaCBpcyB0byBjYWxsIGl0IGZyb20gdGhl IGNvbXBpbGVyIHRocmVhZC4KKyAgICAgICAgV2hlbiByZWFkaW5nIHRoZSBjb2RlLCBJIHNhdyB0 aGF0IHRoaXMgQVBJIHdhcyBub3QgdGhyZWFkIHNhZmUuIFRoaXMgcGF0Y2gKKyAgICAgICAgbWFr ZXMgaXQgdGhyZWFkIHNhZmUuIEl0IGFjdHVhbGx5IHR1cm5zIG91dCB3ZSB3ZXJlIGNhbGxpbmcg dGhpcyBBUEkgZnJvbQorICAgICAgICB0aGUgY29tcGlsZXIgdGhyZWFkIGFscmVhZHkgd2hlbiB3 ZSBjcmVhdGVkIEZUTDo6U3RhdGUgZm9yIGFuIEZUTCBPU1IgZW50cnkKKyAgICAgICAgY29tcGls YXRpb24sIGFuZCBmcm9tIEZUTExvd2VyREZHVG9CMy4gVGhhdCBjb2RlIHdhcyByYWN5IGFuZCB3 cm9uZywgYnV0CisgICAgICAgIGlzIG5vdyBjb3JyZWN0IHdpdGggdGhpcyBwYXRjaC4KKworICAg ICAgICAqIHJ1bnRpbWUvVk0uY3BwOgorICAgICAgICAoSlNDOjpWTTo6Vk0pOgorICAgICAgICAo SlNDOjpWTTo6flZNKToKKyAgICAgICAgKEpTQzo6Vk06OmdhdGhlckNvbnNlcnZhdGl2ZVJvb3Rz KToKKyAgICAgICAgKEpTQzo6Vk06OnNjcmF0Y2hCdWZmZXJGb3JTaXplKToKKyAgICAgICAgKiBy dW50aW1lL1ZNLmg6CisgICAgICAgIChKU0M6OlNjcmF0Y2hCdWZmZXI6OmFsbG9jYXRpb25TaXpl KToKKyAgICAgICAgKEpTQzo6U2NyYXRjaEJ1ZmZlcjo6c2V0QWN0aXZlTGVuZ3RoKTogRGVsZXRl ZC4KKyAgICAgICAgKEpTQzo6Vk06OnNjcmF0Y2hCdWZmZXJGb3JTaXplKTogRGVsZXRlZC4KKwog MjAxNy0wOC0xNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBKU0MgbmFtZWQgYnl0ZWNvZGUgb2Zmc2V0cyBzaG91bGQgdXNlIHJlZmVyZW5jZXMgcmF0 aGVyIHRoYW4gcG9pbnRlcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZN LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJ KHJldmlzaW9uIDIyMDc3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTk0LDcgKzE5NCw2IEBAIFZNOjpWTShWTVR5cGUgdm1UeXBl LCBIZWFwVHlwZSBoZWFwVHlwZSkKICAgICAsIHN5bWJvbEltcGxUb1N5bWJvbE1hcCgqdGhpcykK ICAgICAsIHByb3RvdHlwZU1hcCgqdGhpcykKICAgICAsIGludGVycHJldGVyKDApCi0gICAgLCBz aXplT2ZMYXN0U2NyYXRjaEJ1ZmZlcigwKQogICAgICwgZW50cnlTY29wZSgwKQogICAgICwgbV9y ZWdFeHBDYWNoZShuZXcgUmVnRXhwQ2FjaGUodGhpcykpCiAjaWYgRU5BQkxFKFJFR0VYUF9UUkFD SU5HKQpAQCAtNDIzLDggKzQyMiw4IEBAIFZNOjp+Vk0oKQogI2VuZGlmCiAKICNpZiBFTkFCTEUo REZHX0pJVCkKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2NyYXRjaEJ1ZmZlcnMuc2l6 ZSgpOyArK2kpCi0gICAgICAgIGZhc3RGcmVlKHNjcmF0Y2hCdWZmZXJzW2ldKTsKKyAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9zY3JhdGNoQnVmZmVycy5zaXplKCk7ICsraSkKKyAgICAg ICAgZmFzdEZyZWUobV9zY3JhdGNoQnVmZmVyc1tpXSk7CiAjZW5kaWYKIH0KIApAQCAtNzQ2LDcg Kzc0NSw4IEBAIGlubGluZSB2b2lkIFZNOjp1cGRhdGVTdGFja0xpbWl0cygpCiAjaWYgRU5BQkxF KERGR19KSVQpCiB2b2lkIFZNOjpnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhDb25zZXJ2YXRpdmVS b290cyYgY29uc2VydmF0aXZlUm9vdHMpCiB7Ci0gICAgZm9yIChhdXRvKiBzY3JhdGNoQnVmZmVy IDogc2NyYXRjaEJ1ZmZlcnMpIHsKKyAgICBhdXRvIGxvY2sgPSBob2xkTG9jayhtX3NjcmF0Y2hC dWZmZXJMb2NrKTsKKyAgICBmb3IgKGF1dG8qIHNjcmF0Y2hCdWZmZXIgOiBtX3NjcmF0Y2hCdWZm ZXJzKSB7CiAgICAgICAgIGlmIChzY3JhdGNoQnVmZmVyLT5hY3RpdmVMZW5ndGgoKSkgewogICAg ICAgICAgICAgdm9pZCogYnVmZmVyU3RhcnQgPSBzY3JhdGNoQnVmZmVyLT5kYXRhQnVmZmVyKCk7 CiAgICAgICAgICAgICBjb25zZXJ2YXRpdmVSb290cy5hZGQoYnVmZmVyU3RhcnQsIHN0YXRpY19j YXN0PHZvaWQqPihzdGF0aWNfY2FzdDxjaGFyKj4oYnVmZmVyU3RhcnQpICsgc2NyYXRjaEJ1ZmZl ci0+YWN0aXZlTGVuZ3RoKCkpKTsKQEAgLTEwMDgsNCArMTAwOCwyNyBAQCB2b2lkIFZNOjpzZXRS dW5Mb29wKENGUnVuTG9vcFJlZiBydW5Mb29wCiB9CiAjZW5kaWYgLy8gVVNFKENGKQogCitTY3Jh dGNoQnVmZmVyKiBWTTo6c2NyYXRjaEJ1ZmZlckZvclNpemUoc2l6ZV90IHNpemUpCit7CisgICAg aWYgKCFzaXplKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAgIGF1dG8gbG9ja2VyID0g aG9sZExvY2sobV9zY3JhdGNoQnVmZmVyTG9jayk7CisKKyAgICBpZiAoc2l6ZSA+IG1fc2l6ZU9m TGFzdFNjcmF0Y2hCdWZmZXIpIHsKKyAgICAgICAgLy8gUHJvdGVjdCBhZ2FpbnN0IGEgTl4yIG1l bW9yeSB1c2FnZSBwYXRob2xvZ3kgYnkgZW5zdXJpbmcKKyAgICAgICAgLy8gdGhhdCBhdCB3b3Jz dCwgd2UgZ2V0IGEgZ2VvbWV0cmljIHNlcmllcywgbWVhbmluZyB0aGF0IHRoZQorICAgICAgICAv LyB0b3RhbCBtZW1vcnkgdXNhZ2UgaXMgc29tZXdoZXJlIGFyb3VuZAorICAgICAgICAvLyBtYXgo c2NyYXRjaCBidWZmZXIgc2l6ZSkgKiA0LgorICAgICAgICBtX3NpemVPZkxhc3RTY3JhdGNoQnVm ZmVyID0gc2l6ZSAqIDI7CisKKyAgICAgICAgU2NyYXRjaEJ1ZmZlciogbmV3QnVmZmVyID0gU2Ny YXRjaEJ1ZmZlcjo6Y3JlYXRlKG1fc2l6ZU9mTGFzdFNjcmF0Y2hCdWZmZXIpOworICAgICAgICBS RUxFQVNFX0FTU0VSVChuZXdCdWZmZXIpOworICAgICAgICBtX3NjcmF0Y2hCdWZmZXJzLmFwcGVu ZChuZXdCdWZmZXIpOworICAgIH0KKworICAgIFNjcmF0Y2hCdWZmZXIqIHJlc3VsdCA9IG1fc2Ny YXRjaEJ1ZmZlcnMubGFzdCgpOworICAgIHJldHVybiByZXN1bHQ7Cit9CisKIH0gLy8gbmFtZXNw YWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCShyZXZpc2lvbiAyMjA3 NzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCSh3b3JraW5nIGNvcHkp CkBAIC0yMjEsNyArMjIxLDYgQEAgc3RydWN0IFNjcmF0Y2hCdWZmZXIgewogICAgIH0KIAogICAg IHN0YXRpYyBzaXplX3QgYWxsb2NhdGlvblNpemUoQ2hlY2tlZDxzaXplX3Q+IGJ1ZmZlclNpemUp IHsgcmV0dXJuIChzaXplb2YoU2NyYXRjaEJ1ZmZlcikgKyBidWZmZXJTaXplKS51bnNhZmVHZXQo KTsgfQotICAgIHZvaWQgc2V0QWN0aXZlTGVuZ3RoKHNpemVfdCBhY3RpdmVMZW5ndGgpIHsgdS5t X2FjdGl2ZUxlbmd0aCA9IGFjdGl2ZUxlbmd0aDsgfQogICAgIHNpemVfdCBhY3RpdmVMZW5ndGgo KSBjb25zdCB7IHJldHVybiB1Lm1fYWN0aXZlTGVuZ3RoOyB9OwogICAgIHNpemVfdCogYWRkcmVz c09mQWN0aXZlTGVuZ3RoKCkgeyByZXR1cm4gJnUubV9hY3RpdmVMZW5ndGg7IH07CiAgICAgdm9p ZCogZGF0YUJ1ZmZlcigpIHsgcmV0dXJuIG1fYnVmZmVyOyB9CkBAIC01NjcsMzIgKzU2NiwxMiBA QCBwdWJsaWM6CiAgICAgSW5zdHJ1Y3Rpb24qIHRhcmdldEludGVycHJldGVyUENGb3JUaHJvdzsK ICAgICB1aW50MzJfdCBvc3JFeGl0SW5kZXg7CiAgICAgdm9pZCogb3NyRXhpdEp1bXBEZXN0aW5h dGlvbjsKLSAgICBWZWN0b3I8U2NyYXRjaEJ1ZmZlcio+IHNjcmF0Y2hCdWZmZXJzOwotICAgIHNp emVfdCBzaXplT2ZMYXN0U2NyYXRjaEJ1ZmZlcjsKLQogICAgIGJvb2wgaXNFeGVjdXRpbmdJblJl Z0V4cEpJVCB7IGZhbHNlIH07CiAKLSAgICBTY3JhdGNoQnVmZmVyKiBzY3JhdGNoQnVmZmVyRm9y U2l6ZShzaXplX3Qgc2l6ZSkKLSAgICB7Ci0gICAgICAgIGlmICghc2l6ZSkKLSAgICAgICAgICAg IHJldHVybiAwOwotCi0gICAgICAgIGlmIChzaXplID4gc2l6ZU9mTGFzdFNjcmF0Y2hCdWZmZXIp IHsKLSAgICAgICAgICAgIC8vIFByb3RlY3QgYWdhaW5zdCBhIE5eMiBtZW1vcnkgdXNhZ2UgcGF0 aG9sb2d5IGJ5IGVuc3VyaW5nCi0gICAgICAgICAgICAvLyB0aGF0IGF0IHdvcnN0LCB3ZSBnZXQg YSBnZW9tZXRyaWMgc2VyaWVzLCBtZWFuaW5nIHRoYXQgdGhlCi0gICAgICAgICAgICAvLyB0b3Rh bCBtZW1vcnkgdXNhZ2UgaXMgc29tZXdoZXJlIGFyb3VuZAotICAgICAgICAgICAgLy8gbWF4KHNj cmF0Y2ggYnVmZmVyIHNpemUpICogNC4KLSAgICAgICAgICAgIHNpemVPZkxhc3RTY3JhdGNoQnVm ZmVyID0gc2l6ZSAqIDI7Ci0KLSAgICAgICAgICAgIFNjcmF0Y2hCdWZmZXIqIG5ld0J1ZmZlciA9 IFNjcmF0Y2hCdWZmZXI6OmNyZWF0ZShzaXplT2ZMYXN0U2NyYXRjaEJ1ZmZlcik7Ci0gICAgICAg ICAgICBSRUxFQVNFX0FTU0VSVChuZXdCdWZmZXIpOwotICAgICAgICAgICAgc2NyYXRjaEJ1ZmZl cnMuYXBwZW5kKG5ld0J1ZmZlcik7Ci0gICAgICAgIH0KLQotICAgICAgICBTY3JhdGNoQnVmZmVy KiByZXN1bHQgPSBzY3JhdGNoQnVmZmVycy5sYXN0KCk7Ci0gICAgICAgIHJlc3VsdC0+c2V0QWN0 aXZlTGVuZ3RoKDApOwotICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgIH0KKyAgICAvLyBUaGUg dGhyZWFkaW5nIHByb3RvY29sIGhlcmUgaXMgYXMgZm9sbG93czoKKyAgICAvLyAtIFlvdSBjYW4g Y2FsbCBzY3JhdGNoQnVmZmVyRm9yU2l6ZSBmcm9tIGFueSB0aHJlYWQuCisgICAgLy8gLSBZb3Ug Y2FuIG9ubHkgc2V0IHRoZSBTY3JhdGNoQnVmZmVyJ3MgYWN0aXZlTGVuZ3RoIGZyb20gdGhlIG1h aW4gdGhyZWFkLgorICAgIFNjcmF0Y2hCdWZmZXIqIHNjcmF0Y2hCdWZmZXJGb3JTaXplKHNpemVf dCBzaXplKTsKIAogICAgIEVuY29kZWRKU1ZhbHVlKiBleGNlcHRpb25GdXp6aW5nQnVmZmVyKHNp emVfdCBzaXplKQogICAgIHsKQEAgLTgxNSw2ICs3OTQsOSBAQCBwcml2YXRlOgogICAgIHN0ZDo6 dW5pcXVlX3B0cjxUeXBlUHJvZmlsZXJMb2c+IG1fdHlwZVByb2ZpbGVyTG9nOwogICAgIHVuc2ln bmVkIG1fdHlwZVByb2ZpbGVyRW5hYmxlZENvdW50OwogICAgIGJvb2wgbV9uZWVkVG9GaXJlUHJp bWl0aXZlR2lnYWNhZ2VFbmFibGVkIHsgZmFsc2UgfTsKKyAgICBMb2NrIG1fc2NyYXRjaEJ1ZmZl ckxvY2s7CisgICAgVmVjdG9yPFNjcmF0Y2hCdWZmZXIqPiBtX3NjcmF0Y2hCdWZmZXJzOworICAg IHNpemVfdCBtX3NpemVPZkxhc3RTY3JhdGNoQnVmZmVyIHsgMCB9OwogICAgIElubGluZVdhdGNo cG9pbnRTZXQgbV9wcmltaXRpdmVHaWdhY2FnZUVuYWJsZWQ7CiAgICAgRnVuY3Rpb25IYXNFeGVj dXRlZENhY2hlIG1fZnVuY3Rpb25IYXNFeGVjdXRlZENhY2hlOwogICAgIHN0ZDo6dW5pcXVlX3B0 cjxDb250cm9sRmxvd1Byb2ZpbGVyPiBtX2NvbnRyb2xGbG93UHJvZmlsZXI7Cg==