175584 2017-08-15 10:33:44 -0700 We are too conservative about the effects of PushWithScope 2017-08-15 19:49:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 rmorisset webkit-unassigned buildbot commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1338735 0 rmorisset 2017-08-15 10:33:44 -0700 In https://bugs.webkit.org/show_bug.cgi?id=175470, Saam says that it is safe to remove the annotation that PushWithScope clobbers the world. This bug is just for tracking the removal of this annotation. 1338736 1 318133 rmorisset 2017-08-15 10:35:00 -0700 Created attachment 318133 Patch 1338755 2 318133 saam 2017-08-15 11:19:47 -0700 Comment on attachment 318133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318133&action=review > Source/JavaScriptCore/ChangeLog:7 > + It's worth a sentence describing the reasoning here. Given the semantics of PushWithScope, I think it's also worth changing Clobberize and DoesGC (based on making Clobberize not report it clobbers things). Can you also add tests that would stress a few things: - we CSE around a PushWithScope - cases where PushWithScope throws an exception in the DFG because the "o" is null/undefined - cases where PushWithScope allocates (e.g, the "o" is a number/string/Symbol) 1338995 3 318210 rmorisset 2017-08-15 18:13:18 -0700 Created attachment 318210 Patch 1338997 4 318210 saam 2017-08-15 18:15:28 -0700 Comment on attachment 318210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318210&action=review > Source/JavaScriptCore/dfg/DFGClobberize.h:475 > + read(ScopeProperties); This is not the case, this node does not read ScopeProperties. This heap kind is for GetClosureVar, PutClosureVar. Also, please add tests that stress the CSE this opens up. 1338998 5 318210 saam 2017-08-15 18:18:44 -0700 Comment on attachment 318210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318210&action=review > Source/JavaScriptCore/dfg/DFGClobberize.h:476 > + read(HeapObjectCount); This reads more things. For example, it needs to read at least enough things to do a type check, to JSCell_typeInfo, JSCell_structureID, etc Maybe it's good to just say read(World) for now 1339017 6 318216 rmorisset 2017-08-15 19:06:03 -0700 Created attachment 318216 Patch 1339027 7 318216 commit-queue 2017-08-15 19:49:08 -0700 Comment on attachment 318216 Patch Clearing flags on attachment: 318216 Committed r220783: <http://trac.webkit.org/changeset/220783> 1339028 8 commit-queue 2017-08-15 19:49:09 -0700 All reviewed patches have been landed. Closing bug. 318133 2017-08-15 10:35:00 -0700 2017-08-15 18:13:16 -0700 Patch bug-175584-20170815103458.patch text/plain 1501 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy Y2Y5ZTMwZDU0Y2RhOTMxNjFjYjJjYTY4NzBjNTkxYzY4NDk0MDM3Li4xYzIyYWQ3YjJmODFkOTg3 MjM5ODFmZDNkZjhhM2VlZjhlYThjYWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wOC0xNSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSB0aGUgY29uc2VydmF0aXZlIGNsb2JiZXJpbmcgb2YgdGhl IHdvcmxkIGZyb20gUHVzaFdpdGhTY29wZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTU4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6 CisgICAgICAgIChKU0M6OkRGRzo6QWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlw ZT46OmV4ZWN1dGVFZmZlY3RzKToKKwogMjAxNy0wOC0xNCAgUm9iaW4gTW9yaXNzZXQgIDxybW9y aXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgdGhlICd3aXRoJyBrZXl3b3JkIGlu IERGRwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdElu dGVycHJldGVySW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oCmluZGV4IDUxZjNkN2U5Y2Q3NzljNDA5MzQzOWM1YzMyNTVh NzBmZTQyZTIxNDcuLmZmNmFmNjU1Yzk0YmQ1ZWJlMGY3NGIyNTFlYTIzMGU3ZmRiMGFiYjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRl cklubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50 ZXJwcmV0ZXJJbmxpbmVzLmgKQEAgLTIwNjMsOCArMjA2Myw2IEBAIGJvb2wgQWJzdHJhY3RJbnRl cnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVFZmZlY3RzKHVuc2lnbmVkIGNsb2Ji ZXJMaW1pCiAgICAgfQogCiAgICAgY2FzZSBQdXNoV2l0aFNjb3BlOgotICAgICAgICBjbG9iYmVy V29ybGQobm9kZS0+b3JpZ2luLnNlbWFudGljLCBjbG9iYmVyTGltaXQpOwotCiAgICAgICAgIC8v IFdlIGRvbid0IHVzZSB0aGUgbW9yZSBwcmVjaXNlIHdpdGhTY29wZVN0cnVjdHVyZSgpIGhlcmUg YmVjYXVzZSBpdCBpcyBhIExhenlQcm9wZXJ0eSBhbmQgbWF5IG5vdCB5ZXQgYmUgYWxsb2NhdGVk LgogICAgICAgICBmb3JOb2RlKG5vZGUpLnNldFR5cGUobV9ncmFwaCwgU3BlY09iamVjdE90aGVy KTsKICAgICAgICAgYnJlYWs7Cg== 318210 2017-08-15 18:13:18 -0700 2017-08-15 19:06:01 -0700 Patch bug-175584-20170815181318.patch text/plain 3517 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NjdkMWMxNjE4MzM0ODU3ODU0NWNhNGMxNjkxZjEyOTExY2QyOTYyLi44MmZjMDZlZDUwODEzYTY0 YjliMjZhZWJmMjRhMDFiM2ZmMGQ4YmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNy0wOC0xNSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFdlIGFyZSB0b28gY29uc2VydmF0aXZlIGFib3V0IHRoZSBlZmZlY3Rz IG9mIFB1c2hXaXRoU2NvcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NTU4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFB1c2hXaXRoU2NvcGUgY29udmVydHMgaXRzIGFyZ3VtZW50IHRvIGFuIG9iamVj dCAodGhpcyBjYW4gdGhyb3cgYSB0eXBlIGVycm9yLAorICAgICAgICBidXQgaGFzIG5vIG90aGVy IG9ic2VydmFibGUgZWZmZWN0KSwgYW5kIGFsbG9jYXRlcyBhIG5ldyBzY29wZSwgdGhhdCBpdCB0 aGVuCisgICAgICAgIG1ha2VzIHRoZSBuZXcgY3VycmVudCBzY29wZS4gV2Ugd2VyZSBhIGJpdCB0 b28KKyAgICAgICAgY29uc2VydmF0aXZlIGluIHNheWluZyB0aGF0IGl0IGNsb2JiZXJzIHRoZSB3 b3JsZC4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oOgor ICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5cGU+ OjpleGVjdXRlRWZmZWN0cyk6CisgICAgICAgICogZGZnL0RGR0Nsb2JiZXJpemUuaDoKKyAgICAg ICAgKEpTQzo6REZHOjpjbG9iYmVyaXplKToKKyAgICAgICAgKiBkZmcvREZHRG9lc0dDLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpkb2VzR0MpOgorCiAyMDE3LTA4LTE1ICBTYWFtIEJhcmF0aSAg PHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgVk06OnNjcmF0Y2hCdWZmZXJGb3JT aXplIHRocmVhZCBzYWZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKaW5kZXggOGEyOTg2Yjg5ZDg1MDM0MmFh ZGViNWFhOTgyMTRhYWMxYTRmMjlkMC4uNGQxZTBhN2UzMjhkNzU1Y2I0ODkzMDFiODdlMmRiNTFk N2VhZDViZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH QWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaApAQCAtMjA2NCw4ICsyMDY0LDYgQEAgYm9vbCBB YnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0U3RhdGVUeXBlPjo6ZXhlY3V0ZUVmZmVjdHModW5z aWduZWQgY2xvYmJlckxpbWkKICAgICB9CiAKICAgICBjYXNlIFB1c2hXaXRoU2NvcGU6Ci0gICAg ICAgIGNsb2JiZXJXb3JsZChub2RlLT5vcmlnaW4uc2VtYW50aWMsIGNsb2JiZXJMaW1pdCk7Ci0K ICAgICAgICAgLy8gV2UgZG9uJ3QgdXNlIHRoZSBtb3JlIHByZWNpc2Ugd2l0aFNjb3BlU3RydWN0 dXJlKCkgaGVyZSBiZWNhdXNlIGl0IGlzIGEgTGF6eVByb3BlcnR5IGFuZCBtYXkgbm90IHlldCBi ZSBhbGxvY2F0ZWQuCiAgICAgICAgIGZvck5vZGUobm9kZSkuc2V0VHlwZShtX2dyYXBoLCBTcGVj T2JqZWN0T3RoZXIpOwogICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdDbG9iYmVyaXplLmgKaW5kZXggM2ZlYWIzNTA2Mzk3NzgxNDRmMGM5ZTNmYzc2YzFlNTY2MzIx NTIxZC4uMzlmMTkwZDg5OWY5ODcyYmQ5NmI5ODY3YmNjYmVmODhlM2E3MzI5MyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKQEAgLTQ3MSw2ICs0NzEsMTMgQEAg dm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZSwgY29uc3QgUmVhZEZ1bmN0 b3ImIHJlYWQsIGNvbnN0IFdyaXRlRnUKICAgICAgICAgd3JpdGUoU2lkZVN0YXRlKTsKICAgICAg ICAgcmV0dXJuOwogCisgICAgY2FzZSBQdXNoV2l0aFNjb3BlOiB7CisgICAgICAgIHJlYWQoU2Nv cGVQcm9wZXJ0aWVzKTsKKyAgICAgICAgcmVhZChIZWFwT2JqZWN0Q291bnQpOworICAgICAgICB3 cml0ZShIZWFwT2JqZWN0Q291bnQpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgY2Fz ZSBDcmVhdGVBY3RpdmF0aW9uOiB7CiAgICAgICAgIFN5bWJvbFRhYmxlKiB0YWJsZSA9IG5vZGUt PmNhc3RPcGVyYW5kPFN5bWJvbFRhYmxlKj4oKTsKICAgICAgICAgaWYgKHRhYmxlLT5zaW5nbGV0 b25TY29wZSgpLT5pc1N0aWxsVmFsaWQoKSkKQEAgLTYwNSw3ICs2MTIsNiBAQCB2b2lkIGNsb2Ji ZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlLCBjb25zdCBSZWFkRnVuY3RvciYgcmVhZCwg Y29uc3QgV3JpdGVGdQogICAgIGNhc2UgUHV0RHluYW1pY1ZhcjoKICAgICBjYXNlIFJlc29sdmVT Y29wZUZvckhvaXN0aW5nRnVuY0RlY2xJbkV2YWw6CiAgICAgY2FzZSBSZXNvbHZlU2NvcGU6Ci0g ICAgY2FzZSBQdXNoV2l0aFNjb3BlOgogICAgICAgICByZWFkKFdvcmxkKTsKICAgICAgICAgd3Jp dGUoSGVhcCk7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHRG9lc0dDLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9l c0dDLmNwcAppbmRleCBjNWVkYjU1NDE2ZWU1NDNiYzUxMWY2ZjA5NGUzNzRmMzhkYmQwMmZhLi5i NGFkYmZkZDA4YWRiMzU1ZmQ2NzcyMmFhMDI1NzM2YzMzODYzOGQ0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdEb2VzR0MuY3BwCkBAIC0yODAsOSArMjgwLDkgQEAgYm9vbCBkb2VzR0Mo R3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlKQogICAgIGNhc2UgQXRvbWljc1N1YjoKICAgICBjYXNl IEF0b21pY3NYb3I6CiAgICAgY2FzZSBBdG9taWNzSXNMb2NrRnJlZToKLSAgICBjYXNlIFB1c2hX aXRoU2NvcGU6CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGNhc2UgUHVzaFdpdGhTY29w ZToKICAgICBjYXNlIENyZWF0ZUFjdGl2YXRpb246CiAgICAgY2FzZSBDcmVhdGVEaXJlY3RBcmd1 bWVudHM6CiAgICAgY2FzZSBDcmVhdGVTY29wZWRBcmd1bWVudHM6Cg== 318216 2017-08-15 19:06:03 -0700 2017-08-15 19:49:08 -0700 Patch bug-175584-20170815190602.patch text/plain 3475 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NjdkMWMxNjE4MzM0ODU3ODU0NWNhNGMxNjkxZjEyOTExY2QyOTYyLi44MmZjMDZlZDUwODEzYTY0 YjliMjZhZWJmMjRhMDFiM2ZmMGQ4YmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNy0wOC0xNSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFdlIGFyZSB0b28gY29uc2VydmF0aXZlIGFib3V0IHRoZSBlZmZlY3Rz IG9mIFB1c2hXaXRoU2NvcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NTU4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFB1c2hXaXRoU2NvcGUgY29udmVydHMgaXRzIGFyZ3VtZW50IHRvIGFuIG9iamVj dCAodGhpcyBjYW4gdGhyb3cgYSB0eXBlIGVycm9yLAorICAgICAgICBidXQgaGFzIG5vIG90aGVy IG9ic2VydmFibGUgZWZmZWN0KSwgYW5kIGFsbG9jYXRlcyBhIG5ldyBzY29wZSwgdGhhdCBpdCB0 aGVuCisgICAgICAgIG1ha2VzIHRoZSBuZXcgY3VycmVudCBzY29wZS4gV2Ugd2VyZSBhIGJpdCB0 b28KKyAgICAgICAgY29uc2VydmF0aXZlIGluIHNheWluZyB0aGF0IGl0IGNsb2JiZXJzIHRoZSB3 b3JsZC4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oOgor ICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5cGU+ OjpleGVjdXRlRWZmZWN0cyk6CisgICAgICAgICogZGZnL0RGR0Nsb2JiZXJpemUuaDoKKyAgICAg ICAgKEpTQzo6REZHOjpjbG9iYmVyaXplKToKKyAgICAgICAgKiBkZmcvREZHRG9lc0dDLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpkb2VzR0MpOgorCiAyMDE3LTA4LTE1ICBTYWFtIEJhcmF0aSAg PHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgVk06OnNjcmF0Y2hCdWZmZXJGb3JT aXplIHRocmVhZCBzYWZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKaW5kZXggOGEyOTg2Yjg5ZDg1MDM0MmFh ZGViNWFhOTgyMTRhYWMxYTRmMjlkMC4uNGQxZTBhN2UzMjhkNzU1Y2I0ODkzMDFiODdlMmRiNTFk N2VhZDViZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH QWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaApAQCAtMjA2NCw4ICsyMDY0LDYgQEAgYm9vbCBB YnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0U3RhdGVUeXBlPjo6ZXhlY3V0ZUVmZmVjdHModW5z aWduZWQgY2xvYmJlckxpbWkKICAgICB9CiAKICAgICBjYXNlIFB1c2hXaXRoU2NvcGU6Ci0gICAg ICAgIGNsb2JiZXJXb3JsZChub2RlLT5vcmlnaW4uc2VtYW50aWMsIGNsb2JiZXJMaW1pdCk7Ci0K ICAgICAgICAgLy8gV2UgZG9uJ3QgdXNlIHRoZSBtb3JlIHByZWNpc2Ugd2l0aFNjb3BlU3RydWN0 dXJlKCkgaGVyZSBiZWNhdXNlIGl0IGlzIGEgTGF6eVByb3BlcnR5IGFuZCBtYXkgbm90IHlldCBi ZSBhbGxvY2F0ZWQuCiAgICAgICAgIGZvck5vZGUobm9kZSkuc2V0VHlwZShtX2dyYXBoLCBTcGVj T2JqZWN0T3RoZXIpOwogICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdDbG9iYmVyaXplLmgKaW5kZXggM2ZlYWIzNTA2Mzk3NzgxNDRmMGM5ZTNmYzc2YzFlNTY2MzIx NTIxZC4uNDM4YjkyMDdiYmNjYjhlMDBmOWQxMjg0ZmFkZGViODMxZTlhYjEzNCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKQEAgLTQ3MSw2ICs0NzEsMTIgQEAg dm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZSwgY29uc3QgUmVhZEZ1bmN0 b3ImIHJlYWQsIGNvbnN0IFdyaXRlRnUKICAgICAgICAgd3JpdGUoU2lkZVN0YXRlKTsKICAgICAg ICAgcmV0dXJuOwogCisgICAgY2FzZSBQdXNoV2l0aFNjb3BlOiB7CisgICAgICAgIHJlYWQoV29y bGQpOworICAgICAgICB3cml0ZShIZWFwT2JqZWN0Q291bnQpOworICAgICAgICByZXR1cm47Cisg ICAgfQorCiAgICAgY2FzZSBDcmVhdGVBY3RpdmF0aW9uOiB7CiAgICAgICAgIFN5bWJvbFRhYmxl KiB0YWJsZSA9IG5vZGUtPmNhc3RPcGVyYW5kPFN5bWJvbFRhYmxlKj4oKTsKICAgICAgICAgaWYg KHRhYmxlLT5zaW5nbGV0b25TY29wZSgpLT5pc1N0aWxsVmFsaWQoKSkKQEAgLTYwNSw3ICs2MTEs NiBAQCB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlLCBjb25zdCBSZWFk RnVuY3RvciYgcmVhZCwgY29uc3QgV3JpdGVGdQogICAgIGNhc2UgUHV0RHluYW1pY1ZhcjoKICAg ICBjYXNlIFJlc29sdmVTY29wZUZvckhvaXN0aW5nRnVuY0RlY2xJbkV2YWw6CiAgICAgY2FzZSBS ZXNvbHZlU2NvcGU6Ci0gICAgY2FzZSBQdXNoV2l0aFNjb3BlOgogICAgICAgICByZWFkKFdvcmxk KTsKICAgICAgICAgd3JpdGUoSGVhcCk7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9lc0dDLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHRG9lc0dDLmNwcAppbmRleCBjNWVkYjU1NDE2ZWU1NDNiYzUxMWY2ZjA5NGUz NzRmMzhkYmQwMmZhLi5iNGFkYmZkZDA4YWRiMzU1ZmQ2NzcyMmFhMDI1NzM2YzMzODYzOGQ0IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEb2VzR0MuY3BwCkBAIC0yODAsOSArMjgwLDkg QEAgYm9vbCBkb2VzR0MoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlKQogICAgIGNhc2UgQXRvbWlj c1N1YjoKICAgICBjYXNlIEF0b21pY3NYb3I6CiAgICAgY2FzZSBBdG9taWNzSXNMb2NrRnJlZToK LSAgICBjYXNlIFB1c2hXaXRoU2NvcGU6CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGNh c2UgUHVzaFdpdGhTY29wZToKICAgICBjYXNlIENyZWF0ZUFjdGl2YXRpb246CiAgICAgY2FzZSBD cmVhdGVEaXJlY3RBcmd1bWVudHM6CiAgICAgY2FzZSBDcmVhdGVTY29wZWRBcmd1bWVudHM6Cg==