175576 2017-08-15 09:15:49 -0700 [GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled. 2017-08-29 03:33:08 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply calvaris clopez cturner magomez mcatanzaro oldest_to_newest 1338689 0 mcatanzaro 2017-08-15 09:15:49 -0700 I see this error in stderr for a bunch of tests on the GTK release bot: The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled. That's a WebKit bug since the glvideoflip GStreamer element needs to be either built in our JHBuild environment or installed by install-dependencies. What's supposed to be pulling it in? 1338692 1 clopez 2017-08-15 09:22:58 -0700 (In reply to Michael Catanzaro from comment #0) > I see this error in stderr for a bunch of tests on the GTK release bot: > > The glvideoflip GStreamer element isn't available. Video mirroring and > rotation functionalities are thus disabled. > > That's a WebKit bug since the glvideoflip GStreamer element needs to be > either built in our JHBuild environment or installed by > install-dependencies. What's supposed to be pulling it in? You need to have graphene installed when building gstreamer*, so the glvideoflip automatically gets built. graphene is still not available on debian stretch, its on testing. I have been told this warning is harmless and you are safe to ignore it (unless you care about video mirroring/rotation functionalities of course) 1338700 2 mcatanzaro 2017-08-15 09:33:41 -0700 It's cluttering our layout test results, which is not acceptable. I think we'll need to add graphene to our JHBuild environment, and have the right GStreamer plugins package (-base? -good? -bad?) depend on it. 1338712 3 clopez 2017-08-15 09:50:58 -0700 (In reply to Michael Catanzaro from comment #2) > It's cluttering our layout test results, which is not acceptable. > > I think we'll need to add graphene to our JHBuild environment, and have the > right GStreamer plugins package (-base? -good? -bad?) depend on it. bad. 1339104 4 calvaris 2017-08-16 00:58:47 -0700 FYI, this warning is not WebKit output but IIRC OpenWebRTC one. 1342853 5 319180 mcatanzaro 2017-08-28 10:27:22 -0700 Created attachment 319180 Patch 1342854 6 mcatanzaro 2017-08-28 10:27:50 -0700 There's still a huge number of tests with stderr output, but this cuts fixes ~15 or so. 1342865 7 319180 clopez 2017-08-28 11:17:50 -0700 Comment on attachment 319180 Patch I think that instead of doing this, we can add a patch for openwebrtc on the jhbuild recipe that comments out the warning (its at local/owr_video_renderer.c). That way we keep the jhbuild smaller and quicker to build. 1342872 8 mcatanzaro 2017-08-28 11:35:38 -0700 graphene and meson take almost no time to build since they're small and don't use Autotools! A patch would work too, but I have a suspicion that openwebrtc would not be complaining about the missing element if it were not important for WebRTC. 1342890 9 clopez 2017-08-28 12:24:43 -0700 (In reply to Michael Catanzaro from comment #8) > graphene and meson take almost no time to build since they're small and > don't use Autotools! > Ok. Can you at least add a <pkg-config> entry to avoid building graphene when the developer already installed it from the distro? > A patch would work too, but I have a suspicion that openwebrtc would not be > complaining about the missing element if it were not important for WebRTC. Then I hope to see some new test passing after this lands like webrtc/video-rotation.html :) 1342936 10 mcatanzaro 2017-08-28 14:08:05 -0700 (In reply to Carlos Alberto Lopez Perez from comment #9) > Ok. > > Can you at least add a <pkg-config> entry to avoid building graphene when > the developer already installed it from the distro? No, because graphene depends on glib, and glib is in our jhbuild environment. The system version of graphene could easily require newer symbols than are provided by our glib. 1342943 11 clopez 2017-08-28 14:22:01 -0700 (In reply to Michael Catanzaro from comment #10) > (In reply to Carlos Alberto Lopez Perez from comment #9) > > Ok. > > > > Can you at least add a <pkg-config> entry to avoid building graphene when > > the developer already installed it from the distro? > > No, because graphene depends on glib, and glib is in our jhbuild > environment. The system version of graphene could easily require newer > symbols than are provided by our glib. Mmm..... good point. 1342944 12 319180 clopez 2017-08-28 14:22:26 -0700 Comment on attachment 319180 Patch Please watch the bots after landing for possible breakages. 1342999 13 mcatanzaro 2017-08-28 17:28:55 -0700 OK, I'll watch. 1343003 14 mcatanzaro 2017-08-28 17:40:39 -0700 Committed r221284: <http://trac.webkit.org/changeset/221284> 1343020 15 mcatanzaro 2017-08-28 18:42:57 -0700 Unfortunately release bot has died for unrelated reasons, and all other GTK test bots are behind. The GTK buildbots are fine and the WPE bots are fine. I think it was a low-risk change, though. 1343083 16 calvaris 2017-08-29 03:33:08 -0700 (In reply to Michael Catanzaro from comment #8) > A patch would work too, but I have a suspicion that openwebrtc would not be > complaining about the missing element if it were not important for WebRTC. If it's the code I wrote and I think it is, the only thing is that some screen video flip won't work. Summing up, its importance is very relative. 319180 2017-08-28 10:27:22 -0700 2017-08-28 17:40:04 -0700 Patch bug-175576-20170828122722.patch text/plain 4209 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMjU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjRkYjNkNjMyOTUyZDAwYjk4YjA3YWJjOTFmMzQ5N2Ux NDNlNTE4MC4uYTczNGQ4MTdlYWRiOTQyNWU2ZWYxNjU4NGYyNmY4MGJmMDc3NTcwYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE3LTA4LTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1N0cmVhbWVyXSBUaGUgZ2x2aWRlb2ZsaXAgR1N0cmVhbWVyIGVsZW1l bnQgaXNuJ3QgYXZhaWxhYmxlLiBWaWRlbyBtaXJyb3JpbmcgYW5kIHJvdGF0aW9uIGZ1bmN0aW9u YWxpdGllcyBhcmUgdGh1cyBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTU3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEJ1aWxkIGdyYXBoZW5lIHRvIGVuYWJsZSB0aGUgZ2x2aWRlb2Zs aXAgZWxlbWVudC4KKworICAgICAgICAqIGdzdHJlYW1lci9qaGJ1aWxkLm1vZHVsZXM6CisgICAg ICAgICogZ3RrL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAgKiBqaGJ1aWxkL2poYnVpbGQtd3Jh cHBlcjoKKyAgICAgICAgKiB3cGUvamhidWlsZC5tb2R1bGVzOgorCiAyMDE3LTA4LTI4ICBNczJn ZXIgIDxNczJnZXJAZ21haWwuY29tPgogCiAgICAgICAgIEVuc3VyZSB0aGF0IHRoZSBhbGVydCBm dW5jdGlvbiBpcyBjYWxsZWQgaW4gVGVzdFdlYkV4dGVuc2lvbnMuCmRpZmYgLS1naXQgYS9Ub29s cy9nc3RyZWFtZXIvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZ3N0cmVhbWVyL2poYnVpbGQubW9k dWxlcwppbmRleCA1ODdjMjdmY2ZmYzk0MzlmOGQ5ZThlZDgyYjg2MjllNzhjZGEzY2IyLi5jYWMz NWY5ODBjM2FiYTg5ZWJlNzMzZjJkNDM0MjdmYzIxYmM5MjBkIDEwMDY0NAotLS0gYS9Ub29scy9n c3RyZWFtZXIvamhidWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2dzdHJlYW1lci9qaGJ1aWxkLm1v ZHVsZXMKQEAgLTgzLDYgKzgzLDcgQEAKIAogICA8YXV0b3Rvb2xzIGlkPSJnc3QtcGx1Z2lucy1i YWQiIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSIgYXV0b2dlbmFyZ3M9Ii0tZGlzYWJsZS1leGFtcGxl cyAtLWRpc2FibGUtZ3RrLWRvYyAtLWRpc2FibGUtaW50cm9zcGVjdGlvbiI+CiAgICAgPGRlcGVu ZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ3JhcGhlbmUiLz4KICAgICAgIDxkZXAgcGFj a2FnZT0iZ3N0LXBsdWdpbnMtYmFzZSIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJvcGVuaDI2NCIv PgogICAgIDwvZGVwZW5kZW5jaWVzPgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9k dWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggZGY2NTRlZTlhOGQ0NjYxNzg2 NjEzOTMxZjcxM2I2MWNjMjU0NGFmOS4uMzFiNjAzYmM1MWRmNTcwMTMzODAyYTBjYjBmYzhkMWJm MGIwYTI2MSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29s cy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0xNDcsNiArMTQ3LDE1IEBACiAgICAgICAgICAgICBo YXNoPSJzaGEyNTY6NDU1ZWI5MGMwOWVkMWI3MWY5NWYzZWJmZTFjOTA0YzIwNjcyN2UwZWViMzRm Yzk0ZTVhYWY5NDQ2NjNhODIwYyIvPgogICA8L2F1dG90b29scz4KIAorICA8bWVzb24gaWQ9Imdy YXBoZW5lIj4KKyAgICA8YnJhbmNoIHJlcG89ImdpdGh1Yi5jb20iCisgICAgICAgICAgICBtb2R1 bGU9ImViYXNzaS9ncmFwaGVuZS5naXQiCisgICAgICAgICAgICB0YWc9IjEuNi4wIi8+CisgICAg PGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgorICAgIDwvZGVwZW5k ZW5jaWVzPgorICA8L21lc29uPgorCiAgIDxhdXRvdG9vbHMgaWQ9ImxpYnJzdmciIGF1dG9nZW4t c2g9ImNvbmZpZ3VyZSIKICAgICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWludHJv c3BlY3Rpb24gLS1lbmFibGUtcGl4YnVmLWxvYWRlciAtLWRpc2FibGUtZ3RrLXRoZW1lIj4KICAg ICA8aWYgY29uZGl0aW9uLXNldD0ibWFjb3MiPgpAQCAtNTA5LDQgKzUxOCwxNSBAQAogICAgICAg ICAgICAgaGFzaD0ic2hhMjU2Ojc0ZGEyNzk4NzI4ZTc5YzNhZWRmZmZhMjY4ZDhmZTgxMWMzNzY2 Y2EzNzA4MzA5YzBkYzQ1NTAyYmUxMzdkYTEiLz4KICAgPC9hdXRvdG9vbHM+CiAKKyAgPGRpc3R1 dGlscyBpZD0ibWVzb24iIHB5dGhvbjM9IjEiPgorICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLXRh cmJhbGwiCisgICAgICAgICAgICB2ZXJzaW9uPSIwLjQyLjAiCisgICAgICAgICAgICBtb2R1bGU9 Im1lc29uYnVpbGQvbWVzb24vcmVsZWFzZXMvZG93bmxvYWQvJHt2ZXJzaW9ufS9tZXNvbi0ke3Zl cnNpb259LnRhci5neiIKKyAgICAgICAgICAgIGNoZWNrb3V0ZGlyPSJtZXNvbi0ke3ZlcnNpb259 IgorICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmE3NGM3Mzg3YTNkZDgxNzFlOTMxYmNkOTQ4MzU1 ZjdmOTUyOTM2OGVhZTcyYzNjMjJhOWJlZWY2YzJlNzM0OTgiLz4KKyAgICA8ZGVwZW5kZW5jaWVz PgorICAgICAgPGRlcCBwYWNrYWdlPSJuaW5qYSIvPgorICAgIDwvZGVwZW5kZW5jaWVzPgorICA8 L2Rpc3R1dGlscz4KKwogPC9tb2R1bGVzZXQ+CmRpZmYgLS1naXQgYS9Ub29scy9qaGJ1aWxkL2po YnVpbGQtd3JhcHBlciBiL1Rvb2xzL2poYnVpbGQvamhidWlsZC13cmFwcGVyCmluZGV4IDBhMzM1 YzBkYWExMGQ1NmY1N2JlYzRlMzRkNWMxZjcwN2U0MjY0NWMuLmVkMWJlODgxOTFiMDI5MWY3MDhj ZDA4NjQ2MDRjMGViM2NlZDk3YmEgMTAwNzU1Ci0tLSBhL1Rvb2xzL2poYnVpbGQvamhidWlsZC13 cmFwcGVyCisrKyBiL1Rvb2xzL2poYnVpbGQvamhidWlsZC13cmFwcGVyCkBAIC0yNCw3ICsyNCw3 IEBAIGltcG9ydCBzaGxleAogaW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCBzeXMKIAotamhidWls ZF9yZXZpc2lvbiA9ICdlNThlZTA4N2U5Mjc4OWJkMjE1MTEzMmNhYzkyNmYzMWNjMDEwMmQ4Jwor amhidWlsZF9yZXZpc2lvbiA9ICdiMWQyZWJkZWYxNjU0MzVjMDQ4YzU5MTkyYTMyYmE2OWQ0ZjJj NmRkJwogCiBkZWYgZGV0ZXJtaW5lX3BsYXRmb3JtKCk6CiAgICAgaWYgJy0tZ3RrJyBpbiBzeXMu YXJndjoKZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy93cGUv amhidWlsZC5tb2R1bGVzCmluZGV4IGE1OTdiZDI4MmEzZjg0NzBlN2Q1YmRiZTBkZDI3YTdlMzAy ZmVjNGUuLmU3ZTUxMTk5NDVjODk1ZjU0ZjEzM2UzZTI2OWJkNjZjN2RkMTNiNmMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvd3BlL2poYnVpbGQubW9k dWxlcwpAQCAtMjExLDQgKzIxMSwyNCBAQAogICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIg bW9kdWxlPSJJZ2FsaWEvZHl6IiB0YWc9IjA4ODAyNTJiYWMyNDNhZGQzOWVhNTRjMDc5N2NlYjE2 N2Q3NzVjZTkiLz4KICAgPC9hdXRvdG9vbHM+CiAKKyAgPG1lc29uIGlkPSJncmFwaGVuZSI+Cisg ICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIgorICAgICAgICAgICAgbW9kdWxlPSJlYmFzc2kv Z3JhcGhlbmUuZ2l0IgorICAgICAgICAgICAgdGFnPSIxLjYuMCIvPgorICAgIDxkZXBlbmRlbmNp ZXM+CisgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICA8L2RlcGVuZGVuY2llcz4KKyAg PC9tZXNvbj4KKworICA8ZGlzdHV0aWxzIGlkPSJtZXNvbiIgcHl0aG9uMz0iMSI+CisgICAgPGJy YW5jaCByZXBvPSJnaXRodWItdGFyYmFsbCIKKyAgICAgICAgICAgIHZlcnNpb249IjAuNDIuMCIK KyAgICAgICAgICAgIG1vZHVsZT0ibWVzb25idWlsZC9tZXNvbi9yZWxlYXNlcy9kb3dubG9hZC8k e3ZlcnNpb259L21lc29uLSR7dmVyc2lvbn0udGFyLmd6IgorICAgICAgICAgICAgY2hlY2tvdXRk aXI9Im1lc29uLSR7dmVyc2lvbn0iCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6YTc0YzczODdh M2RkODE3MWU5MzFiY2Q5NDgzNTVmN2Y5NTI5MzY4ZWFlNzJjM2MyMmE5YmVlZjZjMmU3MzQ5OCIv PgorICAgIDxkZXBlbmRlbmNpZXM+CisgICAgICA8ZGVwIHBhY2thZ2U9Im5pbmphIi8+CisgICAg PC9kZXBlbmRlbmNpZXM+CisgIDwvZGlzdHV0aWxzPgorCiA8L21vZHVsZXNldD4K