175571 2017-08-15 08:45:24 -0700 MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes 2017-08-21 05:59:38 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cturner cturner clopez commit-queue koivisto sam webkit-bug-importer oldest_to_newest 1338671 0 cturner 2017-08-15 08:45:24 -0700 After the grand move from WebKit2 -> WebKit, I was struggling to find information about these caching policies and what exactly they mean. The problem is that calculateMemoryCacheSizes fails to set cacheTotalCapacity to something sensible if the system has less than 512MB of RAM. This, // This code is here to avoid a PLT regression. We can remove it if we // can prove that the overall system gain would justify the regression. cacheMaxDeadCapacity = std::max(24u, cacheMaxDeadCapacity); Then obviously violates the checks in MemoryCache::setCapacities, because at this point cacheTotalCapacity is zero from the callsite. Patch basically follows the pattern to make sure cacheTotalCapacity is set. 1338672 1 318118 cturner 2017-08-15 08:47:24 -0700 Created attachment 318118 Patch 1338673 2 cturner 2017-08-15 08:49:43 -0700 Adding Sam, because I have no idea who's best to review this patch, and you were the last one I saw doing things with this area, sorry :) 1340566 3 cturner 2017-08-21 04:36:11 -0700 Please may someone cq+ this for me? I'm not a commiter. 1340578 4 318118 commit-queue 2017-08-21 05:59:03 -0700 Comment on attachment 318118 Patch Clearing flags on attachment: 318118 Committed r220963: <http://trac.webkit.org/changeset/220963> 1340579 5 commit-queue 2017-08-21 05:59:05 -0700 All reviewed patches have been landed. Closing bug. 1340580 6 webkit-bug-importer 2017-08-21 05:59:38 -0700 <rdar://problem/33990750> 318118 2017-08-15 08:47:24 -0700 2017-08-21 05:59:03 -0700 Patch bug-175571-20170815164723.patch text/plain 2226 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM1ZTYzOTNhNGY3NmY2NGRl ZmQyNmQ3Y2UzNGUwMGU1NzY3ZTc0MjYuLjAxZGM4MDA2MDM0ZGQyMjQ5Y2JkZTdjOGViNjkzZWFi ZDU1N2UyMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDgtMTUgIENoYXJsaWUg VHVybmVyICA8Y3R1cm5lckBpZ2FsaWEuY29tPgorCisgICAgICAgIE1lbW9yeUNhY2hlOjpzZXRD YXBhY2l0aWVzIGFzc2VydGlvbiBmYWlsdXJlIG1heERlYWRCeXRlcyA8PSB0b3RhbEJ5dGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU1NzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9D YWNoZU1vZGVsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Y2FsY3VsYXRlTWVtb3J5Q2FjaGVTaXpl cyk6IEVuc3VyZSBjYWNoZVRvdGFsQ2FwYWNpdHkgaXMKKyAgICAgICAgc2V0IHRvIGEgcmVhc29u YWJsZSB2YWx1ZSBldmVuIGluIGxvdy1tZW1vcnkgZW52aXJvbm1lbnRzLgorCiAyMDE3LTA4LTA4 ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg W1dQRV0gSW1wbGVtZW50IFdlYnNpdGVEYXRhU3RvcmU6OmRlZmF1bHRBcHBsaWNhdGlvbkNhY2hl RGlyZWN0b3J5KCkgYW5kIGZyaWVuZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVk L0NhY2hlTW9kZWwuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ2FjaGVNb2RlbC5jcHAKaW5k ZXggOGExM2M2YzJiYTgwNzZkOTk5ZjkzMWI3ZGY5Y2FiYWZkNzcxOWRlYi4uNjU1NjY3ODk3MmYz YzU4Y2YwMDNlNTNiYzMzY2Q5YjVlZWFhNGE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9T aGFyZWQvQ2FjaGVNb2RlbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ2FjaGVNb2Rl bC5jcHAKQEAgLTUxLDYgKzUxLDggQEAgdm9pZCBjYWxjdWxhdGVNZW1vcnlDYWNoZVNpemVzKENh Y2hlTW9kZWwgY2FjaGVNb2RlbCwgdW5zaWduZWQmIGNhY2hlVG90YWxDYXBhY2kKICAgICAgICAg ICAgIGNhY2hlVG90YWxDYXBhY2l0eSA9IDMyICogTUI7CiAgICAgICAgIGVsc2UgaWYgKG1lbW9y eVNpemUgPj0gNTEyKQogICAgICAgICAgICAgY2FjaGVUb3RhbENhcGFjaXR5ID0gMTYgKiBNQjsK KyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2FjaGVUb3RhbENhcGFjaXR5ID0gOCAqIE1COwog CiAgICAgICAgIGNhY2hlTWluRGVhZENhcGFjaXR5ID0gMDsKICAgICAgICAgY2FjaGVNYXhEZWFk Q2FwYWNpdHkgPSAwOwpAQCAtNzUsNiArNzcsOCBAQCB2b2lkIGNhbGN1bGF0ZU1lbW9yeUNhY2hl U2l6ZXMoQ2FjaGVNb2RlbCBjYWNoZU1vZGVsLCB1bnNpZ25lZCYgY2FjaGVUb3RhbENhcGFjaQog ICAgICAgICAgICAgY2FjaGVUb3RhbENhcGFjaXR5ID0gMzIgKiBNQjsKICAgICAgICAgZWxzZSBp ZiAobWVtb3J5U2l6ZSA+PSA1MTIpCiAgICAgICAgICAgICBjYWNoZVRvdGFsQ2FwYWNpdHkgPSAx NiAqIE1COworICAgICAgICBlbHNlCisgICAgICAgICAgICBjYWNoZVRvdGFsQ2FwYWNpdHkgPSA4 ICogTUI7CiAKICAgICAgICAgY2FjaGVNaW5EZWFkQ2FwYWNpdHkgPSBjYWNoZVRvdGFsQ2FwYWNp dHkgLyA4OwogICAgICAgICBjYWNoZU1heERlYWRDYXBhY2l0eSA9IGNhY2hlVG90YWxDYXBhY2l0 eSAvIDQ7CkBAIC0xMDIsNiArMTA2LDggQEAgdm9pZCBjYWxjdWxhdGVNZW1vcnlDYWNoZVNpemVz KENhY2hlTW9kZWwgY2FjaGVNb2RlbCwgdW5zaWduZWQmIGNhY2hlVG90YWxDYXBhY2kKICAgICAg ICAgICAgIGNhY2hlVG90YWxDYXBhY2l0eSA9IDY0ICogTUI7CiAgICAgICAgIGVsc2UgaWYgKG1l bW9yeVNpemUgPj0gNTEyKQogICAgICAgICAgICAgY2FjaGVUb3RhbENhcGFjaXR5ID0gMzIgKiBN QjsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2FjaGVUb3RhbENhcGFjaXR5ID0gMTYgKiBN QjsKIAogICAgICAgICBjYWNoZU1pbkRlYWRDYXBhY2l0eSA9IGNhY2hlVG90YWxDYXBhY2l0eSAv IDQ7CiAgICAgICAgIGNhY2hlTWF4RGVhZENhcGFjaXR5ID0gY2FjaGVUb3RhbENhcGFjaXR5IC8g MjsK