175564 2017-08-15 00:20:44 -0700 [GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose 2017-08-15 23:09:49 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply buildbot clopez gustavo mcatanzaro oldest_to_newest 1338638 0 cgarcia 2017-08-15 00:20:44 -0700 WebAutomationSession expects its client to be nullptr in the destructor. 1338639 1 318114 cgarcia 2017-08-15 00:22:10 -0700 Created attachment 318114 Patch 1338640 2 buildbot 2017-08-15 00:23:44 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1339081 3 cgarcia 2017-08-15 23:09:49 -0700 Committed r220786: <http://trac.webkit.org/changeset/220786> 318114 2017-08-15 00:22:10 -0700 2017-08-15 04:43:43 -0700 Patch wd-client-null.diff text/plain 1434 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTA0Njk2NzliZTEuLjQzOWU5NzNlOWZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE3LTA4LTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFdlYktpdEF1dG9tYXRpb25TZXNzaW9uIHNob3Vs ZCBzZXQgc2Vzc2lvbiBjbGllbnQgdG8gbnVsbHB0ciBvbiBkaXNwb3NlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU1NjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJBdXRvbWF0aW9uU2Vzc2lvbiBl eHBlY3RzIGl0cyBjbGllbnQgdG8gYmUgbnVsbHB0ciBpbiB0aGUgZGVzdHJ1Y3Rvci4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbi5jcHA6Cisg ICAgICAgICh3ZWJraXRBdXRvbWF0aW9uU2Vzc2lvbkRpc3Bvc2UpOgorCiAyMDE3LTA4LTE1ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJE cml2ZXI6IHRpbWVvdXQgd2hlbiBKYXZhU2NyaXB0IGFsZXJ0IGlzIHNob3duIGluIG9ubG9hZCBo YW5kbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRBdXRvbWF0aW9uU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xp Yi9XZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKaW5kZXggODcwMzNiZjhkMDYuLjkzYWI4ZDUw Nzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRB dXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds aWIvV2ViS2l0QXV0b21hdGlvblNlc3Npb24uY3BwCkBAIC0xOTksNiArMTk5LDggQEAgc3RhdGlj IHZvaWQgd2Via2l0QXV0b21hdGlvblNlc3Npb25EaXNwb3NlKEdPYmplY3QqIG9iamVjdCkKIHsK ICAgICBXZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbiogc2Vzc2lvbiA9IFdFQktJVF9BVVRPTUFUSU9O X1NFU1NJT04ob2JqZWN0KTsKIAorICAgIHNlc3Npb24tPnByaXYtPnNlc3Npb24tPnNldENsaWVu dChudWxscHRyKTsKKwogICAgIGlmIChzZXNzaW9uLT5wcml2LT5hcHBsaWNhdGlvbkluZm8pIHsK ICAgICAgICAgd2Via2l0X2FwcGxpY2F0aW9uX2luZm9fdW5yZWYoc2Vzc2lvbi0+cHJpdi0+YXBw bGljYXRpb25JbmZvKTsKICAgICAgICAgc2Vzc2lvbi0+cHJpdi0+YXBwbGljYXRpb25JbmZvID0g bnVsbHB0cjsK