175549 2017-08-14 15:17:51 -0700 Add some convenience utility accessor methods to MacroAssembler::CPUState. 2017-08-14 15:56:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174645 1 mark.lam mark.lam fpizlo jfbastien keith_miller msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1338485 0 mark.lam 2017-08-14 15:17:51 -0700 Patch coming. 1338486 1 webkit-bug-importer 2017-08-14 15:18:27 -0700 <rdar://problem/33884868> 1338498 2 318075 mark.lam 2017-08-14 15:35:56 -0700 Created attachment 318075 proposed patch. 1338502 3 318075 saam 2017-08-14 15:39:48 -0700 Comment on attachment 318075 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=318075&action=review > Source/JavaScriptCore/assembler/MacroAssembler.h:1869 > + template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr> I don't think you need the = nullptr and the * type. 1338506 4 mark.lam 2017-08-14 15:51:54 -0700 Thanks for the review. (In reply to Saam Barati from comment #3) > Comment on attachment 318075 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318075&action=review > > > Source/JavaScriptCore/assembler/MacroAssembler.h:1869 > > + template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr> > > I don't think you need the = nullptr and the * type. Without the "* = nullptr", Clang complains: candidate template ignored: couldn't infer template argument ''. I'll land it as is. 1338508 5 mark.lam 2017-08-14 15:56:01 -0700 Landed in r220720: <http://trac.webkit.org/r220720>. 318075 2017-08-14 15:35:56 -0700 2017-08-14 15:39:48 -0700 proposed patch. bug-175549.patch text/plain 4684 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwNzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBA CisyMDE3LTA4LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBjb252ZW5pZW5jZSB1dGlsaXR5IGFjY2Vzc29yIG1ldGhvZHMgdG8gTWFjcm9Bc3Nl bWJsZXI6OkNQVVN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc1NTQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzg4NDg2OD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5LCBp biBvcmRlciB0byByZWFkIFByb2JlQ29udGV4dCBDUFVTdGF0ZSByZWdpc3RlcnMsIHdlIHVzZWQg dG8gbmVlZCB0bworICAgICAgICBkbyBpdCB0aGlzIHdheToKKworICAgICAgICAgICAgRXhlY1N0 YXRlKiBleGVjID0gcmVpbnRlcnByZXRfY2FzdDxFeGVjU3RhdGUqPihjcHUuZnAoKSk7CisgICAg ICAgICAgICB1aW50MzJfdCBpMzIgPSBzdGF0aWNfY2FzdDx1aW50MzJfdD4oY3B1LmdwcihHUFJJ bmZvOjpyZWdUMCkpOworICAgICAgICAgICAgdm9pZCogcCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9p ZCo+KGNwdS5ncHIoR1BSSW5mbzo6cmVnVDEpKTsKKyAgICAgICAgICAgIHVpbnQ2NF90IHU2NCA9 IGJpdHdpc2VfY2FzdDx1aW50NjRfdD4oY3B1LmZwcihGUFJJbmZvOjpmcFJlZ1QwKSk7CisKKyAg ICAgICAgV2l0aCB0aGlzIHBhdGNoLCB3ZSBjYW4gbm93IHJlYWQgdGhlbSB0aGlzIHdheSBpbnN0 ZWFkOgorICAgICAgICAKKyAgICAgICAgICAgIEV4ZWNTdGF0ZSogZXhlYyA9IGNwdS5mcDxFeGVj U3RhdGUqPigpOworICAgICAgICAgICAgdWludDMyX3QgaTMyID0gY3B1Lmdwcjx1aW50MzJfdD4o R1BSSW5mbzo6cmVnVDApOworICAgICAgICAgICAgdm9pZCogcCA9IGNwdS5ncHI8dm9pZCo+KEdQ UkluZm86OnJlZ1QxKTsKKyAgICAgICAgICAgIHVpbnQ2NF90IHU2NCA9IGNwdS5mcHI8dWludDY0 X3Q+KEZQUkluZm86OmZwUmVnVDApOworCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyLmg6CisgICAgICAgIChKU0M6OiBjb25zdCk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1i bGVyOjpDUFVTdGF0ZTo6ZnByIGNvbnN0KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXI6 OkNQVVN0YXRlOjpwYyBjb25zdCk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyOjpDUFVT dGF0ZTo6ZnAgY29uc3QpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlcjo6Q1BVU3RhdGU6 OnNwIGNvbnN0KToKKyAgICAgICAgKEpTQzo6UHJvYmVDb250ZXh0OjpwYyk6CisgICAgICAgIChK U0M6OlByb2JlQ29udGV4dDo6ZnApOgorICAgICAgICAoSlNDOjpQcm9iZUNvbnRleHQ6OnNwKToK KwogMjAxNy0wOC0xMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg IFB1dCB0aGUgU2NvcGVkQXJndW1lbnRzVGFibGUncyBTY29wZU9mZnNldCBhcnJheSBpbiBzb21l IGdpZ2FjYWdlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlci5oCShyZXZpc2lvbiAyMjA3MTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4NjQsOSAr MTg2NCwxOCBAQCBzdHJ1Y3QgTWFjcm9Bc3NlbWJsZXI6OkNQVVN0YXRlIHsKICAgICBpbmxpbmUg dWludHB0cl90JiBzcHIoU1BSZWdpc3RlcklEKTsKICAgICBpbmxpbmUgZG91YmxlJiBmcHIoRlBS ZWdpc3RlcklEKTsKICAgICAKLSAgICBpbmxpbmUgdm9pZComIHBjKCk7Ci0gICAgaW5saW5lIHZv aWQqJiBmcCgpOwotICAgIGlubGluZSB2b2lkKiYgc3AoKTsKKyAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBULCB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX2ludGVncmFsPFQ+Ojp2YWx1ZT46 OnR5cGUqID0gbnVsbHB0cj4KKyAgICBUIGdwcihSZWdpc3RlcklEKSBjb25zdDsKKyAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX3BvaW50ZXI8 VD46OnZhbHVlPjo6dHlwZSogPSBudWxscHRyPgorICAgIFQgZ3ByKFJlZ2lzdGVySUQpIGNvbnN0 OworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IFQgZnByKEZQUmVnaXN0ZXJJRCkgY29uc3Q7CisK KyAgICB2b2lkKiYgcGMoKTsKKyAgICB2b2lkKiYgZnAoKTsKKyAgICB2b2lkKiYgc3AoKTsKKyAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBUIHBjKCkgY29uc3Q7CisgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gVCBmcCgpIGNvbnN0OworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IFQgc3AoKSBjb25z dDsKICAgICAKICAgICB1aW50cHRyX3QgZ3Byc1tNYWNyb0Fzc2VtYmxlcjo6bnVtYmVyT2ZSZWdp c3RlcnMoKV07CiAgICAgdWludHB0cl90IHNwcnNbTWFjcm9Bc3NlbWJsZXI6Om51bWJlck9mU1BS ZWdpc3RlcnMoKV07CkBAIC0xODkxLDYgKzE5MDAsMjcgQEAgaW5saW5lIGRvdWJsZSYgTWFjcm9B c3NlbWJsZXI6OkNQVVN0YXRlOgogICAgIHJldHVybiBmcHJzW2lkXTsKIH0KIAordGVtcGxhdGU8 dHlwZW5hbWUgVCwgdHlwZW5hbWUgc3RkOjplbmFibGVfaWY8c3RkOjppc19pbnRlZ3JhbDxUPjo6 dmFsdWU+Ojp0eXBlKj4KK1QgTWFjcm9Bc3NlbWJsZXI6OkNQVVN0YXRlOjpncHIoUmVnaXN0ZXJJ RCBpZCkgY29uc3QKK3sKKyAgICBDUFVTdGF0ZSogY3B1ID0gY29uc3RfY2FzdDxDUFVTdGF0ZSo+ KHRoaXMpOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxUPihjcHUtPmdwcihpZCkpOworfQorCit0 ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX3BvaW50 ZXI8VD46OnZhbHVlPjo6dHlwZSo+CitUIE1hY3JvQXNzZW1ibGVyOjpDUFVTdGF0ZTo6Z3ByKFJl Z2lzdGVySUQgaWQpIGNvbnN0Cit7CisgICAgQ1BVU3RhdGUqIGNwdSA9IGNvbnN0X2Nhc3Q8Q1BV U3RhdGUqPih0aGlzKTsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxUPihjcHUtPmdwcihp ZCkpOworfQorCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgorVCBNYWNyb0Fzc2VtYmxlcjo6Q1BVU3Rh dGU6OmZwcihGUFJlZ2lzdGVySUQgaWQpIGNvbnN0Cit7CisgICAgQ1BVU3RhdGUqIGNwdSA9IGNv bnN0X2Nhc3Q8Q1BVU3RhdGUqPih0aGlzKTsKKyAgICByZXR1cm4gYml0d2lzZV9jYXN0PFQ+KGNw dS0+ZnByKGlkKSk7Cit9CisKIGlubGluZSB2b2lkKiYgTWFjcm9Bc3NlbWJsZXI6OkNQVVN0YXRl OjpwYygpCiB7CiAjaWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKQEAgLTE5MzYsNiArMTk2Niwy NyBAQCBpbmxpbmUgdm9pZComIE1hY3JvQXNzZW1ibGVyOjpDUFVTdGF0ZTo6CiAjZW5kaWYKIH0K IAordGVtcGxhdGU8dHlwZW5hbWUgVD4KK1QgTWFjcm9Bc3NlbWJsZXI6OkNQVVN0YXRlOjpwYygp IGNvbnN0Cit7CisgICAgQ1BVU3RhdGUqIGNwdSA9IGNvbnN0X2Nhc3Q8Q1BVU3RhdGUqPih0aGlz KTsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxUPihjcHUtPnBjKCkpOworfQorCit0ZW1w bGF0ZTx0eXBlbmFtZSBUPgorVCBNYWNyb0Fzc2VtYmxlcjo6Q1BVU3RhdGU6OmZwKCkgY29uc3QK K3sKKyAgICBDUFVTdGF0ZSogY3B1ID0gY29uc3RfY2FzdDxDUFVTdGF0ZSo+KHRoaXMpOworICAg IHJldHVybiByZWludGVycHJldF9jYXN0PFQ+KGNwdS0+ZnAoKSk7Cit9CisKK3RlbXBsYXRlPHR5 cGVuYW1lIFQ+CitUIE1hY3JvQXNzZW1ibGVyOjpDUFVTdGF0ZTo6c3AoKSBjb25zdAoreworICAg IENQVVN0YXRlKiBjcHUgPSBjb25zdF9jYXN0PENQVVN0YXRlKj4odGhpcyk7CisgICAgcmV0dXJu IHJlaW50ZXJwcmV0X2Nhc3Q8VD4oY3B1LT5zcCgpKTsKK30KKwogc3RydWN0IFByb2JlQ29udGV4 dCB7CiAgICAgdXNpbmcgQ1BVU3RhdGUgPSBNYWNyb0Fzc2VtYmxlcjo6Q1BVU3RhdGU7CiAgICAg dXNpbmcgUmVnaXN0ZXJJRCA9IE1hY3JvQXNzZW1ibGVyOjpSZWdpc3RlcklEOwpAQCAtMTk1Nyw2 ICsyMDA4LDEwIEBAIHN0cnVjdCBQcm9iZUNvbnRleHQgewogICAgIHZvaWQqJiBwYygpIHsgcmV0 dXJuIGNwdS5wYygpOyB9CiAgICAgdm9pZComIGZwKCkgeyByZXR1cm4gY3B1LmZwKCk7IH0KICAg ICB2b2lkKiYgc3AoKSB7IHJldHVybiBjcHUuc3AoKTsgfQorCisgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gVCBwYygpIHsgcmV0dXJuIGNwdS5wYzxUPigpOyB9CisgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gVCBmcCgpIHsgcmV0dXJuIGNwdS5mcDxUPigpOyB9CisgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gVCBzcCgpIHsgcmV0dXJuIGNwdS5zcDxUPigpOyB9CiB9OwogICAgIAogfSAvLyBuYW1l c3BhY2UgSlNDCg==