175547 2017-08-14 13:55:27 -0700 Obj-C exception crash in AVStreamSession when using EME in Private Browsing mode 2017-08-14 16:33:32 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1338451 0 jer.noble 2017-08-14 13:55:27 -0700 Obj-C exception crash in AVStreamSession when using EME in Private Browsing mode 1338454 1 jer.noble 2017-08-14 13:58:36 -0700 <rdar://problem/33837113> 1338468 2 318062 jer.noble 2017-08-14 14:32:38 -0700 Created attachment 318062 Patch 1338528 3 318062 commit-queue 2017-08-14 16:33:30 -0700 Comment on attachment 318062 Patch Clearing flags on attachment: 318062 Committed r220723: <http://trac.webkit.org/changeset/220723> 1338529 4 commit-queue 2017-08-14 16:33:32 -0700 All reviewed patches have been landed. Closing bug. 318062 2017-08-14 14:32:38 -0700 2017-08-14 16:33:30 -0700 Patch bug-175547-20170814143237.patch text/plain 6237 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RiMjgwYTI3NjI3YjI2 MDNmNjNiNGI0MjAzYmY3ZWExYzFlYTIwMC4uOTQyNjEwMzE2MTZhNWQ2OWU1ODU2MDY1ODAxMjkw ZjlhZTk1Y2FlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA4LTE0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE9iai1DIGV4Y2VwdGlvbiBj cmFzaCBpbiBBVlN0cmVhbVNlc3Npb24gd2hlbiB1c2luZyBFTUUgaW4gUHJpdmF0ZSBCcm93c2lu ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzU1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIHRoZSBzdG9yYWdlUGF0aCgpIGlzIGVtcHR5LCBkbyBub3QgdXNlIHRob3NlIEFWU3RyZWFt U2Vzc2lvbiBBUElzIHdoaWNoIHJlcXVpcmUgYSB2YWxpZCBmaWxlIHBhdGggdG8gc3RvcmVkCisg ICAgICAgIHByb29mLW9mLWtleS1yZWxlYXNlIGRhdGEuCisKKyAgICAgICAgRHJpdmUtYnkgZml4 OiByZXR1cm4gZW1wdHlTdHJpbmcoKSBmcm9tIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVy TWVkaWFLZXlzU3RvcmFnZURpcmVjdG9yeSgpIHdoZW4gaW4gUHJpdmF0ZQorICAgICAgICBCcm93 c2luZyBtb2RlLCB0byBtYXRjaCB0aGUgYmVoYXZpb3Igb2YgV2ViS2l0TWVkaWFLZXlTZXNzaW9u LgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyTWVkaWFLZXlzU3RvcmFnZURpcmVjdG9y eSBjb25zdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMv Q0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lvbi5tbToKKyAgICAgICAgKFdlYkNvcmU6OkNETVNlc3Np b25BVlN0cmVhbVNlc3Npb246OnJlbGVhc2VLZXlzKToKKyAgICAgICAgKFdlYkNvcmU6OkNETVNl c3Npb25BVlN0cmVhbVNlc3Npb246OnVwZGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpDRE1TZXNz aW9uQVZTdHJlYW1TZXNzaW9uOjpnZW5lcmF0ZUtleVJlbGVhc2VNZXNzYWdlKToKKwogMjAxNy0w OC0xMCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIyMDQ2My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwCmluZGV4IDE1ZmEyOTgyMDQ3ZjE2MTdmMDM4MTFiNDI1YmMzNDFmOTNk ZTRmMWYuLmI4NDQ0ZTA3ZTYxMzAyZmVjNWVhNDcwOGNmNjVkMGZlYzY1YTgxYjYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMjUxNiw2ICsyNTE2LDEwIEBA IGJvb2wgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJLZXlOZWVkZWQoTWVkaWFQbGF5ZXIq LCBVaW50OEFycmF5KiBpbml0RGF0YSkKIAogU3RyaW5nIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlh UGxheWVyTWVkaWFLZXlzU3RvcmFnZURpcmVjdG9yeSgpIGNvbnN0CiB7CisgICAgYXV0byogcGFn ZSA9IGRvY3VtZW50KCkucGFnZSgpOworICAgIGlmICghcGFnZSB8fCBwYWdlLT51c2VzRXBoZW1l cmFsU2Vzc2lvbigpKQorICAgICAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKKwogICAgIFN0cmlu ZyBzdG9yYWdlRGlyZWN0b3J5ID0gZG9jdW1lbnQoKS5zZXR0aW5ncygpLm1lZGlhS2V5c1N0b3Jh Z2VEaXJlY3RvcnkoKTsKICAgICBpZiAoc3RvcmFnZURpcmVjdG9yeS5pc0VtcHR5KCkpCiAgICAg ICAgIHJldHVybiBlbXB0eVN0cmluZygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQ0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lv bi5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L0NETVNlc3Npb25BVlN0cmVhbVNlc3Npb24ubW0KaW5kZXggOWZlMzBjNzgxY2JkYTA1ZDg3NjBk ODZlZWU5NmVmOTFkZmI4YmVlMC4uZmVkYzc0NTU1MGZiNzg3NjQ4MmQ2YzQ1MTE3MDQ0NzdmOTVi NGY1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvQ0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lvbi5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9DRE1TZXNzaW9uQVZTdHJl YW1TZXNzaW9uLm1tCkBAIC0xNDIsMTEgKzE0MiwxMiBAQCB2b2lkIENETVNlc3Npb25BVlN0cmVh bVNlc3Npb246OnJlbGVhc2VLZXlzKCkKICAgICAgICAgaWYgKCFtX2NlcnRpZmljYXRlKQogICAg ICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmICghW2dldEFWU3RyZWFtU2Vzc2lvbkNsYXNz KCkgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihwZW5kaW5nRXhwaXJlZFNlc3Npb25SZXBv cnRzV2l0aEFwcElkZW50aWZpZXI6c3RvcmFnZURpcmVjdG9yeUF0VVJMOildKQorICAgICAgICBT dHJpbmcgc3RvcmFnZVBhdGggPSB0aGlzLT5zdG9yYWdlUGF0aCgpOworICAgICAgICBpZiAoc3Rv cmFnZVBhdGguaXNFbXB0eSgpIHx8ICFbZ2V0QVZTdHJlYW1TZXNzaW9uQ2xhc3MoKSByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKHBlbmRpbmdFeHBpcmVkU2Vzc2lvblJlcG9ydHNXaXRoQXBw SWRlbnRpZmllcjpzdG9yYWdlRGlyZWN0b3J5QXRVUkw6KV0pCiAgICAgICAgICAgICByZXR1cm47 CiAKICAgICAgICAgUmV0YWluUHRyPE5TRGF0YT4gY2VydGlmaWNhdGVEYXRhID0gYWRvcHROUyhb W05TRGF0YSBhbGxvY10gaW5pdFdpdGhCeXRlczptX2NlcnRpZmljYXRlLT5kYXRhKCkgbGVuZ3Ro Om1fY2VydGlmaWNhdGUtPmxlbmd0aCgpXSk7Ci0gICAgICAgIE5TQXJyYXkqIGV4cGlyZWRTZXNz aW9ucyA9IFtnZXRBVlN0cmVhbVNlc3Npb25DbGFzcygpIHBlbmRpbmdFeHBpcmVkU2Vzc2lvblJl cG9ydHNXaXRoQXBwSWRlbnRpZmllcjpjZXJ0aWZpY2F0ZURhdGEuZ2V0KCkgc3RvcmFnZURpcmVj dG9yeUF0VVJMOltOU1VSTCBmaWxlVVJMV2l0aFBhdGg6c3RvcmFnZVBhdGgoKV1dOworICAgICAg ICBOU0FycmF5KiBleHBpcmVkU2Vzc2lvbnMgPSBbZ2V0QVZTdHJlYW1TZXNzaW9uQ2xhc3MoKSBw ZW5kaW5nRXhwaXJlZFNlc3Npb25SZXBvcnRzV2l0aEFwcElkZW50aWZpZXI6Y2VydGlmaWNhdGVE YXRhLmdldCgpIHN0b3JhZ2VEaXJlY3RvcnlBdFVSTDpbTlNVUkwgZmlsZVVSTFdpdGhQYXRoOnN0 b3JhZ2VQYXRoXV07CiAgICAgICAgIGZvciAoTlNEYXRhKiBleHBpcmVkU2Vzc2lvbkRhdGEgaW4g ZXhwaXJlZFNlc3Npb25zKSB7CiAgICAgICAgICAgICBOU0RpY3Rpb25hcnkgKmV4cGlyZWRTZXNz aW9uID0gW05TUHJvcGVydHlMaXN0U2VyaWFsaXphdGlvbiBwcm9wZXJ0eUxpc3RXaXRoRGF0YTpl eHBpcmVkU2Vzc2lvbkRhdGEgb3B0aW9uczprQ0ZQcm9wZXJ0eUxpc3RJbW11dGFibGUgZm9ybWF0 Om51bGxwdHIgZXJyb3I6bnVsbHB0cl07CiAgICAgICAgICAgICBOU1N0cmluZyAqcGxheWJhY2tT ZXNzaW9uSWRWYWx1ZSA9IChOU1N0cmluZyAqKVtleHBpcmVkU2Vzc2lvbiBvYmplY3RGb3JLZXk6 UGxheWJhY2tTZXNzaW9uSWRLZXldOwpAQCAtMjAwLDggKzIwMSw5IEBAIGJvb2wgQ0RNU2Vzc2lv bkFWU3RyZWFtU2Vzc2lvbjo6dXBkYXRlKFVpbnQ4QXJyYXkqIGtleSwgUmVmUHRyPFVpbnQ4QXJy YXk+JiBuZXh0CiAKICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCiAjcHJhZ21hIGNsYW5n IGRpYWdub3N0aWMgaWdub3JlZCAiLVdvYmpjLWxpdGVyYWwtY29udmVyc2lvbiIKLSAgICAgICAg aWYgKFtnZXRBVlN0cmVhbVNlc3Npb25DbGFzcygpIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0 b3IocmVtb3ZlUGVuZGluZ0V4cGlyZWRTZXNzaW9uUmVwb3J0czp3aXRoQXBwSWRlbnRpZmllcjpz dG9yYWdlRGlyZWN0b3J5QXRVUkw6KV0pCi0gICAgICAgICAgICBbZ2V0QVZTdHJlYW1TZXNzaW9u Q2xhc3MoKSByZW1vdmVQZW5kaW5nRXhwaXJlZFNlc3Npb25SZXBvcnRzOkBbbV9leHBpcmVkU2Vz c2lvbi5nZXQoKV0gd2l0aEFwcElkZW50aWZpZXI6Y2VydGlmaWNhdGVEYXRhLmdldCgpIHN0b3Jh Z2VEaXJlY3RvcnlBdFVSTDpbTlNVUkwgZmlsZVVSTFdpdGhQYXRoOnN0b3JhZ2VQYXRoKCldXTsK KyAgICAgICAgU3RyaW5nIHN0b3JhZ2VQYXRoID0gdGhpcy0+c3RvcmFnZVBhdGgoKTsKKyAgICAg ICAgaWYgKCFzdG9yYWdlUGF0aC5pc0VtcHR5KCkgJiYgW2dldEFWU3RyZWFtU2Vzc2lvbkNsYXNz KCkgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihyZW1vdmVQZW5kaW5nRXhwaXJlZFNlc3Np b25SZXBvcnRzOndpdGhBcHBJZGVudGlmaWVyOnN0b3JhZ2VEaXJlY3RvcnlBdFVSTDopXSkKKyAg ICAgICAgICAgIFtnZXRBVlN0cmVhbVNlc3Npb25DbGFzcygpIHJlbW92ZVBlbmRpbmdFeHBpcmVk U2Vzc2lvblJlcG9ydHM6QFttX2V4cGlyZWRTZXNzaW9uLmdldCgpXSB3aXRoQXBwSWRlbnRpZmll cjpjZXJ0aWZpY2F0ZURhdGEuZ2V0KCkgc3RvcmFnZURpcmVjdG9yeUF0VVJMOltOU1VSTCBmaWxl VVJMV2l0aFBhdGg6c3RvcmFnZVBhdGhdXTsKICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AK ICAgICAgICAgbV9leHBpcmVkU2Vzc2lvbiA9IG51bGxwdHI7CiAgICAgICAgIHJldHVybiB0cnVl OwpAQCAtMzE2LDEzICszMTgsMTQgQEAgUmVmUHRyPFVpbnQ4QXJyYXk+IENETVNlc3Npb25BVlN0 cmVhbVNlc3Npb246OmdlbmVyYXRlS2V5UmVsZWFzZU1lc3NhZ2UodW5zaWduZWQKICAgICBtX2Nl cnRpZmljYXRlID0gbV9pbml0RGF0YTsKICAgICBSZXRhaW5QdHI8TlNEYXRhPiBjZXJ0aWZpY2F0 ZURhdGEgPSBhZG9wdE5TKFtbTlNEYXRhIGFsbG9jXSBpbml0V2l0aEJ5dGVzOm1fY2VydGlmaWNh dGUtPmRhdGEoKSBsZW5ndGg6bV9jZXJ0aWZpY2F0ZS0+bGVuZ3RoKCldKTsKIAotICAgIGlmICgh W2dldEFWU3RyZWFtU2Vzc2lvbkNsYXNzKCkgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihw ZW5kaW5nRXhwaXJlZFNlc3Npb25SZXBvcnRzV2l0aEFwcElkZW50aWZpZXI6c3RvcmFnZURpcmVj dG9yeUF0VVJMOildKSB7CisgICAgU3RyaW5nIHN0b3JhZ2VQYXRoID0gdGhpcy0+c3RvcmFnZVBh dGgoKTsKKyAgICBpZiAoc3RvcmFnZVBhdGguaXNFbXB0eSgpIHx8ICFbZ2V0QVZTdHJlYW1TZXNz aW9uQ2xhc3MoKSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHBlbmRpbmdFeHBpcmVkU2Vz c2lvblJlcG9ydHNXaXRoQXBwSWRlbnRpZmllcjpzdG9yYWdlRGlyZWN0b3J5QXRVUkw6KV0pIHsK ICAgICAgICAgZXJyb3JDb2RlID0gTWVkaWFQbGF5ZXI6OktleVN5c3RlbU5vdFN1cHBvcnRlZDsK ICAgICAgICAgc3lzdGVtQ29kZSA9ICchbW9yJzsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAg ICAgfQogCi0gICAgTlNBcnJheSogZXhwaXJlZFNlc3Npb25zID0gW2dldEFWU3RyZWFtU2Vzc2lv bkNsYXNzKCkgcGVuZGluZ0V4cGlyZWRTZXNzaW9uUmVwb3J0c1dpdGhBcHBJZGVudGlmaWVyOmNl cnRpZmljYXRlRGF0YS5nZXQoKSBzdG9yYWdlRGlyZWN0b3J5QXRVUkw6W05TVVJMIGZpbGVVUkxX aXRoUGF0aDpzdG9yYWdlUGF0aCgpXV07CisgICAgTlNBcnJheSogZXhwaXJlZFNlc3Npb25zID0g W2dldEFWU3RyZWFtU2Vzc2lvbkNsYXNzKCkgcGVuZGluZ0V4cGlyZWRTZXNzaW9uUmVwb3J0c1dp dGhBcHBJZGVudGlmaWVyOmNlcnRpZmljYXRlRGF0YS5nZXQoKSBzdG9yYWdlRGlyZWN0b3J5QXRV Ukw6W05TVVJMIGZpbGVVUkxXaXRoUGF0aDpzdG9yYWdlUGF0aF1dOwogICAgIGlmICghW2V4cGly ZWRTZXNzaW9ucyBjb3VudF0pIHsKICAgICAgICAgTE9HKE1lZGlhLCAiQ0RNU2Vzc2lvbkFWU3Ry ZWFtU2Vzc2lvbjo6Z2VuZXJhdGVLZXlSZWxlYXNlTWVzc2FnZSglcCkgLSBubyBleHBpcmVkIHNl c3Npb25zIGZvdW5kIiwgdGhpcyk7CiAK