175538 2017-08-14 10:06:52 -0700 [Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set 2017-08-15 15:39:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue sam webkit-bug-importer oldest_to_newest 1338373 0 youennf 2017-08-14 10:06:52 -0700 [Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set 1338376 1 318046 youennf 2017-08-14 10:10:24 -0700 Created attachment 318046 Patch 1338513 2 318046 cdumez 2017-08-14 16:19:36 -0700 Comment on attachment 318046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318046&action=review > Source/WebCore/platform/network/ResourceResponseBase.cpp:237 > + lazyInit(CommonFieldsOnly); I don't think this is needed since m_type is not used to initialize the underlying network object. m_type is a Webkit concept at this point, not an underlying network layer concept. > Source/WebCore/platform/network/ResourceResponseBase.cpp:242 > +void ResourceResponseBase::setRedirected(bool isRedirected) Is this one really needed? I'd expect such responses to have a URL. > Source/WebCore/platform/network/ResourceResponseBase.cpp:249 > +void ResourceResponseBase::setTainting(Tainting tainting) Is this one really needed? I'd expect such responses to have a URL. 1338890 3 318178 youennf 2017-08-15 14:58:35 -0700 Created attachment 318178 Patch 1338906 4 318178 commit-queue 2017-08-15 15:38:28 -0700 Comment on attachment 318178 Patch Clearing flags on attachment: 318178 Committed r220764: <http://trac.webkit.org/changeset/220764> 1338907 5 commit-queue 2017-08-15 15:38:29 -0700 All reviewed patches have been landed. Closing bug. 1338909 6 webkit-bug-importer 2017-08-15 15:39:45 -0700 <rdar://problem/33906142> 318046 2017-08-14 10:10:24 -0700 2017-08-15 14:58:34 -0700 Patch bug-175538-20170814101024.patch text/plain 3323 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZiN2I4MDhhYWJlZjJi NTZhNzY1Zjc4YzczODgwMmU4ZDMyZjMwMC4uYWFmZGIzMjdjYjgzMjc4ODQxMGIzZjcxZmU5NjA5 MGM5OGU3MDNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA4LTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbQ2FjaGUgQVBJXSBFbnN1 cmUgUmVzb3VyY2VSZXNwb25zZSBpcyBub3QgbnVsbCB3aGVuIHJlZGlyZWN0ZWQvdGFpbnRpbmcv dHlwZSBmaWVsZHMgYXJlIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc1NTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorICAgICAgICBUaGlzIGNoYW5nZSBl bnN1cmVzIHRoYXQgdHlwZS9yZWRpcmVjdGVkL3RhaW50aW5nIGFyZSBwcmVzZXJ2ZWQgd2hlbiBl bmNvZGluZy9kZWNvZGluZyBSZXNvdXJjZVJlc3BvbnNlLgorICAgICAgICBUaGlzIHdpbGwgYWxs b3cgQ2FjaGUgQVBJIHRvIHByZXNlcnZlIHRoZXNlIGZpZWxkcyB3aGVuIHJlYWRpbmcgY2FjaGVk IHJlc3BvbnNlcyBmcm9tIGEgZGlmZmVyZW50IHByb2Nlc3MuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlUmVzcG9uc2VCYXNlOjpzZXRUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNl UmVzcG9uc2VCYXNlOjpzZXRSZWRpcmVjdGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNl UmVzcG9uc2VCYXNlOjpzZXRUYWludGluZyk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9S ZXNvdXJjZVJlc3BvbnNlQmFzZS5oOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25z ZUJhc2U6OnNldFR5cGUpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNw b25zZUJhc2U6OnNldFJlZGlyZWN0ZWQpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVz b3VyY2VSZXNwb25zZUJhc2U6OnNldFRhaW50aW5nKTogRGVsZXRlZC4KKwogMjAxNy0wOC0xNCAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lP TihyMjIwNTE3LXIyMjA1MjEpIFtHVEtdIFZhcmlvdXMgY29tcG9zaXRpbmcgdGVzdHMgZmFpbApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3Bv bnNlQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVz cG9uc2VCYXNlLmNwcAppbmRleCA4ZDg4ZDM4YjdhY2JiNDEyOGVjNWY3OGNmMDdlM2RhNjMxZWRh NTBmLi40MjIyYmUzMjI4NDYwNmNlMzc4NmNkZWRmOTdiNzk3NTNhNWY2MDFhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VC YXNlLmNwcApAQCAtMjMyLDYgKzIzMiwyNyBAQCB2b2lkIFJlc291cmNlUmVzcG9uc2VCYXNlOjpz ZXRUZXh0RW5jb2RpbmdOYW1lKGNvbnN0IFN0cmluZyYgZW5jb2RpbmdOYW1lKQogICAgIC8vIEZJ WE1FOiBTaG91bGQgaW52YWxpZGF0ZSBvciB1cGRhdGUgcGxhdGZvcm0gcmVzcG9uc2UgaWYgcHJl c2VudC4KIH0KIAordm9pZCBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6c2V0VHlwZShUeXBlIHR5cGUp Cit7CisgICAgbGF6eUluaXQoQ29tbW9uRmllbGRzT25seSk7CisgICAgbV9pc051bGwgPSBmYWxz ZTsKKyAgICBtX3R5cGUgPSB0eXBlOworfQorCit2b2lkIFJlc291cmNlUmVzcG9uc2VCYXNlOjpz ZXRSZWRpcmVjdGVkKGJvb2wgaXNSZWRpcmVjdGVkKQoreworICAgIGxhenlJbml0KENvbW1vbkZp ZWxkc09ubHkpOworICAgIG1faXNOdWxsID0gZmFsc2U7CisgICAgbV9pc1JlZGlyZWN0ZWQgPSBp c1JlZGlyZWN0ZWQ7Cit9CisKK3ZvaWQgUmVzb3VyY2VSZXNwb25zZUJhc2U6OnNldFRhaW50aW5n KFRhaW50aW5nIHRhaW50aW5nKQoreworICAgIGxhenlJbml0KENvbW1vbkZpZWxkc09ubHkpOwor ICAgIG1faXNOdWxsID0gZmFsc2U7CisgICAgbV90YWludGluZyA9IHRhaW50aW5nOworfQorCiB2 b2lkIFJlc291cmNlUmVzcG9uc2VCYXNlOjppbmNsdWRlQ2VydGlmaWNhdGVJbmZvKCkgY29uc3QK IHsKICAgICBpZiAobV9jZXJ0aWZpY2F0ZUluZm8pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmgKaW5kZXggYzNkOWVjYTk5 MzBiNDY2ZDFmODEwNWRmZThhNjU1MTZiMjc5MDkwMi4uNjU4ZTExYWExNmExYjk5ZmI2OTJmN2Fi OTk0ZmQzNjllMjY3NTBmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaApAQCAtMTU0LDExICsxNTQsMTEgQEAgcHVi bGljOgogICAgIH0KIAogICAgIFR5cGUgdHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZTsgfQot ICAgIHZvaWQgc2V0VHlwZShUeXBlIHR5cGUpIHsgbV90eXBlID0gdHlwZTsgfQorICAgIHZvaWQg c2V0VHlwZShUeXBlKTsKICAgICBib29sIGlzUmVkaXJlY3RlZCgpIGNvbnN0IHsgcmV0dXJuIG1f aXNSZWRpcmVjdGVkOyB9Ci0gICAgdm9pZCBzZXRSZWRpcmVjdGVkKGJvb2wgaXNSZWRpcmVjdGVk KSB7IG1faXNSZWRpcmVjdGVkID0gaXNSZWRpcmVjdGVkOyB9CisgICAgdm9pZCBzZXRSZWRpcmVj dGVkKGJvb2wgaXNSZWRpcmVjdGVkKTsKIAotICAgIHZvaWQgc2V0VGFpbnRpbmcoVGFpbnRpbmcg dGFpbnRpbmcpIHsgbV90YWludGluZyA9IHRhaW50aW5nOyB9CisgICAgdm9pZCBzZXRUYWludGlu ZyhUYWludGluZyk7CiAgICAgVGFpbnRpbmcgdGFpbnRpbmcoKSBjb25zdCB7IHJldHVybiBtX3Rh aW50aW5nOyB9CiAKICAgICBzdGF0aWMgUmVzb3VyY2VSZXNwb25zZSBmaWx0ZXIoY29uc3QgUmVz b3VyY2VSZXNwb25zZSYpOwo= 318178 2017-08-15 14:58:35 -0700 2017-08-15 15:38:28 -0700 Patch bug-175538-20170815145834.patch text/plain 2673 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU4MDRhYjM1ZmNjYmM2 ZGM4NzBhNzdmNjhlMGVlZmMwNzliZjUyMS4uOWNmYWZlMmE2Y2E4OGZiM2Q1NTE5NDJmYzA0OWI4 ZDczYjJmMGU5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA4LTE1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbQ2FjaGUgQVBJXSBFbnN1 cmUgUmVzb3VyY2VSZXNwb25zZSBpcyBub3QgbnVsbCB3aGVuIHJlZGlyZWN0ZWQvdGFpbnRpbmcv dHlwZSBmaWVsZHMgYXJlIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc1NTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorICAgICAgICBUaGlzIGNoYW5nZSBl bnN1cmVzIHRoYXQgcmVzcG9uc2UgdHlwZSBpcyBwcmVzZXJ2ZWQgd2hlbiBlbmNvZGluZy9kZWNv ZGluZyBSZXNvdXJjZVJlc3BvbnNlLCBpbiBwYXJ0aWN1bGFyIHRoZSBlcnJvciB0eXBlLgorICAg ICAgICBUaGlzIHdpbGwgYWxsb3cgQ2FjaGUgQVBJIHRvIHByZXNlcnZlIHJlc3BvbnNlcyB3aGVu IHJlYWRpbmcgdGhlbSBmcm9tIGEgZGlmZmVyZW50IHByb2Nlc3MuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlUmVzcG9uc2VCYXNlOjpzZXRUeXBlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJl c3BvbnNlQmFzZTo6c2V0VHlwZSk6CisKIDIwMTctMDgtMTQgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgogCiAgICAgICAgIFtDYWNoZSBBUEldIEFkZGluZyBnZW5lcmljIHN1cHBv cnQgZm9yIENhY2hlU3RvcmFnZSBhbmQgQ2FjaGUgbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcAppbmRl eCA4ZDg4ZDM4YjdhY2JiNDEyOGVjNWY3OGNmMDdlM2RhNjMxZWRhNTBmLi5iYWQ3ZThlM2U0NmRm MTc4MGIzZTU0NTI3YjJhNThiYjgxZGJmMTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcApAQCAtMjMyLDYg KzIzMiwxMiBAQCB2b2lkIFJlc291cmNlUmVzcG9uc2VCYXNlOjpzZXRUZXh0RW5jb2RpbmdOYW1l KGNvbnN0IFN0cmluZyYgZW5jb2RpbmdOYW1lKQogICAgIC8vIEZJWE1FOiBTaG91bGQgaW52YWxp ZGF0ZSBvciB1cGRhdGUgcGxhdGZvcm0gcmVzcG9uc2UgaWYgcHJlc2VudC4KIH0KIAordm9pZCBS ZXNvdXJjZVJlc3BvbnNlQmFzZTo6c2V0VHlwZShUeXBlIHR5cGUpCit7CisgICAgbV9pc051bGwg PSBmYWxzZTsKKyAgICBtX3R5cGUgPSB0eXBlOworfQorCiB2b2lkIFJlc291cmNlUmVzcG9uc2VC YXNlOjppbmNsdWRlQ2VydGlmaWNhdGVJbmZvKCkgY29uc3QKIHsKICAgICBpZiAobV9jZXJ0aWZp Y2F0ZUluZm8pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jl c291cmNlUmVzcG9uc2VCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jl c291cmNlUmVzcG9uc2VCYXNlLmgKaW5kZXggYzNkOWVjYTk5MzBiNDY2ZDFmODEwNWRmZThhNjU1 MTZiMjc5MDkwMi4uYWJjZGNlYWQ3NzljYWNkYjc0ZjJmZjJmYjZkYmFjYmRiNDllZWEzZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNl QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNw b25zZUJhc2UuaApAQCAtMTUzLDEwICsxNTMsMTEgQEAgcHVibGljOgogICAgICAgICByZXR1cm4g MTI4MDsKICAgICB9CiAKKyAgICB2b2lkIHNldFR5cGUoVHlwZSk7CiAgICAgVHlwZSB0eXBlKCkg Y29uc3QgeyByZXR1cm4gbV90eXBlOyB9Ci0gICAgdm9pZCBzZXRUeXBlKFR5cGUgdHlwZSkgeyBt X3R5cGUgPSB0eXBlOyB9Ci0gICAgYm9vbCBpc1JlZGlyZWN0ZWQoKSBjb25zdCB7IHJldHVybiBt X2lzUmVkaXJlY3RlZDsgfQorCiAgICAgdm9pZCBzZXRSZWRpcmVjdGVkKGJvb2wgaXNSZWRpcmVj dGVkKSB7IG1faXNSZWRpcmVjdGVkID0gaXNSZWRpcmVjdGVkOyB9CisgICAgYm9vbCBpc1JlZGly ZWN0ZWQoKSBjb25zdCB7IHJldHVybiBtX2lzUmVkaXJlY3RlZDsgfQogCiAgICAgdm9pZCBzZXRU YWludGluZyhUYWludGluZyB0YWludGluZykgeyBtX3RhaW50aW5nID0gdGFpbnRpbmc7IH0KICAg ICBUYWludGluZyB0YWludGluZygpIGNvbnN0IHsgcmV0dXJuIG1fdGFpbnRpbmc7IH0K