175531 2017-08-14 04:55:52 -0700 [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon 2017-08-14 08:44:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply buildbot gustavo mcatanzaro oldest_to_newest 1338314 0 cgarcia 2017-08-14 04:55:52 -0700 When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL() might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a new icon. 1338317 1 318031 cgarcia 2017-08-14 05:00:14 -0700 Created attachment 318031 Patch 1338318 2 buildbot 2017-08-14 05:01:24 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1338341 3 cgarcia 2017-08-14 08:44:11 -0700 Committed r220694: <http://trac.webkit.org/changeset/220694> 318031 2017-08-14 05:00:14 -0700 2017-08-14 08:37:15 -0700 Patch wk2-favicon-changed.diff text/plain 3320 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYThmM2I2Mzg1ZGQuLjllYWU0MzBhOGJiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIwIEBACisyMDE3LTA4LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEF2b2lkIGVtaXR0aW5nIFdlYktpdEZhdmljb25E YXRhYmFzZTo6ZmF2aWNvbi1jaGFuZ2VkIG11bHRpcGxlIHRpbWVzIHdoaWxlIHNldHRpbmcgYW4g aWNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1 NTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biB3ZWJraXRGYXZpY29uRGF0YWJhc2VTZXRJY29uRm9yUGFnZVVSTCgpIGlzIGNhbGxlZCwgYm90 aCBzZXRJY29uVVJMRm9yUGFnZVVSTCgpIGFuZCBzZXRJY29uRGF0YUZvckljb25VUkwoKQorICAg ICAgICBtaWdodCBub3RpZnkgdGhlIGNsaWVudCwgd2hpY2ggZW5kcyB1cCBlbWl0dGluZyB0aGUg V2ViS2l0RmF2aWNvbkRhdGFiYXNlOjpmYXZpY29uLWNoYW5nZWQgc2lnbmFsIGFuZCBjYWxsaW5n CisgICAgICAgIHdlYmtpdEZhdmljb25EYXRhYmFzZVNldEljb25VUkxGb3JQYWdlVVJMKCkuIEJv dGggdGhpbmdzIGFyZSBhbHJlYWR5IGRvbmUgYnkKKyAgICAgICAgd2Via2l0RmF2aWNvbkRhdGFi YXNlU2V0SWNvbkZvclBhZ2VVUkwoKSBpdHNlbGYsIHNvIHdlIGNhbiBqdXN0IGlnbm9yZSB0aGUg Y2xpZW50IG5vdGlmaWNhdGlvbiB3aGlsZSBzZXR0aW5nIGEKKyAgICAgICAgbmV3IGljb24uCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcDoK KyAgICAgICAgKHdlYmtpdEZhdmljb25EYXRhYmFzZVNldEljb25VUkxGb3JQYWdlVVJMKTogUmV0 dXJuIGVhcmx5IGlmIGlzU2V0dGluZ0ljb24gaXMgdHJ1ZS4KKyAgICAgICAgKHdlYmtpdEZhdmlj b25EYXRhYmFzZVNldEljb25Gb3JQYWdlVVJMKTogU2V0IGlzU2V0dGluZ0ljb24gdG8gdHJ1ZSBm b3IgdGhlIHNjb3BlLgorCiAyMDE3LTA4LTA4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IGhhbmRsZSBjbGljayBldmVudHMg b24gb3B0aW9uIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRGYXZpY29uRGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2dsaWIvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcAppbmRleCAwY2M5NDA3N2UxMS4u MDVkNjNmZDRjNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2dsaWIvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcApAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgPFdlYkNvcmUvUmVmUHRyQ2Fpcm8uaD4KICNpbmNsdWRlIDxnbGliL2dpMThuLWxpYi5o PgogI2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CisjaW5jbHVkZSA8d3RmL1NldEZvclNjb3BlLmg+ CiAjaW5jbHVkZSA8d3RmL2dsaWIvR1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL0dVbmlx dWVQdHIuaD4KICNpbmNsdWRlIDx3dGYvZ2xpYi9XVEZHVHlwZS5oPgpAQCAtNzUsNiArNzYsNyBA QCBzdHJ1Y3QgX1dlYktpdEZhdmljb25EYXRhYmFzZVByaXZhdGUgewogICAgIFBlbmRpbmdJY29u UmVxdWVzdE1hcCBwZW5kaW5nSWNvblJlcXVlc3RzOwogICAgIEhhc2hNYXA8U3RyaW5nLCBTdHJp bmc+IHBhZ2VVUkxUb0ljb25VUkxNYXA7CiAgICAgYm9vbCBpc1VSTEltcG9ydENvbXBsZXRlZDsK KyAgICBib29sIGlzU2V0dGluZ0ljb247CiB9OwogCiBXRUJLSVRfREVGSU5FX1RZUEUoV2ViS2l0 RmF2aWNvbkRhdGFiYXNlLCB3ZWJraXRfZmF2aWNvbl9kYXRhYmFzZSwgR19UWVBFX09CSkVDVCkK QEAgLTE5Myw2ICsxOTUsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRGYXZpY29uRGF0YWJhc2VTZXRJ Y29uVVJMRm9yUGFnZVVSTChXZWJLaXRGYXZpY29uRGF0YWJhc2UqIGRhdAogICAgICAgICByZXR1 cm47CiAKICAgICBwcml2LT5wYWdlVVJMVG9JY29uVVJMTWFwLnNldChwYWdlVVJMLCBpY29uVVJM KTsKKyAgICBpZiAocHJpdi0+aXNTZXR0aW5nSWNvbikKKyAgICAgICAgcmV0dXJuOworCiAgICAg Z19zaWduYWxfZW1pdChkYXRhYmFzZSwgc2lnbmFsc1tGQVZJQ09OX0NIQU5HRURdLCAwLCBwYWdl VVJMLnV0ZjgoKS5kYXRhKCksIGljb25VUkwudXRmOCgpLmRhdGEoKSk7CiB9CiAKQEAgLTIxMiw2 ICsyMTcsOCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBkaWRDaGFuZ2VJY29uRm9yUGFnZVVSTChj b25zdCBTdHJpbmcmIHBhZ2VVUkwpIG92ZXJyaWRlCiAgICAgeworICAgICAgICBpZiAobV9kYXRh YmFzZS0+cHJpdi0+aXNTZXR0aW5nSWNvbikKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAg U3RyaW5nIGljb25VUkwgPSBtX2RhdGFiYXNlLT5wcml2LT5pY29uRGF0YWJhc2UtPnN5bmNocm9u b3VzSWNvblVSTEZvclBhZ2VVUkwocGFnZVVSTCk7CiAgICAgICAgIHdlYmtpdEZhdmljb25EYXRh YmFzZVNldEljb25VUkxGb3JQYWdlVVJMKG1fZGF0YWJhc2UsIGljb25VUkwsIHBhZ2VVUkwpOwog ICAgIH0KQEAgLTMwNSw2ICszMTIsNyBAQCB2b2lkIHdlYmtpdEZhdmljb25EYXRhYmFzZVNldElj b25Gb3JQYWdlVVJMKFdlYktpdEZhdmljb25EYXRhYmFzZSogZGF0YWJhc2UsIGNvbgogICAgICAg ICByZXR1cm47CiAKICAgICBXZWJLaXRGYXZpY29uRGF0YWJhc2VQcml2YXRlKiBwcml2ID0gZGF0 YWJhc2UtPnByaXY7CisgICAgU2V0Rm9yU2NvcGU8Ym9vbD4gY2hhbmdlKHByaXYtPmlzU2V0dGlu Z0ljb24sIHRydWUpOwogICAgIHByaXYtPmljb25EYXRhYmFzZS0+c2V0SWNvblVSTEZvclBhZ2VV UkwoaWNvbi51cmwuc3RyaW5nKCksIHBhZ2VVUkwpOwogICAgIHByaXYtPmljb25EYXRhYmFzZS0+ c2V0SWNvbkRhdGFGb3JJY29uVVJMKFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKGljb25EYXRhLmJ5dGVz KCksIGljb25EYXRhLnNpemUoKSksIGljb24udXJsLnN0cmluZygpKTsKICAgICB3ZWJraXRGYXZp Y29uRGF0YWJhc2VTZXRJY29uVVJMRm9yUGFnZVVSTChkYXRhYmFzZSwgaWNvbi51cmwuc3RyaW5n KCksIHBhZ2VVUkwpOwo=