175527 2017-08-14 03:56:29 -0700 [GTK][WPE] Crash in IconDatabase::IconRecord::setImageData() 2017-08-17 06:41:01 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply buildbot calvaris gustavo mcatanzaro zan oldest_to_newest 1338306 0 cgarcia 2017-08-14 03:56:29 -0700 I'm still getting crashes there. The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database. #0 0x00007f186d4da26e in WebKit::IconDatabase::IconRecord::setImageData(WTF::RefPtr<WebCore::SharedBuffer>&&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007f186d4dab08 in WebKit::IconDatabase::readFromDatabase() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007f186d4db112 in WebKit::IconDatabase::syncThreadMainLoop() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007f186d4db438 in WebKit::IconDatabase::iconDatabaseSyncThread() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007f186946cb0b in WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #5 0x00007f186949fa39 in WTF::wtfThreadEntryPoint(void*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #6 0x00007f1861288494 in start_thread (arg=0x7f18548fc700) at pthread_create.c:333 #7 0x00007f185fef0a8f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 1338307 1 318028 cgarcia 2017-08-14 03:58:19 -0700 Created attachment 318028 Patch 1338308 2 buildbot 2017-08-14 04:00:05 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1338309 3 cgarcia 2017-08-14 04:12:34 -0700 Committed r220677: <http://trac.webkit.org/changeset/220677> 318028 2017-08-14 03:58:19 -0700 2017-08-17 06:41:01 -0700 Patch wk2-icon-database-crash.diff text/plain 1479 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZGQwZDg4OWQ0NjkuLmQxYWRmNmJhODE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE3LTA4LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIENyYXNoIGluIEljb25EYXRhYmFzZTo6SWNvblJl Y29yZDo6c2V0SW1hZ2VEYXRhKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3NTUyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgd2hlbiBzZXRJbWFnZURhdGEoKSBpcyBj YWxsZWQgZnJvbSBJY29uRGF0YWJhc2U6OnJlYWRGcm9tRGF0YWJhc2UoKSB0aGUgc2hhcmVkIGJ1 ZmZlciBtaWdodAorICAgICAgICBiZSBudWxscHRyLCBiZWNhdXNlIGdldEltYWdlRGF0YUZvcklj b25VUkxGcm9tU1FMRGF0YWJhc2UoKSByZXR1cm5zIG51bGxwdHIgaWYgdGhlIGljb24gZGF0YSBp cyBub3QgaW4gdGhlIGRhdGFiYXNlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL0lj b25EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Okljb25EYXRhYmFzZTo6SWNvblJlY29y ZDo6c2V0SW1hZ2VEYXRhKTogUmV0dXJuIGVhcmx5IGlmIHBhc3NlZCBpbiBidWZmZXIgaXMgbnVs bHB0ci4KKwogMjAxNy0wOC0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVyOiBoYW5kbGUgY2xpY2sgZXZlbnRzIG9uIG9wdGlv biBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv SWNvbkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL0ljb25E YXRhYmFzZS5jcHAKaW5kZXggMjE3MGNkYzRjNDMuLjBlMjVhNjdkNjBjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9JY29uRGF0YWJhc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL0ljb25EYXRhYmFzZS5jcHAKQEAgLTEyMCw3 ICsxMjAsNyBAQCB2b2lkIEljb25EYXRhYmFzZTo6SWNvblJlY29yZDo6c2V0SW1hZ2VEYXRhKFJl ZlB0cjxTaGFyZWRCdWZmZXI+JiYgZGF0YSkKICAgICBtX2ltYWdlRGF0YSA9IFdURk1vdmUoZGF0 YSk7CiAgICAgbV9pbWFnZSA9IG51bGxwdHI7CiAKLSAgICBpZiAoIW1faW1hZ2VEYXRhLT5zaXpl KCkpIHsKKyAgICBpZiAoIW1faW1hZ2VEYXRhIHx8ICFtX2ltYWdlRGF0YS0+c2l6ZSgpKSB7CiAg ICAgICAgIG1faW1hZ2VEYXRhID0gbnVsbHB0cjsKICAgICAgICAgcmV0dXJuOwogICAgIH0K