<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>175514</bug_id>
          
          <creation_ts>2017-08-12 10:56:58 -0700</creation_ts>
          <short_desc>[GTK] ARMv7 build fails to build MacroAssemblerARMv7.cpp.</short_desc>
          <delta_ts>2017-08-21 18:08:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>175656</dependson>
    
    <dependson>175672</dependson>
          <blocked>175446</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>aperez</cc>
    
    <cc>benjamin</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>buildbot</cc>
    
    <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>guijemont</cc>
    
    <cc>gustavo</cc>
    
    <cc>keith_miller</cc>
    
    <cc>msaboff</cc>
    
    <cc>ossy</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1338154</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-12 10:56:58 -0700</bug_when>
    <thetext>See. https://bugs.webkit.org/show_bug.cgi?id=175446#c24:

/tmp/cco6SOuf.s: Assembler messages:
/tmp/cco6SOuf.s:48: Error: VFP single precision register expected -- `vstmia.64 ip!,{ d16-d31 }&apos;
/tmp/cco6SOuf.s:55: Error: VFP single precision register expected -- `vldmdb.64 ip!,{ d16-d31 }&apos;
/tmp/cco6SOuf.s:88: writing to APSR without specifying a bitmask is deprecated</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1338159</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-12 11:14:41 -0700</bug_when>
    <thetext>@Ossy, I looked into this as much as I can from OS(DARWIN) side and cannot find what the issue is.

&gt; /tmp/cco6SOuf.s:48: Error: VFP single precision register expected --
&gt; `vstmia.64 ip!,{ d16-d31 }&apos;
&gt; /tmp/cco6SOuf.s:55: Error: VFP single precision register expected --
&gt; `vldmdb.64 ip!,{ d16-d31 }&apos;

The .64 is supposed to tell the assembler that these instruction operate on the double precision registers.

&gt; /tmp/cco6SOuf.s:88: writing to APSR without specifying a bitmask is
&gt; deprecated

I cannot find any ARM documentation that says the MSR instruction can take an extra bitmask.  The closest possibility is that APSR needs to be specified as APSR_nzcvq.  However, Clang does not like using APSR_nzcvq.

In the end, both of these issue appears to be due to the tool chain on GTK&apos;s side.  Can someone on the GTK side investigate this?

The alternative would be to disable the DFG for non OS(DARWIN) builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1338225</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2017-08-13 02:07:43 -0700</bug_when>
    <thetext>no idea what problem GTK has ... cc-ed GTK guys

Now JSCOnly builds are happy, this one is the only one remaining issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1338226</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-13 04:48:51 -0700</bug_when>
    <thetext>(In reply to Mark Lam from comment #1)
&gt; @Ossy, I looked into this as much as I can from OS(DARWIN) side and cannot
&gt; find what the issue is.
&gt; 
&gt; &gt; /tmp/cco6SOuf.s:48: Error: VFP single precision register expected --
&gt; &gt; `vstmia.64 ip!,{ d16-d31 }&apos;
&gt; &gt; /tmp/cco6SOuf.s:55: Error: VFP single precision register expected --
&gt; &gt; `vldmdb.64 ip!,{ d16-d31 }&apos;
&gt; 
&gt; The .64 is supposed to tell the assembler that these instruction operate on
&gt; the double precision registers.
&gt; 
&gt; &gt; /tmp/cco6SOuf.s:88: writing to APSR without specifying a bitmask is
&gt; &gt; deprecated
&gt; 
&gt; I cannot find any ARM documentation that says the MSR instruction can take
&gt; an extra bitmask.  The closest possibility is that APSR needs to be
&gt; specified as APSR_nzcvq.  However, Clang does not like using APSR_nzcvq.
&gt; 
&gt; In the end, both of these issue appears to be due to the tool chain on GTK&apos;s
&gt; side.  Can someone on the GTK side investigate this?
&gt; 
&gt; The alternative would be to disable the DFG for non OS(DARWIN) builds.

GTK+ ARM bots use Thumb2 instructions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1338658</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-15 05:37:35 -0700</bug_when>
    <thetext>This may be related to the FPU the compiler assume it can use. More info: https://stackoverflow.com/a/33904219

Kov, can you please paste here the output of running &quot;gcc -v&quot; on the ARM buildbot (to see which &quot;--with-fpu&quot; parameter it was built with)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339349</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-16 16:32:03 -0700</bug_when>
    <thetext>To green the GTX bots, I&apos;ve disabled the DFG for GTK ARM_THUMB2 in r220816: &lt;http://trac.webkit.org/r220816&gt;.

Please re-enabled the DFG when this issue is fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339387</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-16 17:52:04 -0700</bug_when>
    <thetext>(In reply to Mark Lam from comment #5)
&gt; To green the GTX bots, I&apos;ve disabled the DFG for GTK ARM_THUMB2 in r220816:
&gt; &lt;http://trac.webkit.org/r220816&gt;.
&gt; 
&gt; Please re-enabled the DFG when this issue is fixed.

It looks is still broken?

(In reply to Carlos Alberto Lopez Perez from comment #4)
&gt; This may be related to the FPU the compiler assume it can use. More info:
&gt; https://stackoverflow.com/a/33904219
&gt; 
&gt; Kov, can you please paste here the output of running &quot;gcc -v&quot; on the ARM
&gt; buildbot (to see which &quot;--with-fpu&quot; parameter it was built with)?

This is the output of gcc -v on Debian armhf (The GTK+ ARM bot runs on Debian)

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabihf/6/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion=&apos;Debian 6.3.0-18&apos; --with-bugurl=file:///usr/share/doc/gcc-6/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-6 --program-prefix=arm-linux-gnueabihf- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libitm --disable-libquadmath --enable-plugin --enable-default-pie --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-6-armhf/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-6-armhf --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-6-armhf --with-arch-directory=arm --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-sjlj-exceptions --with-arch=armv7-a --with-fpu=vfpv3-d16 --with-float=hard --with-mode=thumb --enable-checking=release --build=arm-linux-gnueabihf --host=arm-linux-gnueabihf --target=arm-linux-gnueabihf
Thread model: posix
gcc version 6.3.0 20170516 (Debian 6.3.0-18) 


So, by default its building with --with-fpu=vfpv3-d16

Which according to the GCC help &lt;https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html&gt; means:

‘+vfpv3-d16’

    The VFPv3 floating-point instructions, with 16 double-precision registers.

And the ARM help says this: &lt;http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/Bcfhdhgd.html&gt;

So, my understanding is that when building with --with-fpu=vfpv3-d16 only the double-precision registers d0-d15 are available.

To access the double-precision registers beyond d15 (d16-d31) we need to build with vfpv4/neon or something like -mfpu=vfpv3-fp16


I&apos;m unsure about the consequences of requiring a vfpu with 32 double-precision registers. Do all ARMv7 CPUs support this???</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339431</commentid>
    <comment_count>7</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-16 21:58:31 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #6)
&gt; (In reply to Mark Lam from comment #5)
&gt; &gt; To green the GTX bots, I&apos;ve disabled the DFG for GTK ARM_THUMB2 in r220816:
&gt; &gt; &lt;http://trac.webkit.org/r220816&gt;.
&gt; &gt; 
&gt; &gt; Please re-enabled the DFG when this issue is fixed.
&gt; 
&gt; It looks is still broken?

https://bugs.webkit.org/show_bug.cgi?id=175656 should take care of it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339455</commentid>
    <comment_count>8</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2017-08-17 00:17:17 -0700</bug_when>
    <thetext>vfpv3-d16? Do you really have a SoC that doesn&apos;t support vfpv4? It means it doesn&apos;t support NEON. Nowadays it&apos;s hard 
to find this kind of SoC.

I can imagine that you use the default toolchain of the OS,
which is too conservative and try to support very old
CPUs too by default. I think you should check if your
SoC has vfpv4. If yes, you should just exploit it. If no,
it is a good question .... Mark, does the ARMv7 Thumb2 backend rely on 32 VFP registers?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339457</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2017-08-17 00:25:20 -0700</bug_when>
    <thetext>It seems that only Tegra2 and Marvell dove SoCs don&apos;t have 32 VFP registers, but only 16, because they don&apos;t have NEON support. Are you really want to support these SoCs?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339490</commentid>
    <comment_count>10</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-17 03:11:33 -0700</bug_when>
    <thetext>(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #9)
&gt; It seems that only Tegra2 and Marvell dove SoCs don&apos;t have 32 VFP registers,
&gt; but only 16, because they don&apos;t have NEON support. Are you really want to
&gt; support these SoCs?

Thanks for the info. I had no idea which kind of SoCs where those. This look pretty old indeed.

vfpv3-d16 is the default FPU setting in the Debian toolchain. I think Marvell is one of the SoCs supported by Debian.


https://wiki.debian.org/ArmHardFloatPort#VFP
https://wiki.debian.org/InstallingDebianOn/Marvell

Likely the machine where the GTK+ bot runs supports something better than that. The thing is that Debian defaults to --with-fpu=vfpv3-d16 and we are using the compiler defaults.

I guess the best thing we can do here is to detect on CMake if the compiler supports a FPU with 32 VFP registers and pass the right -fpu flag. If it doesn&apos;t then disable MASM (and JIT).

WDYT?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339536</commentid>
    <comment_count>11</comment_count>
      <attachid>318363</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-17 07:13:23 -0700</bug_when>
    <thetext>Created attachment 318363
proposed patch.

Please try this patch to see if it resolves the GTK build issue.  It addresses the absence of NEON, but doesn&apos;t do anything about the ASPR complaint yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339538</commentid>
    <comment_count>12</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2017-08-17 07:19:10 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #10)

&gt; I guess the best thing we can do here is to detect on CMake if the compiler
&gt; supports a FPU with 32 VFP registers and pass the right -fpu flag. If it
&gt; doesn&apos;t then disable MASM (and JIT).
&gt; 
&gt; WDYT?

Then we can end up in the opposite situation: The compiler may support
generating code for FPUs with 32 VFP registers, and the target device
may not have the hardware — which would end up in odd failures, most
likely the CPU trapping on illegal instructions.

What probably would be safer is making CMake try to build a snippet
with the configured compiler+flags which uses double-precision VFP
registers (e.g. “vstmia.64”) and, if that succeeds, then MASM gets
enabled. Then we can set “$CXXFLAGS” and “$CFLAGS” in the environment
of the build bots to pass the “-mfpu=cfpv4” flag (or whichever other
value is appropriate for the bot).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339540</commentid>
    <comment_count>13</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-17 07:21:25 -0700</bug_when>
    <thetext>(In reply to Adrian Perez from comment #12)
&gt; (In reply to Carlos Alberto Lopez Perez from comment #10)
&gt; 
&gt; &gt; I guess the best thing we can do here is to detect on CMake if the compiler
&gt; &gt; supports a FPU with 32 VFP registers and pass the right -fpu flag. If it
&gt; &gt; doesn&apos;t then disable MASM (and JIT).
&gt; &gt; 
&gt; &gt; WDYT?
&gt; 
&gt; Then we can end up in the opposite situation: The compiler may support
&gt; generating code for FPUs with 32 VFP registers, and the target device
&gt; may not have the hardware — which would end up in odd failures, most
&gt; likely the CPU trapping on illegal instructions.
&gt; 
&gt; What probably would be safer is making CMake try to build a snippet
&gt; with the configured compiler+flags which uses double-precision VFP
&gt; registers (e.g. “vstmia.64”) and, if that succeeds, then MASM gets
&gt; enabled. Then we can set “$CXXFLAGS” and “$CFLAGS” in the environment
&gt; of the build bots to pass the “-mfpu=cfpv4” flag (or whichever other
&gt; value is appropriate for the bot).

According to Platform.h, we already have such a flag: CPU(ARM_NEON).  Please try the attached patch and let me know if it resolves the GTK build issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339546</commentid>
    <comment_count>14</comment_count>
      <attachid>318363</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-17 07:36:43 -0700</bug_when>
    <thetext>Comment on attachment 318363
proposed patch.

Regardless of whether this patch resolves the entire GTK build issue or not, it is correct.  I&apos;m going to track it over in https://bugs.webkit.org/show_bug.cgi?id=175672 and just block the current bug on 175672.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340123</commentid>
    <comment_count>15</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-18 10:10:59 -0700</bug_when>
    <thetext>(In reply to Mark Lam from comment #14)
&gt; Comment on attachment 318363 [details]
&gt; proposed patch.
&gt; 
&gt; Regardless of whether this patch resolves the entire GTK build issue or not,
&gt; it is correct.  I&apos;m going to track it over in
&gt; https://bugs.webkit.org/show_bug.cgi?id=175672 and just block the current
&gt; bug on 175672.

So after r220871 &lt;http://trac.webkit.org/r220871&gt; its possible to enable MASM (and the JIT) on ARMv7 CPUs with only 16 double VFP registers??


If that is the case, then should we revert r220823 &lt;http://trac.webkit.org/r220823&gt; and r220816 &lt;http://trac.webkit.org/r220816&gt; ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340127</commentid>
    <comment_count>16</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-18 10:15:03 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #15)
&gt; (In reply to Mark Lam from comment #14)
&gt; &gt; Comment on attachment 318363 [details]
&gt; &gt; proposed patch.
&gt; &gt; 
&gt; &gt; Regardless of whether this patch resolves the entire GTK build issue or not,
&gt; &gt; it is correct.  I&apos;m going to track it over in
&gt; &gt; https://bugs.webkit.org/show_bug.cgi?id=175672 and just block the current
&gt; &gt; bug on 175672.
&gt; 
&gt; So after r220871 &lt;http://trac.webkit.org/r220871&gt; its possible to enable
&gt; MASM (and the JIT) on ARMv7 CPUs with only 16 double VFP registers??
&gt; 
&gt; 
&gt; If that is the case, then should we revert r220823
&gt; &lt;http://trac.webkit.org/r220823&gt; and r220816
&gt; &lt;http://trac.webkit.org/r220816&gt; ?

Did you actually enable MASM_PROBE for GTK and actually build for the ARM_THUMB2 target to confirm that it works?  

If so, then you can add GTK back to the configurations that enable DFG_JIT.  Please leave http://trac.webkit.org/r220823 in place.  I think it&apos;s useful to keep around for a while.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340152</commentid>
    <comment_count>17</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-18 11:17:50 -0700</bug_when>
    <thetext>(In reply to Mark Lam from comment #16)
&gt; (In reply to Carlos Alberto Lopez Perez from comment #15)
&gt; &gt; (In reply to Mark Lam from comment #14)
&gt; &gt; &gt; Comment on attachment 318363 [details]
&gt; &gt; &gt; proposed patch.
&gt; &gt; &gt; 
&gt; &gt; &gt; Regardless of whether this patch resolves the entire GTK build issue or not,
&gt; &gt; &gt; it is correct.  I&apos;m going to track it over in
&gt; &gt; &gt; https://bugs.webkit.org/show_bug.cgi?id=175672 and just block the current
&gt; &gt; &gt; bug on 175672.
&gt; &gt; 
&gt; &gt; So after r220871 &lt;http://trac.webkit.org/r220871&gt; its possible to enable
&gt; &gt; MASM (and the JIT) on ARMv7 CPUs with only 16 double VFP registers??
&gt; &gt; 
&gt; &gt; 
&gt; &gt; If that is the case, then should we revert r220823
&gt; &gt; &lt;http://trac.webkit.org/r220823&gt; and r220816
&gt; &gt; &lt;http://trac.webkit.org/r220816&gt; ?
&gt; 
&gt; Did you actually enable MASM_PROBE for GTK and actually build for the
&gt; ARM_THUMB2 target to confirm that it works?  
&gt; 

It will take me a while to test this, I don&apos;t have access to a Debian ARM machine now. I will try to setup a RPi with it this weekend.

&gt; If so, then you can add GTK back to the configurations that enable DFG_JIT. 
&gt; Please leave http://trac.webkit.org/r220823 in place.  I think it&apos;s useful
&gt; to keep around for a while.

The issue with r220823 is that building with MASM_PROBE disabled looks broken (at least on GTK). The GTK ARM bot continues to fail to build. See: https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/1050/steps/compile-webkit/logs/stdio/text


Btw.. thanks for the fixes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340202</commentid>
    <comment_count>18</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-08-18 13:08:50 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #17)
&gt; The issue with r220823 is that building with MASM_PROBE disabled looks
&gt; broken (at least on GTK). The GTK ARM bot continues to fail to build. See:
&gt; https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/1050/
&gt; steps/compile-webkit/logs/stdio/text

I think this should be fixed as of r220921: &lt;http://trac.webkit.org/r220921&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340842</commentid>
    <comment_count>19</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-21 16:58:44 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #17)
&gt; &gt; Did you actually enable MASM_PROBE for GTK and actually build for the
&gt; &gt; ARM_THUMB2 target to confirm that it works?  
&gt; &gt; 
&gt; 
&gt; It will take me a while to test this, I don&apos;t have access to a Debian ARM
&gt; machine now. I will try to setup a RPi with it this weekend.
&gt; 

Tested: It builds fine and JSC tests look ok.

I&apos;m uploading patch with the fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340850</commentid>
    <comment_count>20</comment_count>
      <attachid>318701</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-08-21 17:13:11 -0700</bug_when>
    <thetext>Created attachment 318701
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340856</commentid>
    <comment_count>21</comment_count>
      <attachid>318701</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2017-08-21 17:22:15 -0700</bug_when>
    <thetext>Comment on attachment 318701
Patch

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340888</commentid>
    <comment_count>22</comment_count>
      <attachid>318701</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-21 18:07:21 -0700</bug_when>
    <thetext>Comment on attachment 318701
Patch

Clearing flags on attachment: 318701

Committed r220993: &lt;http://trac.webkit.org/changeset/220993&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340889</commentid>
    <comment_count>23</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-08-21 18:07:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340893</commentid>
    <comment_count>24</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-08-21 18:08:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/34004175&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>318363</attachid>
            <date>2017-08-17 07:13:23 -0700</date>
            <delta_ts>2017-08-17 07:36:43 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-175514.patch</filename>
            <type>text/plain</type>
            <size>12328</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwODU1KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA
CisyMDE3LTA4LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBP
bmx5IHVzZSAxNiBWRlAgcmVnaXN0ZXJzIGlmICFDUFUoQVJNX05FT04pLgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NTE0CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBtb3N0bHkgZm9yIEdU
SyB0b29sY2hhaW5zIHdoaWNoIG1heSB0YXJnZXQgb2xkZXIgQVJNIENQVXMgdGhhdCBkbyBub3QK
KyAgICAgICAgaGF2ZSBORU9OIHN1cHBvcnQuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNQXNz
ZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFSTUFzc2VtYmxlcjo6bGFzdEZQUmVnaXN0ZXIpOgor
ICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6OmZwck5hbWUpOgorICAgICAgICAqIGFzc2VtYmxl
ci9BUk12N0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk12N0Fzc2VtYmxlcjo6bGFzdEZQ
UmVnaXN0ZXIpOgorICAgICAgICAoSlNDOjpBUk12N0Fzc2VtYmxlcjo6ZnByTmFtZSk6CisgICAg
ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcDoKKyAgICAgICAgKiBhc3NlbWJs
ZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5jcHA6CisKIDIwMTctMDgtMTcgIFl1c3VrZSBTdXp1a2kg
IDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0pTQ10gQXZvaWQgY29kZSBibG9h
dGluZyBmb3IgaXRlcmF0aW9uIGlmIGJsb2NrIGRvZXMgbm90IGhhdmUgImJyZWFrIgpJbmRleDog
U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCShyZXZp
c2lvbiAyMjA4MzIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2Vt
Ymxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC04Nyw2ICs4Nyw3IEBAIG5hbWVzcGFjZSBKU0Mgewog
ICAgICAgICAgICAgZDEzLAogICAgICAgICAgICAgZDE0LAogICAgICAgICAgICAgZDE1LAorI2lm
IENQVShBUk1fTkVPTikKICAgICAgICAgICAgIGQxNiwKICAgICAgICAgICAgIGQxNywKICAgICAg
ICAgICAgIGQxOCwKQEAgLTEwMyw2ICsxMDQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAg
ICAgIGQyOSwKICAgICAgICAgICAgIGQzMCwKICAgICAgICAgICAgIGQzMSwKKyNlbmRpZiAvLyBD
UFUoQVJNX05FT04pCiAKICAgICAgICAgICAgIC8vIFBzZXVkb255bXMgZm9yIHNvbWUgb2YgdGhl
IHJlZ2lzdGVycy4KICAgICAgICAgICAgIFNEMCA9IGQ3LCAvKiBTYW1lIGFzIHRodW1iIGFzc2Vt
Ymxlci4gKi8KQEAgLTEzNCw3ICsxMzYsMTEgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHN0
YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgbnVtYmVyT2ZTUFJlZ2lzdGVycygpIHsgcmV0dXJuIGxh
c3RTUFJlZ2lzdGVyKCkgLSBmaXJzdFNQUmVnaXN0ZXIoKSArIDE7IH0KIAogICAgICAgICBzdGF0
aWMgY29uc3RleHByIEZQUmVnaXN0ZXJJRCBmaXJzdEZQUmVnaXN0ZXIoKSB7IHJldHVybiBBUk1S
ZWdpc3RlcnM6OmQwOyB9CisjaWYgQ1BVKEFSTV9ORU9OKQogICAgICAgICBzdGF0aWMgY29uc3Rl
eHByIEZQUmVnaXN0ZXJJRCBsYXN0RlBSZWdpc3RlcigpIHsgcmV0dXJuIEFSTVJlZ2lzdGVyczo6
ZDMxOyB9CisjZWxzZQorICAgICAgICBzdGF0aWMgY29uc3RleHByIEZQUmVnaXN0ZXJJRCBsYXN0
RlBSZWdpc3RlcigpIHsgcmV0dXJuIEFSTVJlZ2lzdGVyczo6ZDE1OyB9CisjZW5kaWYKICAgICAg
ICAgc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBudW1iZXJPZkZQUmVnaXN0ZXJzKCkgeyByZXR1
cm4gbGFzdEZQUmVnaXN0ZXIoKSAtIGZpcnN0RlBSZWdpc3RlcigpICsgMTsgfQogCiAgICAgICAg
IHN0YXRpYyBjb25zdCBjaGFyKiBncHJOYW1lKFJlZ2lzdGVySUQgaWQpCkBAIC0xNjYsMTAgKzE3
MiwxMiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgICAgICAiZDQiLCAiZDUiLCAiZDYi
LCAiZDciLAogICAgICAgICAgICAgICAgICJkOCIsICJkOSIsICJkMTAiLCAiZDExIiwKICAgICAg
ICAgICAgICAgICAiZDEyIiwgImQxMyIsICJkMTQiLCAiZDE1IiwKKyNpZiBDUFUoQVJNX05FT04p
CiAgICAgICAgICAgICAgICAgImQxNiIsICJkMTciLCAiZDE4IiwgImQxOSIsCiAgICAgICAgICAg
ICAgICAgImQyMCIsICJkMjEiLCAiZDIyIiwgImQyMyIsCiAgICAgICAgICAgICAgICAgImQyNCIs
ICJkMjUiLCAiZDI2IiwgImQyNyIsCiAgICAgICAgICAgICAgICAgImQyOCIsICJkMjkiLCAiZDMw
IiwgImQzMSIKKyNlbmRpZiAvLyBDUFUoQVJNX05FT04pCiAgICAgICAgICAgICB9OwogICAgICAg
ICAgICAgcmV0dXJuIG5hbWVGb3JSZWdpc3RlcltpZF07CiAgICAgICAgIH0KSW5kZXg6IFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgJKHJldmlz
aW9uIDIyMDgzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3Nl
bWJsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODgsNiArODgsNyBAQCBuYW1lc3BhY2UgQVJNUmVn
aXN0ZXJzIHsKICAgICAgICAgczEzLAogICAgICAgICBzMTQsCiAgICAgICAgIHMxNSwKKyNpZiBD
UFUoQVJNX05FT04pCiAgICAgICAgIHMxNiwKICAgICAgICAgczE3LAogICAgICAgICBzMTgsCkBA
IC0xMDQsNiArMTA1LDcgQEAgbmFtZXNwYWNlIEFSTVJlZ2lzdGVycyB7CiAgICAgICAgIHMyOSwK
ICAgICAgICAgczMwLAogICAgICAgICBzMzEsCisjZW5kaWYgLy8gQ1BVKEFSTV9ORU9OKQogICAg
IH0gRlBTaW5nbGVSZWdpc3RlcklEOwogCiAgICAgdHlwZWRlZiBlbnVtIHsKQEAgLTEyMyw2ICsx
MjUsNyBAQCBuYW1lc3BhY2UgQVJNUmVnaXN0ZXJzIHsKICAgICAgICAgZDEzLAogICAgICAgICBk
MTQsCiAgICAgICAgIGQxNSwKKyNpZiBDUFUoQVJNX05FT04pCiAgICAgICAgIGQxNiwKICAgICAg
ICAgZDE3LAogICAgICAgICBkMTgsCkBAIC0xMzksNiArMTQyLDcgQEAgbmFtZXNwYWNlIEFSTVJl
Z2lzdGVycyB7CiAgICAgICAgIGQyOSwKICAgICAgICAgZDMwLAogICAgICAgICBkMzEsCisjZW5k
aWYgLy8gQ1BVKEFSTV9ORU9OKQogICAgIH0gRlBEb3VibGVSZWdpc3RlcklEOwogCiAgICAgdHlw
ZWRlZiBlbnVtIHsKQEAgLTE1OCw2ICsxNjIsNyBAQCBuYW1lc3BhY2UgQVJNUmVnaXN0ZXJzIHsK
ICAgICAgICAgcTEzLAogICAgICAgICBxMTQsCiAgICAgICAgIHExNSwKKyNpZiBDUFUoQVJNX05F
T04pCiAgICAgICAgIHExNiwKICAgICAgICAgcTE3LAogICAgICAgICBxMTgsCkBAIC0xNzQsNiAr
MTc5LDcgQEAgbmFtZXNwYWNlIEFSTVJlZ2lzdGVycyB7CiAgICAgICAgIHEyOSwKICAgICAgICAg
cTMwLAogICAgICAgICBxMzEsCisjZW5kaWYgLy8gQ1BVKEFSTV9ORU9OKQogICAgIH0gRlBRdWFk
UmVnaXN0ZXJJRDsKIAogICAgIGlubGluZSBGUFNpbmdsZVJlZ2lzdGVySUQgYXNTaW5nbGUoRlBE
b3VibGVSZWdpc3RlcklEIHJlZykKQEAgLTQ0Niw3ICs0NTIsMTEgQEAgcHVibGljOgogICAgIHN0
YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgbnVtYmVyT2ZTUFJlZ2lzdGVycygpIHsgcmV0dXJuIGxh
c3RTUFJlZ2lzdGVyKCkgLSBmaXJzdFNQUmVnaXN0ZXIoKSArIDE7IH0KIAogICAgIHN0YXRpYyBj
b25zdGV4cHIgRlBSZWdpc3RlcklEIGZpcnN0RlBSZWdpc3RlcigpIHsgcmV0dXJuIEFSTVJlZ2lz
dGVyczo6ZDA7IH0KKyNpZiBDUFUoQVJNX05FT04pCiAgICAgc3RhdGljIGNvbnN0ZXhwciBGUFJl
Z2lzdGVySUQgbGFzdEZQUmVnaXN0ZXIoKSB7IHJldHVybiBBUk1SZWdpc3RlcnM6OmQzMTsgfQor
I2Vsc2UKKyAgICBzdGF0aWMgY29uc3RleHByIEZQUmVnaXN0ZXJJRCBsYXN0RlBSZWdpc3Rlcigp
IHsgcmV0dXJuIEFSTVJlZ2lzdGVyczo6ZDE1OyB9CisjZW5kaWYKICAgICBzdGF0aWMgY29uc3Rl
eHByIHVuc2lnbmVkIG51bWJlck9mRlBSZWdpc3RlcnMoKSB7IHJldHVybiBsYXN0RlBSZWdpc3Rl
cigpIC0gZmlyc3RGUFJlZ2lzdGVyKCkgKyAxOyB9CiAKICAgICBzdGF0aWMgY29uc3QgY2hhciog
Z3ByTmFtZShSZWdpc3RlcklEIGlkKQpAQCAtNDc4LDEwICs0ODgsMTIgQEAgcHVibGljOgogICAg
ICAgICAgICAgImQ0IiwgImQ1IiwgImQ2IiwgImQ3IiwKICAgICAgICAgICAgICJkOCIsICJkOSIs
ICJkMTAiLCAiZDExIiwKICAgICAgICAgICAgICJkMTIiLCAiZDEzIiwgImQxNCIsICJkMTUiLAor
I2lmIENQVShBUk1fTkVPTikKICAgICAgICAgICAgICJkMTYiLCAiZDE3IiwgImQxOCIsICJkMTki
LAogICAgICAgICAgICAgImQyMCIsICJkMjEiLCAiZDIyIiwgImQyMyIsCiAgICAgICAgICAgICAi
ZDI0IiwgImQyNSIsICJkMjYiLCAiZDI3IiwKICAgICAgICAgICAgICJkMjgiLCAiZDI5IiwgImQz
MCIsICJkMzEiCisjZW5kaWYgLy8gQ1BVKEFSTV9ORU9OKQogICAgICAgICB9OwogICAgICAgICBy
ZXR1cm4gbmFtZUZvclJlZ2lzdGVyW2lkXTsKICAgICB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcAkocmV2aXNp
b24gMjIwODM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt
YmxlckFSTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Myw2ICsxNTMsOCBAQCBleHRlcm4gIkMi
IHZvaWQgY3RpTWFzbVByb2JlVHJhbXBvbGluZSgpCiAjZGVmaW5lIFBST0JFX0NQVV9EMTNfT0ZG
U0VUIChQUk9CRV9GSVJTVF9GUFJFR19PRkZTRVQgKyAoMTMgKiBGUFJFR19TSVpFKSkKICNkZWZp
bmUgUFJPQkVfQ1BVX0QxNF9PRkZTRVQgKFBST0JFX0ZJUlNUX0ZQUkVHX09GRlNFVCArICgxNCAq
IEZQUkVHX1NJWkUpKQogI2RlZmluZSBQUk9CRV9DUFVfRDE1X09GRlNFVCAoUFJPQkVfRklSU1Rf
RlBSRUdfT0ZGU0VUICsgKDE1ICogRlBSRUdfU0laRSkpCisKKyNpZiBDUFUoQVJNX05FT04pCiAj
ZGVmaW5lIFBST0JFX0NQVV9EMTZfT0ZGU0VUIChQUk9CRV9GSVJTVF9GUFJFR19PRkZTRVQgKyAo
MTYgKiBGUFJFR19TSVpFKSkKICNkZWZpbmUgUFJPQkVfQ1BVX0QxN19PRkZTRVQgKFBST0JFX0ZJ
UlNUX0ZQUkVHX09GRlNFVCArICgxNyAqIEZQUkVHX1NJWkUpKQogI2RlZmluZSBQUk9CRV9DUFVf
RDE4X09GRlNFVCAoUFJPQkVfRklSU1RfRlBSRUdfT0ZGU0VUICsgKDE4ICogRlBSRUdfU0laRSkp
CkBAIC0xNzEsNiArMTczLDkgQEAgZXh0ZXJuICJDIiB2b2lkIGN0aU1hc21Qcm9iZVRyYW1wb2xp
bmUoKQogI2RlZmluZSBQUk9CRV9DUFVfRDMxX09GRlNFVCAoUFJPQkVfRklSU1RfRlBSRUdfT0ZG
U0VUICsgKDMxICogRlBSRUdfU0laRSkpCiAKICNkZWZpbmUgUFJPQkVfU0laRSAoUFJPQkVfRklS
U1RfRlBSRUdfT0ZGU0VUICsgKDMyICogRlBSRUdfU0laRSkpCisjZWxzZQorI2RlZmluZSBQUk9C
RV9TSVpFIChQUk9CRV9GSVJTVF9GUFJFR19PRkZTRVQgKyAoMTYgKiBGUFJFR19TSVpFKSkKKyNl
bmRpZiAvLyBDUFUoQVJNX05FT04pCiAKICNkZWZpbmUgT1VUX1NJWkUgR1BSRUdfU0laRQogCkBA
IC0yMjIsNiArMjI3LDggQEAgQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0YoY3B1LmZwcnNb
QQogQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0YoY3B1LmZwcnNbQVJNUmVnaXN0ZXJzOjpk
MTNdKSA9PSBQUk9CRV9DUFVfRDEzX09GRlNFVCwgUHJvYmVDb250ZXh0X2NwdV9kMTNfb2Zmc2V0
X21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiBDT01QSUxFX0FTU0VSVChQUk9CRV9P
RkZTRVRPRihjcHUuZnByc1tBUk1SZWdpc3RlcnM6OmQxNF0pID09IFBST0JFX0NQVV9EMTRfT0ZG
U0VULCBQcm9iZUNvbnRleHRfY3B1X2QxNF9vZmZzZXRfbWF0Y2hlc19jdGlNYXNtUHJvYmVUcmFt
cG9saW5lKTsKIENPTVBJTEVfQVNTRVJUKFBST0JFX09GRlNFVE9GKGNwdS5mcHJzW0FSTVJlZ2lz
dGVyczo6ZDE1XSkgPT0gUFJPQkVfQ1BVX0QxNV9PRkZTRVQsIFByb2JlQ29udGV4dF9jcHVfZDE1
X29mZnNldF9tYXRjaGVzX2N0aU1hc21Qcm9iZVRyYW1wb2xpbmUpOworCisjaWYgQ1BVKEFSTV9O
RU9OKQogQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0YoY3B1LmZwcnNbQVJNUmVnaXN0ZXJz
OjpkMTZdKSA9PSBQUk9CRV9DUFVfRDE2X09GRlNFVCwgUHJvYmVDb250ZXh0X2NwdV9kMTZfb2Zm
c2V0X21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiBDT01QSUxFX0FTU0VSVChQUk9C
RV9PRkZTRVRPRihjcHUuZnByc1tBUk1SZWdpc3RlcnM6OmQxN10pID09IFBST0JFX0NQVV9EMTdf
T0ZGU0VULCBQcm9iZUNvbnRleHRfY3B1X2QxN19vZmZzZXRfbWF0Y2hlc19jdGlNYXNtUHJvYmVU
cmFtcG9saW5lKTsKIENPTVBJTEVfQVNTRVJUKFBST0JFX09GRlNFVE9GKGNwdS5mcHJzW0FSTVJl
Z2lzdGVyczo6ZDE4XSkgPT0gUFJPQkVfQ1BVX0QxOF9PRkZTRVQsIFByb2JlQ29udGV4dF9jcHVf
ZDE4X29mZnNldF9tYXRjaGVzX2N0aU1hc21Qcm9iZVRyYW1wb2xpbmUpOwpAQCAtMjM4LDYgKzI0
NSw3IEBAIENPTVBJTEVfQVNTRVJUKFBST0JFX09GRlNFVE9GKGNwdS5mcHJzW0EKIENPTVBJTEVf
QVNTRVJUKFBST0JFX09GRlNFVE9GKGNwdS5mcHJzW0FSTVJlZ2lzdGVyczo6ZDI5XSkgPT0gUFJP
QkVfQ1BVX0QyOV9PRkZTRVQsIFByb2JlQ29udGV4dF9jcHVfZDI5X29mZnNldF9tYXRjaGVzX2N0
aU1hc21Qcm9iZVRyYW1wb2xpbmUpOwogQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0YoY3B1
LmZwcnNbQVJNUmVnaXN0ZXJzOjpkMzBdKSA9PSBQUk9CRV9DUFVfRDMwX09GRlNFVCwgUHJvYmVD
b250ZXh0X2NwdV9kMzBfb2Zmc2V0X21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiBD
T01QSUxFX0FTU0VSVChQUk9CRV9PRkZTRVRPRihjcHUuZnByc1tBUk1SZWdpc3RlcnM6OmQzMV0p
ID09IFBST0JFX0NQVV9EMzFfT0ZGU0VULCBQcm9iZUNvbnRleHRfY3B1X2QzMV9vZmZzZXRfbWF0
Y2hlc19jdGlNYXNtUHJvYmVUcmFtcG9saW5lKTsKKyNlbmRpZiAvLyBDUFUoQVJNX05FT04pCiAK
IENPTVBJTEVfQVNTRVJUKHNpemVvZihQcm9iZUNvbnRleHQpID09IFBST0JFX1NJWkUsIFByb2Jl
Q29udGV4dF9zaXplX21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiAjdW5kZWYgUFJP
QkVfT0ZGU0VUT0YKQEAgLTI5MSw4ICsyOTksOSBAQCBhc20gKAogCiAgICAgImFkZCAgICAgICBp
cCwgc3AsICMiIFNUUklOR0laRV9WQUxVRV9PRihQUk9CRV9DUFVfRDBfT0ZGU0VUKSAiXG4iCiAg
ICAgInZzdG1pYS42NCBpcCEsIHsgZDAtZDE1IH0iICJcbiIKKyNpZiBDUFUoQVJNX05FT04pCiAg
ICAgInZzdG1pYS42NCBpcCEsIHsgZDE2LWQzMSB9IiAiXG4iCi0KKyNlbmRpZgogICAgICJtb3Yg
ICAgICAgZnAsIHNwIiAiXG4iIC8vIFNhdmUgdGhlIFByb2JlQ29udGV4dCouCiAKICAgICAvLyBJ
bml0aWFsaXplIFByb2JlQ29udGV4dDo6aW5pdGlhbGl6ZVN0YWNrRnVuY3Rpb24gdG8gemVyby4K
QEAgLTM0OSw5ICszNTgsMTUgQEAgYXNtICgKICAgICAvLyBUbyBlbmFibGUgcHJvYmVzIHRvIG1v
ZGlmeSByZWdpc3RlciBzdGF0ZSwgd2UgY29weSBhbGwgcmVnaXN0ZXJzCiAgICAgLy8gb3V0IG9m
IHRoZSBQcm9iZUNvbnRleHQgYmVmb3JlIHJldHVybmluZy4KIAorI2lmIENQVShBUk1fTkVPTikK
ICAgICAiYWRkICAgICAgIGlwLCBzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9E
MzFfT0ZGU0VUICsgRlBSRUdfU0laRSkgIlxuIgogICAgICJ2bGRtZGIuNjQgaXAhLCB7IGQxNi1k
MzEgfSIgIlxuIgogICAgICJ2bGRtZGIuNjQgaXAhLCB7IGQwLWQxNSB9IiAiXG4iCisjZWxzZQor
ICAgICJhZGQgICAgICAgaXAsIHNwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJPQkVfQ1BVX0Qx
NV9PRkZTRVQgKyBGUFJFR19TSVpFKSAiXG4iCisgICAgInZsZG1kYi42NCBpcCEsIHsgZDAtZDE1
IH0iICJcbiIKKyNlbmRpZgorCiAgICAgImFkZCAgICAgICBpcCwgc3AsICMiIFNUUklOR0laRV9W
QUxVRV9PRihQUk9CRV9DUFVfUjExX09GRlNFVCArIEdQUkVHX1NJWkUpICJcbiIKICAgICAibGRt
ZGIgICAgIGlwLCB7IHIwLXIxMSB9IiAiXG4iCiAgICAgImxkciAgICAgICBpcCwgW3NwLCAjIiBT
VFJJTkdJWkVfVkFMVUVfT0YoUFJPQkVfQ1BVX0ZQU0NSX09GRlNFVCkgIl0iICJcbiIKSW5kZXg6
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt
YmxlckFSTXY3LmNwcAkocmV2aXNpb24gMjIwODMyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl
L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODks
NiArODksOCBAQCBleHRlcm4gIkMiIHZvaWQgY3RpTWFzbVByb2JlVHJhbXBvbGluZSgpCiAjZGVm
aW5lIFBST0JFX0NQVV9EMTNfT0ZGU0VUIChQUk9CRV9GSVJTVF9GUFJFR19PRkZTRVQgKyAoMTMg
KiBGUFJFR19TSVpFKSkKICNkZWZpbmUgUFJPQkVfQ1BVX0QxNF9PRkZTRVQgKFBST0JFX0ZJUlNU
X0ZQUkVHX09GRlNFVCArICgxNCAqIEZQUkVHX1NJWkUpKQogI2RlZmluZSBQUk9CRV9DUFVfRDE1
X09GRlNFVCAoUFJPQkVfRklSU1RfRlBSRUdfT0ZGU0VUICsgKDE1ICogRlBSRUdfU0laRSkpCisK
KyNpZiBDUFUoQVJNX05FT04pCiAjZGVmaW5lIFBST0JFX0NQVV9EMTZfT0ZGU0VUIChQUk9CRV9G
SVJTVF9GUFJFR19PRkZTRVQgKyAoMTYgKiBGUFJFR19TSVpFKSkKICNkZWZpbmUgUFJPQkVfQ1BV
X0QxN19PRkZTRVQgKFBST0JFX0ZJUlNUX0ZQUkVHX09GRlNFVCArICgxNyAqIEZQUkVHX1NJWkUp
KQogI2RlZmluZSBQUk9CRV9DUFVfRDE4X09GRlNFVCAoUFJPQkVfRklSU1RfRlBSRUdfT0ZGU0VU
ICsgKDE4ICogRlBSRUdfU0laRSkpCkBAIC0xMDcsNiArMTA5LDkgQEAgZXh0ZXJuICJDIiB2b2lk
IGN0aU1hc21Qcm9iZVRyYW1wb2xpbmUoKQogI2RlZmluZSBQUk9CRV9DUFVfRDMxX09GRlNFVCAo
UFJPQkVfRklSU1RfRlBSRUdfT0ZGU0VUICsgKDMxICogRlBSRUdfU0laRSkpCiAKICNkZWZpbmUg
UFJPQkVfU0laRSAoUFJPQkVfRklSU1RfRlBSRUdfT0ZGU0VUICsgKDMyICogRlBSRUdfU0laRSkp
CisjZWxzZQorI2RlZmluZSBQUk9CRV9TSVpFIChQUk9CRV9GSVJTVF9GUFJFR19PRkZTRVQgKyAo
MTYgKiBGUFJFR19TSVpFKSkKKyNlbmRpZiAvLyBDUFUoQVJNX05FT04pCiAKICNkZWZpbmUgT1VU
X1NJWkUgR1BSRUdfU0laRQogCkBAIC0xNTksNiArMTY0LDcgQEAgQ09NUElMRV9BU1NFUlQoUFJP
QkVfT0ZGU0VUT0YoY3B1LmZwcnNbQQogQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0YoY3B1
LmZwcnNbQVJNUmVnaXN0ZXJzOjpkMTRdKSA9PSBQUk9CRV9DUFVfRDE0X09GRlNFVCwgUHJvYmVD
b250ZXh0X2NwdV9kMTRfb2Zmc2V0X21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiBD
T01QSUxFX0FTU0VSVChQUk9CRV9PRkZTRVRPRihjcHUuZnByc1tBUk1SZWdpc3RlcnM6OmQxNV0p
ID09IFBST0JFX0NQVV9EMTVfT0ZGU0VULCBQcm9iZUNvbnRleHRfY3B1X2QxNV9vZmZzZXRfbWF0
Y2hlc19jdGlNYXNtUHJvYmVUcmFtcG9saW5lKTsKIAorI2lmIENQVShBUk1fTkVPTikKIENPTVBJ
TEVfQVNTRVJUKFBST0JFX09GRlNFVE9GKGNwdS5mcHJzW0FSTVJlZ2lzdGVyczo6ZDE2XSkgPT0g
UFJPQkVfQ1BVX0QxNl9PRkZTRVQsIFByb2JlQ29udGV4dF9jcHVfZDE2X29mZnNldF9tYXRjaGVz
X2N0aU1hc21Qcm9iZVRyYW1wb2xpbmUpOwogQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0Yo
Y3B1LmZwcnNbQVJNUmVnaXN0ZXJzOjpkMTddKSA9PSBQUk9CRV9DUFVfRDE3X09GRlNFVCwgUHJv
YmVDb250ZXh0X2NwdV9kMTdfb2Zmc2V0X21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7
CiBDT01QSUxFX0FTU0VSVChQUk9CRV9PRkZTRVRPRihjcHUuZnByc1tBUk1SZWdpc3RlcnM6OmQx
OF0pID09IFBST0JFX0NQVV9EMThfT0ZGU0VULCBQcm9iZUNvbnRleHRfY3B1X2QxOF9vZmZzZXRf
bWF0Y2hlc19jdGlNYXNtUHJvYmVUcmFtcG9saW5lKTsKQEAgLTE3NSwxMCArMTgxLDExIEBAIENP
TVBJTEVfQVNTRVJUKFBST0JFX09GRlNFVE9GKGNwdS5mcHJzW0EKIENPTVBJTEVfQVNTRVJUKFBS
T0JFX09GRlNFVE9GKGNwdS5mcHJzW0FSTVJlZ2lzdGVyczo6ZDI5XSkgPT0gUFJPQkVfQ1BVX0Qy
OV9PRkZTRVQsIFByb2JlQ29udGV4dF9jcHVfZDI5X29mZnNldF9tYXRjaGVzX2N0aU1hc21Qcm9i
ZVRyYW1wb2xpbmUpOwogQ09NUElMRV9BU1NFUlQoUFJPQkVfT0ZGU0VUT0YoY3B1LmZwcnNbQVJN
UmVnaXN0ZXJzOjpkMzBdKSA9PSBQUk9CRV9DUFVfRDMwX09GRlNFVCwgUHJvYmVDb250ZXh0X2Nw
dV9kMzBfb2Zmc2V0X21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiBDT01QSUxFX0FT
U0VSVChQUk9CRV9PRkZTRVRPRihjcHUuZnByc1tBUk1SZWdpc3RlcnM6OmQzMV0pID09IFBST0JF
X0NQVV9EMzFfT0ZGU0VULCBQcm9iZUNvbnRleHRfY3B1X2QzMV9vZmZzZXRfbWF0Y2hlc19jdGlN
YXNtUHJvYmVUcmFtcG9saW5lKTsKKyNlbmRpZiAvLyBDUFUoQVJNX05FT04pCiAKIENPTVBJTEVf
QVNTRVJUKHNpemVvZihQcm9iZUNvbnRleHQpID09IFBST0JFX1NJWkUsIFByb2JlQ29udGV4dF9z
aXplX21hdGNoZXNfY3RpTWFzbVByb2JlVHJhbXBvbGluZSk7CiAjdW5kZWYgUFJPQkVfT0ZGU0VU
T0YKLSAgICAKKwogYXNtICgKICAgICAiLnRleHQiICJcbiIKICAgICAiLmFsaWduIDIiICJcbiIK
QEAgLTIzMCw4ICsyMzcsOSBAQCBhc20gKAogCiAgICAgImFkZCAgICAgICBpcCwgc3AsICMiIFNU
UklOR0laRV9WQUxVRV9PRihQUk9CRV9DUFVfRDBfT0ZGU0VUKSAiXG4iCiAgICAgInZzdG1pYS42
NCBpcCEsIHsgZDAtZDE1IH0iICJcbiIKKyNpZiBDUFUoQVJNX05FT04pCiAgICAgInZzdG1pYS42
NCBpcCEsIHsgZDE2LWQzMSB9IiAiXG4iCi0KKyNlbmRpZgogICAgICJtb3YgICAgICAgZnAsIHNw
IiAiXG4iIC8vIFNhdmUgdGhlIFByb2JlQ29udGV4dCouCiAKICAgICAvLyBJbml0aWFsaXplIFBy
b2JlQ29udGV4dDo6aW5pdGlhbGl6ZVN0YWNrRnVuY3Rpb24gdG8gemVyby4KQEAgLTI4OSw5ICsy
OTcsMTQgQEAgYXNtICgKICAgICAvLyBUbyBlbmFibGUgcHJvYmVzIHRvIG1vZGlmeSByZWdpc3Rl
ciBzdGF0ZSwgd2UgY29weSBhbGwgcmVnaXN0ZXJzCiAgICAgLy8gb3V0IG9mIHRoZSBQcm9iZUNv
bnRleHQgYmVmb3JlIHJldHVybmluZy4KIAorI2lmIENQVShBUk1fTkVPTikKICAgICAiYWRkICAg
ICAgIGlwLCBzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9EMzFfT0ZGU0VUICsg
RlBSRUdfU0laRSkgIlxuIgogICAgICJ2bGRtZGIuNjQgaXAhLCB7IGQxNi1kMzEgfSIgIlxuIgog
ICAgICJ2bGRtZGIuNjQgaXAhLCB7IGQwLWQxNSB9IiAiXG4iCisjZWxzZQorICAgICJhZGQgICAg
ICAgaXAsIHNwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJPQkVfQ1BVX0QxNV9PRkZTRVQgKyBG
UFJFR19TSVpFKSAiXG4iCisgICAgInZsZG1kYi42NCBpcCEsIHsgZDAtZDE1IH0iICJcbiIKKyNl
bmRpZgogCiAgICAgImFkZCAgICAgICBpcCwgc3AsICMiIFNUUklOR0laRV9WQUxVRV9PRihQUk9C
RV9DUFVfUjExX09GRlNFVCArIEdQUkVHX1NJWkUpICJcbiIKICAgICAibGRtZGIgICAgIGlwLCB7
IHIwLXIxMSB9IiAiXG4iCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>318701</attachid>
            <date>2017-08-21 17:13:11 -0700</date>
            <delta_ts>2017-08-21 18:07:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-175514-20170822021309.patch</filename>
            <type>text/plain</type>
            <size>1858</size>
            <attacher name="Carlos Alberto Lopez Perez">clopez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY1ZjMwMmRjOGZjZDYzMjAwNDhjYTY1
NjgzNDFiOGFlNDg3YzFkNTEuLjI1MGZmYzc4YjdlNTU2ZDc3YmFiZDY2NWUyOWNkNzJiMzY5M2Q2
NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDgtMjEgIENhcmxvcyBBbGJlcnRvIExvcGV6
IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQVJNdjcgYnVpbGQg
ZmFpbHMgdG8gYnVpbGQgTWFjcm9Bc3NlbWJsZXJBUk12Ny5jcHAuCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU1MTQKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBFbmFibGUg
REZHIGFuZCBNQVNNX1BST0JFIGJhY2sgZm9yIEdUSyBBUk1fVEhVTUIyLgorCiAyMDE3LTA4LTIw
ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3RyaW5nVmlldyBjb3Vs
ZCB1c2UgYSBmdW5jdGlvbiB0byBzdHJpcCBsZWFkaW5nL3RyYWlsaW5nIGNoYXJhY3RlcnMgd2l0
aG91dCBhbGxvY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIv
U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCAzMGJkYWNmYThkZDkxZjNkYjBjYjRjMmE3
YjU1NDMxODU0ZTdlNGJmLi5hNTU1MGYxZGEwNWMxYjM0N2ViYmQ1YTdlMzU3YzY4ZWZlMDM4MzY2
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYv
d3RmL1BsYXRmb3JtLmgKQEAgLTc4Niw4ICs3ODYsOCBAQAogI2lmIChDUFUoWDg2KSB8fCBDUFUo
WDg2XzY0KSkgJiYgKE9TKERBUldJTikgfHwgT1MoTElOVVgpIHx8IE9TKEZSRUVCU0QpIHx8IE9T
KEhVUkQpKQogI2RlZmluZSBFTkFCTEVfREZHX0pJVCAxCiAjZW5kaWYKLS8qIEVuYWJsZSB0aGUg
REZHIEpJVCBvbiBBUk12Ny4gIE9ubHkgdGVzdGVkIG9uIGlPUyBhbmQgUXQvR1RLKyBMaW51eC4g
Ki8KLSNpZiAoQ1BVKEFSTV9USFVNQjIpIHx8IENQVShBUk02NCkpICYmIChQTEFURk9STShJT1Mp
IHx8IFBMQVRGT1JNKFdQRSkpCisvKiBFbmFibGUgdGhlIERGRyBKSVQgb24gQVJNdjcuICBPbmx5
IHRlc3RlZCBvbiBpT1MgYW5kIEdUSysvV1BFIExpbnV4LiAqLworI2lmIChDUFUoQVJNX1RIVU1C
MikgfHwgQ1BVKEFSTTY0KSkgJiYgKFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0oR1RLKSB8fCBQ
TEFURk9STShXUEUpKQogI2RlZmluZSBFTkFCTEVfREZHX0pJVCAxCiAjZW5kaWYKIC8qIEVuYWJs
ZSB0aGUgREZHIEpJVCBvbiBBUk0uICovCkBAIC04MzEsMTEgKzgzMSw2IEBACiAjdW5kZWYgRU5B
QkxFX01BU01fUFJPQkUKICNkZWZpbmUgRU5BQkxFX01BU01fUFJPQkUgMAogI2VuZGlmCi0jaWYg
UExBVEZPUk0oR1RLKSAmJiBDUFUoQVJNX1RIVU1CMikKLS8qIEZJWE1FOiBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NTE0ICovCi0jdW5kZWYgRU5BQkxFX01BU01f
UFJPQkUKLSNkZWZpbmUgRU5BQkxFX01BU01fUFJPQkUgMAotI2VuZGlmCiAKIC8qIElmIHRoZSBi
YXNlbGluZSBqaXQgaXMgbm90IGF2YWlsYWJsZSwgdGhlbiBkaXNhYmxlIHVwcGVyIHRpZXJzIGFz
IHdlbGwuCiAgICBUaGUgTWFjcm9Bc3NlbWJsZXI6OnByb2JlKCkgaXMgYWxzbyByZXF1aXJlZCBm
b3Igc3VwcG9ydGluZyB0aGUgdXBwZXIgdGllcnMuICovCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>