175509 2017-08-12 02:42:29 -0700 [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion 2017-08-20 01:45:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner rniwa thorton oldest_to_newest 1338132 0 wenson_hsieh 2017-08-12 02:42:29 -0700 This test is hitting a debug assertion after a recent SDK update. Instead of using [UIFont boldSystemFontOfSize:] to test that attributed strings preserve styles when dropping, use a foreground color and check that the resulting inserted text is colored in the DOM. 1338133 1 wenson_hsieh 2017-08-12 02:44:41 -0700 <rdar://problem/33728169> 1338134 2 317993 wenson_hsieh 2017-08-12 03:02:23 -0700 Created attachment 317993 Patch 1338183 3 megan_gardner 2017-08-12 15:08:29 -0700 This looks good, minus it not working on iOS-sim. I thought that the call you switched to might be too new for the perf bots, but it seems to be fine. 1338185 4 wenson_hsieh 2017-08-12 15:13:00 -0700 (In reply to Megan Gardner from comment #3) > This looks good, minus it not working on iOS-sim. I thought that the call > you switched to might be too new for the perf bots, but it seems to be fine. Thanks for taking a look! Unfortunately, these API tests are not run on the EWS bots at all. The test failures making 'ios-sim' orange in the dashboard are unrelated: - imported/w3c/web-platform-tests/fetch/ - imported/w3c/web-platform-tests/cors/ - imported/w3c/web-platform-tests/XMLHttpRequest/ - imported/w3c/web-platform-tests/beacon/ - http/tests/blink/sendbeacon/ - http/wpt/beacon/ 1338187 5 megan_gardner 2017-08-12 15:19:16 -0700 Oh, I forgot that they don't run. LGTM then! (In reply to Wenson Hsieh from comment #4) > (In reply to Megan Gardner from comment #3) > > This looks good, minus it not working on iOS-sim. I thought that the call > > you switched to might be too new for the perf bots, but it seems to be fine. > > Thanks for taking a look! > > Unfortunately, these API tests are not run on the EWS bots at all. The test > failures making 'ios-sim' orange in the dashboard are unrelated: > > - imported/w3c/web-platform-tests/fetch/ > - imported/w3c/web-platform-tests/cors/ > - imported/w3c/web-platform-tests/XMLHttpRequest/ > - imported/w3c/web-platform-tests/beacon/ > - http/tests/blink/sendbeacon/ > - http/wpt/beacon/ 1340213 6 318536 wenson_hsieh 2017-08-18 13:33:23 -0700 Created attachment 318536 Patch 1340214 7 wenson_hsieh 2017-08-18 13:34:53 -0700 Tim and I chatted in person -- we're going to keep the debug-assertion-ing test, but mark it as disabled, and add a new test that fulfills the same purpose (w.r.t. testing attributed strings and DnD) but uses color instead to ensure that we don't leave this codepath untested. 1340387 8 318536 rniwa 2017-08-18 23:18:42 -0700 Comment on attachment 318536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318536&action=review > Tools/ChangeLog:11 > + Clone ExternalSourceAttributedStringToContentEditable to ExternalSourceColoredAttributedStringToContentEditable, > + which tests an attributed string with colored text instead of a bold attributed string of system font. Due to a > + recent change in behavior in UIKit, this test is hitting a debug assertion. The purpose of this test is to verify Could you clarify that you're adding a test which changes color because bold case is crashing. 1340391 9 318536 wenson_hsieh 2017-08-19 00:39:21 -0700 Comment on attachment 318536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318536&action=review >> Tools/ChangeLog:11 >> + recent change in behavior in UIKit, this test is hitting a debug assertion. The purpose of this test is to verify > > Could you clarify that you're adding a test which changes color because bold case is crashing. Will do! 1340394 10 318584 wenson_hsieh 2017-08-19 01:04:35 -0700 Created attachment 318584 Patch for landing 1340395 11 318584 commit-queue 2017-08-19 01:46:20 -0700 Comment on attachment 318584 Patch for landing Clearing flags on attachment: 318584 Committed r220952: <http://trac.webkit.org/changeset/220952> 317993 2017-08-12 03:02:23 -0700 2017-08-18 13:33:21 -0700 Patch bug-175509-20170812030222.patch text/plain 2625 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNDU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGE1MzIwOWUzMGFkOWU5NjBiODZhMjA4OTYxODA3M2U2 MGUwZDQ3MS4uZDVmYWI1M2I2MTVlOTQ4YzkwYjQyZjcwYTgzYjQ3NGVjNzMzZDcyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTA4LTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1MgV0syXSBEYXRhSW50ZXJhY3Rpb25UZXN0cy5FeHRlcm5hbFNvdXJjZUF0 dHJpYnV0ZWRTdHJpbmdUb0NvbnRlbnRFZGl0YWJsZSBoaXRzIGEgZGVidWcgYXNzZXJ0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU1MDkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMzNzI4MTY5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFR3ZWFrIGEgZHJhZyBhbmQgZHJvcCB0ZXN0IHRvIGNo ZWNrIHRoYXQgZm9udCBjb2xvciBpcyBwcmVzZXJ2ZWQgb24gZHJvcC4gRHVlIHRvIGEgcmVjZW50 IGNoYW5nZSBpbiBiZWhhdmlvciBpbgorICAgICAgICArW1VJRm9udCBib2xkU3lzdGVtRm9udE9m U2l6ZTpdLCB0aGlzIGlzIGhpdHRpbmcgYSBkZWJ1ZyBhc3NlcnRpb24uIFRoZSBwdXJwb3NlIG9m IHRoaXMgdGVzdCBpcyB0byB2ZXJpZnkgdGhhdAorICAgICAgICB0aGUgYXR0cmlidXRlZCBzdHJp bmcgVVRJIGNhbiBiZSBhY2NlcHRlZCBpbiBjb250ZW50ZWRpdGFibGUgYXJlYXMsIHNvIGl0IHN1 ZmZpY2VzIHRvIGNoZWNrIHRoYXQgYW5vdGhlciBzdHlsZQorICAgICAgICBhdHRyaWJ1dGUsIHN1 Y2ggYXMgY29sb3IsIGNhcnJpZXMgb3ZlciBmcm9tIHRoZSBOU0F0dHJpYnV0ZWRTdHJpbmcgdG8g dGhlIERPTS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0RhdGFJbnRlcmFj dGlvblRlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTctMDgt MDggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIyMDM5My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvaW9zL0RhdGFJbnRlcmFjdGlvblRlc3RzLm1tIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9pb3MvRGF0YUludGVyYWN0aW9uVGVzdHMubW0KaW5kZXggNjA2MGI5OTliZTQy ZjllMDJiNDhmOTZiZmZkYzAyYTU5N2I1ZjM4Yy4uYTgyMTg4YWI0MTU5NzJjZjUyNWM1NGJkNjhj NDVjN2QyYjM5YzZiMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv RGF0YUludGVyYWN0aW9uVGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvRGF0YUludGVyYWN0aW9uVGVzdHMubW0KQEAgLTY5MSwxMiArNjkxLDEzIEBAIFRFU1QoRGF0 YUludGVyYWN0aW9uVGVzdHMsIEV4dGVybmFsU291cmNlQXR0cmlidXRlZFN0cmluZ1RvQ29udGVu dEVkaXRhYmxlKQogICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJn ZXRTZWxlY3Rpb24oKS5yZW1vdmVBbGxSYW5nZXMoKSJdOwogCiAgICAgYXV0byBkYXRhSW50ZXJh Y3Rpb25TaW11bGF0b3IgPSBhZG9wdE5TKFtbRGF0YUludGVyYWN0aW9uU2ltdWxhdG9yIGFsbG9j XSBpbml0V2l0aFdlYlZpZXc6d2ViVmlldy5nZXQoKV0pOwotICAgIE5TRGljdGlvbmFyeSAqdGV4 dEF0dHJpYnV0ZXMgPSBAeyBOU0ZvbnRBdHRyaWJ1dGVOYW1lOiBbVUlGb250IGJvbGRTeXN0ZW1G b250T2ZTaXplOjIwXSB9OworICAgIE5TRGljdGlvbmFyeSAqdGV4dEF0dHJpYnV0ZXMgPSBAeyBO U0ZvcmVncm91bmRDb2xvckF0dHJpYnV0ZU5hbWU6IFtVSUNvbG9yIHJlZENvbG9yXSB9OwogICAg IE5TQXR0cmlidXRlZFN0cmluZyAqcmljaFRleHQgPSBbW05TQXR0cmlidXRlZFN0cmluZyBhbGxv Y10gaW5pdFdpdGhTdHJpbmc6QCJUaGlzIGlzIGEgdGVzdCIgYXR0cmlidXRlczp0ZXh0QXR0cmli dXRlc107CiAgICAgYXV0byBpdGVtUHJvdmlkZXIgPSBhZG9wdE5TKFtbVUlJdGVtUHJvdmlkZXIg YWxsb2NdIGluaXRXaXRoT2JqZWN0OnJpY2hUZXh0XSk7CiAgICAgW2RhdGFJbnRlcmFjdGlvblNp bXVsYXRvciBzZXRFeHRlcm5hbEl0ZW1Qcm92aWRlcnM6QFsgaXRlbVByb3ZpZGVyLmdldCgpIF1d OwogICAgIFtkYXRhSW50ZXJhY3Rpb25TaW11bGF0b3IgcnVuRnJvbTpDR1BvaW50TWFrZSgzMDAs IDQwMCkgdG86Q0dQb2ludE1ha2UoMTAwLCAzMDApXTsKIAorICAgIEVYUEVDVF9XS19TVFJFUSgi cmdiKDI1NSwgMCwgMCkiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAi Z2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdwJykpLmNvbG9yIl0pOwog ICAgIEVYUEVDVF9XS19TVFJFUSgiVGhpcyBpcyBhIHRlc3QiLCBbd2ViVmlldyBzdHJpbmdCeUV2 YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0uVVRGOFN0cmluZyk7CiB9 CiAK 318536 2017-08-18 13:33:23 -0700 2017-08-18 23:18:42 -0700 Patch bug-175509-20170818133322.patch text/plain 3900 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwODU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWIyNWFhMzA4YjE5ODZlYjJjMzVkNDYxN2E4MzE4MTc1 NWI4ZDU4Yy4uN2I1ODVlZWI3ZWI4Nzc0NWNmODhiZDFhZGViYjcyNzYyZjIwMjQ3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE3LTA4LTE4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1MgV0syXSBBZGQgYSB2ZXJzaW9uIG9mIERhdGFJbnRlcmFjdGlvblRlc3Rz LkV4dGVybmFsU291cmNlQXR0cmlidXRlZFN0cmluZ1RvQ29udGVudEVkaXRhYmxlIHRoYXQgZG9l c24ndCBoaXQgYSBkZWJ1ZyBhc3NlcnRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTUwOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzM3Mjgx Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xv bmUgRXh0ZXJuYWxTb3VyY2VBdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRpdGFibGUgdG8gRXh0 ZXJuYWxTb3VyY2VDb2xvcmVkQXR0cmlidXRlZFN0cmluZ1RvQ29udGVudEVkaXRhYmxlLAorICAg ICAgICB3aGljaCB0ZXN0cyBhbiBhdHRyaWJ1dGVkIHN0cmluZyB3aXRoIGNvbG9yZWQgdGV4dCBp bnN0ZWFkIG9mIGEgYm9sZCBhdHRyaWJ1dGVkIHN0cmluZyBvZiBzeXN0ZW0gZm9udC4gRHVlIHRv IGEKKyAgICAgICAgcmVjZW50IGNoYW5nZSBpbiBiZWhhdmlvciBpbiBVSUtpdCwgdGhpcyB0ZXN0 IGlzIGhpdHRpbmcgYSBkZWJ1ZyBhc3NlcnRpb24uIFRoZSBwdXJwb3NlIG9mIHRoaXMgdGVzdCBp cyB0byB2ZXJpZnkKKyAgICAgICAgdGhhdCB0aGUgYXR0cmlidXRlZCBzdHJpbmcgVVRJIGNhbiBi ZSBhY2NlcHRlZCBpbiBjb250ZW50ZWRpdGFibGUgYXJlYXMsIHNvIGl0IHN1ZmZpY2VzIHRvIGNo ZWNrIHRoYXQgYW5vdGhlciBzdHlsZQorICAgICAgICBhdHRyaWJ1dGUsIHN1Y2ggYXMgY29sb3Is IGNhcnJpZXMgb3ZlciBmcm9tIHRoZSBOU0F0dHJpYnV0ZWRTdHJpbmcgdG8gdGhlIERPTS4KKwor ICAgICAgICBBbHNvIG1hcmtzIEV4dGVybmFsU291cmNlQm9sZFN5c3RlbUF0dHJpYnV0ZWRTdHJp bmdUb0NvbnRlbnRFZGl0YWJsZSBhcyBkaXNhYmxlZCBmb3IgdGhlIHRpbWUgYmVpbmcuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbToK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE3LTA4LTE3ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEFk ZCBOVExNIGF1dGhlbnRpY2F0aW9uIGVuYWJsZWQgQVBJCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbSBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvaW9zL0RhdGFJbnRlcmFjdGlvblRlc3RzLm1tCmluZGV4IDYwNjBiOTk5 YmU0MmY5ZTAyYjQ4Zjk2YmZmZGMwMmE1OTdiNWYzOGMuLjhhNGQ2ODU4YjlkODNkNzU2MzJhMDFi YWI2ZWU0ZTNjMzAzZTFkZWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv aW9zL0RhdGFJbnRlcmFjdGlvblRlc3RzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvaW9zL0RhdGFJbnRlcmFjdGlvblRlc3RzLm1tCkBAIC02ODQsNyArNjg0LDcgQEAgVEVTVChE YXRhSW50ZXJhY3Rpb25UZXN0cywgRXh0ZXJuYWxTb3VyY2VIVE1MVG9Db250ZW50RWRpdGFibGUp CiAgICAgRVhQRUNUX1RSVUUoW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpA IiEhZWRpdG9yLnF1ZXJ5U2VsZWN0b3IoJ2gxJykiXS5ib29sVmFsdWUpOwogfQogCi1URVNUKERh dGFJbnRlcmFjdGlvblRlc3RzLCBFeHRlcm5hbFNvdXJjZUF0dHJpYnV0ZWRTdHJpbmdUb0NvbnRl bnRFZGl0YWJsZSkKK1RFU1QoRGF0YUludGVyYWN0aW9uVGVzdHMsIERJU0FCTEVEX0V4dGVybmFs U291cmNlQm9sZFN5c3RlbUF0dHJpYnV0ZWRTdHJpbmdUb0NvbnRlbnRFZGl0YWJsZSkKIHsKICAg ICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhG cmFtZTpDR1JlY3RNYWtlKDAsIDAsIDMyMCwgNTAwKV0pOwogICAgIFt3ZWJWaWV3IHN5bmNocm9u b3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpAImF1dG9mb2N1cy1jb250ZW50ZWRpdGFibGUiXTsKQEAg LTcwMCw2ICs3MDAsMjMgQEAgVEVTVChEYXRhSW50ZXJhY3Rpb25UZXN0cywgRXh0ZXJuYWxTb3Vy Y2VBdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRpdGFibGUpCiAgICAgRVhQRUNUX1dLX1NUUkVR KCJUaGlzIGlzIGEgdGVzdCIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6 QCJlZGl0b3IudGV4dENvbnRlbnQiXS5VVEY4U3RyaW5nKTsKIH0KIAorVEVTVChEYXRhSW50ZXJh Y3Rpb25UZXN0cywgRXh0ZXJuYWxTb3VyY2VDb2xvcmVkQXR0cmlidXRlZFN0cmluZ1RvQ29udGVu dEVkaXRhYmxlKQoreworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3 IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7CisgICAg W3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOkAiYXV0b2ZvY3VzLWNvbnRl bnRlZGl0YWJsZSJdOworICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6 QCJnZXRTZWxlY3Rpb24oKS5yZW1vdmVBbGxSYW5nZXMoKSJdOworCisgICAgYXV0byBkYXRhSW50 ZXJhY3Rpb25TaW11bGF0b3IgPSBhZG9wdE5TKFtbRGF0YUludGVyYWN0aW9uU2ltdWxhdG9yIGFs bG9jXSBpbml0V2l0aFdlYlZpZXc6d2ViVmlldy5nZXQoKV0pOworICAgIE5TRGljdGlvbmFyeSAq dGV4dEF0dHJpYnV0ZXMgPSBAeyBOU0ZvcmVncm91bmRDb2xvckF0dHJpYnV0ZU5hbWU6IFtVSUNv bG9yIHJlZENvbG9yXSB9OworICAgIE5TQXR0cmlidXRlZFN0cmluZyAqcmljaFRleHQgPSBbW05T QXR0cmlidXRlZFN0cmluZyBhbGxvY10gaW5pdFdpdGhTdHJpbmc6QCJUaGlzIGlzIGEgdGVzdCIg YXR0cmlidXRlczp0ZXh0QXR0cmlidXRlc107CisgICAgYXV0byBpdGVtUHJvdmlkZXIgPSBhZG9w dE5TKFtbVUlJdGVtUHJvdmlkZXIgYWxsb2NdIGluaXRXaXRoT2JqZWN0OnJpY2hUZXh0XSk7Cisg ICAgW2RhdGFJbnRlcmFjdGlvblNpbXVsYXRvciBzZXRFeHRlcm5hbEl0ZW1Qcm92aWRlcnM6QFsg aXRlbVByb3ZpZGVyLmdldCgpIF1dOworICAgIFtkYXRhSW50ZXJhY3Rpb25TaW11bGF0b3IgcnVu RnJvbTpDR1BvaW50TWFrZSgzMDAsIDQwMCkgdG86Q0dQb2ludE1ha2UoMTAwLCAzMDApXTsKKwor ICAgIEVYUEVDVF9XS19TVFJFUSgicmdiKDI1NSwgMCwgMCkiLCBbd2ViVmlldyBzdHJpbmdCeUV2 YWx1YXRpbmdKYXZhU2NyaXB0OkAiZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCdwJykpLmNvbG9yIl0pOworICAgIEVYUEVDVF9XS19TVFJFUSgiVGhpcyBpcyBhIHRlc3Qi LCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250 ZW50Il0uVVRGOFN0cmluZyk7Cit9CisKIFRFU1QoRGF0YUludGVyYWN0aW9uVGVzdHMsIEV4dGVy bmFsU291cmNlTXVsdGlwbGVVUkxzVG9Db250ZW50RWRpdGFibGUpCiB7CiAgICAgYXV0byB3ZWJW aWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0 TWFrZSgwLCAwLCAzMjAsIDUwMCldKTsK 318584 2017-08-19 01:04:35 -0700 2017-08-19 01:46:20 -0700 Patch for landing bug-175509-20170819010435.patch text/plain 4084 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwODU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWIyNWFhMzA4YjE5ODZlYjJjMzVkNDYxN2E4MzE4MTc1 NWI4ZDU4Yy4uNTYxMzkzNTljYzYwM2FkYTkwMGI5NWIzZGJjODQ1ODQzZjU0ZmZlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE3LTA4LTE5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1MgV0syXSBBZGQgYSB2ZXJzaW9uIG9mIERhdGFJbnRlcmFjdGlvblRlc3Rz LkV4dGVybmFsU291cmNlQXR0cmlidXRlZFN0cmluZ1RvQ29udGVudEVkaXRhYmxlIHRoYXQgZG9l c24ndCBoaXQgYSBkZWJ1ZyBhc3NlcnRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTUwOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzM3Mjgx Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIFJlbW92 ZXMgRXh0ZXJuYWxTb3VyY2VBdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRpdGFibGUgYW5kIGFk ZHMKKyAgICAgICAgRXh0ZXJuYWxTb3VyY2VDb2xvcmVkQXR0cmlidXRlZFN0cmluZ1RvQ29udGVu dEVkaXRhYmxlLCB3aGljaCB0ZXN0cyBkcm9wcGluZyBhbiBhdHRyaWJ1dGVkIHN0cmluZyB3aXRo IGNvbG9yZWQKKyAgICAgICAgdGV4dCBpbnN0ZWFkIG9mIGEgYm9sZCBhdHRyaWJ1dGVkIHN0cmlu ZyBvZiBzeXN0ZW0gZm9udC4gRHVlIHRvIGEgcmVjZW50IGNoYW5nZSBpbiBiZWhhdmlvciBpbiBV SUtpdCwgdGhlCisgICAgICAgIG9yaWdpbmFsIHRlc3QgKHdoaWNoIHRoaXMgcGF0Y2ggcmVuYW1l cyB0byBFeHRlcm5hbFNvdXJjZUJvbGRTeXN0ZW1BdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRp dGFibGUpIGhpdHMgYQorICAgICAgICBkZWJ1ZyBhc3NlcnRpb24gd2hlbiBkcm9wcGluZyB0ZXh0 IG9mIHN5c3RlbSBib2xkIGZvbnQuIFNpbmNlIHRoZSBvcmlnaW5hbCBpbnRlbnQgb2YgdGhpcyB0 ZXN0IHdhcyB0byB2ZXJpZnkKKyAgICAgICAgdGhhdCB0aGUgYXR0cmlidXRlZCBzdHJpbmcgVVRJ IGNhbiBiZSBhY2NlcHRlZCBpbiByaWNobHkgY29udGVudGVkaXRhYmxlIGFyZWFzLCBpdCBzdWZm aWNlcyB0byBjaGVjayB0aGF0IHNvbWUKKyAgICAgICAgb3RoZXIgc3R5bGUgYXR0cmlidXRlLCBz dWNoIGFzIGNvbG9yLCBjYXJyaWVzIG92ZXIgZnJvbSB0aGUgTlNBdHRyaWJ1dGVkU3RyaW5nIHRv IHRoZSBET00uCisKKyAgICAgICAgQWxzbyBtYXJrcyBFeHRlcm5hbFNvdXJjZUJvbGRTeXN0ZW1B dHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRpdGFibGUgYXMgZGlzYWJsZWQgZm9yIHRoZSB0aW1l IGJlaW5nLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvRGF0YUludGVyYWN0 aW9uVGVzdHMubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxNy0wOC0x NyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS11bV1BFXSBBZGQgTlRMTSBhdXRoZW50aWNhdGlvbiBlbmFibGVkIEFQSQpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvRGF0YUludGVyYWN0aW9uVGVzdHMubW0g Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQpp bmRleCA2MDYwYjk5OWJlNDJmOWUwMmI0OGY5NmJmZmRjMDJhNTk3YjVmMzhjLi44YTRkNjg1OGI5 ZDgzZDc1NjMyYTAxYmFiNmVlNGUzYzMwM2UxZGVkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQpAQCAtNjg0LDcgKzY4 NCw3IEBAIFRFU1QoRGF0YUludGVyYWN0aW9uVGVzdHMsIEV4dGVybmFsU291cmNlSFRNTFRvQ29u dGVudEVkaXRhYmxlKQogICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGlu Z0phdmFTY3JpcHQ6QCIhIWVkaXRvci5xdWVyeVNlbGVjdG9yKCdoMScpIl0uYm9vbFZhbHVlKTsK IH0KIAotVEVTVChEYXRhSW50ZXJhY3Rpb25UZXN0cywgRXh0ZXJuYWxTb3VyY2VBdHRyaWJ1dGVk U3RyaW5nVG9Db250ZW50RWRpdGFibGUpCitURVNUKERhdGFJbnRlcmFjdGlvblRlc3RzLCBESVNB QkxFRF9FeHRlcm5hbFNvdXJjZUJvbGRTeXN0ZW1BdHRyaWJ1dGVkU3RyaW5nVG9Db250ZW50RWRp dGFibGUpCiB7CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxs b2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAsIDUwMCldKTsKICAgICBbd2Vi VmlldyBzeW5jaHJvbm91c2x5TG9hZFRlc3RQYWdlTmFtZWQ6QCJhdXRvZm9jdXMtY29udGVudGVk aXRhYmxlIl07CkBAIC03MDAsNiArNzAwLDIzIEBAIFRFU1QoRGF0YUludGVyYWN0aW9uVGVzdHMs IEV4dGVybmFsU291cmNlQXR0cmlidXRlZFN0cmluZ1RvQ29udGVudEVkaXRhYmxlKQogICAgIEVY UEVDVF9XS19TVFJFUSgiVGhpcyBpcyBhIHRlc3QiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRp bmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0uVVRGOFN0cmluZyk7CiB9CiAKK1RF U1QoRGF0YUludGVyYWN0aW9uVGVzdHMsIEV4dGVybmFsU291cmNlQ29sb3JlZEF0dHJpYnV0ZWRT dHJpbmdUb0NvbnRlbnRFZGl0YWJsZSkKK3sKKyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtb VGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIDMyMCwg NTAwKV0pOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpAImF1 dG9mb2N1cy1jb250ZW50ZWRpdGFibGUiXTsKKyAgICBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRp bmdKYXZhU2NyaXB0OkAiZ2V0U2VsZWN0aW9uKCkucmVtb3ZlQWxsUmFuZ2VzKCkiXTsKKworICAg IGF1dG8gZGF0YUludGVyYWN0aW9uU2ltdWxhdG9yID0gYWRvcHROUyhbW0RhdGFJbnRlcmFjdGlv blNpbXVsYXRvciBhbGxvY10gaW5pdFdpdGhXZWJWaWV3OndlYlZpZXcuZ2V0KCldKTsKKyAgICBO U0RpY3Rpb25hcnkgKnRleHRBdHRyaWJ1dGVzID0gQHsgTlNGb3JlZ3JvdW5kQ29sb3JBdHRyaWJ1 dGVOYW1lOiBbVUlDb2xvciByZWRDb2xvcl0gfTsKKyAgICBOU0F0dHJpYnV0ZWRTdHJpbmcgKnJp Y2hUZXh0ID0gW1tOU0F0dHJpYnV0ZWRTdHJpbmcgYWxsb2NdIGluaXRXaXRoU3RyaW5nOkAiVGhp cyBpcyBhIHRlc3QiIGF0dHJpYnV0ZXM6dGV4dEF0dHJpYnV0ZXNdOworICAgIGF1dG8gaXRlbVBy b3ZpZGVyID0gYWRvcHROUyhbW1VJSXRlbVByb3ZpZGVyIGFsbG9jXSBpbml0V2l0aE9iamVjdDpy aWNoVGV4dF0pOworICAgIFtkYXRhSW50ZXJhY3Rpb25TaW11bGF0b3Igc2V0RXh0ZXJuYWxJdGVt UHJvdmlkZXJzOkBbIGl0ZW1Qcm92aWRlci5nZXQoKSBdXTsKKyAgICBbZGF0YUludGVyYWN0aW9u U2ltdWxhdG9yIHJ1bkZyb206Q0dQb2ludE1ha2UoMzAwLCA0MDApIHRvOkNHUG9pbnRNYWtlKDEw MCwgMzAwKV07CisKKyAgICBFWFBFQ1RfV0tfU1RSRVEoInJnYigyNTUsIDAsIDApIiwgW3dlYlZp ZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImdldENvbXB1dGVkU3R5bGUoZG9jdW1l bnQucXVlcnlTZWxlY3RvcigncCcpKS5jb2xvciJdKTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoIlRo aXMgaXMgYSB0ZXN0IiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImVk aXRvci50ZXh0Q29udGVudCJdLlVURjhTdHJpbmcpOworfQorCiBURVNUKERhdGFJbnRlcmFjdGlv blRlc3RzLCBFeHRlcm5hbFNvdXJjZU11bHRpcGxlVVJMc1RvQ29udGVudEVkaXRhYmxlKQogewog ICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0 aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7Cg==