175480 2017-08-11 08:09:13 -0700 [GTK] Update some test expectations. 2017-08-14 01:28:19 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 Ms2ger Ms2ger bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1337886 0 Ms2ger 2017-08-11 08:09:13 -0700 . 1337887 1 317930 Ms2ger 2017-08-11 08:11:54 -0700 Created attachment 317930 Patch 1337890 2 317930 mcatanzaro 2017-08-11 08:23:30 -0700 Comment on attachment 317930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317930&action=review > LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:7 > +FAIL ':in-range' matches all elements that are candidates for constraint validation, have range limitations, and that are neither suffering from an underflow nor suffering from an overflow assert_array_equals: lengths differ, expected 10 got 5 > +FAIL ':out-of-range' matches all elements that are candidates for constraint validation, have range limitations, and that are either suffering from an underflow or suffering from an overflow assert_array_equals: lengths differ, expected 12 got 2 > +FAIL ':in-range' update number1's value < min assert_array_equals: lengths differ, expected 9 got 4 > +FAIL ':out-of-range' update number1's value < min assert_array_equals: lengths differ, expected 13 got 3 > +FAIL ':in-range' update number3's min < value assert_array_equals: lengths differ, expected 10 got 5 > +FAIL ':out-of-range' update number3's min < value assert_array_equals: lengths differ, expected 12 got 2 Why is this expected behavior? 1337891 3 Ms2ger 2017-08-11 08:29:54 -0700 That's actually kind of odd. The only difference between this file and the platform-neutral expectation file is the whitespace at the end. I have no idea where it comes from. 1337895 4 mcatanzaro 2017-08-11 08:42:54 -0700 OK, then it's fine. Youenn accepts lots of FAILS is our web platform tests expectations since it's still useful to catch unexpected behavior changes. I'd just prefer to not have them in GTK-specific expectations as that's not how we track bugs on our port. 1338295 5 317930 commit-queue 2017-08-14 01:28:18 -0700 Comment on attachment 317930 Patch Clearing flags on attachment: 317930 Committed r220655: <http://trac.webkit.org/changeset/220655> 1338296 6 commit-queue 2017-08-14 01:28:19 -0700 All reviewed patches have been landed. Closing bug. 317930 2017-08-11 08:11:54 -0700 2017-08-14 01:28:18 -0700 Patch bug-175480-20170811171153.patch text/plain 5286 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTgzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWUxNDBhMGMyNDBkZTQ3N2NjNWE5 MDE1MzRiMDY0YmEyMTJiN2NmZi4uNmM3MDI4ZTI0ZjUwMDk2ZGU5Zjg3OWQ3NzAzYTY1MWQ1OWIy ZTAxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTExICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBVcGRhdGUgc29tZSB0ZXN0IGV4cGVjdGF0aW9u cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTQ4 MAorCisgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9zZWxlY3RvcnMvcHNldWRv LWNsYXNzZXMvaW5yYW5nZS1vdXRvZnJhbmdlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL3Np bXBsZWNhbGwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxNy0wOC0xMCAgTmFuIFdhbmcgIDxu X3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCB0ZXN0IGFjY2Vzc2liaWxpdHkvcHJl c3MtdGFyZ2V0LXVzZXMtdGV4dC1kZXNjZW5kYW50LW5vZGUuaHRtbCBpcyBmbGFreS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMmIzMDg2ZGMyNDUzY2Jh NmUzMWRiOGRkNjE2MmJkYTNiOTU4NmMxOC4uOWJjNTQyM2VlMTRmMWVhNDNiYjRkMTM1YzdhMTcx ZGRiODZiN2I1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTcyNyw3ICs3MjcsNiBAQCB3ZWJraXQub3JnL2IvMTMxNTQ2IG1lZGlhL3RyYWNrL3RyYWNr LWluLWJhbmQtbW9kZS5odG1sIFsgU2tpcCBdCiAKICMgRGF0YUN1ZS52YWx1ZSBub3QgZW5hYmxl ZAogQnVnKEdUSykgaHR0cC90ZXN0cy9tZWRpYS90cmFjay1pbi1iYW5kLWhscy1tZXRhZGF0YS5o dG1sIFsgU2tpcCBdCi1CdWcoR1RLKSBtZWRpYS90cmFjay90cmFjay1kYXRhY3VlLXZhbHVlLmh0 bWwgWyBTa2lwIF0KIAogIyBTbmFwc2hvdHRlZCBwbHVnaW5zIG5vdCBlbmFibGVkCiB3ZWJraXQu b3JnL2IvOTg2OTYgcGx1Z2lucy9zbmFwc2hvdHRpbmcgWyBTa2lwIF0KQEAgLTE4OTQsNiArMTg5 Myw5IEBAIHdlYmtpdC5vcmcvYi8xNzQzNTMgbWVkaWEvdmlkZW8tcmVzdHJpY3RlZC1pbnZpc2li bGUtYXV0b3BsYXktbm90LWFsbG93ZWQuaHRtbCBbCiAKIHdlYmtpdC5vcmcvYi8xNzQzNTQgaW1w b3J0ZWQvdzNjL0luZGV4ZWREQi1wcml2YXRlLWJyb3dzaW5nL2lkYmZhY3Rvcnlfb3Blbi5odG1s IFsgQ3Jhc2ggUGFzcyBdCiAKK3dlYmtpdC5vcmcvYi8xNzU0NzggY29tcG9zaXRpbmcvaW1hZ2Vz L3Bvc2l0aW9uZWQtaW1hZ2UtY29udGVudC1yZWN0Lmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1 cmUgXQord2Via2l0Lm9yZy9iLzE3NTQ3OCBjb21wb3NpdGluZy9pbWFnZXMvdHJ1bmNhdGVkLWRp cmVjdC1wbmctaW1hZ2UuaHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFpbHVyZSBdCisKICMvLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEVuZCBvZiBGbGFreSB0ZXN0cwogIy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KQEAgLTM0MTAsNiArMzQxMiwxMyBAQCB3ZWJraXQub3Jn L2IvMTc1NDIxIHByaW50aW5nL3dpZHRoLW92ZXJmbG93Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtp dC5vcmcvYi8xNzU0MjIgaHR0cC90ZXN0cy9ibGluay9zZW5kYmVhY29uL2JlYWNvbi1zYW1lLW9y aWdpbi5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTc1NDIyIGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvYmVhY29uL2hlYWRlcnMvaGVhZGVyLWNvbnRlbnQtdHlwZS5odG1s IFsgRmFpbHVyZSBdCiAKK3dlYmtpdC5vcmcvYi8xNzU0NzggY29tcG9zaXRpbmcvY29udGVudHMt b3BhcXVlL29wYXF1ZS13aXRoLWNsaXAtcGF0aC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCit3 ZWJraXQub3JnL2IvMTc1NDc4IGNvbXBvc2l0aW5nL21hc2tzL2NvbXBvc2l0aW5nLWNsaXAtcGF0 aC1hbmQtbWFzay5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTc1NDc4 IGNvbXBvc2l0aW5nL21hc2tzL2NvbXBvc2l0aW5nLWNsaXAtcGF0aC5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTc1NDc4IGNvbXBvc2l0aW5nL21hc2tzL2NvbXBvc2l0 aW5nLWNsaXAtcGF0aC1vcmlnaW4uaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQord2Via2l0Lm9y Zy9iLzE3NTQ3OCBjb21wb3NpdGluZy9tYXNrcy9yZWZlcmVuY2UtY2xpcC1wYXRoLW9uLWNvbXBv c2l0ZWQuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzE3NTQ3OCBjc3Mz L2ZpbHRlcnMvYW5pbWF0aW9uLWZyb20taW5pdGlhbC12YWx1ZXMtd2l0aC1jb2xvci1tYXRyaXgu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQorCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLwogIyBFbmQgb2Ygbm9uLWNyYXNoaW5nLCBub24tZmxha3kgdGVzdHMgZmFpbGluZwogIy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNz L3NlbGVjdG9ycy9wc2V1ZG8tY2xhc3Nlcy9pbnJhbmdlLW91dG9mcmFuZ2UtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvaHRtbC9zZW1hbnRpY3Mvc2VsZWN0b3JzL3BzZXVkby1jbGFzc2VzL2lucmFuZ2Utb3V0b2Zy YW5nZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDEzYmNkYzEyNDFjMDQ2OWE0YzI1MzYwNTE0 ZWRkMzM1MDhiOWNkMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3NlbGVjdG9y cy9wc2V1ZG8tY2xhc3Nlcy9pbnJhbmdlLW91dG9mcmFuZ2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsOCBAQAorCitGQUlMICc6aW4tcmFuZ2UnIG1hdGNoZXMgYWxsIGVsZW1lbnRzIHRoYXQgYXJl IGNhbmRpZGF0ZXMgZm9yIGNvbnN0cmFpbnQgdmFsaWRhdGlvbiwgaGF2ZSByYW5nZSBsaW1pdGF0 aW9ucywgYW5kIHRoYXQgYXJlIG5laXRoZXIgc3VmZmVyaW5nIGZyb20gYW4gdW5kZXJmbG93IG5v ciBzdWZmZXJpbmcgZnJvbSBhbiBvdmVyZmxvdyBhc3NlcnRfYXJyYXlfZXF1YWxzOiBsZW5ndGhz IGRpZmZlciwgZXhwZWN0ZWQgMTAgZ290IDUKK0ZBSUwgJzpvdXQtb2YtcmFuZ2UnIG1hdGNoZXMg YWxsIGVsZW1lbnRzIHRoYXQgYXJlIGNhbmRpZGF0ZXMgZm9yIGNvbnN0cmFpbnQgdmFsaWRhdGlv biwgaGF2ZSByYW5nZSBsaW1pdGF0aW9ucywgYW5kIHRoYXQgYXJlIGVpdGhlciBzdWZmZXJpbmcg ZnJvbSBhbiB1bmRlcmZsb3cgb3Igc3VmZmVyaW5nIGZyb20gYW4gb3ZlcmZsb3cgYXNzZXJ0X2Fy cmF5X2VxdWFsczogbGVuZ3RocyBkaWZmZXIsIGV4cGVjdGVkIDEyIGdvdCAyCitGQUlMICc6aW4t cmFuZ2UnIHVwZGF0ZSBudW1iZXIxJ3MgdmFsdWUgPCBtaW4gYXNzZXJ0X2FycmF5X2VxdWFsczog bGVuZ3RocyBkaWZmZXIsIGV4cGVjdGVkIDkgZ290IDQKK0ZBSUwgJzpvdXQtb2YtcmFuZ2UnIHVw ZGF0ZSBudW1iZXIxJ3MgdmFsdWUgPCBtaW4gYXNzZXJ0X2FycmF5X2VxdWFsczogbGVuZ3RocyBk aWZmZXIsIGV4cGVjdGVkIDEzIGdvdCAzCitGQUlMICc6aW4tcmFuZ2UnIHVwZGF0ZSBudW1iZXIz J3MgbWluIDwgdmFsdWUgYXNzZXJ0X2FycmF5X2VxdWFsczogbGVuZ3RocyBkaWZmZXIsIGV4cGVj dGVkIDEwIGdvdCA1CitGQUlMICc6b3V0LW9mLXJhbmdlJyB1cGRhdGUgbnVtYmVyMydzIG1pbiA8 IHZhbHVlIGFzc2VydF9hcnJheV9lcXVhbHM6IGxlbmd0aHMgZGlmZmVyLCBleHBlY3RlZCAxMiBn b3QgMgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL3dlYnJ0Yy9zaW1wbGVjYWxsLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnJ0Yy9z aW1wbGVjYWxsLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mYTgzNWI1MGM3MjBhM2YzOTBhYjlh YTViMTU3NGFmNzU5MmJmYmQwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL3NpbXBsZWNhbGwt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorVGhlIGZlYXR1cmUocykgdGVzdGVkIGhlcmUg YXJlIGtub3duIHRvIGhhdmUgYmVlbiBtYWRlIGF2YWlsYWJsZSB2aWEgdmVuZG9yIHByZWZpeGVz OyB5b3UgY2FuIHJ1biB0aGlzIHRlc3Qgd2l0aCB2ZW5kb3IgcHJlZml4ZXMgZW5hYmxlZC4KKwor UEFTUyBDYW4gc2V0IHVwIGEgYmFzaWMgV2ViUlRDIGNhbGwuIAorICAK