17548 2008-02-25 23:29:22 -0800 JavaScriptCore print(a, b) differs from Spidermonkey Behavior 2008-06-07 14:58:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bfulgham sam oldest_to_newest 71974 0 bfulgham 2008-02-25 23:29:22 -0800 Spidermonkey allows comma-separated arguments to print. These values are printed with a space inbetween. This: print ("foo", "bar") Produces: foo bar In JavaScriptCore it produces: foo 82578 1 21565 zwarich 2008-06-07 14:04:35 -0700 Created attachment 21565 Proposed patch Here is a patch. It uses indices instead of iterators because our iterators don't have a distance function. 82579 2 21566 zwarich 2008-06-07 14:51:27 -0700 Created attachment 21566 Revised proposed patch Includes some changes suggested by Eric. 82580 3 21566 eric 2008-06-07 14:52:40 -0700 Comment on attachment 21566 Revised proposed patch Looks great! (I think I even wrote work-around code in some test cases instead of fixing this once.) 82583 4 zwarich 2008-06-07 14:58:09 -0700 Landed in r34429. 21565 2008-06-07 14:04:35 -0700 2008-06-07 14:51:27 -0700 Proposed patch printmulti.diff text/plain 1389 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0NDI4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDYt MDcgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE3NTQ4OiBKYXZhU2Ny aXB0Q29yZSBwcmludChhLCBiKSBkaWZmZXJzIGZyb20gU3BpZGVybW9ua2V5IEJlaGF2aW9yCisg ICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NDg+CisK KyAgICAgICAgKiBranMvdGVzdGtqcy5jcHA6CisgICAgICAgIChmdW5jdGlvblByaW50KToKKwog MjAwOC0wNi0wNyAgQ2FtZXJvbiBad2FyaWNoICA8Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTYW0uCkluZGV4OiBranMvdGVzdGtqcy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0ga2pzL3Rlc3RranMuY3BwCShyZXZpc2lvbiAzNDQyOCkKKysrIGtqcy90ZXN0a2pzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTU5LDExICsxNTksMTcgQEAgR2xvYmFsT2JqZWN0OjpHbG9i YWxPYmplY3QoVmVjdG9yPFVTdHJpbgogCiBKU1ZhbHVlKiBmdW5jdGlvblByaW50KEV4ZWNTdGF0 ZSogZXhlYywgSlNPYmplY3QqLCBjb25zdCBMaXN0JiBhcmdzKQogewotICAgIGlmICghYXJncy5p c0VtcHR5KCkpCi0gICAgICAgIHByaW50ZigiJXNcbiIsIGFyZ3NbMF0tPnRvU3RyaW5nKGV4ZWMp LlVURjhTdHJpbmcoKS5jX3N0cigpKTsKLSAgICBlbHNlCi0gICAgICAgIHB1dGNoYXIoJ1xuJyk7 CisgICAgaWYgKCFhcmdzLmlzRW1wdHkoKSkgeworICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgYXJncy5zaXplKCk7ICsraSkgeworICAgICAgICAgICAgY29uc3QgY2hhciogYXJnU3Ry aW5nID0gYXJnc1tpXS0+dG9TdHJpbmcoZXhlYykuVVRGOFN0cmluZygpLmNfc3RyKCk7CisgICAg ICAgICAgICBmd3JpdGUoYXJnU3RyaW5nLCBzaXplb2YoY2hhciksIHN0cmxlbihhcmdTdHJpbmcp LCBzdGRvdXQpOworICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoKGkgKyAxKSAhPSBhcmdz LnNpemUoKSkKKyAgICAgICAgICAgICAgICBwdXRjaGFyKCcgJyk7CisgICAgICAgIH0KKyAgICB9 CiAgICAgCisgICAgcHV0Y2hhcignXG4nKTsKICAgICBmZmx1c2goc3Rkb3V0KTsKICAgICByZXR1 cm4ganNVbmRlZmluZWQoKTsKIH0K 21566 2008-06-07 14:51:27 -0700 2008-06-07 14:52:40 -0700 Revised proposed patch printmulti.diff text/plain 1231 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0NDI4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDYt MDcgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE3NTQ4OiBKYXZhU2Ny aXB0Q29yZSBwcmludChhLCBiKSBkaWZmZXJzIGZyb20gU3BpZGVybW9ua2V5IEJlaGF2aW9yCisg ICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NDg+CisK KyAgICAgICAgKiBranMvdGVzdGtqcy5jcHA6CisgICAgICAgIChmdW5jdGlvblByaW50KToKKwog MjAwOC0wNi0wNyAgQ2FtZXJvbiBad2FyaWNoICA8Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTYW0uCkluZGV4OiBranMvdGVzdGtqcy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0ga2pzL3Rlc3RranMuY3BwCShyZXZpc2lvbiAzNDQyOCkKKysrIGtqcy90ZXN0a2pzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTU5LDExICsxNTksMTQgQEAgR2xvYmFsT2JqZWN0OjpHbG9i YWxPYmplY3QoVmVjdG9yPFVTdHJpbgogCiBKU1ZhbHVlKiBmdW5jdGlvblByaW50KEV4ZWNTdGF0 ZSogZXhlYywgSlNPYmplY3QqLCBjb25zdCBMaXN0JiBhcmdzKQogewotICAgIGlmICghYXJncy5p c0VtcHR5KCkpCi0gICAgICAgIHByaW50ZigiJXNcbiIsIGFyZ3NbMF0tPnRvU3RyaW5nKGV4ZWMp LlVURjhTdHJpbmcoKS5jX3N0cigpKTsKLSAgICBlbHNlCi0gICAgICAgIHB1dGNoYXIoJ1xuJyk7 CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGFyZ3Muc2l6ZSgpOyArK2kpIHsKKyAgICAg ICAgaWYgKGkgIT0gMCkKKyAgICAgICAgICAgIHB1dGNoYXIoJyAnKTsKKyAgICAgICAgCisgICAg ICAgIHByaW50ZigiJXMiLCBhcmdzW2ldLT50b1N0cmluZyhleGVjKS5VVEY4U3RyaW5nKCkuY19z dHIoKSk7CisgICAgfQogICAgIAorICAgIHB1dGNoYXIoJ1xuJyk7CiAgICAgZmZsdXNoKHN0ZG91 dCk7CiAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiB9Cg==