175477 2017-08-11 05:30:22 -0700 [WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String' 2017-08-11 06:27:06 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez annulen bugs-noreply commit-queue darin mcatanzaro zan oldest_to_newest 1337869 0 aperez 2017-08-11 05:30:22 -0700 Building WPE from “trunk” with Clang 4.0.1 results in the following error: --- ../../Source/WebKit/Shared/wpe/WebEventFactory.cpp:62:16: error: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String' return String(uchar16.get()); ^~~~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/text/WTFString.h:99:27: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'const UChar *' (aka 'const char16_t *') for 1st argument WTF_EXPORT_STRING_API String(const UChar*); ^ ../../Source/WTF/wtf/text/WTFString.h:106:27: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'const LChar *' (aka 'const unsigned char *') for 1st argument WTF_EXPORT_STRING_API String(const LChar* characters); ^ ../../Source/WTF/wtf/text/WTFString.h:107:27: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'const char *' for 1st argument WTF_EXPORT_STRING_API String(const char* characters); ^ ../../Source/WTF/wtf/text/WTFString.h:122:27: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'WTF::ASCIILiteral' for 1st argument WTF_EXPORT_STRING_API String(ASCIILiteral); ^ ../../Source/WTF/wtf/text/WTFString.h:132:5: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'const WTF::String' for 1st argument String(const String& other) ^ ../../Source/WTF/wtf/text/WTFString.h:135:5: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'WTF::String' for 1st argument String(String&& other) ^ ../../Source/WTF/wtf/text/WTFString.h:476:5: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'WTF::HashTableDeletedValueType' for 1st argument String(WTF::HashTableDeletedValueType) : m_impl(WTF::HashTableDeletedValue) { } ^ ../../Source/WTF/wtf/text/WTFString.h:552:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'WTF::StringImpl &' for 1st argument inline String::String(StringImpl& impl) ^ ../../Source/WTF/wtf/text/WTFString.h:557:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'WTF::StringImpl *' for 1st argument inline String::String(StringImpl* impl) ^ ../../Source/WTF/wtf/text/WTFString.h:562:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'Ref<WTF::StringImpl>' for 1st argument inline String::String(Ref<StringImpl>&& impl) ^ ../../Source/WTF/wtf/text/WTFString.h:567:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'RefPtr<WTF::StringImpl>' for 1st argument inline String::String(RefPtr<StringImpl>&& impl) ^ ../../Source/WTF/wtf/text/WTFString.h:572:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'Ref<WTF::AtomicStringImpl>' for 1st argument inline String::String(Ref<AtomicStringImpl>&& impl) ^ ../../Source/WTF/wtf/text/WTFString.h:577:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'RefPtr<WTF::AtomicStringImpl>' for 1st argument inline String::String(RefPtr<AtomicStringImpl>&& impl) ^ ../../Source/WTF/wtf/text/WTFString.h:582:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'StaticStringImpl &' (aka 'WTF::StringImpl::StaticStringImpl &') for 1st argument inline String::String(StaticStringImpl& impl) ^ ../../Source/WTF/wtf/text/WTFString.h:587:16: note: candidate constructor not viable: no known conversion from 'pointer' (aka 'unsigned short *') to 'StaticStringImpl *' (aka 'WTF::StringImpl::StaticStringImpl *') for 1st argument inline String::String(StaticStringImpl* impl) ^ ../../Source/WTF/wtf/text/WTFString.h:593:9: note: candidate template ignored: could not match 'Vector<char16_t, inlineCapacity, type-parameter-0-1, 16>' against 'unsigned short *' String::String(const Vector<UChar, inlineCapacity, OverflowHandler>& vector) ^ ../../Source/WTF/wtf/text/WTFString.h:128:5: note: candidate constructor template not viable: requires 2 arguments, but 1 was provided String(const char (&characters)[characterCount], ConstructFromLiteralTag) : m_impl(StringImpl::createFromLiteral<characterCount>(characters)) { } ^ ../../Source/WTF/wtf/text/WTFString.h:82:5: note: candidate constructor not viable: requires 0 arguments, but 1 was provided String() { } ^ ../../Source/WTF/wtf/text/WTFString.h:103:27: note: candidate constructor not viable: requires 2 arguments, but 1 was provided WTF_EXPORT_STRING_API String(const char* characters, unsigned length); ^ ../../Source/WTF/wtf/text/WTFString.h:102:27: note: candidate constructor not viable: requires 2 arguments, but 1 was provided WTF_EXPORT_STRING_API String(const LChar* characters, unsigned length); ^ ../../Source/WTF/wtf/text/WTFString.h:85:27: note: candidate constructor not viable: requires 2 arguments, but 1 was provided WTF_EXPORT_STRING_API String(const UChar* characters, unsigned length); ^ 1337870 1 317926 aperez 2017-08-11 05:38:46 -0700 Created attachment 317926 Patch 1337871 2 317926 commit-queue 2017-08-11 06:26:02 -0700 Comment on attachment 317926 Patch Clearing flags on attachment: 317926 Committed r220585: <http://trac.webkit.org/changeset/220585> 1337872 3 commit-queue 2017-08-11 06:26:04 -0700 All reviewed patches have been landed. Closing bug. 1337873 4 annulen 2017-08-11 06:27:06 -0700 FYI, it's because of ICU 59, not Clang 317926 2017-08-11 05:38:46 -0700 2017-08-11 06:26:02 -0700 Patch bug-175477-20170811153845.patch text/plain 1575 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE4YzY1NDQxMGQyMTRiODY1 ZmQ2MDA5ZDY1MjMyMjdkNTk2YjU4MmIuLmY5OTNmMTFlNDUxOTRmNDU2ODRkY2MxMDhjYTk4ZWMz YWI5MTY5NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDgtMTEgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlsdXJlIHdpdGggQ2xhbmcgNC4wLjE6IG5vIG1hdGNoaW5nIGNvbnZlcnNpb24gZm9yIGZ1 bmN0aW9uYWwtc3R5bGUgY2FzdCBmcm9tICdwb2ludGVyJyAoYWthICd1bnNpZ25lZCBzaG9ydCAq JykgdG8gJ1dURjo6U3RyaW5nJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc1NDc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OnNpbmdsZUNoYXJhY3RlclN0cmluZ0ZvcktleUV2ZW50KTogQ2FzdCB0byBVQ2hhciog dG8gbWFrZQorICAgICAgICBjb21waWxlciBjaG9vc2UgdGhlIGNvcnJlY3QgV1RGOjpTdHJpbmcg Y29uc3RydWN0b3IuCisKIDIwMTctMDgtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTb3VwXSBDYW5ub3QgYWNjZXNzIEhUVFBTIHNpdGVz IHVzaW5nIGEgSFRUUCBwcm94eSB0aGF0IHJlcXVpcmVzIGF1dGhlbnRpY2F0aW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCmluZGV4IDU1NzFlMWFhYzk3 NmQ1NzlkOWFhOTNmMGY3NWI3YzE0Y2EwZjE0NjIuLmUwYWM2ZWY4NWE5NGE3MmIyMmVlZGUwNzA2 ODljNzJmNWNlZWY5NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJF dmVudEZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZh Y3RvcnkuY3BwCkBAIC01OSw3ICs1OSw3IEBAIHN0YXRpYyBTdHJpbmcgc2luZ2xlQ2hhcmFjdGVy U3RyaW5nRm9yS2V5RXZlbnQoc3RydWN0IHdwZV9pbnB1dF9rZXlib2FyZF9ldmVudCoKICAgICBn bG9uZyBsZW5ndGg7CiAgICAgR1VuaXF1ZVB0cjxndW5pY2hhcjI+IHVjaGFyMTYoZ191Y3M0X3Rv X3V0ZjE2KCZldmVudC0+dW5pY29kZSwgMSwgMCwgJmxlbmd0aCwgbnVsbHB0cikpOwogICAgIGlm ICh1Y2hhcjE2KQotICAgICAgICByZXR1cm4gU3RyaW5nKHVjaGFyMTYuZ2V0KCkpOworICAgICAg ICByZXR1cm4gU3RyaW5nKHJlaW50ZXJwcmV0X2Nhc3Q8VUNoYXIqPih1Y2hhcjE2LmdldCgpKSwg bGVuZ3RoKTsKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAK