175476 2017-08-11 05:18:01 -0700 [GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h 2017-08-11 06:47:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia commit-queue darin ggaren webkit-bug-importer zan oldest_to_newest 1337866 0 aperez 2017-08-11 05:18:01 -0700 The following warning is generated when building with Clang: In file included from ../../Source/WebCore/platform/graphics/ImageBufferData.h:31: ../../Source/WebCore/platform/graphics/cairo/ImageBufferDataCairo.h:65:45: warning: 'proxy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] RefPtr<TextureMapperPlatformLayerProxy> proxy() const; ^ ../../Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h:36:53: note: overridden virtual function is here virtual RefPtr<TextureMapperPlatformLayerProxy> proxy() const = 0; ^ 1337867 1 317925 aperez 2017-08-11 05:20:27 -0700 Created attachment 317925 Patch 1337876 2 317925 commit-queue 2017-08-11 06:47:03 -0700 Comment on attachment 317925 Patch Clearing flags on attachment: 317925 Committed r220586: <http://trac.webkit.org/changeset/220586> 1337877 3 commit-queue 2017-08-11 06:47:04 -0700 All reviewed patches have been landed. Closing bug. 1337878 4 webkit-bug-importer 2017-08-11 06:47:48 -0700 <rdar://problem/33847932> 317925 2017-08-11 05:20:27 -0700 2017-08-11 06:47:03 -0700 Patch bug-175476-20170811152026.patch text/plain 1448 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAwYmNmZjczZGNiMzM3 OTUwOWNmZTFhMzc5YzBjMDA3NzkwZjZjZS4uMjhhMjI2YTQ1Y2NhYWFmODAwYzY0MjhiZjM1Yzc2 YzRkZjkxNGI0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA4LTExICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V1BFXSBPdmVycmlkZW4gdmlydHVhbCBmdW5jdGlvbiBub3QgbWFya2VkIOKAnG92ZXJyaWRl4oCd IGluIEltYWdlQnVmZmVyRGF0YUNhaXJvLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NTQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJE YXRhQ2Fpcm8uaDogQWRkIG1pc3NpbmcgIm92ZXJyaWRlIiBxdWFsaWZpZXIuCisKIDIwMTctMDgt MTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtTb3VwXSBDYW5ub3QgYWNjZXNzIEhUVFBTIHNpdGVzIHVzaW5nIGEgSFRUUCBwcm94eSB0aGF0 IHJlcXVpcmVzIGF1dGhlbnRpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckRhdGFDYWlyby5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJEYXRhQ2Fpcm8uaAppbmRleCBl YmRhOTYyZGEwODY4NDcwZGEyYjNkNjY2YzI1YzZlNmY5Y2ZmM2RhLi4xMjA1MjhmZDRhMGY3Mjg2 YzE0NmM3NjM2ZWEwYmJlY2M4ZTQ0MjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckRhdGFDYWlyby5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyRGF0YUNhaXJvLmgKQEAg LTYyLDcgKzYyLDcgQEAgcHVibGljOgogICAgIHZvaWQgY3JlYXRlQ2Fpcm9HTFN1cmZhY2UoKTsK IAogI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDU19USFJFQURFRCkKLSAgICBSZWZQdHI8VGV4 dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJQcm94eT4gcHJveHkoKSBjb25zdDsKKyAgICBSZWZQdHI8 VGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJQcm94eT4gcHJveHkoKSBjb25zdCBvdmVycmlkZTsK ICAgICB2b2lkIHN3YXBCdWZmZXJzSWZOZWVkZWQoKSBvdmVycmlkZTsKICAgICB2b2lkIGNyZWF0 ZUNvbXBvc2l0b3JCdWZmZXIoKTsKIAo=