175475 2017-08-11 03:24:14 -0700 [CMake] Many warnings about missing “override” keywords in ANGLE with Clang 2017-08-11 08:44:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez beidson cgarcia commit-queue lforschler mcatanzaro mmaxfield thorton webkit-bug-importer oldest_to_newest 1337858 0 aperez 2017-08-11 03:24:14 -0700 Currently building ANGLE as part of WebCore with Clang spews a good bunch of warnings similar to the following one: In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.cpp:10: In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.h:13: ../../Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.h:86:10: warning: 'visitBranch' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] bool visitBranch(Visit visit, TIntermBranch *); ^ ../../Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.h:957:18: note: overridden virtual function is here virtual bool visitBranch(Visit visit, TIntermBranch *node) { return true; } ^ As ANGLE is third-party code, let's to pass “-Wno-inconsistent-missing-override” when building its sources. 1337859 1 317923 aperez 2017-08-11 03:27:11 -0700 Created attachment 317923 Patch 1337896 2 317923 commit-queue 2017-08-11 08:44:04 -0700 Comment on attachment 317923 Patch Clearing flags on attachment: 317923 Committed r220591: <http://trac.webkit.org/changeset/220591> 1337898 3 commit-queue 2017-08-11 08:44:05 -0700 All reviewed patches have been landed. Closing bug. 317923 2017-08-11 03:27:11 -0700 2017-08-11 08:44:04 -0700 Patch bug-175475-20170811132710.patch text/plain 1530 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAwYmNmZjczZGNiMzM3 OTUwOWNmZTFhMzc5YzBjMDA3NzkwZjZjZS4uYjk3YjE5NmNiOTNmYTM4ZjNlZjI2ZDRjNGVlOWVh NzdiZWJjYWY1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA4LTExICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtl XSBNYW55IHdhcm5pbmcgYWJvdXQgbWlzc2luZyDigJxvdmVycmlkZeKAnSBrZXl3b3JkcyBpbiBB TkdMRSB3aXRoIENsYW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzU0NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBBZGQgIi1Xbm8taW5jb25zaXN0ZW50LW1pc3Npbmct b3ZlcnJpZGUiIHRvIHRoZQorICAgICAgICBjb21waWxlciBmbGFncyB1c2luZyBmb3IgYnVpbGRp bmcgdGhlIEFOR0xFIHNvdXJjZXMuCisKIDIwMTctMDgtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTb3VwXSBDYW5ub3QgYWNjZXNzIEhU VFBTIHNpdGVzIHVzaW5nIGEgSFRUUCBwcm94eSB0aGF0IHJlcXVpcmVzIGF1dGhlbnRpY2F0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJD b3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDMzY2RkNGM4OGRkNTM5MjUzYzExMTU2ZjY1NmVlZjlj ZjYzNmYxZjYuLjY0ODE2MzFlOGY2YWQ1YTFkMWY2ZmYxOTBhZDg2M2U0N2QzNTUxNDMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHMudHh0CkBAIC00MDM1LDYgKzQwMzUsNyBAQCBpZiAoRU5BQkxFX0dSQVBISUNT X0NPTlRFWFRfM0QgQU5EIE5PVCBXSU4zMikKIAogICAgIGlmIChDT01QSUxFUl9JU19HQ0NfT1Jf Q0xBTkcpCiAgICAgICAgIFdFQktJVF9BRERfVEFSR0VUX0NYWF9GTEFHUyhBTkdMRVN1cHBvcnQg LVduby1pbXBsaWNpdC1mYWxsdGhyb3VnaAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIC1Xbm8taW5jb25zaXN0ZW50LW1pc3Npbmctb3ZlcnJpZGUKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25vLW51bGwt Y29udmVyc2lvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC1Xbm8tc3VnZ2VzdC1hdHRyaWJ1dGU9Zm9ybWF0CiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLVduby11bnVzZWQtZnVuY3Rpb24K