17547 2008-02-25 22:46:43 -0800 JavaScriptCore print() differs from Spidermonkey Behavior 2008-06-07 12:35:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bfulgham sam oldest_to_newest 71971 0 bfulgham 2008-02-25 22:46:43 -0800 Spidermonkey has the useful behavior of printing a newline when no argument is passed: print("abc") print() print("def") yields: abc def In JavaScriptCore, the same code yields: abc undefined def This can be easily worked around by passing an empty string, but it prevents reuse of code between the two implementations. 82570 1 21562 zwarich 2008-06-07 11:34:23 -0700 Created attachment 21562 Proposed patch 82572 2 21562 sam 2008-06-07 12:27:22 -0700 Comment on attachment 21562 Proposed patch + if (args.size()) I would rather you use !args.isEmpty() here. r=me 82573 3 zwarich 2008-06-07 12:35:34 -0700 Landed in r34428. 21562 2008-06-07 11:34:23 -0700 2008-06-07 12:27:22 -0700 Proposed patch printempty.diff text/plain 1081 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0NDI2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDYt MDcgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE3NTQ3OiBKYXZhU2Ny aXB0Q29yZSBwcmludCgpIGRpZmZlcnMgZnJvbSBTcGlkZXJtb25rZXkgQmVoYXZpb3IKKyAgICAg ICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU0Nz4KKworICAg ICAgICAqIGtqcy90ZXN0a2pzLmNwcDoKKyAgICAgICAgKGZ1bmN0aW9uUHJpbnQpOgorCiAyMDA4 LTA2LTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBN b3JlIGJ1aWxkIGZpeGVzLgpJbmRleDoga2pzL3Rlc3RranMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtq cy90ZXN0a2pzLmNwcAkocmV2aXNpb24gMzQ0MjYpCisrKyBranMvdGVzdGtqcy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1OSw3ICsxNTksMTEgQEAgR2xvYmFsT2JqZWN0OjpHbG9iYWxPYmplY3Qo VmVjdG9yPFVTdHJpbgogCiBKU1ZhbHVlKiBmdW5jdGlvblByaW50KEV4ZWNTdGF0ZSogZXhlYywg SlNPYmplY3QqLCBjb25zdCBMaXN0JiBhcmdzKQogewotICAgIHByaW50ZigiJXNcbiIsIGFyZ3Nb MF0tPnRvU3RyaW5nKGV4ZWMpLlVURjhTdHJpbmcoKS5jX3N0cigpKTsKKyAgICBpZiAoYXJncy5z aXplKCkpCisgICAgICAgIHByaW50ZigiJXNcbiIsIGFyZ3NbMF0tPnRvU3RyaW5nKGV4ZWMpLlVU RjhTdHJpbmcoKS5jX3N0cigpKTsKKyAgICBlbHNlCisgICAgICAgIHB1dGNoYXIoJ1xuJyk7Cisg ICAgCiAgICAgZmZsdXNoKHN0ZG91dCk7CiAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiB9Cg==